From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB1DD12D41 for ; Sun, 10 Nov 2024 15:09:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DC076B009F; Sun, 10 Nov 2024 10:09:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 78C376B00A1; Sun, 10 Nov 2024 10:09:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62C496B00A3; Sun, 10 Nov 2024 10:09:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3BC766B009F for ; Sun, 10 Nov 2024 10:09:27 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BCA88A146D for ; Sun, 10 Nov 2024 15:09:26 +0000 (UTC) X-FDA: 82770517914.10.4EDA005 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) by imf25.hostedemail.com (Postfix) with ESMTP id E6200A000B for ; Sun, 10 Nov 2024 15:08:54 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Kwl2ylu4; spf=pass (imf25.hostedemail.com: domain of yanjun.zhu@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=yanjun.zhu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731251194; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PCo17FAGoI0N36z1xhgr+jZX1coQaBkOx2Lfp0sQCQA=; b=Y3Eqtn+aQ3VeRrEy2Ju2ej9ai9RdWy4eWD4e750VpdvWkLTZm6gkWya/IbzL4KEN8nrVst gB+XpCMXpsCxxswkAIlYyl2SeJTir6s8ezeKT8/DGtcsJPDnm8j/jk9gXsd4Yudf/BuIgR ZGoAlUoNBIHNEzUalyqO61SIHqInaXg= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Kwl2ylu4; spf=pass (imf25.hostedemail.com: domain of yanjun.zhu@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=yanjun.zhu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731251194; a=rsa-sha256; cv=none; b=OoW1LiwP+0AteowLckziNGQ2/c6k0/MpM5J5tFIfRbIWLxcg96mjWVqotjBJF4DAhiTl3l ADWiE2XG3HvZ19jPRDmjzNx+NAV5+lYtYIe/CzXt9UJweo5KLGQUxQSvm2JcgAxL9pbnMv UEpYP1//SROye8He934gNefATE/GcHQ= Message-ID: <5ea594b3-7451-4553-92c1-2590c8baef20@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1731251359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PCo17FAGoI0N36z1xhgr+jZX1coQaBkOx2Lfp0sQCQA=; b=Kwl2ylu4VPdk87+OR+b1SUGCOqDGZ8sXihB72SCRVQi9i6kYT1ztmGzGjEKIgaTkzqz7O7 gUdz5mo8gHkrYMkATcROHwm+OWPXtUwFXI2ChCzpDr7jZTQAnz47D+n7DFqKijh6+E8P9T rOxWb9K9BcpUIQd4Xi7vpR/Dwmt+txs= Date: Sun, 10 Nov 2024 16:09:11 +0100 MIME-Version: 1.0 Subject: Re: [PATCH v1 04/17] dma-mapping: Add check if IOVA can be used To: Leon Romanovsky , Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg Cc: Leon Romanovsky , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org References: <9515f330b9615de92a1864ab46acbd95e32634b6.1730298502.git.leon@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: <9515f330b9615de92a1864ab46acbd95e32634b6.1730298502.git.leon@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E6200A000B X-Stat-Signature: zcxgx71duff6hpcedugjw3t6qicomu7y X-Rspam-User: X-HE-Tag: 1731251334-190263 X-HE-Meta: U2FsdGVkX1/b9UMRa6HY68mVL320TNYWnRgWiwrKm0rTDVTPjh4twK1uBv0C8g+xngHXO9G3LXAia3snROXz7xZS6wxfT416yhfKWrbtaNE727tnTPJ5z7WD7GKRZpbVagJ9jAnjAjgn2xSLVSePt2o8gBlW+Wq4DKMprL0d/tLz+qDeD/M5g6XDK+uPurDqryVI4XUcA6u9KErXmGJwsFqZmZttS1GCrh9RM728sKDwJF8uQJUqw9Z1HUugK0LIezbGN1NxTVsOAFjiSziOSCBCmTnrlywV1ZiF7WlysKYIHeWDlNXvDKBcgRA+a9lwroGYPVMEzBubT1Q3Yv/Yq236fRYJ9jKKq3zdOQYAmvMva7fYFSzXG5Py27MqsW3j86XC9h7RDDwwYHelZGeviDNna9rZW2GIM+o6/d2HVI0FjkV2c4mN+yfNmMCZKlNzDVXegMbd2MkHhxvYQ7/gsxlqKZOHt57PPJGF76WhDAD78CYuij1JhEluSk2QsmjlTJ1/oPOH+viQgyHo/Bgcr2mryRt50MQbul30Cq7Yz/Ect6jURKtgttAB3jP0c+9N/Mq6UEw/dLrlFp6I3+p8QjBH3hTcAs24Z46niB6ee7Eh5F5GAJX4snBKz9UwFt2Sp3p1bJlIh8110ZHRs8rryUZXVynXHLfA6V7hjfHyND2oEzZp3zxxKwHPRwlce5xcddTXSrzEbdET3upkX42zjWwBOGxjY6FSvi5a5/cdlO+duhHp8Mu1VSwQ372OraSZkBB9fKbPp3Bovea1lls1uk5tozg0iY7NRagfNu0hiDbuOkmU7bKENqD0j/0dWn1MOfF1Y8eLtt6SsxkyHeQzrJmNQVsdb4TfPovj8KMb1WgnUPKwvbXRB7r2e0Ky03OGkA/BQcn0LgMF8Ev4vq9rN+XWB02ernhs3P1lSTkK+eL2ZdIC4mGTxBg9b0fVi2CYSaGICjqeDWE1TlheYnu zGl7j0PP Vpm0undOxS2KEE3WAHxLUP2ABNzcjpB+ov0gh2gYXgo1uft/Lu5aqc222DCZYCn+0HlqsonrrYeQs3sUZrJgx5/oKi/r17LOKDvKj+hkQ+cXVnFrJXrUWbruS+hiskNqdfWrLEe2iSaHJp+qGTaEtMfJgbIGJvNXoNNj13hJGtrdb/b9NEDQzM8mMqFS7UcPHQrbp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/10/30 16:12, Leon Romanovsky 写道: > From: Leon Romanovsky > > This patch adds a check if IOVA can be used for the specific > transaction. > > In the new API a DMA mapping transaction is identified by a > struct dma_iova_state, which holds some recomputed information > for the transaction which does not change for each page being > mapped. > > Signed-off-by: Leon Romanovsky > --- > include/linux/dma-mapping.h | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h > index 1524da363734..6075e0708deb 100644 > --- a/include/linux/dma-mapping.h > +++ b/include/linux/dma-mapping.h > @@ -76,6 +76,20 @@ > > #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1)) > > +struct dma_iova_state { > + size_t __size; > +}; > + > +/* > + * Use the high bit to mark if we used swiotlb for one or more ranges. > + */ > +#define DMA_IOVA_USE_SWIOTLB (1ULL << 63) A trivial problem. In the above macro, using BIT_ULL(63) is better? Zhu Yanjun > + > +static inline size_t dma_iova_size(struct dma_iova_state *state) > +{ > + return state->__size & ~DMA_IOVA_USE_SWIOTLB; > +} > + > #ifdef CONFIG_DMA_API_DEBUG > void debug_dma_mapping_error(struct device *dev, dma_addr_t dma_addr); > void debug_dma_map_single(struct device *dev, const void *addr, > @@ -281,6 +295,25 @@ static inline int dma_mmap_noncontiguous(struct device *dev, > } > #endif /* CONFIG_HAS_DMA */ > > +#ifdef CONFIG_IOMMU_DMA > +/** > + * dma_use_iova - check if the IOVA API is used for this state > + * @state: IOVA state > + * > + * Return %true if the DMA transfers uses the dma_iova_*() calls or %false if > + * they can't be used. > + */ > +static inline bool dma_use_iova(struct dma_iova_state *state) > +{ > + return state->__size != 0; > +} > +#else /* CONFIG_IOMMU_DMA */ > +static inline bool dma_use_iova(struct dma_iova_state *state) > +{ > + return false; > +} > +#endif /* CONFIG_IOMMU_DMA */ > + > #if defined(CONFIG_HAS_DMA) && defined(CONFIG_DMA_NEED_SYNC) > void __dma_sync_single_for_cpu(struct device *dev, dma_addr_t addr, size_t size, > enum dma_data_direction dir);