From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91929C3ABBF for ; Tue, 6 May 2025 14:25:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69AD96B0082; Tue, 6 May 2025 10:25:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 623B96B0085; Tue, 6 May 2025 10:25:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44DF46B0088; Tue, 6 May 2025 10:25:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1CC916B0082 for ; Tue, 6 May 2025 10:25:00 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0A865BB7A4 for ; Tue, 6 May 2025 14:25:00 +0000 (UTC) X-FDA: 83412704760.30.E4CCB21 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id D0885140006 for ; Tue, 6 May 2025 14:24:56 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tz2VDahg; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746541497; a=rsa-sha256; cv=none; b=vh+LeKY8ZZFbrWeb+yfk0lsozLjxOsdPyxJa0oBf9deevSKroOqP87W9IPDKhnrHScda9s ZBGiD8hH7XAlqYzBqDRlpva0Z9ObBMHqO01k9NRwqlnvYLYluBNykgcB6RCCoqfMGIu1Ia u7mYtzLgc1qKh3LqX/5pOJHDPzALQGw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tz2VDahg; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746541497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9zc1ZtvmGJ5KapEi1iwLqXeN/vl2AD2R+iU1xpLs0mw=; b=mbBzfEMRRkwzh0/70wn0zyp94stuqpZ2HK54dfxPG7/yA+DXr42XhDFLRXJoeejMmz2gwb Y5amLlPQ0VDdYjRNj/+ZLObsbDT+MsU2PnObs2IG3kFhdEQkEi7TfnW5b1Zf8PixloMEWc NLYkPBuKaf5yeEQAwzVuMtMmOIrwhXk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746541494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9zc1ZtvmGJ5KapEi1iwLqXeN/vl2AD2R+iU1xpLs0mw=; b=Tz2VDahgGjoT9E8V/qNhcxuWDHHlW+2Kl7ynqObPJpGTKvAAVYo+STRiiARgVpxRE7fccg 855xryVEJ+NPhS7NcLnXhcwBU7QVEysgSdJ2zrYTHIXFRMoPvXtV4rQeJPqad1P/KiG+qH vn0063zvrr6GtOpd3RizMT2hFyWlLdU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-Cwi9aY0HO4aOdkdwNCp8EQ-1; Tue, 06 May 2025 10:24:52 -0400 X-MC-Unique: Cwi9aY0HO4aOdkdwNCp8EQ-1 X-Mimecast-MFC-AGG-ID: Cwi9aY0HO4aOdkdwNCp8EQ_1746541492 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-39130f02631so1618606f8f.2 for ; Tue, 06 May 2025 07:24:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746541491; x=1747146291; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9zc1ZtvmGJ5KapEi1iwLqXeN/vl2AD2R+iU1xpLs0mw=; b=MNM70d19j1m85BAEvd69yYVXxIoc5AFsdiQRsUiPobJSDm55T1te40p2jdzziN00Np i0popAuKA7PvPjlTZnPl0FQq8xQmZItwRSBRxjxEFTddYmaHfbTN1nsMYqDqvrQrYBRC 8hFRQ9iDTv2Ue7K+aFG0CJ/KONbbGiRQtTkDuMy+AhlaAsG77jNV1BPbHOI3S10ZnUbj VK2x6XGMhCZZxgU3Pdbn9Vli++yhpoUVjJJ3srm4bsbTTvKbLnkAjTYlcN5Q+l18PcTT 3t2P/R4kKdWouW4AvJ7IAtNGi3dCup4N4IpDs5+EI8d6Fr5XR7z+PbwmgU8L1DyNjJH3 /9eg== X-Forwarded-Encrypted: i=1; AJvYcCUmp5AvEkT+P0xZo2BYJe06C/f/crPSBTcCOjcNnJNegByuEkN193R7eoJMw3lmsnOWHpc78QJzsQ==@kvack.org X-Gm-Message-State: AOJu0YyKVDJao10VqsPMlUQYAm2c/rAkl/akUX59Dc7xHbS3qAE2ioFq kCy5E+6Fb3HkliRe0pLAEaxopWwmOATDIffEOuKy/lz1q0CFanjL/8QNeRirElsy52SPSMX4CPt /MKXuxwKv8VcfHB1RDE/K9dEPjYQZ/cs69QiCTKBFSQSDrdky X-Gm-Gg: ASbGnctPISqCH6oYs/pOpP7o7ONsXsP9vvZT0TzZpO2Mk4u6n3QRKg3q0H/c691SpZY 3hnHdKhgf0k4tI1j8HlQnXa8h2i5z0A/gsoHvbk8zyvpWaC5/sDBrDe0+piddLMEhOuzydsplmh kBz2hboDdXVR3VZN/NaqrqmuEAP4AaCyQZ7vatB9/n4Gql//qDoqD5HI7HtqcbFWC35PVy55yrW 6c4j8nWeyLoBU01y6TBZzJbIvAYRb1pehuv+6K0tg+ZjBbM+gD8r/Fy0o8S/DNRi6EMJqeyViJL Z+iHHTXpjGrJ0rqFmCpV0Joi/Jjof6Z1mgbuWM7YZm4ePNMaqbc= X-Received: by 2002:a05:6000:1882:b0:3a0:8c30:63dc with SMTP id ffacd0b85a97d-3a099adcademr12398425f8f.26.1746541491633; Tue, 06 May 2025 07:24:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELT3uhvXzYaDL4GC+mS3AuYh8FvYuciR4o2IRMpMPpmXJqrQKgtNFIpV3cWERG4orkT5s5GQ== X-Received: by 2002:a05:6000:1882:b0:3a0:8c30:63dc with SMTP id ffacd0b85a97d-3a099adcademr12398409f8f.26.1746541491233; Tue, 06 May 2025 07:24:51 -0700 (PDT) Received: from ?IPV6:2a01:599:915:8911:b13f:d972:e237:7fe2? ([2a01:599:915:8911:b13f:d972:e237:7fe2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099b178absm14075606f8f.97.2025.05.06.07.24.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 May 2025 07:24:50 -0700 (PDT) Message-ID: <5ea287f0-24cb-4ad4-8448-6e397fbf1ec8@redhat.com> Date: Tue, 6 May 2025 16:24:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v4 4/5] mm/readahead: Store folio order in struct file_ra_state To: Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , Alexander Viro , Christian Brauner , Jan Kara , Dave Chinner , Catalin Marinas , Will Deacon , Kalesh Singh , Zi Yan Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20250430145920.3748738-1-ryan.roberts@arm.com> <20250430145920.3748738-5-ryan.roberts@arm.com> <2b1ea3d9-6c9b-4700-ae21-5f65565a995a@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <2b1ea3d9-6c9b-4700-ae21-5f65565a995a@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RG5PIcz48ZppD5uicOXlrWIdCSRkmmYXSDlnpTXfw7g_1746541492 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D0885140006 X-Stat-Signature: cbehbinppqt3rp9x4wirzrs3bizbr4s8 X-HE-Tag: 1746541496-366202 X-HE-Meta: U2FsdGVkX1+ktCL+rrS2iHDeb0WhByVP7rH+C81+vcU6ljlne6GrYY7QOmJ5X4Vph66nlYFGrhSGenSgjO5qLFg42oOrW/MHaLsaLahGcdki38pTVqNnSoHhu8xKf0LD+IXcNH1wILswHbYzBiqzcuAuTq6+ap37/MaSiY8hhAHsCrFAvMjl9OniNL0h4TPlyBanrk86FpI+idvg46356pd733bfT9UAtaEUXqqJ5ax2xACCuFVKUs2ujEaw7vhe6VXb6d+jSqjsz3xsAIadrwRsftImnLLefoVlgGE8zhtPfbNydju/dv6zoIkd684WlAWpE5IJMJKoHQsDK395EQ4MBskkeDSEZA2wwLVx8+JR+7fzcxlLjLcNhOJf2yEreCGEF5GfhTjb6WwiJApxZdi+uFwUfx7oHLuykMhWCZSuD8l6ZD1R/RqaMIwCpxofRL+PXCrmW2Z7SRvL1pMcSGqWaRCvr6qBWBnUYFFKcc4Z3D8/5eH/68/skjriZTkwszbxRFZRlCcg6zrB0qCk8L9Vuu8/+PJ0V5155SZ2XhAr30dIoNU4fIOFj2ogTSzfSTzf+VKKjrrNm4mYtWXSdEZ7Vfjwb/sZ+gI7ESIec8khVeDbBppNeAo48CvM0PJJZqQW6ensqgZmgRTFSKzu9+KeJ6k+YhHoIPttYwELhVCvzfOT0u2esJGPbCSmb/qLBoZwEYlNY2NAQGHQRel/rPMPFPRzSvyQA0fQO5iRZcl0T3IZTR0HSJLw4dz512/W/3jmNvkc3l2T5tNFdReGXr674Eqdod+v4SMJ9UYd0nml+FHyCPnnsLAsuNvueO5FcVdNxqkf+92sdtrMhaMpZot/aasGe35u0GMIZLRga+r9LXY7cWwV9tPNIA6JK9+8DM25GZZxYNT4QQT8gamwBLV04pnr+jAuERe8ftp2ayOFgiG3AZpyWERcaWjx37Mv7PBTzMTvxysZxxPFgS3 4VBi8ni6 Sh3T8HA90evuxPmmf9hzpdT3RgM3N1qZGM2/EzT2CrsaIquKEsvYUiGxlbCa7zhkmxItVeWLT6osGFHME1ZOldO6WKoldaUho7kVbhVFaokBcbI7t3kE4sEoPGw9zAoDYctVAB+x64FRe2pnytGaLmax0X7YH8YVH3cpsj/iE4v0gr2wJTO6WIFXJf+IuXNxhQLk4aFw4O4rnMQKVrDP9ssTZD8uE3PV5p1+iIfm53eXgBX92dW5f74JeuLfK+pNr1NkM0vZ9kPWFgu9zKgCPiNF3zEla3/SQZb3NMFaXJDtLcpYudDxHQK6CySrhgHL0hsDXYzr1W4koR9JoKSfWMHcKHNftGEPTRUqu0AnB82nkuLwl/cDJMlcZwuUjcCgmIduKlaEhiXxdZ7ZNeS2ZRpAIq7OoHzeOvMy6BvlkorIASPJFnYbZaILToTlrpG0Ddxa0TvUI1qKuZ4zBMdV6ABbhATIC5CJ2WbTs2Jggc5v3OZHkTH38BKpOZ/lDMTjuHcoSeE+60Yt4oQzpOFGCcGyA5Uk+OAdYXw4UwI5343kMzk7rhJWzTGBBT5XkQWeSRVUVU9OdQKadUN7c+YiHoW1hCwDcBv9xpRis X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.05.25 12:03, Ryan Roberts wrote: > On 05/05/2025 11:08, David Hildenbrand wrote: >> On 30.04.25 16:59, Ryan Roberts wrote: >>> Previously the folio order of the previous readahead request was >>> inferred from the folio who's readahead marker was hit. But due to the >>> way we have to round to non-natural boundaries sometimes, this first >>> folio in the readahead block is often smaller than the preferred order >>> for that request. This means that for cases where the initial sync >>> readahead is poorly aligned, the folio order will ramp up much more >>> slowly. >>> >>> So instead, let's store the order in struct file_ra_state so we are not >>> affected by any required alignment. We previously made enough room in >>> the struct for a 16 order field. This should be plenty big enough since >>> we are limited to MAX_PAGECACHE_ORDER anyway, which is certainly never >>> larger than ~20. >>> >>> Since we now pass order in struct file_ra_state, page_cache_ra_order() >>> no longer needs it's new_order parameter, so let's remove that. >>> >>> Worked example: >>> >>> Here we are touching pages 17-256 sequentially just as we did in the >>> previous commit, but now that we are remembering the preferred order >>> explicitly, we no longer have the slow ramp up problem. Note >>> specifically that we no longer have 2 rounds (2x ~128K) of order-2 >>> folios: >>> >>> TYPE    STARTOFFS     ENDOFFS        SIZE  STARTPG    ENDPG   NRPG  ORDER  RA >>> -----  ----------  ----------  ----------  -------  -------  -----  -----  -- >>> HOLE   0x00000000  0x00001000        4096        0        1      1 >>> FOLIO  0x00001000  0x00002000        4096        1        2      1      0 >>> FOLIO  0x00002000  0x00003000        4096        2        3      1      0 >>> FOLIO  0x00003000  0x00004000        4096        3        4      1      0 >>> FOLIO  0x00004000  0x00005000        4096        4        5      1      0 >>> FOLIO  0x00005000  0x00006000        4096        5        6      1      0 >>> FOLIO  0x00006000  0x00007000        4096        6        7      1      0 >>> FOLIO  0x00007000  0x00008000        4096        7        8      1      0 >>> FOLIO  0x00008000  0x00009000        4096        8        9      1      0 >>> FOLIO  0x00009000  0x0000a000        4096        9       10      1      0 >>> FOLIO  0x0000a000  0x0000b000        4096       10       11      1      0 >>> FOLIO  0x0000b000  0x0000c000        4096       11       12      1      0 >>> FOLIO  0x0000c000  0x0000d000        4096       12       13      1      0 >>> FOLIO  0x0000d000  0x0000e000        4096       13       14      1      0 >>> FOLIO  0x0000e000  0x0000f000        4096       14       15      1      0 >>> FOLIO  0x0000f000  0x00010000        4096       15       16      1      0 >>> FOLIO  0x00010000  0x00011000        4096       16       17      1      0 >>> FOLIO  0x00011000  0x00012000        4096       17       18      1      0 >>> FOLIO  0x00012000  0x00013000        4096       18       19      1      0 >>> FOLIO  0x00013000  0x00014000        4096       19       20      1      0 >>> FOLIO  0x00014000  0x00015000        4096       20       21      1      0 >>> FOLIO  0x00015000  0x00016000        4096       21       22      1      0 >>> FOLIO  0x00016000  0x00017000        4096       22       23      1      0 >>> FOLIO  0x00017000  0x00018000        4096       23       24      1      0 >>> FOLIO  0x00018000  0x00019000        4096       24       25      1      0 >>> FOLIO  0x00019000  0x0001a000        4096       25       26      1      0 >>> FOLIO  0x0001a000  0x0001b000        4096       26       27      1      0 >>> FOLIO  0x0001b000  0x0001c000        4096       27       28      1      0 >>> FOLIO  0x0001c000  0x0001d000        4096       28       29      1      0 >>> FOLIO  0x0001d000  0x0001e000        4096       29       30      1      0 >>> FOLIO  0x0001e000  0x0001f000        4096       30       31      1      0 >>> FOLIO  0x0001f000  0x00020000        4096       31       32      1      0 >>> FOLIO  0x00020000  0x00021000        4096       32       33      1      0 >>> FOLIO  0x00021000  0x00022000        4096       33       34      1      0 >>> FOLIO  0x00022000  0x00024000        8192       34       36      2      1 >>> FOLIO  0x00024000  0x00028000       16384       36       40      4      2 >>> FOLIO  0x00028000  0x0002c000       16384       40       44      4      2 >>> FOLIO  0x0002c000  0x00030000       16384       44       48      4      2 >>> FOLIO  0x00030000  0x00034000       16384       48       52      4      2 >>> FOLIO  0x00034000  0x00038000       16384       52       56      4      2 >>> FOLIO  0x00038000  0x0003c000       16384       56       60      4      2 >>> FOLIO  0x0003c000  0x00040000       16384       60       64      4      2 >>> FOLIO  0x00040000  0x00050000       65536       64       80     16      4 >>> FOLIO  0x00050000  0x00060000       65536       80       96     16      4 >>> FOLIO  0x00060000  0x00080000      131072       96      128     32      5 >>> FOLIO  0x00080000  0x000a0000      131072      128      160     32      5 >>> FOLIO  0x000a0000  0x000c0000      131072      160      192     32      5 >>> FOLIO  0x000c0000  0x000e0000      131072      192      224     32      5 >>> FOLIO  0x000e0000  0x00100000      131072      224      256     32      5 >>> FOLIO  0x00100000  0x00120000      131072      256      288     32      5 >>> FOLIO  0x00120000  0x00140000      131072      288      320     32      5  Y >>> HOLE   0x00140000  0x00800000     7077888      320     2048   1728 >>> >>> Signed-off-by: Ryan Roberts >>> --- >>>   include/linux/fs.h |  2 ++ >>>   mm/filemap.c       |  6 ++++-- >>>   mm/internal.h      |  3 +-- >>>   mm/readahead.c     | 18 +++++++++++------- >>>   4 files changed, 18 insertions(+), 11 deletions(-) >>> >>> diff --git a/include/linux/fs.h b/include/linux/fs.h >>> index 44362bef0010..cde482a7270a 100644 >>> --- a/include/linux/fs.h >>> +++ b/include/linux/fs.h >>> @@ -1031,6 +1031,7 @@ struct fown_struct { >>>    *      and so were/are genuinely "ahead".  Start next readahead when >>>    *      the first of these pages is accessed. >>>    * @ra_pages: Maximum size of a readahead request, copied from the bdi. >>> + * @order: Preferred folio order used for most recent readahead. >> >> Looking at other members, and how it relates to the other members, should we >> call this something like "ra_prev_order" / "prev_ra_order" to distinguish it >> from !ra members and indicate the "most recent" semantics similar to "prev_pos"? > > As you know, I'm crap at naming, but... > > start, size, async_size and order make up the parameters for the "most recent" > readahead request. Where "most recent" includes "current" once passed into > page_cache_ra_order(). The others don't include "ra" or "prev" in their name so > wasn't sure it was necessary here. > > ra_pages is a bit different; that's not part of the request, it's a (dynamic) > ceiling to use when creating requests. > > Personally I'd leave it as is, but no strong opinion. I'm fine with it staying that way; I was merely trying to make sense of it all ... ... maybe a better description of the parameters might make the semantics easier to grasp. ""most recent" includes "current" once passed into page_cache_ra_order()" is *really* hard to digest :) > >> >> Just a thought while digging through this patch ... >> >> ... >> >>> --- a/mm/filemap.c >>> +++ b/mm/filemap.c >>> @@ -3222,7 +3222,8 @@ static struct file *do_sync_mmap_readahead(struct >>> vm_fault *vmf) >>>           if (!(vm_flags & VM_RAND_READ)) >>>               ra->size *= 2; >>>           ra->async_size = HPAGE_PMD_NR; >>> -        page_cache_ra_order(&ractl, ra, HPAGE_PMD_ORDER); >>> +        ra->order = HPAGE_PMD_ORDER; >>> +        page_cache_ra_order(&ractl, ra); >>>           return fpin; >>>       } >>>   #endif >>> @@ -3258,8 +3259,9 @@ static struct file *do_sync_mmap_readahead(struct >>> vm_fault *vmf) >>>       ra->start = max_t(long, 0, vmf->pgoff - ra->ra_pages / 2); >>>       ra->size = ra->ra_pages; >>>       ra->async_size = ra->ra_pages / 4; >>> +    ra->order = 0; >>>       ractl._index = ra->start; >>> -    page_cache_ra_order(&ractl, ra, 0); >>> +    page_cache_ra_order(&ractl, ra); >>>       return fpin; >>>   } >> >> Why not let page_cache_ra_order() consume the order and update ra->order (or >> however it will be called :) ) internally? > > You mean continue to pass new_order as a parameter to page_cache_ra_order()? The > reason I did it the way I'm doing it is because I thought it would be weird for > the caller of page_cache_ra_order() to set up all the parameters (start, size, > async_size) of the request except for order... Agreed. As above, I think we might do better with the description of these parameters in general ... or even document how page_cache_ra_order() acts on these inputs? -- Cheers, David / dhildenb