From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C5C7E7718B for ; Sat, 21 Dec 2024 15:30:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 671536B007B; Sat, 21 Dec 2024 10:30:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 620B76B0083; Sat, 21 Dec 2024 10:30:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 474886B0085; Sat, 21 Dec 2024 10:30:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2A1FE6B007B for ; Sat, 21 Dec 2024 10:30:31 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9AB72B0719 for ; Sat, 21 Dec 2024 15:30:30 +0000 (UTC) X-FDA: 82919352600.02.41BEB2C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 3FD0210001B for ; Sat, 21 Dec 2024 15:29:48 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ux4P2WX7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734795011; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F0VhgHyYLlMxgv1xwC4J5EeYD2lgquIC4u4kKFeQ5vg=; b=4PJLLXXG8t01MaSm3/UJohTl6QEHdYA6YprkAvD1ZJR3RNQFjPlz5frja2Disot5UBJP0W 0KnVSwvybo8R/kkxiEgjZTIeXHB0GuRh4zB/TybhyGviK7DneyvUz2EwiYxN7Z+Llgwerj mUc/4zwvQheTR6CBW0k9HbTc5Q420Dk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734795011; a=rsa-sha256; cv=none; b=uc5wnkKJUvg2zgW71cLuYTqO2A7pRzML9o7fuhgpKZV5rk4AuehjTwt7oST8/c3fLbYndV FkU81kLhp3PL2KrZ80LMqirTUIEGQGRzvGVM5cE6BGAteGxb5Ur8A7nCeh52NkXU5fX2U3 vHNQyUXPidtGOFCfFu5QgGxy4sEICI8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ux4P2WX7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734795026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=F0VhgHyYLlMxgv1xwC4J5EeYD2lgquIC4u4kKFeQ5vg=; b=Ux4P2WX7GJfvsrL9qeFwW2xI6c+eeNKmFvJHPQLQbwNbUQ2yLuXw1xUoyXj1UUcWBZJHVJ KGrJaj2ohml0awzTKtuOy5uKzz/Jxzb3qXLBLdF/4zrqo3tHpdWPJftOzJTqp30PRfRIul IK7X0i1iGWBvSN6+mx4QzQxiDzuoDTw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-nsxlUC0hP7azMl028VDxrg-1; Sat, 21 Dec 2024 10:30:25 -0500 X-MC-Unique: nsxlUC0hP7azMl028VDxrg-1 X-Mimecast-MFC-AGG-ID: nsxlUC0hP7azMl028VDxrg Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-385e1fd40acso1519963f8f.3 for ; Sat, 21 Dec 2024 07:30:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734795024; x=1735399824; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=F0VhgHyYLlMxgv1xwC4J5EeYD2lgquIC4u4kKFeQ5vg=; b=BgK4o4ElgyJTYqP70SxmCagZwKQCzw+MXojdsJrZvzyHRjALDjcWcPUiH1I0tZF2Z5 0idWzoR9Q68EAqF1dVuTaaXs2RYy0h5m7p0gqaOd5P1aGUC+uDxnktyJPRiGlmzzTHSl 6Es1bf+u84Ja3SEl0uM1nOLDTt2vsuUPNW4LEDcNQLLqRtO8SCBvuE1i2VI06XGzj33B vKKxgR3+td8wjxe0jPLekdirDrsyDR32VhE5w1KjVqOGa6CQOtkSfj8qt4J/DfPJf/xT w1gGZrwXI4A9pY0asJA78z7GUa0gRIvibVRzPJ+h2VO7+KAPiYDYZgrv0eGkI8xSRVP9 7rMw== X-Forwarded-Encrypted: i=1; AJvYcCXJELWd0iC3xanqnMvDfDTBk3r1/87nS5fGSa3aJkMDKGYSjlBgQ2JMAnHUSbMprzGukFQG5JJ+gw==@kvack.org X-Gm-Message-State: AOJu0YzMFSzP/TxXdwYEvBA6FgqPVkBaKlF2DcItUEbaD7DsGWfKnz4k tVYofuUZb8X7b8fym5aypEYLN0ndAabL4vXZGdGO6locGqOm+s0HTNmqahw+a2aS7FudpXHOAFE 4x1973b1IDk/2brEBzeDNbA0dxtLys1as7/FolprXenEpYkTK X-Gm-Gg: ASbGncuHE59mhd1p1ILQKPCNpY+B3arfHQpB3X3PX2Pq+rp61eS5re/SBM4gMz7b+I6 z9Cttjo3wARtykwD0RBt6EZN+qI3GcZOGArbktN0I4/N8DHBJ7fhxuVJemCYVMxtIxo/Cs91Lb6 2lnoIck+EASH5pIgvPzE7OMq9+cOsQIe+tFIDH7a1aIYmwqz4HsdEc+CS/qZahKV3hW8423nUSq XWPocMTHUzcAermdNHiWGRgxl9Y29pCb6JN8Bvrery+pe4W32jQ8nIk3pxuvA/MA7vLKUKFCC0Z r6KQ8nPdF9yQDgbPGva9OVUTUmMQ0FhGAUU2s9tE7U91cjMq4HIFqg2vr3sf4QpNUbYOqqNGgPS FNKQ314yj X-Received: by 2002:a05:6000:188e:b0:386:3327:9d07 with SMTP id ffacd0b85a97d-38a223ff350mr6047736f8f.54.1734795024481; Sat, 21 Dec 2024 07:30:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IEWX2iVqMHhGPmB89UgFg1Tn2AeeYo7Utwo6Z8s6ZVQXawGejFass05esanNdIaD8+DsbKoYQ== X-Received: by 2002:a05:6000:188e:b0:386:3327:9d07 with SMTP id ffacd0b85a97d-38a223ff350mr6047718f8f.54.1734795024074; Sat, 21 Dec 2024 07:30:24 -0800 (PST) Received: from ?IPV6:2003:cb:c70e:d000:4622:73e7:6184:8f0d? (p200300cbc70ed000462273e761848f0d.dip0.t-ipconnect.de. [2003:cb:c70e:d000:4622:73e7:6184:8f0d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8a6e19sm6705451f8f.100.2024.12.21.07.30.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Dec 2024 07:30:23 -0800 (PST) Message-ID: <5e958aaa-b1ac-4512-a592-0e1612032861@redhat.com> Date: Sat, 21 Dec 2024 16:30:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: add build-time option for hotplug memory default online type To: Gregory Price , linux-mm@kvack.org Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, kernel-team@meta.com, corbet@lwn.net, osalvador@suse.de, akpm@linux-foundation.org, chenhuacai@kernel.org, kernel@xen0n.name, gregkh@linuxfoundation.org, rafael@kernel.org References: <20241220210709.300066-1-gourry@gourry.net> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241220210709.300066-1-gourry@gourry.net> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yNF4bFaqhExB8-b3cdttcXJoe59uMB9T0HVTYu3m-f0_1734795024 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: x1zmxk5oyd6m1wn87anfyyycji7x3r3j X-Rspamd-Queue-Id: 3FD0210001B X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1734794988-819214 X-HE-Meta: U2FsdGVkX1/XkvQUk1TLHeFByOKoecHWa5+PswYONyl2dbDMeeuaNWBfjF7/q9sTwldbkYwz0omoX+ZAtFQ0+0fNGvUYrZ2sFp2z3ekn6+sG/vovW2QyQkO78E6v2NpGxsOVd9QKGGcG6kDUpAsB9cocFhkWwQLE1phpowFSdoZAwqc8853JFOOLKayKeGbEHwpa+Ao39DPQCwhBqoJ9X18AF60w1x+VcBww69qwfr35wbVUvH3odsjKmTye/SUJ2J0FjqV9WdYhXgie4x8XbUqvNcCjPIGe1FsyHK40x4AwVbb5N2vP1YF2iMBpGIBbXXAhTLsTjt65Rhb3+NqddBzC2iqiSjrzsvHy7sps/tpeG0wku26bvpGCHuIzOEecWOmYQvJAxlIvIfZC5coXr1wrvl9gfYLPMcZeWsDPWhbV0KAhWL13tfB5ox+ye3Mq1w2wgOfgXAv3Q5J0+8hpybb3NJi3YmqmS9HS2YaotzY0ykuZViVYqa9grGE4noxIcWa74FdshfBU+CJvW+AJEep9ReGD+t5NUFyY9EMTvppAaRZUpi+spzhVvm3IFH2e4HfVLeNvYxM1S0XiWo8toqCV0b/W8D6GjzD1f6yP7OQXhXNNB62XSzDARNcTBxLkvUAaYi5IT5sw71WDBqAHtWZEU2mmOoLqbfsd7ZU9JkgRlxYQx3qHQFHZKeqb8wE/5ZqxPGhh3BVAsvBeQwz8WaNT41bwszHwT9JgIeB0FlR5UWNSyA2FdL58PE4NbZXUkTS+Xp8kCKRgjBF6bkiKmd3Gsc19ktA+LqW+OwiShNgBMzcSyQJ5XlbNh+y9Ab7MxwWJG6O28ICo9qccI7h/bINnt5OVw5kNcIxx9UNS7rw8NIfQHqB9Ug1A7dkXHG6VMMnM5EbtvMfO4oizwvGW6uKfELqZZDiSRMP3gQ+WVMyuwnSkEwtJWFyy+slrUHfDa5FZhGg1O4Je56ZrSGV VbKNnDey 6M4aBE3vfRqX2jey8UIeY4PRUoGUTb7Tk5N27xf1DVOz/HyMeHtTSQjikA+woickC9tYzUPjLdE6XEpZFiMGqJhIyr8rW8FM8hEIx53QTZficgDYIkyrgKrIFAG4AOMmdmqw8Dw2HH71mvbUVnffqiyTXUOiARgUQEsLUGID+HAl3/KYC7X9NkQGiR3QBuzoTdez7sy5rtoPH7+krsvGsMZ14Mb5p/o/W8eXpzf3bHQNSWO8qVZAy4sxXWa4JFC777fqkInF/YRNaVbOGhjbDdHQPMaIizg5cDbVaxJr+g3iD6wQGWGVlLstAzgZA34VrWYVK9LlyPAwBZR0l2hYpXhlB8W81YPfiafmtsNojVhlyEbtwMRvtyohD2lDNHLAurhbgReypm9QwmgRCD9b0ksgQyGAkkS/4eLeNBZgul/XkFqk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000119, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > -config MEMORY_HOTPLUG_DEFAULT_ONLINE > - bool "Online the newly added memory blocks by default" > - depends on MEMORY_HOTPLUG > +choice > + prompt "Memory Hotplug Default Online Type" > + default MHP_DEFAULT_ONLINE_TYPE_OFFLINE > help > + Default memory type for driver managed hotplug memory. We should call it "hotplugged memory" consistently, which it is from a pure core-mm perspective ("add memory"). "Driver managed" reminds too much about add_memory_driver_managed(), which is only one case. Maybe just drop the "e.g., page tables" from the examples below. > + > This option sets the default policy setting for memory hotplug > onlining policy (/sys/devices/system/memory/auto_online_blocks) which > determines what happens to newly added memory regions. Policy setting > can always be changed at runtime. > + > + The default is 'offline'. > + > + Select offline to defer onlining to drivers and user policy. > + Select auto to let the kernel choose what zones to utilize. > + Select online_kernel to generally allow kernel usage of this memory. > + Select online_movable to generally disallow kernel usage of this memory. > + > + Example kernel usage would be page structs and page tables. > + > See Documentation/admin-guide/mm/memory-hotplug.rst for more information. > > - Say Y here if you want all hot-plugged memory blocks to appear in > - 'online' state by default. > - Say N here if you want the default policy to keep all hot-plugged > - memory blocks in 'offline' state. > +config MHP_DEFAULT_ONLINE_TYPE_OFFLINE > + bool "offline" > + help > + Driver managed memory will not be onlined by default. "Hotplugged memory" > + Choose this for systems with drivers and user policy that> + handle onlining of hotplug memory policy. > +> +config MHP_DEFAULT_ONLINE_TYPE_ONLINE_AUTO > + bool "auto" > + help > + Select this if you want the kernel to automatically online > + memory into the zone it thinks is reasonable. This memory hotplugged memory > + may be utilized for kernel data (e.g. page tables). > + > +config MHP_DEFAULT_ONLINE_TYPE_ONLINE_KERNEL > + bool "kernel" > + help > + Select this if you want the kernel to automatically online > + hotplug memory into a zone capable of being used for kernel > + data (e.g. page tables). This typically means ZONE_NORMAL. > + > +config MHP_DEFAULT_ONLINE_TYPE_ONLINE_MOVABLE > + bool "movable" > + help > + Select this if you want the kernel to automatically online > + hotplug memory into ZONE_MOVABLE. This memory will generally > + not be utilized for kernel data (e.g. page tables). > + > + This should only be used when the admin knows sufficient > + ZONE_NORMAL memory is available to describe hotplug memory, > + otherwise hotplug memory may fail to online. For example, > + sufficient kernel-capable memory (ZONE_NORMAL) must be > + available to allocate page structs to describe ZONE_MOVABLE. > + > +endchoice > > config MEMORY_HOTREMOVE > bool "Allow for memory hot remove" > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 3b6f93962481..e3655f07dd6e 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -219,11 +219,30 @@ void put_online_mems(void) > > bool movable_node_enabled = false; > > -#ifndef CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE > -int mhp_default_online_type = MMOP_OFFLINE; > -#else > -int mhp_default_online_type = MMOP_ONLINE; > -#endif > +static int mhp_default_online_type = -1; > +int mhp_get_default_online_type(void) > +{ > + if (mhp_default_online_type >= 0) > + return mhp_default_online_type; > + > + if (IS_ENABLED(CONFIG_MHP_DEFAULT_ONLINE_TYPE_OFFLINE)) > + mhp_default_online_type = MMOP_OFFLINE; > + else if (IS_ENABLED(CONFIG_MHP_DEFAULT_ONLINE_TYPE_ONLINE_AUTO)) > + mhp_default_online_type = MMOP_ONLINE; > + else if (IS_ENABLED(CONFIG_MHP_DEFAULT_ONLINE_TYPE_ONLINE_KERNEL)) > + mhp_default_online_type = MMOP_ONLINE_KERNEL; > + else if (IS_ENABLED(CONFIG_MHP_DEFAULT_ONLINE_TYPE_ONLINE_MOVABLE)) > + mhp_default_online_type = MMOP_ONLINE_MOVABLE; > + else > + mhp_default_online_type = MMOP_OFFLINE; What would be nice is if we could use the symbols from Kconfig, to then only do mhp_default_online_type = CONFIG_MHP_DEFAULT_ONLINE_TYPE; But as far as I know, that's not possible. Thanks! Acked-by: David Hildenbrand -- Cheers, David / dhildenb