From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63AF8C021A4 for ; Mon, 24 Feb 2025 11:13:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D89D36B0085; Mon, 24 Feb 2025 06:13:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D384D6B0088; Mon, 24 Feb 2025 06:13:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C001C280001; Mon, 24 Feb 2025 06:13:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9C2326B0085 for ; Mon, 24 Feb 2025 06:13:51 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 54FE0B66C9 for ; Mon, 24 Feb 2025 11:13:51 +0000 (UTC) X-FDA: 83154578262.25.429814C Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf13.hostedemail.com (Postfix) with ESMTP id 307CA20006 for ; Mon, 24 Feb 2025 11:13:48 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf13.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740395629; a=rsa-sha256; cv=none; b=fGRqICj++HVpq7QMcZqes2Dxqy/mxzkwiTDIqtFqt2npZKv6MNjV1gBD5BLUsb4jXxUWlt ZL42otOqon81Khcu5KenCAwwPM6yJr18nGsCT4oMlK1Us+2qj7bNcTUdJy0JbHts/OJjn+ ftXI51EwVBIrTio2JKmE/Fi9gSvOK2o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf13.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740395629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=agwkPsQh4b0DyXkYLYLuwktIP7TFr6q/buoiPBn5ggc=; b=tecYtymRf+sM+XH9qkk03kjZwavNPtMWsTtCXd8mZyxMIf3ISK+oOPICpejRyoA3VVRpnl k1MOHZYS7OadnCOGJqNfQduW+yy25NSIzqHcOUpYKNmRNilIuDzI9CzxMUAcbTG11/1d3V xPtlJl04Udgm893POvrHFGH7Llj6iPU= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Z1dQg35xWz9sSq; Mon, 24 Feb 2025 12:13:47 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id reeUmV24E4zC; Mon, 24 Feb 2025 12:13:47 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Z1dQg2BZFz9sSp; Mon, 24 Feb 2025 12:13:47 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 2FFAC8B765; Mon, 24 Feb 2025 12:13:47 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id kefUlrU39Hz9; Mon, 24 Feb 2025 12:13:47 +0100 (CET) Received: from [10.25.207.138] (unknown [10.25.207.138]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C903F8B763; Mon, 24 Feb 2025 12:13:46 +0100 (CET) Message-ID: <5e8a4dd9-50a8-4080-8d63-dbb8c7241b98@csgroup.eu> Date: Mon, 24 Feb 2025 12:13:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE To: Anshuman Khandual , Steven Price , linux-mm@kvack.org Cc: Catalin Marinas , Will Deacon , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Vasily Gorbik , Thomas Gleixner , Ingo Molnar , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org References: <20250213040934.3245750-1-anshuman.khandual@arm.com> <20250213040934.3245750-5-anshuman.khandual@arm.com> <8e75c5ff-a97b-4a6f-9c8b-ac2598eafe60@arm.com> <6e1201a1-60c1-40a3-951f-d603b6341a11@csgroup.eu> <03b042ec-1cb7-4419-8741-c65e74e49d51@arm.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <03b042ec-1cb7-4419-8741-c65e74e49d51@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 307CA20006 X-Stat-Signature: fp7skwqr3q5w5xqc3tewrkg7ej4r6ry3 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740395628-127053 X-HE-Meta: U2FsdGVkX18JANzOJ8D69x8OlbnyYv1wP2WeyhSVYXFgEg6kEW8Apnjy0gimMcuBgEiXi79gWlojeTmowztxM22nHTX+qQVCyq5F8Vuw1S6+HNln1rnhQWl9wumvMFjQMg9XvtkZ9YXGNEdnlLT+aBf3h+fQK6qRs4UTont98D1r2pQBaDAPvfOvWPYWTUeMYhop/ukSnETtPXXT2sGNszNOS61Jybe5wZuH4Zh+8y2WGzWL9z8vThW3xZR2gRV5um6eDU800Q65F3uH0P9wJMu5QX/IhUtHnSHf5jx3VmC6LtDijyghGaEnx9fKURAlSKqxkLY4iyVFPB9+wHcUZE2+2eUo6PXR8SXSInrXdeCSsNWUNDccLEVceMtk7TOFZDvh4zajjWQ+4EM7V4RtSil+BJV8fxUBhqyj2enH1qdxGFAJJOsJzvr23nA6QER8DHgK8EVd9Z+TwmDHl1G8lH6zOmZsvYU17cU9zgg4Qoa5haf/Ie7bRQgU2LkLZCQfFIBo6kGCzf0ueMF/KvRocExDN111F4LWwNWpwALwdg6d9lXbYk94is44QvY/sc5N/0kB97l32C2FL8+JL7QishSVic3KkTACmOkH5sFbt+WhE2gDFWTxHkQ4l1diIp0gg49mQc1uDZGM19RmkSOkRjMIMU/ZF43OjN/z8LPN2lQsYRDe4gtG8iRzef1wkoXm73l6O8oXajLOZDPB7BssZiy3CvG0jtB+ShUOuNtQxgXo1goChejBRZBn4M3qys7jfmo7cK2s6LLe5dZrufGIS3Dr+BzU2EymJ7eydNriGTSKSzqUg61QuN8H2lpQCRbOT7L4CraOozvHdA3fTrJvCnBLD7enRkDPFnqvs0zRxV9KWdhubRbs0B4xyPKtKwPUI5t2B2bXvs1XP+is2oqDorDIpY3Dq8D0XfRSOhJT+7qsujUXPuzRk19Q84CXg4lOxlT4Etn47W3T/USlkM7 grnkCd2t yx1UtzJOOn755mRKjPlJ/F+uuBE+J1o9n/r01iYfirhLAZDaTpghEyNH/Tg86D2DOTnDwU52BDn3ykB1rDtmCjdP9okPIlpkYEIhRHUpI7o/f4AqchUYdQalukgK/Vmpo95Z5mMqBCiyUQWAi0Yf2izTBCFpDq2KmLMwY/cLc3BZ528dq4aRUuLxDmPk66gnpaJ8630uB6SBlfIDMeae8WtIo11B8k4NBrV0RUsBF3PAh3Kk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 14/02/2025 à 08:26, Anshuman Khandual a écrit : > > > On 2/13/25 17:19, Christophe Leroy wrote: >> >> >> Le 13/02/2025 à 12:23, Steven Price a écrit : >>> On 13/02/2025 04:09, Anshuman Khandual wrote: >>>> Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP. >>>> But generic ptdump gets enabled via PTDUMP_CORE. These configs combination >>>> is confusing as they sound very similar and does not differentiate between >>>> platform's feature subscription and feature enablement for ptdump. Rename >>>> the configs as ARCH_HAS_PTDUMP and PTDUMP making it more clear and improve >>>> readability. >>> >>> [...] >>>> diff --git a/arch/powerpc/configs/mpc885_ads_defconfig b/arch/powerpc/configs/mpc885_ads_defconfig >>>> index 77306be62e9e..db005618690b 100644 >>>> --- a/arch/powerpc/configs/mpc885_ads_defconfig >>>> +++ b/arch/powerpc/configs/mpc885_ads_defconfig >>>> @@ -78,4 +78,4 @@ CONFIG_DEBUG_VM_PGTABLE=y >>>>   CONFIG_DETECT_HUNG_TASK=y >>>>   CONFIG_BDI_SWITCH=y >>>>   CONFIG_PPC_EARLY_DEBUG=y >>>> -CONFIG_GENERIC_PTDUMP=y >>>> +CONFIG_PTDUMP=y >>> >>> I'd suggest dropp this from the defconfig too, just like patch 1 dropped >>> it from debug.config. >>> >> >> Thanks for spotting that. >> >> That one is wrong. Was introduced by commit d210ee3fdfe8 ("powerpc/configs: Update config files for removed/renamed symbols") which aimed at fixing commit e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP") but it did it wrong. >> >> It is CONFIG_PTDUMP_DEBUGFS that is wanted. > > Should this replacement be done in the series or would you like it > to be handled in powerpc later ? Yes I think you should do the replacement.