From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
kvmarm@lists.cs.columbia.edu, linux@armlinux.org.uk,
catalin.marinas@arm.com, will.deacon@arm.com, mpe@ellerman.id.au,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
peterz@infradead.org, christoffer.dall@arm.com,
marc.zyngier@arm.com, "Kirill A. Shutemov" <kirill@shutemov.name>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Michal Hocko <mhocko@suse.com>,
ard.biesheuvel@linaro.org, mark.rutland@arm.com,
steve.capper@arm.com, james.morse@arm.com, robin.murphy@arm.com,
aneesh.kumar@linux.ibm.com, Vlastimil Babka <vbabka@suse.cz>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH] mm: Introduce GFP_PGTABLE
Date: Mon, 14 Jan 2019 09:44:05 +0530 [thread overview]
Message-ID: <5e87d900-9548-1782-6244-6dcf7339139d@arm.com> (raw)
In-Reply-To: <CALvZod5euX2mW7qgL28YZrTVQ-gYYR83aGKfOyZ9=BEzHwyJOw@mail.gmail.com>
On 01/12/2019 10:18 PM, Shakeel Butt wrote:
>> --- a/arch/x86/kernel/espfix_64.c
>> +++ b/arch/x86/kernel/espfix_64.c
>> @@ -57,8 +57,6 @@
>> # error "Need more virtual address space for the ESPFIX hack"
>> #endif
>>
>> -#define PGALLOC_GFP (GFP_KERNEL | __GFP_ZERO)
>> -
>> /* This contains the *bottom* address of the espfix stack */
>> DEFINE_PER_CPU_READ_MOSTLY(unsigned long, espfix_stack);
>> DEFINE_PER_CPU_READ_MOSTLY(unsigned long, espfix_waddr);
>> @@ -172,7 +170,7 @@ void init_espfix_ap(int cpu)
>> pud_p = &espfix_pud_page[pud_index(addr)];
>> pud = *pud_p;
>> if (!pud_present(pud)) {
>> - struct page *page = alloc_pages_node(node, PGALLOC_GFP, 0);
>> + struct page *page = alloc_pages_node(node, GFP_PGTABLE, 0);
>>
>> pmd_p = (pmd_t *)page_address(page);
>> pud = __pud(__pa(pmd_p) | (PGTABLE_PROT & ptemask));
>> @@ -184,7 +182,7 @@ void init_espfix_ap(int cpu)
>> pmd_p = pmd_offset(&pud, addr);
>> pmd = *pmd_p;
>> if (!pmd_present(pmd)) {
>> - struct page *page = alloc_pages_node(node, PGALLOC_GFP, 0);
>> + struct page *page = alloc_pages_node(node, GFP_PGTABLE, 0);
>>
>> pte_p = (pte_t *)page_address(page);
>> pmd = __pmd(__pa(pte_p) | (PGTABLE_PROT & ptemask));
>> diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c
>> index 7bd0170..d608b03 100644
>> --- a/arch/x86/mm/pgtable.c
>> +++ b/arch/x86/mm/pgtable.c
>> @@ -13,19 +13,17 @@ phys_addr_t physical_mask __ro_after_init = (1ULL << __PHYSICAL_MASK_SHIFT) - 1;
>> EXPORT_SYMBOL(physical_mask);
>> #endif
>>
>> -#define PGALLOC_GFP (GFP_KERNEL_ACCOUNT | __GFP_ZERO)
>> -
> You have silently dropped __GFP_ACCOUNT from all the allocations in this file.
Right, they need to be added back explicitly after GFP_PGTABLE. Matthew had
pointed this earlier. Will fix it next time around.
>
> BTW why other archs not using __GFP_ACCOUNT for the user page tables?
>
Some archs do and some dont. User page tables pages should use __GFP_ACCOUNT
for allocation. I am working on fixing it for arm64.
next prev parent reply other threads:[~2019-01-14 4:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 10:26 Anshuman Khandual
2019-01-12 12:12 ` Matthew Wilcox
2019-01-12 12:55 ` Anshuman Khandual
2019-01-12 13:49 ` Christophe Leroy
2019-01-12 15:49 ` Matthew Wilcox
2019-01-12 16:50 ` Shakeel Butt
2019-01-12 16:50 ` Shakeel Butt
2019-01-14 4:28 ` Anshuman Khandual
2019-01-12 16:48 ` Shakeel Butt
2019-01-12 16:48 ` Shakeel Butt
2019-01-14 4:14 ` Anshuman Khandual [this message]
2019-01-13 17:35 ` Michal Hocko
2019-01-14 4:00 ` Anshuman Khandual
2019-01-14 7:01 ` Michal Hocko
2019-01-15 14:11 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e87d900-9548-1782-6244-6dcf7339139d@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=james.morse@arm.com \
--cc=kirill@shutemov.name \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=shakeelb@google.com \
--cc=steve.capper@arm.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox