From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2837DC3DA4A for ; Thu, 8 Aug 2024 15:20:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 951846B00EE; Thu, 8 Aug 2024 11:20:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 901BC6B00EF; Thu, 8 Aug 2024 11:20:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C9626B00F0; Thu, 8 Aug 2024 11:20:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5F10F6B00EE for ; Thu, 8 Aug 2024 11:20:35 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 06FD3A7714 for ; Thu, 8 Aug 2024 15:20:35 +0000 (UTC) X-FDA: 82429440030.10.4AB8E3D Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf11.hostedemail.com (Postfix) with ESMTP id CCB8C40023 for ; Thu, 8 Aug 2024 15:20:31 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LE2NutbZ; dmarc=none; spf=pass (imf11.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723130422; a=rsa-sha256; cv=none; b=kqaUZEpk0yqDDMKm9E75n3XnSqL2N6YuUlzvYptvk73UjAB6LisWcbRBPnWKiHiWt6CIrt 7coUgnOStJ0k0UcUu9VUO/ImWw+H+BAFUlhl6CWmCir2NmfsJPhb2PI2y2i3Ns7hEHX+eF IoIS+AT8/2DBwh3JUE8wLmC2AS8w6PM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LE2NutbZ; dmarc=none; spf=pass (imf11.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723130422; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SiZq70LSf/bCrrIvFZliDXUYPXu4ym37OR0vAgA3uYk=; b=lEwCi8xW1G6VHh81ALr3iSrPyOoaYkukMc7BsXlB1//5caABoHCcCETMKQjIWsFEzFwNXd wYEYhGsVUKjNDHy0p1L+3aPnSKCPZ16Fx4urpn/bkEQbfC7NZWwpjCO8/vKsvsHY0f0gsb FXb3IDcpo4I5yrGJdqdjiixsZTORfVU= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1fda7fa60a9so10452215ad.3 for ; Thu, 08 Aug 2024 08:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723130430; x=1723735230; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=SiZq70LSf/bCrrIvFZliDXUYPXu4ym37OR0vAgA3uYk=; b=LE2NutbZ4CwWJEb72JqV8/LmBHPYRRFNkSPBGQTTASqOO4U0hi8i4tDvgBo6Bpc3b5 BXlEiBo8ImsfwyXmoZVuQ0Y7qS8xkjdqx+axxv7OW+jHLom8JqIlCtSZFx8e6Bgk4vXg eojk8irvcAyJIFjOJ6tWMoOnhiQXgE7aS2j4qIOclvEhFndjoAHvMNnuYEWsy9ydXpvK 8ho42cROGDY4KUeBuS5SzIB+ArHrsfvkSTjtiPFGdjQ1OpEoGvyuVRpmTUFP0JlYYyGE ZBwEHamUQv1zL9msIMvOD4u1P+c5tKQ7L9vFFsLM+nbPCxljnx15cthirAERuwpzrotx u/FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723130430; x=1723735230; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SiZq70LSf/bCrrIvFZliDXUYPXu4ym37OR0vAgA3uYk=; b=mBXKdJfsK504qFCosUKmGVBkXDaSD8FvuczO2kkrvSRyctOGNVFTTxeUMnJgNWziFo U04k3qcjN4V4vpPUVlHkxnejCpTx7rjNC8s150UkIDCfzic6ZuEhCWSbR/7gJd1aB0+I M2kumnPcrJbyFwHAXD1daZLpK7KDd5Al9q5mpYg9pjnLzySii1VCmZg0ybnMDC0Cc/UH eAfppK0V/XMZl3YsnNv34wnf7++HdjQtBL4mEr1MvOgE9yl+D0aC/BrCJjsAb5fXQW2M LyEKEYor8d7lt/GbI8wtw2DEXhsYUA79Tvr12/CkA9E+QT0LZZ2JnnLijnNtX8p5vywr zCVg== X-Forwarded-Encrypted: i=1; AJvYcCWZCGsI0pXKcUAaPS4EqYoAeuJqFFVrygtz0T0DuzgqDLker2efOhqoAjZBmhX6HGm5pqNC99imhguf8E2V6GA9Urc= X-Gm-Message-State: AOJu0YyCeAD11b95Nk4uO8hY8D95z0Pv5cJnTzTruNKKg8FgxYCxPzWy r+oF647U0A3qja9UZ3HONss9EvfwlwesZpV5qDvYn4cHPSKTrIf0 X-Google-Smtp-Source: AGHT+IE8816vdK61O2xaKdqeewiL3CLyGiq118QlvJdPwT9G6srmiOZdavzDEeaCFuHZvoihZEnIrA== X-Received: by 2002:a17:903:41ce:b0:1fc:6901:9c2b with SMTP id d9443c01a7336-2009524a701mr30855585ad.23.1723130430254; Thu, 08 Aug 2024 08:20:30 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ff5928ee8dsm125869725ad.230.2024.08.08.08.20.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Aug 2024 08:20:29 -0700 (PDT) Message-ID: <5e7c59c6-ec88-4ee3-8a5c-93a16e5f444e@roeck-us.net> Date: Thu, 8 Aug 2024 08:20:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] powerpc/mm: Fix size of allocated PGDIR To: Christophe Leroy , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org References: <1cdaacb391cbd3e0240f0e0faf691202874e9422.1723109462.git.christophe.leroy@csgroup.eu> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <1cdaacb391cbd3e0240f0e0faf691202874e9422.1723109462.git.christophe.leroy@csgroup.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: CCB8C40023 X-Rspamd-Server: rspam01 X-Stat-Signature: 3tjdk6jqz56h8m7pukcrt46gsu4gpywo X-HE-Tag: 1723130431-422612 X-HE-Meta: U2FsdGVkX1/ireOBM3XOk74+gbIK787bHNsBuBj5EhOQYbafIuRsPKiYDy8bou/utypSCUfqMFIYwhGewRfJjnvQrlN3fuImBblMs78kVuBE1pfmUuTL5EycD8TtywgFzmzx0ksI5PtquJQU1NPlfV1VJ0hzZBYSIBX04CmjdnmVeayboXfmO44T3eI4rl005Gxvfgw0cdgqf4dRZpXu8PhIPgQalszZYnrPelzFO9UwTecs6w3T9/kEdz/5Bv2A3YEHcaFTVXfpWFMo7Szeeh+21A+dU9cxavSZuEYHIbBnv66dC7j6x0cIzguxPbmBBZEX5+Ds3OaU80MLVUAXUhbvJ03CAtG6ZgMDi9I9Fq/pQ/pC/YxOVdhlLftO2vOctzhpIeGqGUrHoLxDNFmGxgRutVOxi2J9Pjl4oKjJBA8Wc4uZLlqzZikMCHwnycmrSLUFon+mNCcbZ5W7DCJUpSmMWPMU+Z1vtfzpOpB36N1KtEZ/1rxAOhQ1jCaY/d3gMwrQuds9C8kx0geYYkPjm77E7e7szojZAycBUkjH9I71Gay1Vg3MVac0n2Ju0qRHvFbptnbLF618ZKZjckOu8cKT7UJ9bKLf8eMGGnI6yKz3Omkz6aOWaEiTso2GooxlIkPh8lAontwVDaR9MP8O1D0NO1Sp1g8yDXehk49tiSJiHwmNqe2QdnzK/91+hHWZItLwNoyhHL/z3d6HqQqbCZdZmLV3kfkiDH1mSvF8FvrTnMktMMvaESBIsk32NaNirrXtDShR1kHbl6Y7nohW0z7qILB/IZzsmRAFVODwSLs4pJZyNW6aAlgbGNMABRfjkT7r9wBoSV/wHbr8R9Qrh8WxJ98ET3rnVRo1sEW1dR02VXzBCBi8L+3wXbc8k7XkP2wbZc8A7ERIEAQr0UubVgvbOpq9q2cFfwIDSB2VgBqOJ1vzEg/mC1+wFwuKLPEOaT6iz2udL3JEREJHZaT PaKhMvxZ Dl7sW3DskvOoCzrBh462yWKXQTwcARz3r3JnFzlBkQL3CTMM5ddu1NQBeV9/4tHQZFsN3Qu2KOSl7EdxCkziQpHD89mETSCAMvwPivWMLtUvI/hFsTeh8Xy2EUAlZzrmgR2Pra9A8gQ4guMNjL4FJ2k70BR7hWLbv6Z2JMw8IiJT+Ax3VWqXOjjEM9M5r+M/Rp1fptl+b5szjI7+e/DrQYgPYSFidWRfyxxRGu5Mfp4oNDFqXVEmd2JOHZ6A92kpPQ9Nh7RJ6xcK/nBySEyFWy/7seJJAlFc8xX4IRmrnBF/a76FYR1Rp/5x8Iy8qkOWhuf6Nbfc5UscjUgbX0n9Exp4PQQuNwz/HAeSDpbDLwTYlia+u4Spy74LWE0fIL8zUxYigYB4cpgi8OFfueAIOx8oiaCYEhhV/Mkx3w4QSWRhaC7my5alrO5/aBdkrGGg6NGQJQWpa+0vk9UAv6Hvs1Lj0N1nS40l3sVt+tu7QkI9PyE3IXum9pBcUQnHCrbai/qscQwOShIdyfIXjvDGbOoOuDE0q2z55WUREC4kVIIeQnBuzXCRsCwpMbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/8/24 02:32, Christophe Leroy wrote: > Commit 6b0e82791bd0 ("powerpc/e500: switch to 64 bits PGD on 85xx > (32 bits)") increased the size of PGD entries but failed to increase > the PGD directory. > > Use the size of pgd_t instead of the size of pointers to calculate > the allocated size. > > Reported-by: Guenter Roeck > Fixes: 6b0e82791bd0 ("powerpc/e500: switch to 64 bits PGD on 85xx (32 bits)") > Signed-off-by: Christophe Leroy Tested-by: Guenter Roeck > --- > arch/powerpc/mm/init-common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/mm/init-common.c b/arch/powerpc/mm/init-common.c > index 9b4a675eb8f8..2978fcbe307e 100644 > --- a/arch/powerpc/mm/init-common.c > +++ b/arch/powerpc/mm/init-common.c > @@ -73,7 +73,7 @@ void setup_kup(void) > > #define CTOR(shift) static void ctor_##shift(void *addr) \ > { \ > - memset(addr, 0, sizeof(void *) << (shift)); \ > + memset(addr, 0, sizeof(pgd_t) << (shift)); \ > } > > CTOR(0); CTOR(1); CTOR(2); CTOR(3); CTOR(4); CTOR(5); CTOR(6); CTOR(7); > @@ -117,7 +117,7 @@ EXPORT_SYMBOL_GPL(pgtable_cache); /* used by kvm_hv module */ > void pgtable_cache_add(unsigned int shift) > { > char *name; > - unsigned long table_size = sizeof(void *) << shift; > + unsigned long table_size = sizeof(pgd_t) << shift; > unsigned long align = table_size; > > /* When batching pgtable pointers for RCU freeing, we store