From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3D45C3ABBF for ; Tue, 6 May 2025 12:59:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84E896B0088; Tue, 6 May 2025 08:59:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 800E16B0085; Tue, 6 May 2025 08:59:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6299C6B008A; Tue, 6 May 2025 08:59:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3EFD86B0085 for ; Tue, 6 May 2025 08:59:57 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7620FB6B35 for ; Tue, 6 May 2025 12:59:58 +0000 (UTC) X-FDA: 83412490476.17.A050468 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf06.hostedemail.com (Postfix) with ESMTP id 30C2C180008 for ; Tue, 6 May 2025 12:59:55 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Brmv+GDb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0IeWWCQ+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Brmv+GDb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0IeWWCQ+; dmarc=none; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746536396; a=rsa-sha256; cv=none; b=TphLOtTophnz7hp2afFOZE/jlcDk0E8KaJV7BI6Di5tzSSS5m47JizbZwQvUIz2HFP6j8P C4t1bAh9XRk7gt/4+hVMGB34k+pZBmjjRt9e164o3mlfKtrE3KQtUt9qmv4h6f2Lh2l9Ry qVQgpWMawE1vl3H6qWkmFd8DZl9It9Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746536396; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LE288l1OjNqKRkvvMw8NUANY6m2+aW6j7ftSgAAUxjs=; b=1k9c2VhJsOJEg4qmlAzdHlh9u2CrVHMCqMLlCRgcP5yEg5TpxQBvch2dmzGO+iRExQznGt VOQyfczWPqGX3IewvMxEiYd9fEcfiu/it9kc1G3GZHWRX1G+g/cFxmJe1bLgstPfBNG0X+ mbfasT4BsFwOZpbK6pWpg+DxP2M8v5s= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Brmv+GDb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0IeWWCQ+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Brmv+GDb; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0IeWWCQ+; dmarc=none; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 99AF71F7CC; Tue, 6 May 2025 12:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746536394; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LE288l1OjNqKRkvvMw8NUANY6m2+aW6j7ftSgAAUxjs=; b=Brmv+GDbbaZI8nnTTjKvvWkSZQpx+O47c25SxiaYph71lFHXyckCO1nK1ICZFD/wM85lPv no8Da9lgStssS7PjcDLdM2ihEqDjaQwnMv3bajjEr76frANBZlVVyDNnCPxV56dAfhNHm3 IHiSFGlKsXTvUX50Aad11so7hB/3v1U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746536394; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LE288l1OjNqKRkvvMw8NUANY6m2+aW6j7ftSgAAUxjs=; b=0IeWWCQ+hkKQAt2Jf/PboVlhZwlCcUFpQiQRh64K0PokVha2z5p2qtLy+nizUUi+CAg0my FEx7xI7r1llasNBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746536394; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LE288l1OjNqKRkvvMw8NUANY6m2+aW6j7ftSgAAUxjs=; b=Brmv+GDbbaZI8nnTTjKvvWkSZQpx+O47c25SxiaYph71lFHXyckCO1nK1ICZFD/wM85lPv no8Da9lgStssS7PjcDLdM2ihEqDjaQwnMv3bajjEr76frANBZlVVyDNnCPxV56dAfhNHm3 IHiSFGlKsXTvUX50Aad11so7hB/3v1U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746536394; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LE288l1OjNqKRkvvMw8NUANY6m2+aW6j7ftSgAAUxjs=; b=0IeWWCQ+hkKQAt2Jf/PboVlhZwlCcUFpQiQRh64K0PokVha2z5p2qtLy+nizUUi+CAg0my FEx7xI7r1llasNBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7841913687; Tue, 6 May 2025 12:59:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id /fUCHcoHGmh0MwAAD6G6ig (envelope-from ); Tue, 06 May 2025 12:59:54 +0000 Message-ID: <5e708851-6e8a-4ec8-81ee-55a55d1e3d2c@suse.cz> Date: Tue, 6 May 2025 14:59:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] locking/local_lock: Introduce local_lock_is_locked(). Content-Language: en-US To: Alexei Starovoitov , bpf@vger.kernel.org, linux-mm@kvack.org Cc: harry.yoo@oracle.com, shakeel.butt@linux.dev, mhocko@suse.com, bigeasy@linutronix.de, andrii@kernel.org, memxor@gmail.com, akpm@linux-foundation.org, peterz@infradead.org, rostedt@goodmis.org, hannes@cmpxchg.org, willy@infradead.org References: <20250501032718.65476-1-alexei.starovoitov@gmail.com> <20250501032718.65476-4-alexei.starovoitov@gmail.com> From: Vlastimil Babka In-Reply-To: <20250501032718.65476-4-alexei.starovoitov@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 30C2C180008 X-Stat-Signature: 48xwk4ttr39diafauo3t9z1xkx78khse X-Rspam-User: X-HE-Tag: 1746536395-540839 X-HE-Meta: U2FsdGVkX1/cjGQp8OL0Zy4wm6wYtFe2wR1RaRBUFHB3NaFDKBmIQ8mxjRoWHDGesoyTntAUVW6cmrcve7iuJlxYOjh1N13a6DeAHGVYQLjnAdwdp+09EEO4k1PeR1GZVP37O6sWKaabXlrKlStPxTbu70KCzCKJckrPoEmjySRQHxgy7F8uWf5J2YcGz6Vu6d3BqCPQI/pf8ptG/IQLkw4KdnnIgRpSuFpIOiFlnPpuO9ivsMuELxfPgEmo90e7JOt/e5LJ9Ows2HGR/tV8Wa0Dd7Fzlf6SyUJdiSiJrxhiUDXqywS9VGnO2Y1Yi7Yj+Tzgd0kvSbVVCNNQ3qdQ7tndwhGoRyWBpt91ohvo6DvurbgHogz1j8+8q/gpjZKRqO/fv/DBuZ5ZAKNDPR0bLLx/9SDcf1gKsIdjCJRta63aboZBKxY5UII4XD3HWpwMCeNep9V1NvXDWx5nBx8rWHvxkxr10rXBiQzdP9ELbYvtqlN2fvPeVkJ9z7GAyqtpodGeg1pUn4CYiHMudlIzfNUBrSWDxjEkTKJBNbYeNmd7iKdIQasTJgWaQDHOKMEb/jD0d69tVsWXS5UAgYA2ILgm+eWFC7Hqa+sy8DHTJfC+rJcOL3u/syR9HKGLpdIFvlToZ9Cc2nD7ySD9iC+Y21oO71AmGrQJb+hjz/3lWchp0UK+pWoLIpHgNaT3zlDVnGb36y+cfW2peN54YZ0JnlRmSMKe8aH0kfMuFHtS824VV2423KpC4/QtyVUAtpFDQOeFpFMbX/9+AoFYgEjV/C5WOxTfON8HyfLWiJeKw2VWBQQptoRzgnY4CUqu1BuU+I+S8WH9/DMiZZOKUqox5lxRa1hOKtKCQ6QxLEnGwl/gAl7yaeCdafX8nw4k5xX3DQxby7PKt1c7AXlEU7Sb6DQ547XMj13tlr/dVXDxDl85rkUGBYT1i7K242Z6tbtHYEafXRyuvoLKsLZkrzA snwiiplZ TvfcjIrBVP7wzfo2p9TFczHAFktDnWGxLupxBsxF+Nhh5ljo4Qv9EfeQbgAixk4UDf2dSFi7qQXNy69GvT+5ANRGkSB1Q+Ep1/VZJhHzTnl6gJvEPq63QD6y0SH7ASd+xFTPAqM2Y1JJLIABOYSaZeEPPbUAqY1fQFaC2qvGuRVmFDF4PD2aMxF1glkQ31JeGmKLCSr1meXvnGN/t5CvB0xLmX7MCkcEY389Ge+iHymXpCXFPsjpY9M3cITbj8lu9t4YaHZnG1543kJGa3vW7RygezUm8Rnzt2TcIks6NxDfL6QxQJW5mfRN6xBUAIkQymBC/D3cZB1oSIjYTcest2Xv3nV1/pffMXLuYFHsp5ooMLegxmnN8H5zzSUEcUpLtoNsNc/FFuTDqqIJAtTu0/oHwjk0ycK1UDI49aie2rXywT/0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/1/25 05:27, Alexei Starovoitov wrote: > From: Alexei Starovoitov > > Introduce local_lock_is_locked() that returns true when > given local_lock is locked by current cpu (in !PREEMPT_RT) or > by current task (in PREEMPT_RT). > > Signed-off-by: Alexei Starovoitov On !RT this only works for local_trylock_t, which is fine, but maybe make it part of the name then? local_trylock_is_locked()? > --- > include/linux/local_lock.h | 2 ++ > include/linux/local_lock_internal.h | 8 ++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/include/linux/local_lock.h b/include/linux/local_lock.h > index 16a2ee4f8310..092ce89b162a 100644 > --- a/include/linux/local_lock.h > +++ b/include/linux/local_lock.h > @@ -66,6 +66,8 @@ > */ > #define local_trylock(lock) __local_trylock(lock) > > +#define local_lock_is_locked(lock) __local_lock_is_locked(lock) > + > /** > * local_trylock_irqsave - Try to acquire a per CPU local lock, save and disable > * interrupts if acquired > diff --git a/include/linux/local_lock_internal.h b/include/linux/local_lock_internal.h > index 29df45f95843..263723a45ecd 100644 > --- a/include/linux/local_lock_internal.h > +++ b/include/linux/local_lock_internal.h > @@ -165,6 +165,9 @@ do { \ > !!tl; \ > }) > > +/* preemption or migration must be disabled before calling __local_lock_is_locked */ > +#define __local_lock_is_locked(lock) READ_ONCE(this_cpu_ptr(lock)->acquired) > + > #define __local_lock_release(lock) \ > do { \ > local_trylock_t *tl; \ > @@ -285,4 +288,9 @@ do { \ > __local_trylock(lock); \ > }) > > +/* migration must be disabled before calling __local_lock_is_locked */ > +#include "../../kernel/locking/rtmutex_common.h" > +#define __local_lock_is_locked(__lock) \ > + (rt_mutex_owner(&this_cpu_ptr(__lock)->lock) == current) > + > #endif /* CONFIG_PREEMPT_RT */