From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0490ECD11DF for ; Tue, 26 Mar 2024 09:44:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D3DC6B0082; Tue, 26 Mar 2024 05:44:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88D2D6B0083; Tue, 26 Mar 2024 05:44:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74B386B0088; Tue, 26 Mar 2024 05:44:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6180C6B0082 for ; Tue, 26 Mar 2024 05:44:16 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 36D3D1A02FC for ; Tue, 26 Mar 2024 09:44:16 +0000 (UTC) X-FDA: 81938704512.13.E82445E Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf22.hostedemail.com (Postfix) with ESMTP id 53EAEC000A for ; Tue, 26 Mar 2024 09:44:14 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b="WpQ+Ny/V"; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf22.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711446254; a=rsa-sha256; cv=none; b=oXYKTNPl8va6LYy5lj9F6gZ0R5PCfAQrrM5xijhvyTVxLoGquuLT00Qw0ggGUUdEXt2Hfe B7oT/xkTHaVtihCxwmI8b65m0g83OOVJ8XRtd/G4MQeuTrYZrfpEmQRNoD4nl1+5VcQGta SQ054pUZw/TC9Lf08NufG+TRUN5uKKo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b="WpQ+Ny/V"; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf22.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711446254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YrxaH5mDWbAQSraF+LJ/aFHOMZvEWk75cjO9z38h3ds=; b=o9PY+qKT9ZEGfUgRJT+7garmhRJkIc/pC+cK09mqlnckM2lc01soqYqiTjEwXE/PuI8rn2 LI3th8cjypX78ZtEYomoZea3ku9TkZGdAK2goxQ6p0UlLILE2epXPU/xjEABELJLbRUjtA L7HXHivV29dc4h2wopHAJfF/q8Od8Iw= Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4V3lHr6bWfz9scb; Tue, 26 Mar 2024 10:44:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1711446248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YrxaH5mDWbAQSraF+LJ/aFHOMZvEWk75cjO9z38h3ds=; b=WpQ+Ny/VkIGZVysTH9mt6ac6RJIyCQebBhbHlxffuvruRXKXPbTkzElPZGzrve3xAMydqz FzwRyBnZHBfacuxH6PnJB8Bf2FbqGz9YWC2THPAs9/Rq5Cnrv2Y3pfWlbhZhv5RO3FrVMF N7rBO3rjyZhniq35YhDDYlFMWpAgwkeMPjPc98/zmWCggjAIJlL/B3sPeJ93UWO8swi9bP VNEOiZ2fS2J3aSpm+Bs1m5GwKCu7yXFOjkPmpp48UafhHQM3lKS85eHfvVH+pGt3rzgs5S vg8Z5qaYNPqqQ6dPRygBDajkpk2y3m9pi0ejAzbH6PPK7VaVGZKbr2T9ZcMIxQ== Message-ID: <5e5523b1-0766-43b2-abb1-f18ea63906d6@pankajraghav.com> Date: Tue, 26 Mar 2024 10:44:02 +0100 MIME-Version: 1.0 Subject: Re: [PATCH v3 04/11] readahead: rework loop in page_cache_ra_unbounded() Content-Language: en-US To: Hannes Reinecke , Matthew Wilcox Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, gost.dev@samsung.com, chandan.babu@oracle.com, mcgrof@kernel.org, djwong@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@fromorbit.com, akpm@linux-foundation.org, Pankaj Raghav References: <20240313170253.2324812-1-kernel@pankajraghav.com> <20240313170253.2324812-5-kernel@pankajraghav.com> <7217df4e-470b-46ab-a4fc-1d4681256885@suse.de> From: Pankaj Raghav In-Reply-To: <7217df4e-470b-46ab-a4fc-1d4681256885@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 53EAEC000A X-Stat-Signature: 5gzq3woui17d49hcsy9keifed4uxs4uz X-HE-Tag: 1711446254-65466 X-HE-Meta: U2FsdGVkX1+ReiJI5pkRNbxtwAZnDeriE2gIga8xcRvi1DcveDyT1yJN65nErYnfOCt8H7UeBuud5l1UG1Sb+2bAXzH1ebARTTp28ioa1LczHNuh6s1miueORICF9y7g5ZkBmkgmjPh8lGhABoNWeO/hX2X4V3o7tFDMwzlqgg0i5O9UVRiti2QXXIdQLTu88O5bHxXuwkqqKKiJXYg77e2eNCQObKwminhRtVSzUzVzB4YP6KV2ThQ6vuPt2TYkbEfxwY3YG50hQ2Z9a4cSDxPETN82EjUdDLTgCCtoaUKjPKa9NhJ5NBtkwvUU5t/XNNO4PjUyNvILjSZL3PEvayQkq22Mi5PuBOGJaltwR+nWvyvkVSoie2ECGA3sW1ryqUcSaUcG+K++158yawVsQd7jWG3la7O4b5rdfCZmEU+jkM5Y5aXrcbW46lJqHPKuhWXl3rXlEJ/XaEIQP8flsSWh6C/LH+WgKnSSKMCjBQC6kpvnNd/O2iaOUl5LnL+wPAgYIZuis8GXRtzScAX+p5VNJbdKaW472bjUBxuCbokgd+Sm6TKdnlLoWaWSO9dyx9gBPgGv7uQ410SU8f6O3fmzRXeWTZzQOd+BPGY4FfEZOAskItslSBoAD03zfD7sEAmR7LAq6JKhflYBQJmykAn9mI7yNnB6eIVm0/lHa5qlqsuINQ4m/uNulIMUI5TM1uvuc9gllNK8/lKuEySe9Oz9Ual5+1ppVHTo/niBhJC10rbHZdOs0b2yKppZ03bp6MzTXR7dZjwSMONR8GI3cQwCuyUHydOD7nLjE+n/4enVi09qQG/bsOQKPWlizeJqAGjHRG6iD+oSPQKZ0HNDapLswadZoCDLMlwEUdLZHx0KrHoQAO5ONsEv4jAA5449P7VUQe63yWPb4K8b+6WUfKhzBVt+iIbkOfMgr12pE7ZsFifvVnF5ECiFBdirlHGhmXcsh12HerZcS+aQ7Ji RFRkMPVn nk5GTnTwEJ7ZzXDP339H2zR9N+z/a1LPEtN1GKNwYQCxqN35wsUcPAulvZnAdpAQowaMTc/2IFZndISkz1O8eyYzhev76fu7hZHst/oY6qUG6LI3Rn7YGRYrR0HZYWhFEgRKgQ3ggcsn/eo3xtnHCZST1ml7B6MZWB0v+hljEQWOy6xAGwK/LFizkMI6Kz42dYby9PTcXcp1G5nV47GKw8FNpiLaB1Ty8L46Kk8DqSYpu2jrNo0ZWXtmrccX11i69ihb0+ZBblUJrdxuFPn09/t3LAWnkftYm1wAbCEJ61P6qkUbbbOg1OTKFsT1RIAhTVCduTS/3qlPXWAAusIdk1NCwuBVMtvIZNNvzgRhqzJZEhts= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Hannes, On 26/03/2024 10:39, Hannes Reinecke wrote: > On 3/25/24 19:41, Matthew Wilcox wrote: >> On Wed, Mar 13, 2024 at 06:02:46PM +0100, Pankaj Raghav (Samsung) wrote: >>> @@ -239,8 +239,8 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, >>>                * not worth getting one just for that. >>>                */ >>>               read_pages(ractl); >>> -            ractl->_index++; >>> -            i = ractl->_index + ractl->_nr_pages - index - 1; >>> +            ractl->_index += folio_nr_pages(folio); >>> +            i = ractl->_index + ractl->_nr_pages - index; >>>               continue; >>>           } >>>   @@ -252,13 +252,14 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, >>>               folio_put(folio); >>>               read_pages(ractl); >>>               ractl->_index++; >>> -            i = ractl->_index + ractl->_nr_pages - index - 1; >>> +            i = ractl->_index + ractl->_nr_pages - index; >>>               continue; >>>           } >> >> You changed index++ in the first hunk, but not the second hunk.  Is that >> intentional? > > Hmm. Looks you are right; it should be modified, too. > Will be fixing it up. > You initially had also in the second hunk: ractl->index += folio_nr_pages(folio); and I changed it to what it is now. The reason is in my reply to willy: https://lore.kernel.org/linux-xfs/s4jn4t4betknd3y4ltfccqxyfktzdljiz7klgbqsrccmv3rwrd@orlwjz77oyxo/ Let me know if you agree with it. > Cheers, > > Hannes >