From: John Hubbard <jhubbard@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Alistair Popple <apopple@nvidia.com>,
Shigeru Yoshida <syoshida@redhat.com>,
David Hildenbrand <david@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Minchan Kim <minchan@kernel.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>
Subject: Re: [PATCH] mm/gup: stop leaking pinned pages in low memory conditions
Date: Wed, 16 Oct 2024 15:05:28 -0700 [thread overview]
Message-ID: <5e499b63-8b38-4ddc-82ab-848301fd8d2b@nvidia.com> (raw)
In-Reply-To: <20241016145739.770543d44313967f611f3810@linux-foundation.org>
On 10/16/24 2:57 PM, Andrew Morton wrote:
> On Wed, 16 Oct 2024 13:22:42 -0700 John Hubbard <jhubbard@nvidia.com> wrote:
...
>> Fix this by unpinning the pages that __get_user_pages_locked() has
>> pinned, in such error cases.
>
> Thanks.
>
>> Fixes: 24a95998e9ba ("mm/gup.c: simplify and fix check_and_migrate_movable_pages() return codes")
>
> I'll add this to the -stable backport pile, although this seems a bit
> marginal?
I'm on the fence about that. It is marginal: you have to
exhaust memory. On the other hand, a real user reported
this bug to us.
I guess I'd lean toward "correctness in -stable", and
add it to the pile, in the end.
thanks,
--
John Hubbard
next prev parent reply other threads:[~2024-10-16 22:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 20:22 John Hubbard
2024-10-16 21:57 ` Andrew Morton
2024-10-16 22:05 ` John Hubbard [this message]
2024-10-16 22:41 ` Andrew Morton
2024-10-16 22:13 ` Alistair Popple
2024-10-16 22:22 ` John Hubbard
2024-10-17 8:51 ` David Hildenbrand
2024-10-17 8:53 ` David Hildenbrand
2024-10-17 17:06 ` John Hubbard
2024-10-17 17:10 ` David Hildenbrand
2024-10-17 16:54 ` John Hubbard
2024-10-17 21:28 ` Alistair Popple
2024-10-17 21:47 ` David Hildenbrand
2024-10-17 21:57 ` John Hubbard
2024-10-17 22:03 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e499b63-8b38-4ddc-82ab-848301fd8d2b@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=syoshida@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox