From: "Arnd Bergmann" <arnd@arndb.de>
To: "Michael Ellerman" <mpe@ellerman.id.au>,
"kernel test robot" <lkp@intel.com>,
"Arnd Bergmann" <arnd@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"Masahiro Yamada" <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
"Linux Memory Management List" <linux-mm@kvack.org>,
"Matt Turner" <mattst88@gmail.com>,
"Vineet Gupta" <vgupta@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>, guoren <guoren@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Greg Ungerer" <gerg@linux-m68k.org>,
"Michal Simek" <monstr@monstr.eu>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Dinh Nguyen" <dinguyen@kernel.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Geoff Levand" <geoff@infradead.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"Andy Lutomirski" <luto@kernel.org>
Subject: Re: [PATCH 17/22] powerpc: ps3: move udbg_shutdown_ps3gelic prototype
Date: Fri, 10 Nov 2023 07:30:20 +0100 [thread overview]
Message-ID: <5e0966cd-7fa6-4217-a92e-d4a73b6b8bd6@app.fastmail.com> (raw)
In-Reply-To: <87h6lu8ed8.fsf@mail.lhotse>
On Fri, Nov 10, 2023, at 04:40, Michael Ellerman wrote:
> As pointed out by Arnd this is due to there being two symbols that
> control the gelic_udbg.c code.
>
> I don't see the need for PS3GELIC_UDBG, without PPC_EARLY_DEBUG_PS3GELIC
> it just causes gelic_udbg.c to be built, but never called.
>
> The diff below fixes the error AFAICS.
>
> I can just fold it in if you're happy with that Arnd.
Yes, looks good to me, please do.
Arnd
next prev parent reply other threads:[~2023-11-10 6:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231108125843.3806765-18-arnd@kernel.org>
2023-11-09 0:44 ` kernel test robot
2023-11-10 3:40 ` Michael Ellerman
2023-11-10 6:30 ` Arnd Bergmann [this message]
2023-11-13 9:46 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e0966cd-7fa6-4217-a92e-d4a73b6b8bd6@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dinguyen@kernel.org \
--cc=geoff@infradead.org \
--cc=gerg@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=guoren@kernel.org \
--cc=hca@linux.ibm.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mattst88@gmail.com \
--cc=mhiramat@kernel.org \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tsbogend@alpha.franken.de \
--cc=vgupta@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox