From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B826EB8FA5 for ; Wed, 6 Sep 2023 07:34:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAEB944014D; Wed, 6 Sep 2023 03:34:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5C958E0014; Wed, 6 Sep 2023 03:34:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4AE744014D; Wed, 6 Sep 2023 03:34:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B2B2C8E0014 for ; Wed, 6 Sep 2023 03:34:01 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7ABB140C2E for ; Wed, 6 Sep 2023 07:34:01 +0000 (UTC) X-FDA: 81205358682.04.820C8A9 Received: from out-230.mta0.migadu.com (out-230.mta0.migadu.com [91.218.175.230]) by imf06.hostedemail.com (Postfix) with ESMTP id A3ED618002B for ; Wed, 6 Sep 2023 07:33:59 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lgStmjcg; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.230 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693985639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tk/s4MxiPDplWhRsl6zv9N83u4QAtXd5AWvpGC4pJg8=; b=1Fa3h0jYVHbgV3T2B88HZ5fh6z+q9E+4kVame/zcR9DNojbo42mIJN/H5+fjD/+4+ctiEW LCR9MZQkFAOVs0+LDtmeupmFsDdZBCEBifvK9lPS27TMqFwycQQoiLS0lmQmvY8n3aItC4 1VEs3iZHAL8a3ewD+LA8ia7Jt6nCdSE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lgStmjcg; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.230 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693985639; a=rsa-sha256; cv=none; b=wFp2ZtPSzuzEOtA6jWCzSkGJ6N6wZJ2gARx2xSDpQTp5D0fcUTDX5tUX3vIZKCauVeX3ZX k1aC9bjBwRC0Ogs4tRv3A6C7pVv1nwt4bDdKhanh9W0PRSD+9YxTiKgbeUUCKrH+5r+Yd4 n/6wkwx6Pyq9D1xDDXml72Qs/3YKw6U= Message-ID: <5e091211-9a32-8480-55fb-faff6a0fadef@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1693985638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tk/s4MxiPDplWhRsl6zv9N83u4QAtXd5AWvpGC4pJg8=; b=lgStmjcgO0rcpsyMCXOfWFSEMeXz1vBisxDpN1k4XIXLPq7UIowl4CZKoTN35ezyzdaqxk qB3Vytj5U8bUxgHJtGI52up6hyz8H1kfYiXn+6mGtk4nhbywwRV+xcvlzylE8cQ97B77vn SjNNGy/sCyBop0ge3AZjnt0nvAUtRHA= Date: Wed, 6 Sep 2023 15:33:50 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v2 07/11] hugetlb: perform vmemmap restoration on a list of pages To: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Muchun Song , Joao Martins , Oscar Salvador , David Hildenbrand , Miaohe Lin , David Rientjes , Anshuman Khandual , Naoya Horiguchi , Barry Song , Michal Hocko , Matthew Wilcox , Xiongchun Duan , Andrew Morton References: <20230905214412.89152-1-mike.kravetz@oracle.com> <20230905214412.89152-8-mike.kravetz@oracle.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230905214412.89152-8-mike.kravetz@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: A3ED618002B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: uzeunupijm3mxrt8xanpctkaeekoku4m X-HE-Tag: 1693985639-397562 X-HE-Meta: U2FsdGVkX1+s6OgmYSvdAtVJ7z3Nnj6/La84NjkAG6hkHH1ygPj3YvNQMgf1bqEXTuraN/TuVmc7IEfQiqoKidSkBmkmvOEglAUVcz/gRPGWf3yW2hgC6h6RNFplLi/HzaWK9u1DW3AxPtWgECcghJmCEAOuC9TGpXnblvcS2kn1JTxeyqVuXZadHSJwAdN/oyR+FDEnihvlvm00ei1i/PEWYnuTamEMvctVI03kmJsRsfYuV7HZYz/Kd20Sii2JNZohz0tHq97oP/lSk6l4qXopfRtw33QTpNtntmpASJPWU0iKJBNdbP7VWzyLsIhcvhKaJXvLdLdcS/ViOh6ciAj3d+0Df0VKeyv7SiTW/JFYaE2+fiKUAKQa8uwcbVR9vvmAKNmKgQ7T/faBnya8UGl8mJOfPiZEi9lQUu8Wohny0dAgDe/MNCMvhtXgckIbWVldoQQcTTnWZFTvNfw5KLtNG7yxACdodyYrzDBqB2s/DCsiUL/tIe775rugyk01LZVopq5Eqr5hkhBRqb8Ph0sWLlOyRKQsD3AvtCvypey9gpW+zDrrP4zUyMOhlpyWWXwi1ubzHxzXbtXPu0GDBkbjGoj0NLZb8kKY0T117aCgwPGKd0TVVKy6SAm7WWnvpC9kc8W23N4TVmqwYKcAq4Jk+/VOhfbV5ohzJxou1hXoMFVNefwgvSFdR2iTJuzubzTFoVV20b7XCxwawbjvVEl6zxH6PLVweXH/OnJMm/f84hcAvHFzDzxhZSu0OYNuB4s7b8FIQlAal+Zfwd+DmORW8yh6TGBwqR6s7mm2c5yarQK77JhOr4q1u0rLJ1Wh5WiomqzkYuYksptNThEuqwYjsUQ5IHVc4f4o6sNK6T6fytKCoYj2UrB0XPvpdJ6y7nLZCLhUwlq088aqSft43Uz5DJVwsA3OHparfmwyRgj71/9UCdMVgYF01qAC9ON+qzwu23N0AMCjaXrLbpz mbsNgRXc KS4WHJ1HQYl1XOGstrbMxuYXg3ICKKWfQsMpuD75tE0MDStycPrvDBaQFjKOXFGmmRDfnifeMFvFivz0Ss0ozKX8yH9ghuazqOO1amKzICu66J7VwJuF6ei+L8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/9/6 05:44, Mike Kravetz wrote: > When removing hugetlb pages from the pool, we first create a list > of removed pages and then free those pages back to low level allocators. > Part of the 'freeing process' is to restore vmemmap for all base pages > if necessary. Pass this list of pages to a new routine > hugetlb_vmemmap_restore_folios() so that vmemmap restoration can be > performed in bulk. > > Signed-off-by: Mike Kravetz > --- > mm/hugetlb.c | 3 +++ > mm/hugetlb_vmemmap.c | 13 +++++++++++++ > mm/hugetlb_vmemmap.h | 5 +++++ > 3 files changed, 21 insertions(+) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 554be94b07bd..dd2dbc256172 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1838,6 +1838,9 @@ static void update_and_free_pages_bulk(struct hstate *h, struct list_head *list) > { > struct folio *folio, *t_folio; > > + /* First restore vmemmap for all pages on list. */ > + hugetlb_vmemmap_restore_folios(h, list); > + > list_for_each_entry_safe(folio, t_folio, list, lru) { > update_and_free_hugetlb_folio(h, folio, false); > cond_resched(); > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > index ac5577d372fe..79de984919ef 100644 > --- a/mm/hugetlb_vmemmap.c > +++ b/mm/hugetlb_vmemmap.c > @@ -481,6 +481,19 @@ int hugetlb_vmemmap_restore(const struct hstate *h, struct page *head) > return ret; > } > > +/* > + * This function will attempt to resore vmemmap for a list of folios. There > + * is no guarantee that restoration will be successful for all or any folios. > + * This is used in bulk operations, and no feedback is given to the caller. > + */ > +void hugetlb_vmemmap_restore_folios(const struct hstate *h, struct list_head *folio_list) > +{ > + struct folio *folio; > + > + list_for_each_entry(folio, folio_list, lru) > + (void)hugetlb_vmemmap_restore(h, &folio->page); I am curious about the purpose of "void" here, seems it it not necessnary, ritgh? We cound see so many palces where we do not add the void if the caller does not care about the return value of the callee. Thanks. > +} > + > /* Return true iff a HugeTLB whose vmemmap should and can be optimized. */ > static bool vmemmap_should_optimize(const struct hstate *h, const struct page *head) > { > diff --git a/mm/hugetlb_vmemmap.h b/mm/hugetlb_vmemmap.h > index 036494e040ca..b4ee945dc1d4 100644 > --- a/mm/hugetlb_vmemmap.h > +++ b/mm/hugetlb_vmemmap.h > @@ -12,6 +12,7 @@ > > #ifdef CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP > int hugetlb_vmemmap_restore(const struct hstate *h, struct page *head); > +void hugetlb_vmemmap_restore_folios(const struct hstate *h, struct list_head *folio_list); > void hugetlb_vmemmap_optimize(const struct hstate *h, struct page *head); > void hugetlb_vmemmap_optimize_folios(struct hstate *h, struct list_head *folio_list); > > @@ -44,6 +45,10 @@ static inline int hugetlb_vmemmap_restore(const struct hstate *h, struct page *h > return 0; > } > > +static inline void hugetlb_vmemmap_restore_folios(const struct hstate *h, struct list_head *folio_list) > +{ > +} > + > static inline void hugetlb_vmemmap_optimize(const struct hstate *h, struct page *head) > { > }