From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 486A0ECAAD3 for ; Fri, 9 Sep 2022 14:26:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBC326B0071; Fri, 9 Sep 2022 10:26:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D44218D0003; Fri, 9 Sep 2022 10:26:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBF208D0002; Fri, 9 Sep 2022 10:26:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AC2F66B0071 for ; Fri, 9 Sep 2022 10:26:50 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 95874A1471 for ; Fri, 9 Sep 2022 14:26:50 +0000 (UTC) X-FDA: 79892773380.10.D24B635 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf07.hostedemail.com (Postfix) with ESMTP id 224AC4006B for ; Fri, 9 Sep 2022 14:26:49 +0000 (UTC) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 289DNv2j011076; Fri, 9 Sep 2022 14:26:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Y7BsX2EYzelZfjnhFjQsPPG0kf7OX1RAsnfqWH3D0UQ=; b=JHmFLR4/3d9ATDjwCkkpjCVmA+K3ocu5p0ZbedmWlxAIKWUljlOikDw+3Z8i1imVwWzz zIS7rWNBVQlhbbzA4lhDcol7LBP+QtT20VwjP0SgDaQL2miurNuAdat4cjAiNGoFlw1P MtldPeKxwTjWG4Hry3axuDloExMuy3xpHXxLi+p2UdS96XoNeqhTr71sSHJOd39uXBVY 4FSoN9psDAwdnkZKtTcetvdrvgr01JQEGj0t7PsYFs0NTr9GZcj8NX532Un0/Ood+1gD Db5Uvnw/CJU+Ru4VjdjNqSyRiIEjj61FoDs4Iv+woIg7nqYh4f7aUXBnuFbh71zAHeTD lw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jg6b4t014-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Sep 2022 14:26:41 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 289DOB3K012866; Fri, 9 Sep 2022 14:26:41 GMT Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jg6b4t00c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Sep 2022 14:26:40 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 289EMstD006756; Fri, 9 Sep 2022 14:26:38 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03fra.de.ibm.com with ESMTP id 3jbxj8x0vs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Sep 2022 14:26:38 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 289EN1bL42795372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Sep 2022 14:23:01 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 60D3042041; Fri, 9 Sep 2022 14:26:36 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 530024203F; Fri, 9 Sep 2022 14:26:35 +0000 (GMT) Received: from [9.145.83.17] (unknown [9.145.83.17]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 9 Sep 2022 14:26:35 +0000 (GMT) Message-ID: <5e086349-e12b-0e8f-6100-1814e0c185fe@linux.ibm.com> Date: Fri, 9 Sep 2022 16:26:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [RFC PATCH RESEND 19/28] mm: disallow do_swap_page to handle page faults under VMA lock Content-Language: fr To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, kernel-team@android.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <20220901173516.702122-1-surenb@google.com> <20220901173516.702122-20-surenb@google.com> From: Laurent Dufour In-Reply-To: <20220901173516.702122-20-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: qXaBsnlFWkc8htuvnjQoZRrtArrrpv5u X-Proofpoint-GUID: l_-h7mrIGvq8aOTQrkDf7U1hncHr9B85 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-09_08,2022-09-09_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 adultscore=0 mlxscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 mlxlogscore=906 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209090049 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662733610; a=rsa-sha256; cv=none; b=zA+gDJqQPK/mDkCqsbh4j/rKeZ2C64rg1CqkyiyuzuncUOLDghECv9k6WC6jGa9H7RXLj0 PR/mNI1DUqzXNzwyr2f69mnoMGyz7Ydt2pocUSvtcFjohZAA4lZP/Eg2QI0BoNuJoyffgh FsBRjewCoQp5NKNN8eREVqbCCWOkTuw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="JHmFLR4/"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf07.hostedemail.com: domain of ldufour@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=ldufour@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662733610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y7BsX2EYzelZfjnhFjQsPPG0kf7OX1RAsnfqWH3D0UQ=; b=ay8cY8blXDSscA0C2xKc7ULT3a84Dz+zkKt1LRDF7SWwiNKMbuWyNccf/nVSD7FAG5/EAK PrakvfUIg348+olEeM4EMeWhPupf9l4YlV3i8/HskxoV8ZYb35Hpj9zftw+MPbRKvV4UFt 47ezhJ/iTt9IomCXlBNwqQWZh/UXs9A= Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="JHmFLR4/"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf07.hostedemail.com: domain of ldufour@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=ldufour@linux.ibm.com X-Rspam-User: X-Rspamd-Queue-Id: 224AC4006B X-Rspamd-Server: rspam11 X-Stat-Signature: kqzc7gcugjq96rzof4boyzaiyqrpsbx8 X-HE-Tag: 1662733609-437628 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 01/09/2022 à 19:35, Suren Baghdasaryan a écrit : > Due to the possibility of do_swap_page dropping mmap_lock, abort fault > handling under VMA lock and retry holding mmap_lock. This can be handled > more gracefully in the future. > > Signed-off-by: Suren Baghdasaryan Reviewed-by: Laurent Dufour > --- > mm/memory.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/memory.c b/mm/memory.c > index 9ac9944e8c62..29d2f49f922a 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3738,6 +3738,11 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > vm_fault_t ret = 0; > void *shadow = NULL; > > + if (vmf->flags & FAULT_FLAG_VMA_LOCK) { > + ret = VM_FAULT_RETRY; > + goto out; > + } > + > if (!pte_unmap_same(vmf)) > goto out; >