From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0910C433B4 for ; Sat, 15 May 2021 23:05:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1BA1561283 for ; Sat, 15 May 2021 23:05:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BA1561283 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 43EE66B0070; Sat, 15 May 2021 19:05:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 414CE6B0071; Sat, 15 May 2021 19:05:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DE1A6B0072; Sat, 15 May 2021 19:05:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id F13616B0070 for ; Sat, 15 May 2021 19:05:06 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 816C283F4 for ; Sat, 15 May 2021 23:05:06 +0000 (UTC) X-FDA: 78144997812.23.43DF7FC Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf16.hostedemail.com (Postfix) with ESMTP id 3E2CE80192FD for ; Sat, 15 May 2021 23:05:04 +0000 (UTC) Received: by mail-qt1-f180.google.com with SMTP id m13so2300387qtk.13 for ; Sat, 15 May 2021 16:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uoo0qXdDxgLvDQ6O3zd/SIJRl7VC+uLuxoa4iDl46SM=; b=B/uIdQOyaCH2JuF/j0KRQ1IkQXG3dUU3vPPcp37i1LHk2YJ/OzjzwHruzoGP4j+3qw pLRfBTcw5ANthLrQMZYJsU1u9I4Jofx+wVh/R8e04vqOUU1CsQUy81anwrW8oNNl0SyG vRAM1R2yDLttd7b4pvUrUfApu7/w861wlWIeyhrzV2AaD5O3sXO9NfayzmXGXllzm5T4 dai7kErDuHnaFl0APAnRjvdBDhC0esQkNySdEumPWEDMeU3sPOwZdiWZ7mlKkk1BWacm ku0Pwp3iGrebF/zP6EHlUzxrSNXpJF6G0bUDustOPRoMdLkoqUHKjVn4FeUIwsyXVB/I APLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uoo0qXdDxgLvDQ6O3zd/SIJRl7VC+uLuxoa4iDl46SM=; b=o1bAtGX8qbxZG/qTB82FwOo/lx6ouZR+xQOA9ehDypKugLjuyrctN5pX8KoE5KULjE y/NLk0z1p3Hz+0xWs1B1jmvyA13OUPz0ZZto1CI5y79ZSWPJguFx/lD2CUZGNh+uADjt S3pLzOMlIM0N34YqXKS0edpzqH9eQ2cHfMwuiz9e7ueN5Epln/8x/WnaYPIB8UWC0sj6 KP2/S4ZRkwB77dBnDqxy0B+wqY2ynlMFAP/zoALVtcBEGx1G1/y16ESrf/f3gCEfLKwK avMbIungiZ03+auv6jr/WyqprIXeVpJYqRiBksUHnmlqSkzhPay8lARR1wBEuSoAa5C0 v6+Q== X-Gm-Message-State: AOAM532hVFVszRmw0U/nUbTwKhf3O7CsV3rmrKMkutXSgMFfL+aSkfgz NZmlZVWEkFMrnS4PjWNM2l4= X-Google-Smtp-Source: ABdhPJyuzpRNgj2PdyTmuCTqw+goRfaazw+9D4ESaV8KAA5fApck7lRw6T07DdsxBH0HeeNBZ7zqfA== X-Received: by 2002:ac8:5790:: with SMTP id v16mr22366187qta.301.1621119905496; Sat, 15 May 2021 16:05:05 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 189sm7505298qkd.51.2021.05.15.16.05.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 May 2021 16:05:04 -0700 (PDT) Subject: Re: [PATCH v5 5/9] powerpc/mm/book3s64: Update tlb flush routines to take a page walk cache flush argument To: Andrew Morton Cc: "Aneesh Kumar K.V" , linux-mm@kvack.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, kaleshsingh@google.com, npiggin@gmail.com, joel@joelfernandes.org, Christophe Leroy References: <20210422054323.150993-1-aneesh.kumar@linux.ibm.com> <20210422054323.150993-6-aneesh.kumar@linux.ibm.com> <20210515163525.GA1106462@roeck-us.net> <20210515134141.b719412dc9dc46bdf2a8ced2@linux-foundation.org> From: Guenter Roeck Message-ID: <5df3f31f-17d5-ac4d-927c-6b90f31e1311@roeck-us.net> Date: Sat, 15 May 2021 16:05:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210515134141.b719412dc9dc46bdf2a8ced2@linux-foundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3E2CE80192FD Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="B/uIdQOy"; dmarc=none; spf=pass (imf16.hostedemail.com: domain of groeck7@gmail.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=groeck7@gmail.com X-Rspamd-Server: rspam03 X-Stat-Signature: 5far7qnw9kc5g75yixr7n39xrxqn9xq3 X-HE-Tag: 1621119904-403422 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/15/21 1:41 PM, Andrew Morton wrote: > On Sat, 15 May 2021 09:35:25 -0700 Guenter Roeck wrote: > >>> >>> #define __HAVE_ARCH_FLUSH_PMD_TLB_RANGE >>> static inline void flush_pmd_tlb_range(struct vm_area_struct *vma, >> ^^^^ >>> unsigned long start, unsigned long end) >>> +{ >>> + return flush_pmd_tlb_pwc_range(vma, start, end, false); >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> >> Doesn't that cause build warnings/errors all over the place ? > > It will, thanks. I queued a fix. > Also in mm/mremap.c, in case you didn't see it: #ifndef flush_pte_tlb_pwc_range #define flush_pte_tlb_pwc_range flush_pte_tlb_pwc_range static inline void flush_pte_tlb_pwc_range(struct vm_area_struct *vma, ^^^^ unsigned long start, unsigned long end) { return flush_tlb_range(vma, start, end); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ }