From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F04BAC31E4B for ; Fri, 14 Jun 2019 16:13:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 84A9E2175B for ; Fri, 14 Jun 2019 16:13:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84A9E2175B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F13076B000A; Fri, 14 Jun 2019 12:13:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC3F16B000D; Fri, 14 Jun 2019 12:13:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D64CC6B000E; Fri, 14 Jun 2019 12:13:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by kanga.kvack.org (Postfix) with ESMTP id A0B266B000A for ; Fri, 14 Jun 2019 12:13:19 -0400 (EDT) Received: by mail-pf1-f198.google.com with SMTP id j7so2101735pfn.10 for ; Fri, 14 Jun 2019 09:13:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:openpgp:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=523Cuj+viKGNR/h9WOMcxR+9uhzdFMbZSWmdmMb6NFM=; b=WbAg7lpBHkHZ6hZPsuvNrTa1Uz6JYTLf8KbLTHc9zES6Mv/2D7aesSzcL3Sp4nmGXg mmLvh8dYRzE9xorJL5G8qZMjaq3oCs4qrVp7ajS6Gn44sLxREyLEgkSjjOEM/5Y8Pq1H jEYvpMIsfymzVoxAeKc2Tgbf6kOrd7q5i4DPNJ6I/oglIbCYdKQIDIoB5MeVM3x0weRa zGPrHsRnWbJ1Em60qLox1J3JqFlmDeIR7FpgFaXGoT4N1gIiz1foMatGeWtkYNaJZuoi J2DjHtlqmDlqU6UsBvpTskucxKttaVlTfixSC59GYg5E1bEwO1+OwMU03tMrD5f/fMAg G2OQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of dave.hansen@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Gm-Message-State: APjAAAUwQY0ZUnlzicixOpMkm+6WWuZZY7SjqpSK5FRBMj3XutM+jRO5 HOlgjwKs68QHoECGAjrZ5aw7V1fSlXrdnVHmcVuqv1F+2xgqE0TeQKqQzCq27HDEYswCQzFOsUJ R3aQ4keqHpioyLs45vNGUOwif+Q3x7y5NfT4Io3tIjHbYTcoQvFZZyqz04KqU9Gbwow== X-Received: by 2002:a17:90a:cb97:: with SMTP id a23mr11653745pju.67.1560528799319; Fri, 14 Jun 2019 09:13:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqw21lVc0qnm0GL2G+Wow7d7hVMCy7tTNnOVku0qvSZVahmee6Io1MCneH4XLG6ZlX8zFqQS X-Received: by 2002:a17:90a:cb97:: with SMTP id a23mr11653675pju.67.1560528798323; Fri, 14 Jun 2019 09:13:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560528798; cv=none; d=google.com; s=arc-20160816; b=jOEfpDvdZGGty3pWan+mc8aWMad7W9we6Fx03vvY9ObQdi82fZf7OtqsIGlaiJLuNt ho6nKmqc+QtGCsC2UmQH9+/kc553n/WhFL7YSOvkuwxWB6jUoNR+YioYvseWAceB9wlE 2M0nJSECtAs2uXHeps4RYf2OvxwYXc2fHpe8ouiL8xXXx+6zR8jnuoyQpEgS2Lxd6vGo mOZ8lQhnRVmiQjVivxdDz7+o+ok9VwEgZoeCM1AQszJ2sjcv1iydcEQ9J1K+V2TNaTWC jpFYiea6aj8MpIfxk349ezxoluJcGhIyhazZ6NI5M1Hunhk4aICUVskCzABTtEFTbAQ6 GwkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:autocrypt:openpgp:from:references:cc:to :subject; bh=523Cuj+viKGNR/h9WOMcxR+9uhzdFMbZSWmdmMb6NFM=; b=YJGaA7Yww2fTTGfk0IXh+rIkZWugibzmacsMpfnlER/JcipzpbL/REFEyBOaaDLrQA bXJB6QlOZ8uSdVBwvsehVU7SK7mt32zVOo++v+o23VLNqYEZvekP61hfTlDfaP7+sRqz ZucOY4rj1vbT7s2s4g+HpaV+QDkp7RNHdjMZQQeWzqCpGzynCsVEQEXHn/rp+GVP9I6C 7/VzjNV7mrbvgHOmBlNZ3T5/9KREk0caAl8RM2cypSjZyYloPY+X6S/68b2xsK26rOFc Hk47NocuTOpuBfbHgce+fR0ebBsipKxd5huSHsUhyXlEyJFdNCa0iSuIx1yn6Zz92B72 YgEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dave.hansen@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from mga04.intel.com (mga04.intel.com. [192.55.52.120]) by mx.google.com with ESMTPS id y16si2837250pfm.236.2019.06.14.09.13.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jun 2019 09:13:18 -0700 (PDT) Received-SPF: pass (google.com: domain of dave.hansen@intel.com designates 192.55.52.120 as permitted sender) client-ip=192.55.52.120; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dave.hansen@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2019 09:13:17 -0700 X-ExtLoop1: 1 Received: from unknown (HELO [10.7.201.15]) ([10.7.201.15]) by orsmga008.jf.intel.com with ESMTP; 14 Jun 2019 09:13:16 -0700 Subject: Re: [PATCH v7 03/14] x86/cet/ibt: Add IBT legacy code bitmap setup function To: Yu-cheng Yu , Andy Lutomirski Cc: Peter Zijlstra , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin References: <20190606200926.4029-1-yu-cheng.yu@intel.com> <20190607174336.GM3436@hirez.programming.kicks-ass.net> <34E0D316-552A-401C-ABAA-5584B5BC98C5@amacapital.net> <7e0b97bf1fbe6ff20653a8e4e147c6285cc5552d.camel@intel.com> <25281DB3-FCE4-40C2-BADB-B3B05C5F8DD3@amacapital.net> <3f19582d-78b1-5849-ffd0-53e8ca747c0d@intel.com> <5aa98999b1343f34828414b74261201886ec4591.camel@intel.com> <0665416d-9999-b394-df17-f2a5e1408130@intel.com> <5c8727dde9653402eea97bfdd030c479d1e8dd99.camel@intel.com> <328275c9b43c06809c9937c83d25126a6e3efcbd.camel@intel.com> <92e56b28-0cd4-e3f4-867b-639d9b98b86c@intel.com> <1b961c71d30e31ecb22da2c5401b1a81cb802d86.camel@intel.com> From: Dave Hansen Openpgp: preference=signencrypt Autocrypt: addr=dave.hansen@intel.com; keydata= mQINBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABtEVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT6JAjgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lcuQINBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABiQIfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y Message-ID: <5ddf59e2-c701-3741-eaa1-f63ee741ea55@intel.com> Date: Fri, 14 Jun 2019 09:13:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/14/19 8:25 AM, Yu-cheng Yu wrote: > On Mon, 2019-06-10 at 15:59 -0700, Dave Hansen wrote: >> On 6/10/19 3:40 PM, Yu-cheng Yu wrote: >>> Ok, we will go back to do_mmap() with MAP_PRIVATE, MAP_NORESERVE and >>> VM_DONTDUMP. The bitmap will cover only 48-bit address space. >> >> Could you make sure to discuss the downsides of only doing a 48-bit >> address space? > > The downside is that we cannot load legacy lib's above 48-bit address space, but > currently ld-linux does not do that. Should ld-linux do that in the future, > dlopen() fails. Considering CRIU migration, we probably need to do this anyway? Again, I was thinking about JITs. Please remember that not all code in the system is from files on the disk. Please. We need to be really, really sure that we don't addle this implementation by being narrow minded about this. Please don't forget about JITs. >> What are the reasons behind and implications of VM_DONTDUMP? > > The bitmap is very big. Really? It's actually, what, 8*4096=32k, so 1/32,768th of the size of the libraries legacy libraries you load? Do our crash dumps really not know how to represent or deal with sparse mappings? > In GDB, it should be easy to tell why a control-protection fault occurred > without the bitmap. How about why one didn't happen?