From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B63BC74A5B for ; Tue, 21 Mar 2023 07:49:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B03C6B0075; Tue, 21 Mar 2023 03:49:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 139236B0078; Tue, 21 Mar 2023 03:49:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF4026B007B; Tue, 21 Mar 2023 03:49:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E09C16B0075 for ; Tue, 21 Mar 2023 03:49:33 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A3B4A1A1399 for ; Tue, 21 Mar 2023 07:49:33 +0000 (UTC) X-FDA: 80592130626.30.8F6FCF5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf28.hostedemail.com (Postfix) with ESMTP id 9061EC0005 for ; Tue, 21 Mar 2023 07:49:31 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LYSvaIkW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SLLvPwEb; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679384971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s4W7gKMmHGb0ayQx6tQE8mbg4P/fHcq+VmAkv3kTCzs=; b=nEuQDynW7ixusggJTUK0szVbaxsCNItxUS0bJg93f4PvRep/ytTExNNC7pfQIGtTNC1OvP WwTubF3qZRs1kPIieNCZbBJxeHx+UUQgJFRXzb/+jUXh0bCFd+NyRpXcuedFhopcG6mGHz tDi9PzIhqVdtEGS/IbLYZBXuqbfX600= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LYSvaIkW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SLLvPwEb; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679384971; a=rsa-sha256; cv=none; b=KsC4spxwESSRugdiUZuSp7/KOD4kN84pK+2d8nrp7tprQ4m7R/kel38aJUJCKy8ZRk7jJl rEPu1oOwOE67qurzxwekcRsEuKqdphCkMWSTkwfrSrF1bBS5n0ETcUbGQiYFzKYyH0+WLs D4sm6NxsDkL13yeDmgmpBNKMmjp9Y4Q= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 300BF21A8F; Tue, 21 Mar 2023 07:49:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679384970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s4W7gKMmHGb0ayQx6tQE8mbg4P/fHcq+VmAkv3kTCzs=; b=LYSvaIkWhLLUO6caIzYaAUkE3Kc++nlEJ7zWeaaOxRfxWnMs8NAFsmGiGpTK2XGykmuzMS gcoFbnmp15oBSrgnUVGeanIqchMsY6qkfaEfchPFfRzaTyU4YjGtYcxUHJDuO6gJJ0GZDt pPVxoK/AZHjRtcldG/W5bCl5+jTy5DE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679384970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s4W7gKMmHGb0ayQx6tQE8mbg4P/fHcq+VmAkv3kTCzs=; b=SLLvPwEbjNhaNT64IgKgCpzxuV8WCV2lBi0VMD5Al5FCOQAWHF+HOwO8bP886Tfnofzyy/ WjhTRoraTDDLIuCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 06B8B13440; Tue, 21 Mar 2023 07:49:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id b7vqAIphGWRzLQAAMHmgww (envelope-from ); Tue, 21 Mar 2023 07:49:30 +0000 Message-ID: <5dc4dbdc-603d-0334-94a2-715032c4506b@suse.cz> Date: Tue, 21 Mar 2023 08:49:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 02/10] um: Fix MAX_ORDER usage in linux_main() Content-Language: en-US To: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , David Hildenbrand Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Weinberger , Anton Ivanov , Johannes Berg References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-3-kirill.shutemov@linux.intel.com> From: Vlastimil Babka In-Reply-To: <20230315113133.11326-3-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: ymfpf88xzhn6wy4o1chgfts1ykhz8oea X-Rspam-User: X-Rspamd-Queue-Id: 9061EC0005 X-Rspamd-Server: rspam06 X-HE-Tag: 1679384971-107266 X-HE-Meta: U2FsdGVkX18mbou9ba8uE09Enqtm6mCXiOimX2r9ZrROTY9pOdZZRxgDf59UPVcIvDRUaQsqaVHF37Csr63fwqHFdRccIF1cro1vBK+v7b4PQx/ku++gcUS58CA1/0Q5vQBLfZTgnvl+Du1QVLxb1twwO6xmu21rC7wgSvJFL9Eab98syOKvfqBWibxx0wzm6RbXsU5rYHO3tfAh6ga/djDOy89PlE2qjemHKtRHEOvog+tgnaIL7J5w4Zif1WkJXdVRL9LBAJQnmqXOkBKFc1y4YtHxizK77ki6ea8uB1ZqYOekf02jnvKjpYyyAY3QSq/7doVWN96Xv3SbvmD+HpnzPldXdR77JSf3ux6ZIHs8tApfz+vnyQRAsuXButwcuLCoQwD8DFY0OxpFqfAhiW9Q+34YgroAOmaTXvOLZQC7ldvvRh0qjuSRvfHDZLWadvOqCxA8cm7ReS3drWSrVDb7dME0swfqGyY0ajxdjOFaL6oTXSmZPRvN3RbGSARnQxJYncZhK5MiU9McuHdCxP2m/O6s0EQxsSg9Y2PkApma9FX0hhzmgqrVXzd0PxYxLCmr/w54vzyF5UoNORbtyWfJPK2MDKvKEEJP82vIbx8128AVSFVlgEsyp0D4Pdlspp3NbksDkMrWz3Xou0lL7BTWjzk/6DmKiX7sWdDbnbIYKFDWETUKvUoInCJkd9RiIBwACr1m7JZPq80FgUk/AKHOQL5SSqj6tc+qm70x9P0l6cu/KVDMg/zZ69um8RoWrqEBV7tdAdfB8vj4DLPYBurV1TGKoJmLU0hgBW+10qHhjTtfe9D6la7tVleFZb9QU0opkbxpvcni+AFmNcZ1+3q+icxpxQGNeWoRZY1wV/lakfpbsvweYYPSdugusdWL4eLYtc2gJ7nhqJXYB67bU7jaE9+OmflUzd2Q9v+ULTvACrKNTu4xZfZv1d8R5KnyrojHNOyc3Vql6U4vtSZ yfuoAsUv DqchFTlelyhWuLlOdmQ7d8+VnFZ6jG/Q2xaLWEkv65VCXyWFXUvUWwnzUcDNd45YG4IihuaOeG9uD/GrjqyqYxdP8O9N0GC3mSsY2s1OByUiveCTAfm6TMBd4f5HiUgD6VV/ktMfbVpWY2268d/4VcUQF/IGo7polSrnjF3emxPm5bhtl2m+KON3j5NEEtCddWeXP5zRe0fmouwudh6NFPhGvGFLZgbqTVfyGFQjLlSM1eERM00W/mnRjAC1v66wi7VMk5Q9JVn/2fKTvfeLqNK/UJXmo9Tnzaapti9WI09Rch6VlXIin1Fmp11uo0oTssnd9xSDADrdFes0IVr00g8pNLFB256t2r2fXsssrxaFalRs2tA4+e4f5xrZQs1K98G/E2yMYXdL7W14Y61+sF/gc5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 12:31, Kirill A. Shutemov wrote: > MAX_ORDER is not inclusive: the maximum allocation order buddy allocator > can deliver is MAX_ORDER-1. > > Fix MAX_ORDER usage in linux_main(). > > Signed-off-by: Kirill A. Shutemov Acked-by: Vlastimil Babka > Cc: Richard Weinberger > Cc: Anton Ivanov > Cc: Johannes Berg > --- > arch/um/kernel/um_arch.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c > index 8dcda617b8bf..5e5a9c8e0e5d 100644 > --- a/arch/um/kernel/um_arch.c > +++ b/arch/um/kernel/um_arch.c > @@ -368,10 +368,10 @@ int __init linux_main(int argc, char **argv) > max_physmem = TASK_SIZE - uml_physmem - iomem_size - MIN_VMALLOC; > > /* > - * Zones have to begin on a 1 << MAX_ORDER page boundary, > + * Zones have to begin on a 1 << MAX_ORDER-1 page boundary, > * so this makes sure that's true for highmem > */ > - max_physmem &= ~((1 << (PAGE_SHIFT + MAX_ORDER)) - 1); > + max_physmem &= ~((1 << (PAGE_SHIFT + MAX_ORDER - 1)) - 1); > if (physmem_size + iomem_size > max_physmem) { > highmem = physmem_size + iomem_size - max_physmem; > physmem_size -= highmem;