From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FA72C7619A for ; Wed, 12 Apr 2023 08:47:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11D4E900004; Wed, 12 Apr 2023 04:47:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CD66900003; Wed, 12 Apr 2023 04:47:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFE1E900004; Wed, 12 Apr 2023 04:47:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E0EE4900003 for ; Wed, 12 Apr 2023 04:47:32 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 95A281C8577 for ; Wed, 12 Apr 2023 08:43:59 +0000 (UTC) X-FDA: 80672101398.18.DAB4EF5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 4EEF0A0003 for ; Wed, 12 Apr 2023 08:43:57 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="e8Pjp/tu"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681289037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d/hXxn+yXaBHFr3p7Aq6yPxQrR1AxmJJ59WzgjnicMk=; b=ivjj26JIdoaujArDyOgPJYhisv0Fbbu4O6j9bdt84q7gWf0MIvp/QNmzAnBpUmUh8trVNU oz3u1OL/ono7YW88OSh9ThKeqLak32tUISSMIYGSOP9ijT6rVPoDdYYEjZ42xsb07RSQ6u ssPvorcySHniwVlo/g6GVhlOlzCXIZI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="e8Pjp/tu"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681289037; a=rsa-sha256; cv=none; b=a/4krmXvbQSSldOlmXqJPYxbdpYpp5W1W8DGq6smk7e0sTOK+eiVIIu1tvnRADRDQdaAJU Oidg5iJcOw7i0C7ifTzj1zg9PuOpvrqbIwDcd18Y1kN0QqC1nQLB/HtXYi5Vf2B2fzbfDg TmtTVjojvfELGjWu9y7dzwlvIGgvgf0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681289036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d/hXxn+yXaBHFr3p7Aq6yPxQrR1AxmJJ59WzgjnicMk=; b=e8Pjp/tuWe4XYthB+okNox9KqtIqR80U0v6YDdSK4LgGRTkq/lio+PU8jKhofzfhRwNhmN D2T8Snty7T8Tmcc20QeE7oS8vuxZ7ueO2PY3ohNCPbU2Z2xX2ToixrMw8l/MCuTIfKiJK/ mXVnmjRGj88OfLIfQftb9xGfZrIYbxU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10-dUKlKlDaN3a4pEqxTVpTRQ-1; Wed, 12 Apr 2023 04:43:55 -0400 X-MC-Unique: dUKlKlDaN3a4pEqxTVpTRQ-1 Received: by mail-wr1-f71.google.com with SMTP id i1-20020adfaac1000000b002f3fceeda8aso458549wrc.18 for ; Wed, 12 Apr 2023 01:43:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681289034; x=1683881034; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d/hXxn+yXaBHFr3p7Aq6yPxQrR1AxmJJ59WzgjnicMk=; b=RzhLEMsl8xU1rC8UyoMwr1IIo3zsYHC1tyFbhQTgpBEHj1Rm7ifyJcAWmYTr3SRhnJ EDxOE6nEiWhuHdcwBVBd7v2hOFYaFKSKp6shcMjLL0OjvRY4UQcdAXLnUGeQMhjlqg2m VQGeT/f5zgKElaMhy8pr0jQth1diZS+vymea0xyzuHy/kfm6DDEsPF1f+/jWJkCXI+nT L0Lm3qQsSOLg+fUQezt6Iu7ZoCvctPsfzS5xgdMjctcHVJXgU7E0FhV7v6GuzCBrsbZ3 D7YDonzIsF/r1IlKvMn/rnK20+qHS566GSBOB1BLX64Od/e73SLLval1B3J+KLSA9Z2M o0LA== X-Gm-Message-State: AAQBX9fJEdR6MaDt37s3bO7KIHgf25fVcrEsZk2EmJg4Mb9rsmZ/z0q4 Vaf24/r2ni9dXpx+6wxgH+e3/jtKhshIQVA4HCigFJOa1Go7s5iPl0rDFaG+mUpOQO2dTPRMjUY guAloq7mRFgBB17177Pw= X-Received: by 2002:adf:ed91:0:b0:2ef:3980:87e0 with SMTP id c17-20020adfed91000000b002ef398087e0mr8026936wro.64.1681289034013; Wed, 12 Apr 2023 01:43:54 -0700 (PDT) X-Google-Smtp-Source: AKy350YAf16IuVo77Vevj7O1avN+jEH7YlsbUOO6l+PFz+Tq7rE5m5pRlSuGi74pD6b6XHxqd8bFDw== X-Received: by 2002:adf:ed91:0:b0:2ef:3980:87e0 with SMTP id c17-20020adfed91000000b002ef398087e0mr8026924wro.64.1681289033659; Wed, 12 Apr 2023 01:43:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4b00:c6fa:b613:dbdc:ab? (p200300cbc7024b00c6fab613dbdc00ab.dip0.t-ipconnect.de. [2003:cb:c702:4b00:c6fa:b613:dbdc:ab]) by smtp.gmail.com with ESMTPSA id e10-20020adfdbca000000b002ceac2ccc4asm16610129wrj.23.2023.04.12.01.43.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 01:43:53 -0700 (PDT) Message-ID: <5db8766d-2574-7904-f112-80a862335a5d@redhat.com> Date: Wed, 12 Apr 2023 10:43:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] mm/rmap: convert __page_{set, check}_anon_rmap() to folios To: Yajun Deng , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230412021811.1503281-1-yajun.deng@linux.dev> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230412021811.1503281-1-yajun.deng@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4EEF0A0003 X-Stat-Signature: wpgtb4o5956usjmq1w5y8oc7n7m55qqi X-HE-Tag: 1681289037-112012 X-HE-Meta: U2FsdGVkX1/DsgWY64qDJFUzrcu24PUwVYFZA/vLgi2giyptAaIUYASYiPEGcT5cwmQ+vIkteFlyCQLgB2QZmoouNb2THFGmmv/IxEzTkC1hqlOWVzgnfZYFOG5KLbXDTa9ShBQQFfGRQi2OSfC2H4cjldx5yPuIJeULbsO+OVQobHUuslFYyplR/tajQhekOJJbn4VGw9shCoz714kp/0cKeYP6/D3BIOkpUNZvOvItZAS7whzXGhBIGGIHtxf0jQFtlbzPSaBsIHHqUNruH4oIGS9HEwQsAkuqo9voXvoD5/7qczBMHidsl3fdmh17iat/qp0TvKjj1vwPgGSORsG5NoQOfsAQjx9mU5pad0l+LmjjR28YH3lb9T8vS/3hkHjYVKOKjT6E5CzIDRg6/fb43tXPjQ+6yPBYqQCNIRL6hf+MnsGUzozcBWtDbgPN98ecLDybSQVmzyX2uC6hRscitMRmfFqsW5gilKu8gphQa0XhZDHoU77a9lsjcbM+3FN5q2FTNcU/s0nW1D2mUmrR5k5Gw5/2oO0ZRqu6NKk3/tRYiUWbj5VpexKQFCGVzFKKhigoE4dtO+mqV0oKDbQ7zpo+KDFfjVy+wH1EriFCNoFTLCVGtWF7aY6D4RqBrYWwsJ6uLQKdKzjmaa0FWtmK3Mk7zVpUoRAiLEEI6WooAo2g2x4+4bR1J9sjjwoOi23+xZFM34MfOKGfjugWamk0k4Z/M5BWfvdZzideBpl5jHncuRk2TxaVkCJBgGDlH2vN00B/4X7Fgvq9M7d8Vr1tcMiuEPVEk2bCvvfM4rD+9J88V0RA1d0RmVCu34Lre3ftKrj/eGJl3Gr6Cfmy2cko4Rv8ZyZUoIPAoKIiQ7+3ZusGB/39Sna7KF7ZyYrsvMjXNvS2l4o9nvQqeWFnWxL8aObeeGuTGSSJqggMc7A6Ltt9FcjePDrYvx6lJNr0VKqkAOzbcxLm3wq5NYs 79YxdQqP lSYj65lqF+x3AW7cQ6DDd966XVFuAvX9ubvxHbA9Vi53fc5veZ184+90peVsVjvK+YH3Rk87nfoBuD/MDIk8hpVnqFT3rNqm2ZqoyxjzYzeFEuIw3nVAufLUah0GQBf3O9YzzA2IAMD05AHX4nihQ1t6o+gnN76YyWdlm0vsJ8aTwR3m6qf13c/pf9fYixybcqtT19eGuIjOMcnZshlYlvoI+xjIsIrFGagHrMW2qHDaZWcAWBqQrfvI1edr502cwUyjRn7xMd34eNOz9WFVZXvUAcaSE0w1LVrm85T62u4FyzsVRBJ6a1NYQSXKoHcOr/tywu6qrWWk931LTanA/aCpw4ciK5yCyxt0xmkGGYrggHV95Q04+0A3fyymTKdpLpKTFpfbGx6xKpcWqtZ+veqCgG2w2oi28fyiyUG0bHhh3c0NQfv+LVEKSnrf6Pi5UolzI X-Bogosity: Ham, tests=bogofilter, spamicity=0.016042, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.04.23 04:18, Yajun Deng wrote: > The 2nd parameter in __page_set_anon_rmap() is only used by > SetPageAnonExclusive(), so there is no need to put > SetPageAnonExclusive() in __page_set_anon_rmap(). > > Remove SetPageAnonExclusive() from __page_set_anon_rmap() and modify > __page_set_anon_rmap() to __folio_set_anon_rmap(). > > Since __page_check_anon_rmap() needs a folio, we can directly use > and change it to __folio_check_anon_rmap(). > Leaking the SetPageAnonExclusive() into all callers is not an improvement. Not convinced we want this patch TBH. Tentative NAK. -- Thanks, David / dhildenb