From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 761ECCEACE8 for ; Tue, 1 Oct 2024 16:27:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB42A2800C3; Tue, 1 Oct 2024 12:27:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E63D5280068; Tue, 1 Oct 2024 12:27:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDD7F2800C3; Tue, 1 Oct 2024 12:27:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AC88B280068 for ; Tue, 1 Oct 2024 12:27:52 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4C106C16E4 for ; Tue, 1 Oct 2024 16:27:52 +0000 (UTC) X-FDA: 82625564784.05.8B7250E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id E06BFC000B for ; Tue, 1 Oct 2024 16:27:49 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NNGXPewv; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ltzNxVRk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NNGXPewv; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ltzNxVRk; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727799901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TnUobPlKy1NZWZZQ4Zh+O8yWLp+TDg2iNuddZ1NE3vY=; b=y6Xux7qAydD8BhSTgdjtMPa0/zqDBTa5Aez0V5lVJzKZhicCWR1OKIBcqziRQEZI/WlKZh VyvA5OPEF+hy24HW1JItIkXk/e4rvrh4NkMtH3V/8ofZ/YjFxU2zivafakQAtVkyt+XAwi vVTaaF0MKHpqxXUz5vabcWcJ92iXJd0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NNGXPewv; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ltzNxVRk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NNGXPewv; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ltzNxVRk; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727799901; a=rsa-sha256; cv=none; b=ik6WEvvXKqrPoQJLTV32olT27BHyy2+uWnZaybNFDPySCbbStrhhrg6tavfs5Qc3BM39M3 x+iFPqW9XyOecXp697IN6vR07fMdT4OV/BCASz4henykc2ct1isw9W4nL6VyTp3/XS1AWP IlraGLV4TcxzcHPvx4gbr18QstNXm8M= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6969F21B52; Tue, 1 Oct 2024 16:27:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727800068; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TnUobPlKy1NZWZZQ4Zh+O8yWLp+TDg2iNuddZ1NE3vY=; b=NNGXPewvnM8TSv0Hpk2dycv8V94DKwkIcznu5vz2R8PTwpic7Q4UVPK3uhXiQK/KeLcbN3 NlnrohPVd6SUXLK1Z/sp07BmnZHp8HRqU+/gjrDmwohSE+aT4bsUEdfTxDPMGjIJ3/oeWE RH1z2g9wmzcYtjvs3Igs738fLQNxBxI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727800068; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TnUobPlKy1NZWZZQ4Zh+O8yWLp+TDg2iNuddZ1NE3vY=; b=ltzNxVRkgIjfK3b71A0U8qgCVtVF0GxGeEdEJ3xi04yS1YXD+lwMCmCm9wRcw7ewj49mug Bb2U67mAoK5V+9CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727800068; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TnUobPlKy1NZWZZQ4Zh+O8yWLp+TDg2iNuddZ1NE3vY=; b=NNGXPewvnM8TSv0Hpk2dycv8V94DKwkIcznu5vz2R8PTwpic7Q4UVPK3uhXiQK/KeLcbN3 NlnrohPVd6SUXLK1Z/sp07BmnZHp8HRqU+/gjrDmwohSE+aT4bsUEdfTxDPMGjIJ3/oeWE RH1z2g9wmzcYtjvs3Igs738fLQNxBxI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727800068; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TnUobPlKy1NZWZZQ4Zh+O8yWLp+TDg2iNuddZ1NE3vY=; b=ltzNxVRkgIjfK3b71A0U8qgCVtVF0GxGeEdEJ3xi04yS1YXD+lwMCmCm9wRcw7ewj49mug Bb2U67mAoK5V+9CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 448F813A6E; Tue, 1 Oct 2024 16:27:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VU/4DwQj/GZiRgAAD6G6ig (envelope-from ); Tue, 01 Oct 2024 16:27:48 +0000 Message-ID: <5da1dc60-8392-47d5-8521-fe3a7b830369@suse.cz> Date: Tue, 1 Oct 2024 18:27:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm, slab: fix use of SLAB_SUPPORTS_SYSFS in kmem_cache_release() Content-Language: en-US To: Nilay Shroff , linux-mm@kvack.org, linux-block@vger.kernel.org Cc: akpm@linux-foundation.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, yi.zhang@redhat.com, shinichiro.kawasaki@wdc.com, axboe@kernel.dk, gjoyce@linux.ibm.com References: <20241001140245.306087-1-nilay@linux.ibm.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241001140245.306087-1-nilay@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E06BFC000B X-Stat-Signature: mkrmtpmxg3po1jzsocyh5q8z3srfmsad X-Rspam-User: X-HE-Tag: 1727800069-648829 X-HE-Meta: U2FsdGVkX19sG6z4eZAPAfsBp0xaJbs3eN4Mo/jehho9e6DBZcFG2T6OlexxTyTsQIlHlu2cuk4W2WHkzS9VWk9f04gIVTlF1R7z1Db9/pUGYdshBL7C0YkDGXkPwAP/3wMw/7r63CqwcfufLKUgeEKqyg+dYT6GuRozjnoQBe7a8O8o6VgBxEAyjOiq6hDFTazVimXDr9WKeCk/HpND39MZ6wjHa1LFaFjnrauZDUg89iERJvctAC9hp6isLEbTAGbq0/Zw6CbHXWaH0b3T0Zedr4lWmnCAn6KSsV1lrjmOliliB83emeYyhXlN3zrt81PislTdnxB0t3IKXeEFozSX0DaLz/ptEe9HPilXIIY6U1ABSyJ5ZrXAKs9NvlglPszdDa5h1ycIhSWHsSyvHcyaaGmC06UZthQ2iA5yZ6UGZI0v4Hiumqs9daorhT0A619UJjkUVr3aoSJdEi4hWQrydDycjrweGz2AJhp1spN8Uh8y0BH3FCTtJ2veb43SZ4bXscASrPghi2FjFY+jy0FBzq/7+V7ec4SMZ6ooEazl6UwwkwfpLaRkp4G4aVdMwnnYZ0Zhl2mlN+ciW5iqtgdBD0gnfdBSq7avHvvL3HZdyFjlHRD/KZCKTDb81g0jteP+z0Tyjj2Zs6HBocBFfkmaU6PekQ1JY0zEC8aE0rNAiZn/di7bkZ+n8ST1FxRncWVaB6Uyf3v7GydaMaqZuJPhCrxGQL80qLhhXjm6fCJT7qgzKbXwBQULMmCOLZlNNvjWkJg3T86iQCLS1Cspmskq3WrDO3gB6MZkhzLVpYq++Q4Vix46KoNGuLb/O3oo1fiXVGKAODCzgLE3SEfn18d1Wn9h4ajod+FhZ2ga/XVOhgrq24XhCWMO0rVJFI/EvlTfwqe5zNtMv0qu4D2AMNNa9rQJaZ8XM1DNZVDMdgaKUFw0JitazYCD80ip8uiyFdsxCZ+vFBbRTLrCHhA 1AdbCzVp 6FPVDQWqtxe67Kk66C5aHNZZ9WDmg3sczMAM4fIMWgR+VDlmzczifnM+NkMROrr5o1eho4IPY6wYB2bE5B+ldhxLcvrhdDTgXyBrJ7JtRP+j0+SxYwSbq9/vy9SlZt//L8lGp2n94anhCxOIe1slrtWSJkeDqPcLGw17iaeZSAYjAfIX9k8S7jkOTFzkm3Ied/CtNThZDm+IK6PZ60LGeI+ecerN8R4dW9ZzyNzvIMmzExnjlau9wxoK3IpcPDc6Gx2hRZB9Y/idhZCuIUkQosI8qu0UAahDa6Zke8XjeMR/6ZiNIDYFjdEYWgIIZeahdwBrMCYPEi8wfrHtyheN5+u8APlD4MZn8pcKvZ1FHn8FQ/Ns7/tyrDGJMPSavRFACuf8Gahy0IXQ+t3BY6sr/bJLByA5mOHYhZGfGwkGCyE7m+SFJgHYTQ7tI/kF5XkxQXydYR4Q77TUiRND2Bs/u837XpGb1O8fwcoEkxmY6zJLufjY8dXBFoxP7Xg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/1/24 16:02, Nilay Shroff wrote: > The fix implemented in commit 4ec10268ed98 ("mm, slab: unlink slabinfo, > sysfs and debugfs immediately") caused a subtle side effect due to which > while destroying the kmem cache, the code path would never get into > sysfs_slab_release() function even though SLAB_SUPPORTS_SYSFS is defined > and slab state is FULL. Due to this side effect, we would never release > kobject defined for kmem cache and leak the associated memory. > > The issue here's with the use of __is_defined() macro in kmem_cache_ > release(). The __is_defined() macro expands to __take_second_arg( > arg1_or_junk 1, 0). If "arg1_or_junk" is defined to 1 then it expands to > __take_second_arg(0, 1, 0) and returns 1. If "arg1_or_junk" is NOT defined > to any value then it expands to __take_second_arg(... 1, 0) and returns 0. > > In this particular issue, SLAB_SUPPORTS_SYSFS is defined without any > associated value and that causes __is_defined(SLAB_SUPPORTS_SYSFS) to > always evaluate to 0 and hence it would never invoke sysfs_slab_release(). > > This patch helps fix this issue by defining SLAB_SUPPORTS_SYSFS to 1. > > Fixes: 4ec10268ed98 ("mm, slab: unlink slabinfo, sysfs and debugfs immediately") > Reported-by: Yi Zhang > Closes: https://lore.kernel.org/all/CAHj4cs9YCCcfmdxN43-9H3HnTYQsRtTYw1Kzq-L468GfLKAENA@mail.gmail.com/ > Signed-off-by: Nilay Shroff Added to slab/for-next, thanks! > --- > mm/slab.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slab.h b/mm/slab.h > index f22fb760b286..3e0a08ea4c42 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -310,7 +310,7 @@ struct kmem_cache { > }; > > #if defined(CONFIG_SYSFS) && !defined(CONFIG_SLUB_TINY) > -#define SLAB_SUPPORTS_SYSFS > +#define SLAB_SUPPORTS_SYSFS 1 > void sysfs_slab_unlink(struct kmem_cache *s); > void sysfs_slab_release(struct kmem_cache *s); > #else