From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06D91CDE01B for ; Thu, 26 Sep 2024 16:03:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8032E6B0093; Thu, 26 Sep 2024 12:03:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B3816B0095; Thu, 26 Sep 2024 12:03:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67B3A6B0096; Thu, 26 Sep 2024 12:03:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4411B6B0093 for ; Thu, 26 Sep 2024 12:03:57 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E9F8D1A1B60 for ; Thu, 26 Sep 2024 16:03:56 +0000 (UTC) X-FDA: 82607360472.09.895BA9F Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf18.hostedemail.com (Postfix) with ESMTP id BB8801C0034 for ; Thu, 26 Sep 2024 16:03:54 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=CIZPyL4+; spf=pass (imf18.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.216.54 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727366572; a=rsa-sha256; cv=none; b=mNdLIGA+HdzaUlg4ewgifVLSmNZlY3etALLEygJSGUmp/4VEQGHU1IoZx9OVBj/uDu5GpR +RahjGRltUW7z92X/ECRrJIj2xEmHk2RkbgM4AaMyuo4aOnTkoneMWskbvsHPAL+gCOOEm R1V67g9aU2BIQqoigPQvjLXS01031s8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=CIZPyL4+; spf=pass (imf18.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.216.54 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727366572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l7bPPk0kAmsAXYjb0/D93cH5UC48AsXEk9c6DNPfZ9Q=; b=XrTRxuHn5G/PEey7fwiEPNNDG1+tINueyG2aPzyNHpy80aI9UUjyXJVNN/lgzmRri/lDN9 F+HWEcaDYT+iVaD2ZVPTVVgH/JN5yNYeY5+W2625Y7lnbrBRYCsv5F0WKyVTgoRPD5tDF2 ZhjJv6HPgbiNGFqDyEk0gJFNVPApZF4= Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2d8b679d7f2so1070667a91.1 for ; Thu, 26 Sep 2024 09:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1727366633; x=1727971433; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l7bPPk0kAmsAXYjb0/D93cH5UC48AsXEk9c6DNPfZ9Q=; b=CIZPyL4+9Q38cHFWa3HGQykH1cSIlJpRVP+bRTtlUinBBt0HSzxw/Uo08F7uR6yOlW /cBWItR1hEDx0IaDHZ8wkgq0+ew775G71wgsT+GbHfCT2QJkGLC2YhY6yUy1Optblr5T Um+G5zoJ26XUGspUnlk3hwK90y0zdsgr/uuNs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727366633; x=1727971433; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l7bPPk0kAmsAXYjb0/D93cH5UC48AsXEk9c6DNPfZ9Q=; b=R8BCIqmDm3lPb4/H6ZWC8Zu1oPe2aJXeaSc7rKMUCUWUfw8e9TrT8xX8Bd14ZTbze9 yrvIgS4jS6wQmUnvvUyqA0h0mpjKEX/R333+UWbFEx8SBFJ7xwqVTQ8TSWDaaLidK07t aDOT1BP3Q8eOCQMNDTWp9rMiagln7+RWF2ZqvARVXh3EDWZbvKXf6l6UgMdOEqhUpfaP /isceH0SyVBHlGeqm9IS7vQkCvuG3GTyTNonmQ5508QSwgCUvsQb7kdO44UTlNRG3Old iOYEpsdC9SXx/4SkUg5OiaV/RKPX7KIJJq5WNnMK1LJJhOKTufOtVr4XUQUebzAJhcml Kljw== X-Gm-Message-State: AOJu0YxTGGr4pl+Z7vDlyAVdsklEb6zgMTlKqZX57LRe4PlB6w1wwhi9 DsYBy3j/+lBnpIC9GtAuylgr+J/i3HG7nEBz+P/6q8f2ymAAcFH080OC45td1k0= X-Google-Smtp-Source: AGHT+IHTpMcYmF9z2kltnsJqkihXDzYulmllfE5WCQAP4YEs16N79sFK7tcp+DcdzifQ+u5hSHcozA== X-Received: by 2002:a17:90a:8a8c:b0:2e0:94da:bfd2 with SMTP id 98e67ed59e1d1-2e0b899cc3amr225520a91.8.1727366632896; Thu, 26 Sep 2024 09:03:52 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4d8888c33f8sm21149173.89.2024.09.26.09.03.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Sep 2024 09:03:52 -0700 (PDT) Message-ID: <5d9c8052-e7ca-4819-bd0c-d7f88905c7a1@linuxfoundation.org> Date: Thu, 26 Sep 2024 10:03:50 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] selftests/mm: hugetlb_fault_after_madv: use default hguetlb page size To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Andrew Morton , Shuah Khan , Mario Casquero , Breno Leitao , Shuah Khan References: <20240926152044.2205129-1-david@redhat.com> <20240926152044.2205129-2-david@redhat.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240926152044.2205129-2-david@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: pkpi1zszoijdkba5gce6axxewrr6pqdq X-Rspamd-Queue-Id: BB8801C0034 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1727366634-297508 X-HE-Meta: U2FsdGVkX19pDcj5tcNLGrHDRlyNBjaLCf5O3+QipLwzvEl3Y284Jxy8eAOLt/Yd81L7yg77QUcNZ0ke6y/Z5UOpJpxbA4ePexkc30Kp4dUH2wy8LuXZPEiVAl0wqL7uJv02Wc8Qs1JZ6bLc8DSwxOwZKJq+NXiC2+J2Iz0YG3MjxgbOjdqC6ot+VXhrvEOkuZXfK4K+ZmapxODkT1qEDM70M7TSybCa0jF4f+7DE9v7RwUyt01mYnhqObr9tY4UABGvTF8ytDatN/DdejnmZbXgnENLBngoh6DtSbA4j3yrwXlxvn0FkNbwP2L53qyo4/HesNNziMhSukdYGUlgYFrEYt/+5lJxkxeSfQno+ckK5vRdXfLAO8ZZPddha0IdOWpIPTld3W4pP3KKnzWjdixGLaIwkV8xIKLGS8xwTiotghmFsf9CvXy3l1jEwHrvBI69U5P5o1T/rAplZhvAT4XaVX0EW+F3apm8dwYzCym8qcpKJupzLhZ1P/JOhWO+IjUPpJ482+hXMm4NjQ2+BRMRfS0eWdvV3K/j/ZOBjKmcx2TXeEZLhM+QpyOv7acrTOjMrYgzqH+7bg36E+UPkrJ7Ho+MBweeBWetyPMzzMBTblmvvT5knYH7CSpIl9IOf2uqSDDVALJowOLIhcG5zkqUgVklBn6A5GMdNy5MpfCc8CK/CytPzk6XLODCRIBZZ3gexKPcigQ29f6biG9Nk00zkO1PyFBZzzyp0AdHAoQEaGqxXIrIxWGfm3XDqJGClVlq6j+Z+z0W+KPx60VuilyAgzD+D0y3zWyeXPi5kJEnhKvVPCiVVsa3dF8TAUTm/ga3WOR2P/7F7N4AGVwpJqEwImXln7f6Cu4PGFlD7WxV42cmjrDjMbUZmlgFrW99hgBOGMnE+PDmoEb/g5r8ShqNF3VxFt4pNGV6nSKK2WP+rtqXazwhXr+wN1wKPzZrIC6GnY4JFWw8fw2nSGQ 63CWPv35 ej2rUpEOfTVhJ12kLsA7XgBfm+fuMiHiDzemvuoePm0KwNbFHNbBxRL5Dgmu4iDtuWlJcd3D29VgNR0aeLtLIbS3gW336CuTwwbb4DxczakXbI5E3NVzsJifpJOQ6de3/L+SGUJa8BvoN/oGVThKDl5qI+sA75AOGO+cGQEl5PJYTxxSfP9Hq5h1kHyIUJvET9pfJ2Oi/1jMT8FhxAkAp4/AIqL7Fvonz2vOHYfs/h76lTG5s5sD+yg+1QZ+fSEMc99fBcnw4h6ejVEySYGU6Gft6h92jbk+UqAPQ0OvPmVbwM0uqEH9mmouxpwtFiUSi4V1S06fElIDrlckELR+bNzqy2j+CFhZeH8tffnF7WqzJlx7gmE00UGrwb0e4arA/idzx/SBQ0A/J4bHFwiyWFH30vByVAIGaWR5GhIc8LnVS5f9jzqhwueDZbvSMeY4s2SZymKPCKuBiq9UKPBKELL0CrvchCiUQA8lA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/26/24 09:20, David Hildenbrand wrote: > We currently assume that the hugetlb page size is 2 MiB, which is > why we mmap() a 2 MiB range. > > Is the default hugetlb size is larger, mmap() will fail because the > range is not suitable. If the default hugetlb size is smaller (e.g., > s390x), mmap() will fail because we would need more than one hugetlb > page, but just asserted that we have exactly one. > > So let's simply use the default hugetlb page size instead of hard-coded > 2 MiB, so the test isn't unconditionally skipped on architectures like > s390x. > > Before this patch on s390x: > $ ./hugetlb_fault_after_madv > 1..0 # SKIP Failed to allocated huge page > > With this change on s390x: > $ ./hugetlb_fault_after_madv > > While at it, make "huge_ptr" static. > > Reported-by: Mario Casquero > Signed-off-by: David Hildenbrand > --- > .../selftests/mm/hugetlb_fault_after_madv.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/mm/hugetlb_fault_after_madv.c b/tools/testing/selftests/mm/hugetlb_fault_after_madv.c > index 73b81c632366..ff3ba675278d 100644 > --- a/tools/testing/selftests/mm/hugetlb_fault_after_madv.c > +++ b/tools/testing/selftests/mm/hugetlb_fault_after_madv.c > @@ -9,10 +9,10 @@ > #include "vm_util.h" > #include "../kselftest.h" > > -#define MMAP_SIZE (1 << 21) > #define INLOOP_ITER 100 > > -char *huge_ptr; > +static char *huge_ptr; > +static size_t huge_page_size; > > /* Touch the memory while it is being madvised() */ > void *touch(void *unused) > @@ -30,7 +30,7 @@ void *madv(void *unused) > usleep(rand() % 10); > > for (int i = 0; i < INLOOP_ITER; i++) > - madvise(huge_ptr, MMAP_SIZE, MADV_DONTNEED); > + madvise(huge_ptr, huge_page_size, MADV_DONTNEED); Magical effects of hard-coded values :) Thank you for fixing this Reviewed-by: Shuah Khan thanks, -- Shuah