From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A3AC021B3 for ; Fri, 21 Feb 2025 15:42:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26D3F280004; Fri, 21 Feb 2025 10:42:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 21CC7280001; Fri, 21 Feb 2025 10:42:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07035280004; Fri, 21 Feb 2025 10:42:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D1F02280001 for ; Fri, 21 Feb 2025 10:42:10 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 582518150F for ; Fri, 21 Feb 2025 15:42:10 +0000 (UTC) X-FDA: 83144368020.21.A060EFC Received: from flow-a5-smtp.messagingengine.com (flow-a5-smtp.messagingengine.com [103.168.172.140]) by imf14.hostedemail.com (Postfix) with ESMTP id 34D78100010 for ; Fri, 21 Feb 2025 15:42:08 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=Aua5F14v; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="h K/x4O6"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf14.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.140 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740152528; a=rsa-sha256; cv=none; b=vHxwpjZ+5o8fI/2TTOLfuehA0WRXk66duPMMQby99ggepVVx4wHwKyce17O+fr4+WLJNqi kmr/NFNE36o1uHYIFhPJIkhwVCruD1YQ4uPZeLruBQ5y6H0m0BK2MCVUttULlw/1a81sLp VcCkC7SNzHGhEP7PVTbXjWXsra2JlLs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=Aua5F14v; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="h K/x4O6"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf14.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.140 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740152528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zogi8f8M8Um40C2L5aiooebB5l2P6zGuaVkKnMZ0aqo=; b=JzeMa6d4skpYCLux3HKhNXLB3b6jlXqTrzLYlMllj9ps2XZkCQc5QIG7ew89MGQtjs3WdP 2LQpQSSTw4ulIz8u41re+oU2/LPci262Xe4ll77I3znmvbTRDgiovW/Gr+gnpL5uGo8FEi 3fUQdry9IraOpNtA3CtJ00KUz505w2E= Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailflow.phl.internal (Postfix) with ESMTP id 68A162008E9; Fri, 21 Feb 2025 10:42:07 -0500 (EST) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-11.internal (MEProxy); Fri, 21 Feb 2025 10:42:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1740152527; x=1740159727; bh=Zogi8f8M8Um40C2L5aiooebB5l2P6zGuaVkKnMZ0aqo=; b= Aua5F14vWebL0DOxXVcNVFiZkYyvO+ZDn0lBIGthpSro7L8yySiSiaVg08WR7pLs JojgEjUtKFzq3p96R+2HmZUtkfnB835nBY2UB1NRwsKhE3G6/KpCcrJCM9nOPLjg 2axdv5yBZa5jZAlSVtFXsSKh6/ocWFYVTAyli8xq5LHUWD1AKQJ5G4+Mr/4ewUSx Yn/azkxhSGwazkgtAuJI1r5HiztAgb54Hy57zjASBXgbNstUSX1FQ056H8+WzBWb bY73DEtylf/GOrATlkUX6KJLQyEzNftkEsaFLVyJSfRZdT3QoOtN3rFZ19iqpA5R KJtz9HVtMoMVC5CtzTJTYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1740152527; x= 1740159727; bh=Zogi8f8M8Um40C2L5aiooebB5l2P6zGuaVkKnMZ0aqo=; b=h K/x4O6oyNBPbMt/oANZVu7iwmMXMPEIsjZuQL8HZIOTsUUJO7Auhm1hFIArdijoJ AB7VBKyq2IuRmCYnjPjcsdGs9S/cnI6aMm4jXLNLxVrlFDCnDgv/of6zLAJcxDcI eL4AzPwv+QV8bY2ycaIOH64w/uZlZdCJ8e62DGEoD1siZA0vWqTZ/ReNgiqYKlv1 mihPOMp/ykpji+1Q19VspQRFz5r4aZTlYen0gNe9e7yhu15yzjE/MGurq1TMqurP hR+5nH3l3BZzUbTYF6NMvpDtU6o63shcpD1jG8+Rp04xMu2H9dbuLLoa9S/eymhA yXXAttMvAK8zmGaHmjzhA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdejtdegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredt tdenucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusg druggvqeenucggtffrrghtthgvrhhnpefhtdfhvddtfeehudekteeggffghfejgeegteef gffgvedugeduveelvdekhfdvieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggvpdhnsggprhgtphhtthhopeeg gedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheprhhosghinhdrmhhurhhphhihse grrhhmrdgtohhmpdhrtghpthhtohepsghrghhlsegsghguvghvrdhplhdprhgtphhtthho pehmihhquhgvlhdrrhgrhihnrghlsegsohhothhlihhnrdgtohhmpdhrtghpthhtohepug grvhgvmhesuggrvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopehnphhighhgihhnsehg mhgrihhlrdgtohhmpdhrtghpthhtohepgihihihouhdrfigrnhhgtghonhhgsehgmhgrih hlrdgtohhmpdhrtghpthhtohephhgvrhgsvghrthesghhonhguohhrrdgrphgrnhgrrdho rhhgrdgruhdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhmpdhrtg hpthhtohepiihijhhunhgphhhusehitghlohhuugdrtghomh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 469352220072; Fri, 21 Feb 2025 10:42:04 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Fri, 21 Feb 2025 16:40:58 +0100 From: "Arnd Bergmann" To: "Zijun Hu" , "Greg Kroah-Hartman" , "Will Deacon" , "Aneesh Kumar K.V" , "Andrew Morton" , "Nicholas Piggin" , "Peter Zijlstra" , "Thomas Gleixner" , "Herbert Xu" , "David S . Miller" , "Rafael J . Wysocki" , "Danilo Krummrich" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Simon Horman" , "Johannes Berg" , "Jamal Hadi Salim" , "Cong Wang" , "Jiri Pirko" , "Jason Gunthorpe" , "Leon Romanovsky" , "Linus Walleij" , "Bartosz Golaszewski" , "Lee Jones" , "Thomas Graf" , "Christoph Hellwig" , "Marek Szyprowski" , "Robin Murphy" , "Miquel Raynal" , "Richard Weinberger" , "Vignesh Raghavendra" Cc: "Zijun Hu" , Linux-Arch , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Netdev , linux-wireless@vger.kernel.org, linux-rdma@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-pm@vger.kernel.org, iommu@lists.linux.dev, linux-mtd@lists.infradead.org Message-Id: <5d662c4c-76f7-4e5c-82f3-2aeeaf9e3311@app.fastmail.com> In-Reply-To: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> References: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> Subject: Re: [PATCH *-next 00/18] Remove weird and needless 'return' for void APIs Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 34D78100010 X-Stat-Signature: zdgscqs6qyiur48f1os9uyt9b8h5fj9c X-Rspam-User: X-HE-Tag: 1740152528-612507 X-HE-Meta: U2FsdGVkX180SoeLi0bipeRwcp6ot5A6/rWvZSzT1nNSyYHJuV7uD/WMJZ8c+LmXUinFrSFqvgOEkIi5HoE/v/G9w8/DiNu+p7mhYGwNfrHqqIwoWnHlGkPU+oUSycu+iFvIJV3Mb6mV4ae3CQZTkDobT9xB31VADjZcljWptBkXOz7LveFrrz+ZItlb31YIgFr27Pkqgf9CN9xTYneCyAgsvR5chE6Y5Bchz17SbcJOCwFgjdq85E1XdZ+rZr7YaXzgVJoTdSIrxLh0TANnq6W/FeESYMdnthtTtOnyikvd9p26KQGe6nXDPFVa9+iblHYLSmYqo2uj0jN+wh0AQ4Hnd+sd0mLsvTzCn+RQ2xG3hgFm7o8TN4xAz/+bwDZ7M1dZIBB4vluu2TM79q7NeQWOOTCKF3LvCC4sfkUKzkR05V9WKU59GbpVKPL9KZuWpf761JZnzwjcLQD3UmeEWkyENvAaxsngRMtZvQLdu9ugM0vfA7AsxFCScPy+rk77qyN4kGBK16lVRYTE03NfmWKrvz1+BdYX5XV1OHFmuJv9OpznwZ1GqNvxXlM4Y7HezZIqF3Gi9hpdlarur1kYg+VIoJgQTaB1JzET4s5Ia4vu6tBfN1712hIlTCbc3wJKA0EhnZPvXdn5KvhGBfAj3YjgffzXGSN2jlXLu9nXPOLBeZ5fiNzn6R6xR3TzBCjEbzF/1N6NOg4nC4G4wyV3/LdFf3yStv3daC8041iXLvSvlLQDe5hqEdxSGvrD695FcFdqNmkxNsxr3bR7IpACR8VXsBhGNP3n21pDIDBK2NNXxuUOMs1VKVpAs22yzKM1UQX1Z49Uz8gSZ9H+mUkxHqrVBKQ/XdGmVASkXb2O1/ta76Tdk5O/IO5ilMY//uOGxOXXUW0LOCN6bnXdsca63gljvBdhj+SAXHijDt087m6Uky1k/5wDrrE8Ymi0k1h1z2/ksDim85nv/7I8S9F bPCXnzf3 2tN98EGpZNkWWnEWEqjQKzJdTo6b3+MDjY3kjRHrAbjtSV7tZV92uoSOC1eRZa+63jiM4XMEKcbwZ2ECyExoP7AIW+BAH8FZVvZPBOukzULu6HZrDjpuqfw/vILubEE3GELDABXV142xIoF9K7minsbQI6EadueRIwkQ524c/ZwgtRqLBjrTOEbWVV6AYVtkXaTrvH9POxEjr10Yok0nrAZq7j1mUULSoPyr00PgiweqWtc2+RIYl/+/9CMIzqYpa9kTdlwdj2BExqz1LUL0WxonP+qIut/6D19qwE2sJr1NgP/PfhWh9S7f6/2phR3farDAIzv5LayDeHH0jOli5RIrmMTW3hcQNHY6p X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 21, 2025, at 14:02, Zijun Hu wrote: > This patch series is to remove weird and needless 'return' for > void APIs under include/ with the following pattern: > > api_header.h: > > void api_func_a(...); > > static inline void api_func_b(...) > { > return api_func_a(...); > } > > Remove the needless 'return' in api_func_b(). > > Signed-off-by: Zijun Hu I have no objection to the changes, but I think you should describe the motivation for them beyond them being 'weird'. Do these 'return' statements get in the way of some other work you are doing? Is there a compiler warning you want to enable to ensure they don't come back? Is this all of the instances in the kernel or just the ones you found by inspection? Arnd