From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC29DC021A0 for ; Thu, 13 Feb 2025 20:03:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 649E06B0088; Thu, 13 Feb 2025 15:03:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F96A6B008C; Thu, 13 Feb 2025 15:03:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E8C96B0092; Thu, 13 Feb 2025 15:03:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 311BF6B0088 for ; Thu, 13 Feb 2025 15:03:40 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DD7E01215FE for ; Thu, 13 Feb 2025 20:03:39 +0000 (UTC) X-FDA: 83115996558.15.F9FF53C Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf03.hostedemail.com (Postfix) with ESMTP id 2735A20003 for ; Thu, 13 Feb 2025 20:03:38 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739477018; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kiDJ37lC/bFC/k5LpRlLaYmhcPUANLi7k+DPcMCgTnU=; b=htnpbgHOvhn1QJTJa1/3ApYBIo2KUtnf8/Pvi4tL28XDRwBjA6DpmYCsn6IbxnrT5iPA2E ItqZoIF8Rzxr80HuVRSRhRpUEDCupGerdLEPDhtjfMvTMKHL/NRfaXZW07YAIiA5UwnOeH BxGkXMmcLHSHkaRTuz4d+SqITn521ow= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739477018; a=rsa-sha256; cv=none; b=10y7IKpOXx1/uoC/74/l2+SJ4iHcvCmqHyXy0lZgyszkbqmmv034Yh3ekzoIbm2AMMUdro ME6wH8q0Abj7gU9Z7/BVMJauAM6cLwQRjA5pZkGgkgBZu2xJF7zZ9YK77OaxdkjLYg2cB3 70U8PVmpeFnGmg7gLNlS8TYKKAG61ng= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tifQ0-000000007hf-1anO; Thu, 13 Feb 2025 15:02:40 -0500 Message-ID: <5d6130a40f173e341306faca897a0e42f8cd5a20.camel@surriel.com> Subject: Re: [PATCH v11 00/12] AMD broadcast TLB invalidation From: Rik van Riel To: Brendan Jackman Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com Date: Thu, 13 Feb 2025 15:02:40 -0500 In-Reply-To: References: <20250213161423.449435-1-riel@surriel.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2735A20003 X-Stat-Signature: 1fn5m4xiae69nnwfatyogq414m6a3wwa X-HE-Tag: 1739477017-838109 X-HE-Meta: U2FsdGVkX19DGs7JWf/GT5hinT4oUvf3VXWp9Ce9bQCKjexwQIjg+xQE0AIbkoXjuCwt8dsE5qr8NlcoMOQmTs4qJVTB0rYU4hla5RdoELEvqSTL2V6Zqypf6PSTXvZdeHGiPY7ILswfZZGruxxAqYavCbJb+TfkQZIKm3mHoIeYUxtev6Ve0b8OE7rkE8D89sSJIh6ANe3/HwVOT3YrD2TJ3pFhu8wVnk76pb4jpx2dj6j/pTGQ6gI0AJnGQNDWkNSDBPeH1iAKCKjc4NAnAG9JRAkxxUJhOJH1tKvdVjB/Fo7bSklggE3nBSggK8zp/6/N34q0PyyxRB58off/Nnd00rMXcw/gNIcyTPyaZmjpOjX99QjP3jE/SmujLMC7VjCN2pq54AOZWIQleXteAKCYDawJvF+naQM3SRTl8YCRtUb9OKRJ7hWIRcXjSO7aI7mwYQ2hIY4W7P7NRovWm4ZIimIG3An5SfdyzUotpieKhap1CyCNdOC0yWzSzQS2aYpBuK4ArnpD/SGILvYOWld+1oOz231cG3M5FN+qxkPaPNJB+RsGg0czoqq9fqsoOx+0/mhg/ke6WXgce/+qw1yYkGTnYz0Z7K8z4L1IUZnIP5bzuTxdWk8y3dxbdnEv7RPNXi1Zlii8lhZSSw2bYDK2R5TfSk83uwHI0JrH3Jjw4wOjfRMOLsfnodCW8rKaAkkBKXfpdsLjXQivvxmK165Fw2xrKsYAmxlWbS7skct58M/oaRo0Np2zhgXUuwOVLOSLO+pzAru9xtv8FyrRuez6vysTuDkjjE8I1f47mJRSAExBlF2FnTG1z7WEvGHYnzGcJaUXHiE6UxIfK4uqCcvCFQP9trt0Iuzht8T7B7XLco2uh26Q2clOVvM85cPvTyHmAFl9zs8oX4zpf5A/UeKOEcuJfSekR63CP0F4z/KN2jNUlnXP20VAr9+9xQG8Wydpfn4tQ+B3P4YEXXo wOwGyP8i p3UgdbP2mKXXVtHF5nm7SWLFoxZs+lFyVZH9RwGAGCQJI4uY/wGJWwtno3f3yTRc9MNmKfCLeGFsYPvlnQ1ZAFieT9cAeDGr0VqgzvvKD3+gL82USP3zQL3yzqZ1v8PJBxGpeguct90fLIK27M1TTWI7D2zRiKBB2FiyVB4GDVk7Rj6wmxO85ta+cSQ7aAcxlCiz1Sdzdz8f9iG5uPeVMOqP+hN2Q3RjgduynFNxbv1GugGpt8bO4DDqqhzoAn9lvylOTAT9GNJiJkPMXegJx9fEnK5sYA8Bwgc6Yxa6DJzrPcoYonPQNEG3l55jndHRSG9RF5gz9RJZUqt5nX4JcVW+1ZH2w150AjQ3d7OTlG+IEruYMUr478oi4Jcuxsr2DTNK2mprfRNlF6ojKU9WvrXD+ndtV2GY8A8yQ2MQpq3Zk5hQVA6ViS+ngxRjVy4ua40Z9MrwxQ0Mu/BHkAz315YLyZ7OM0pfqnMJh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 2025-02-13 at 19:31 +0100, Brendan Jackman wrote: > On Thu, 13 Feb 2025 at 17:20, Rik van Riel wrote: > >=20 > > Add support for broadcast TLB invalidation using AMD's INVLPGB > > instruction. >=20 > Oh - what if the user sets nopcid. We need to disable invlpgb in that > case right? >=20 That's automatic, when !X86_FEATURE_PCID, choose_new_asid() always returns 0, and we never assign a global ASID to a task on any CPU. I suppose we could make "nopcid" a little more efficient by short-circuiting the code in consider_global_asid() as well, but it should already work correctly. Peter, do you prefer a v12, or should additional small fixes and improvements just be sent in follow-up patches at this point? --=20 All Rights Reversed.