From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC549C3ABBC for ; Mon, 12 May 2025 08:08:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D284E6B00CF; Mon, 12 May 2025 04:08:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAEAC6B00D0; Mon, 12 May 2025 04:08:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B00E86B00D1; Mon, 12 May 2025 04:08:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8E01C6B00CF for ; Mon, 12 May 2025 04:08:32 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5920380916 for ; Mon, 12 May 2025 08:08:32 +0000 (UTC) X-FDA: 83433528864.30.F020C29 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id C0C6640009 for ; Mon, 12 May 2025 08:08:29 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="V/J1SX1o"; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747037310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UGUdqmhJSrxghOP8zxzQdatB2JBTD1eddUHrFZRyN48=; b=a4F3g/3biXaE4+YTQERPsS9FtwZCmZSpmWDNRW41SqD8VeAGlq9IRZekJ2okVQWZ9C6l99 k4AnuIZia6WjixVDLMg9pc0rRnkb9YaaCAgnb5YaUUm5Jxq+c0riec18xfoRRk0isfF7JJ Zn7zuS89WzpoCJlKihm6CES00Yy6xXk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="V/J1SX1o"; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747037310; a=rsa-sha256; cv=none; b=umKEygCsiPof+9YzeevLS0HJuiX7LK9bFw2zX3fYWGO6Bzj/xuoC8q04UoktIHNWub0XGi sJOzaM0whPJbwNXZPf70450T84epysD2rgzVyg7ubwFMQAlZCI3QpcdQ/Jrpoth/5/6w6/ ErEEJ23JM6jhk+sGPJFX2E8l5kSw1ks= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747037309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UGUdqmhJSrxghOP8zxzQdatB2JBTD1eddUHrFZRyN48=; b=V/J1SX1oq4wul56smUp0AWpU27zCasQc3Dl/Lfx0V4+RAWc0tI2PHqhOWYhE94feevRo6/ n1EbrI/f5BrUA3E5ROeoAn3CE62Pc1aY2WbbJaUy2qM9nHl6w1DEuD0hWqlL+O5uDV4/eK UPrJRbKYCcDM1YORh0Z18pLCspZ/mog= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-HPC111cSOgu0J5-PrBYMXg-1; Mon, 12 May 2025 04:08:25 -0400 X-MC-Unique: HPC111cSOgu0J5-PrBYMXg-1 X-Mimecast-MFC-AGG-ID: HPC111cSOgu0J5-PrBYMXg_1747037304 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a202744565so495159f8f.0 for ; Mon, 12 May 2025 01:08:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747037304; x=1747642104; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UGUdqmhJSrxghOP8zxzQdatB2JBTD1eddUHrFZRyN48=; b=b5J1y6DCq62eAXLzD7MaQHAFkaB+8NRpGu2RMxgxEfI1URhLPTHfgj40fAxSm4GXjR UpvLeSDZjR/wvYvbNBmJgZ6smPHK2QgVpE9Bp+NtjRn9BU7KRrXscqjZmnpjrZswWS1r xync5MnxPClsyPbljkuwa3T9esXBqRGBF8XBLtyWxzbF5VvN47OsmsLheBuUPUJ+Is/i seZOeANsd5OKjSHhqOiD0rzlm4GzBsdfEIrvEGj3R5o1HfYTwGM36PHBGOhfEraG6QL5 pbVMdhdWJh8fYgaJJm+TOpmal/GrqwY6hsPjqZUrS5wUBZ3cmtFQAsdcH5/lEhRE4CH0 ZgZw== X-Forwarded-Encrypted: i=1; AJvYcCWw0wxr4Yoc+wzFR3Q+Ia8z7ej1CX5PCTdcMv6X+WYSTfq+mugAn7Vflw92pzyjebjwBUi+U8vZaA==@kvack.org X-Gm-Message-State: AOJu0YwIADnZB2d2a5N5H5AJJ9n4f0z5RJYuQopPghfU8u8F6L4MSSy7 u2WqtQVv7hgdlCG7C/VSMUHVaYC66E4sLtmFOkwmjQVg5Cu+JPUfBxeEhE75OJuChugNpSsE7TE Ov6LwWUqvTfjzoPcOWU6Wb2JE9xOHz0Bihw2aSqSPzW/tlrDg X-Gm-Gg: ASbGncvRPT2I/54MIj5K9KhR0mOz2kcoWGL82IwzxHiPcd2QYk1NZHqYV0ZP6McU+Fc 7+mw5QITRIshN3qGFPAl6dKSWvWS/GB8JLXrjrNtogodkqE2+I/H/R7aFSJPsl408byTQ5uRL11 drWTWiDprVLKT+JD5hkxAaQZ0Ee+9BvLa/EGN2/5m9OPzXbDLt/eWC+zCpCbZZmA00X/uGveCeR 0TRTiNsv/L4LCjk+B8iZniGAjZkSjKyrUsZjFuK87++UpDTKCt9bRS0A7wH34d+KJn6LQ5B8s+Y EUi2Y0+99J72YOFZGHRptU3uJLiPDDIRChR9J5Q3CEeZqFt/8R/3OARBER2CqNVQIWU1bX2fsvX Isvg4ysjLoksoKeSV9EuO4aY080W5I56WvJGvigc= X-Received: by 2002:a05:6000:2502:b0:3a0:af41:f92f with SMTP id ffacd0b85a97d-3a0b9941d91mr14517673f8f.20.1747037304090; Mon, 12 May 2025 01:08:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOoFqrplAInUI/G0YpV+kZq787EFRHoWXWRXZr2R9GzOjZDVbLxdiJMlgpB+zpYyoph9nGKA== X-Received: by 2002:a05:6000:2502:b0:3a0:af41:f92f with SMTP id ffacd0b85a97d-3a0b9941d91mr14517593f8f.20.1747037303582; Mon, 12 May 2025 01:08:23 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4a:5800:f1ae:8e20:d7f4:51b0? (p200300d82f4a5800f1ae8e20d7f451b0.dip0.t-ipconnect.de. [2003:d8:2f4a:5800:f1ae:8e20:d7f4:51b0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f58ecccbsm11737338f8f.32.2025.05.12.01.08.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 May 2025 01:08:23 -0700 (PDT) Message-ID: <5d5e50f1-ee5d-4fca-8d7a-31482a8482bb@redhat.com> Date: Mon, 12 May 2025 10:08:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm: khugepaged: decouple SHMEM and file folios' collapse To: Baolin Wang , akpm@linux-foundation.org Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, ziy@nvidia.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: S-dLmO19j82pvx0yX3K_SLYRG1PwJ6Q-LfZ4WtaK_Xg_1747037304 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Stat-Signature: ybboat3f5psioir7mcpj13dxs8sq9ba6 X-Rspamd-Queue-Id: C0C6640009 X-Rspam-User: X-HE-Tag: 1747037309-496360 X-HE-Meta: U2FsdGVkX185zrYBSEoZ2Oh+lw8SmfgVpaRYf8JkTEmXmZu3uu7b8EVRa5hhF5VCGIR4oqrPvAF/eOq5LasTb34/tfRW1tRD/8cFF6oWwDWUroC4wbm/pbDKoAhQjGDnnWc/Wud/Csmf9LgwQth+sHkHIAJ4uDbM+YO1cnfNJOvIt9UrE976xir6nBl7MUvHUNO3SnvfzSQ53VbZKJBkqA1lXMv1YlkNB1SFj4vDyvDtrlwaoyOk6Sk8EnZj2optUlRyLvWwpPiDzlwOgBO3swKnp4kTidkLzYe4HxLpwoq8YU1SreXChoIZD2MvBAWcSrdgfR4g4Ewi6TgplLsNCh3aIjmdYd8bI1mqcaWTrJhm4Y6cBY8rQ7u9ID60pvwPrVwd0swNCdw5jMsNDFbYGkcozkd++rcr0rSR7iSx6s+SeiyxA0/P04kpfvtdrf85mIAITgnWOcTVE/eug+Jl2E+bMhaNJEEV2DtWDGINrWCk/T948k6PZJWAuu4ztJrdxKkc46hraBdmBgFndK3miZ2g+OHjavcuFULINXDFrQ57IKloYiPr65xiRXK6YeOS5PaT/uE8NA2rNwFQMNg60bdO07qDXKNtMzqDRE/OE48eQFHIU5R6lHOZa11jh1x53+Pi2ShETDZPs/YLskZ/ZtN/+gTgymDdk+K5O/HrMOdPBJ8GNpNf0DtN6GRfpOWr2O7fJvGREG/0qYK3o7HcZwGPs8tjYDKJwErLE28orevzSdgkKCl8c/TtEEpjeeXoRdBAvhHJIFpZmSTV3TEnQZvzVSPNuprsZbjE5xYvgxu+EHGyZrg9HhrAC0GUVxmHa3kb0P1iImakiJf/Ad1u8gVbzS81uQdtsGHK+OIwsp3aw6alBBr94sHKr+acXR7ziIb68hfwqYCmzpnvGgZH8T0VOLPK7l+4rbcFHUQ8JMRfQ7NUbPnl0Ad1rNuzMXZ4h3KEPB/wo5v6f8Ognxc MnEZSB1X 1vNvyyyxRs1AMnImv3jHg+dhGge98IpjNdrZ2rxG0n/D8384xCPhQ3ysGn+NnuB4unIgdUhpBeWOkKTCHsndprX5LotPBSftNn8A9DORvcZmDwcEMk+cghh1nFPYh0VJXpI5Z/KoYhsPIKqBZoMlnRVLR7iRJuyHyOsaDlMPGMCN9nCBbHuAXkziQwzVnWOTSkqNYOEOxQy9Rw2ymGFT93uzMtOEtPLxtgdw6JI1BvuxQ3k+J70ESQ7IAAozD03poc8Su1U001dXDe5dQWFijPZB+K4Iyasdkf4Q3Vqz7/DKN0w/wu2z7VRRsMREm43mtaVzDWHdQxmOUz4kz0W9j7YfEboM003pgcspqDhuy4D5rbuFQ9UD7EE3kOMSnel/I0GTuuax9B2GiQlzeewPIX/mgfUEEtqU1Ciy2MgIOi33zrpaS+To/vrX0pk1J4XMjR4r8OwekGd6YVTdbqqUYkJSMvNRUxWmtScKkfMxl3/ADpj6sXvB3Zr/x6UWjGDfL3rW5GWP+dyfRJCU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result, > struct collapse_control *cc) > @@ -2436,7 +2427,7 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result, > VM_BUG_ON(khugepaged_scan.address < hstart || > khugepaged_scan.address + HPAGE_PMD_SIZE > > hend); > - if (IS_ENABLED(CONFIG_SHMEM) && !vma_is_anonymous(vma)) { > + if (!vma_is_anonymous(vma)) { > struct file *file = get_file(vma->vm_file); > pgoff_t pgoff = linear_page_index(vma, > khugepaged_scan.address); > @@ -2782,7 +2773,7 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev, > mmap_assert_locked(mm); > memset(cc->node_load, 0, sizeof(cc->node_load)); > nodes_clear(cc->alloc_nmask); > - if (IS_ENABLED(CONFIG_SHMEM) && !vma_is_anonymous(vma)) { > + if (!vma_is_anonymous(vma)) { > struct file *file = get_file(vma->vm_file); > pgoff_t pgoff = linear_page_index(vma, addr); > Yeah, I've been complaining about these checks for too long :) I assume this is fine Acked-by: David Hildenbrand -- Cheers, David / dhildenb