From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B231ECAAD4 for ; Wed, 31 Aug 2022 11:37:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79EBF6B0071; Wed, 31 Aug 2022 07:37:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74E0D8D0002; Wed, 31 Aug 2022 07:37:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 615DA8D0001; Wed, 31 Aug 2022 07:37:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 53A3E6B0071 for ; Wed, 31 Aug 2022 07:37:41 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E69251C6236 for ; Wed, 31 Aug 2022 11:37:40 +0000 (UTC) X-FDA: 79859687880.17.0417B3C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf08.hostedemail.com (Postfix) with ESMTP id 6A87F160055 for ; Wed, 31 Aug 2022 11:37:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E8EDA2216B; Wed, 31 Aug 2022 11:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661945858; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e4xD++8mKew67TRKWbW4Uu7LwpMCM4MnX8ALzZeQUkQ=; b=cG2MY93H4o54htZpvovVgJuXw677gYtaToonHe4BG2C3If/WEH4VuB4dLJglkDqkk5XtKA U51AItXcxi8VyQ/JB1kAF52/17Xjcm2qFw0rm84DQxI+GqimuSh/5Xvw5ehLn9gQZqIlU7 0DTsjlteBDvc73IKTWRt0aibe8TjV2M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661945858; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e4xD++8mKew67TRKWbW4Uu7LwpMCM4MnX8ALzZeQUkQ=; b=xkyGZSmbIMFJqfHHExOwvESuuvi/fewPIB3OMbNJSnWTv6P4YJh1/7XNQAu/1QapaD0aVC sIA22cM6lNWYswBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BABCF1332D; Wed, 31 Aug 2022 11:37:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id z+9WLAJID2NiAwAAMHmgww (envelope-from ); Wed, 31 Aug 2022 11:37:38 +0000 Message-ID: <5d48856b-3fc2-4203-d964-520aa4d5631e@suse.cz> Date: Wed, 31 Aug 2022 13:37:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH -next] mm: kence: add __kmem_cache_free to function skip list To: Marco Elver , Feng Tang Cc: Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-mm@kvack.org References: <20220831073051.3032-1-feng.tang@intel.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661945860; a=rsa-sha256; cv=none; b=L56n6s3esAASQ4JSdu6pGp5xoK1SMzD+a2scdYwKQ+aJJVjWs6IXbTITo5Gz7btE1kToYc q7PYMi3NMsvDafVXOlO9j21zY9FgKmy2W41iCfYmaK7GWX9LOmjlzzULDM+A+GbRDQSEJ/ bKU52PpQ46JyyM0jvW5DT5QMvO5sx/E= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cG2MY93H; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xkyGZSmb; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661945860; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e4xD++8mKew67TRKWbW4Uu7LwpMCM4MnX8ALzZeQUkQ=; b=zdchmLAAu7Ll6Ovls7ap67aoaVsr5csF0nEInT/333l04/JtTV0KF7BLDmlVK03AWHHoWh WtsIp/NAmosxfUBwH1jI/FpcZS0tap6b7PTpiv+JtRKXS0mfndvRokK2OK9SUi9Bg+qYrr ij+JsZQ8HM5UlJOWLSCxAKqarZYvU1Y= Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cG2MY93H; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xkyGZSmb; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: mhmde3zxmrc3qf6moiid8trhncipedxe X-Rspamd-Queue-Id: 6A87F160055 X-HE-Tag: 1661945860-512084 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/31/2022 9:35 AM, Marco Elver wrote: > On Wed, 31 Aug 2022 at 09:30, Feng Tang wrote: >> >> When testing the linux-next kernel, kfence's kunit test reported some >> errors: >> >> [ 12.812412] not ok 7 - test_double_free >> [ 13.011968] not ok 9 - test_invalid_addr_free >> [ 13.438947] not ok 11 - test_corruption >> [ 18.635647] not ok 18 - test_kmalloc_aligned_oob_write >> >> Further check shows there is the "common kmalloc" patchset from >> Hyeonggon Yoo, which cleanup the kmalloc code and make a better >> sharing of slab/slub. There is some function name change around it, >> which was not recognized by current kfence function name handling >> code, and interpreted as error. >> >> Add new function name "__kmem_cache_free" to make it known to kfence. >> >> Signed-off-by: Feng Tang > > Reviewed-by: Marco Elver > > Thank you for catching this. Thanks, will incorporate there. > >> --- >> mm/kfence/report.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/mm/kfence/report.c b/mm/kfence/report.c >> index f5a6d8ba3e21..7e496856c2eb 100644 >> --- a/mm/kfence/report.c >> +++ b/mm/kfence/report.c >> @@ -86,6 +86,7 @@ static int get_stack_skipnr(const unsigned long stack_entries[], int num_entries >> /* Also the *_bulk() variants by only checking prefixes. */ >> if (str_has_prefix(buf, ARCH_FUNC_PREFIX "kfree") || >> str_has_prefix(buf, ARCH_FUNC_PREFIX "kmem_cache_free") || >> + str_has_prefix(buf, ARCH_FUNC_PREFIX "__kmem_cache_free") || >> str_has_prefix(buf, ARCH_FUNC_PREFIX "__kmalloc") || >> str_has_prefix(buf, ARCH_FUNC_PREFIX "kmem_cache_alloc")) >> goto found; >> -- >> 2.27.0 >> >> -- >> You received this message because you are subscribed to the Google Groups "kasan-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. >> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20220831073051.3032-1-feng.tang%40intel.com.