From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FAA1C61DA4 for ; Mon, 6 Feb 2023 15:04:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FA9E6B0074; Mon, 6 Feb 2023 10:04:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AA216B0075; Mon, 6 Feb 2023 10:04:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FDB06B0078; Mon, 6 Feb 2023 10:04:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0117E6B0074 for ; Mon, 6 Feb 2023 10:04:15 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9161CA0757 for ; Mon, 6 Feb 2023 15:04:15 +0000 (UTC) X-FDA: 80437187670.19.AB77504 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf07.hostedemail.com (Postfix) with ESMTP id 7FD6C40017 for ; Mon, 6 Feb 2023 15:04:09 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CO7R8bTF; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf07.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675695850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IitKtmmS/5/pG+Mkfj4ignZTcJvRsloJtehbJ8g+Ikc=; b=c0uTYOkG/Co77GvwoBRRbky0D77dB7FKwTFhLyE3f1a/yzQifXLRk9ZrU0DIyel2Yn5INY j7yIw6buAYHOoxyM4qCNp/hjLeWtmNqgpCh3FxuhRS5yN+W28SqgvlFMY+o9hrzY751KNI 9gjqVY+2lf4U+GjhviqtEE22ccOq13k= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CO7R8bTF; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf07.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675695850; a=rsa-sha256; cv=fail; b=IqPAR6W6lp1civxZPW8HLZQucxktshH5CKBeUQf7dPQbdXc5Btro4f5ReZPiCaxPQ4bStc UWChf2TTUQ3k4OjLS9vGoUCoi3JnJrbhjaYTRG9wGmLKvhFjwtIrH+8cSyZAAsIMe8JIaO 0hk+jT94AoTsgrL1lHavG/lhUgbhb9Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675695849; x=1707231849; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=fm+GpfXLOJurl5c8qYk+M8OGp29KXmcS4dEdtWvB6OQ=; b=CO7R8bTFrSz3R3jeS7Ng2Ah1J7kuo+p9kP22pjnqDUIqo26Hz8lEtlZF 6Ym7vc1TlbR4kOCmFGOhQH3p8uCyx3fQZ0eR9XSs6sLPNV+SPBVGAkI1t N5pikbRUXxC/lfLwpN1YhqUtYJmGQkncUE1Hinkf79KsBzEDQ9l/P1acZ Ia/+JxJLv2CEoiQTk/xWsRuU24f5/OAYGG5/scdTU5mOW+PuJ580xcIrS L3gZLNL+Lee1AYKKE7bYpSlRvnCd3HA3j3ogfDmXwvSte2LpKiMxR3N+l bxQrwNDaU0J4d3dFfE/asIHL4Lr757Py5FtYkH++WO/cSk22LxJzNupxu g==; X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="415442969" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="415442969" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 07:04:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="730042261" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="730042261" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 06 Feb 2023 07:04:04 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 07:04:03 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 6 Feb 2023 07:04:03 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 6 Feb 2023 07:04:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KBxOh4QHuU4Wbdx55NrtfXkcC6IvOvaz6gLWg3NWPeocAjjparyCxq2DvWNkcS4+zrLphw3Mv3eK5DUmg5GA6g7b6aHDBEsiTJojV/myurEwc4vCgrB+z5paoqESquiXIFt0iamKK7RfIz12uQQk5vr/52I61b/lYm99m8GgRq5kAJafCwKd1xs0t+pBe4NCB2NirJ/oekdcHtDPO5SxdCow/RH8ynKxlXJOUHHk/O0f+c0yaPgAn2bNrzN/L7227QPCXKnT0haG1r4KesP2GPqrhULmWptEum20aPe6jLrrRI/B+a9wHfZGmg3FG6imU++gsQUIHHBj8K5MWYDhLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IitKtmmS/5/pG+Mkfj4ignZTcJvRsloJtehbJ8g+Ikc=; b=YgISlD7xHlsyp1O5WsPCNDekju0p7RiTVpuAegwSde+Az3JEoId1gt0eu1YsyvExQtmceVVrLPlwYY2Z+pj1vMBupUxe3ASmvfLRKxKjPz2+cC5hrBvdHduT2GFekByvtUpc4iOslJ1EPiPf0P1ZjqaB1DahMeuud/z9f69GutljrnundPAdTY1J/1v+L9QkEiQJnVxa7akzrAgHUXmso98b/Ik/l/pCWKZ63VzE9QanIXR0sX+6hnCZ52NFmrdnS6gk47rjHqpfo2CSSUPxvk7eY9VG/DMNfVwexC0k+P/qWQb3+6kJx/W9Fqht7/uwKuP/iYmgzaNJWR7N025CyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by DS0PR11MB6494.namprd11.prod.outlook.com (2603:10b6:8:c2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.29; Mon, 6 Feb 2023 15:04:01 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::1531:707:dec4:68b4]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::1531:707:dec4:68b4%3]) with mapi id 15.20.6064.032; Mon, 6 Feb 2023 15:04:01 +0000 Message-ID: <5d456528-ad10-4c2d-9374-54aab485fd87@intel.com> Date: Mon, 6 Feb 2023 23:03:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [RFC PATCH v4 4/4] filemap: batched update mm counter,rmap when map file folio Content-Language: en-US To: Matthew Wilcox CC: , , , , References: <20230206140639.538867-1-fengwei.yin@intel.com> <20230206140639.538867-5-fengwei.yin@intel.com> From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR04CA0212.apcprd04.prod.outlook.com (2603:1096:4:187::8) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|DS0PR11MB6494:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f1b08c3-0df0-47a5-5c71-08db08536124 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hPBylCbysdoO5uYQ9RLTjjzVfFxl9Le0OVvM5Duf+n1vkJY65krspaGiNOVZWMVwL9NB4/CofxAQw9s9btcDDq6NfKSCZv7R1yB5K+lfZYbpEvUAFXBqC04s225J3WeSvflC89Ja1EBeT9Pv6Kz+JoyQnV2tDZKf46jIEUFYDw4BHWVmDjRZzMFamdTeK6Nrib05lKLjofSRYszlFs5ESQRPjf8dKZZE3PniW4RRsXkpsIIDoUTCjicmRqqKmBFpxMnFoHvsknBrFgRflx9/VseHEzCVSBVLNq0EobmXUWvpxS4GKUO4PvZA0jkAu2xmSp4najtVh8eS90qJGgTGmR20MdhM6LVW4EYj3Uy3CRBrwfcMuhQ6vdsoC5WrB0urbhc/H4/PkPp8Jd0b3+KAxKiou6j80xUmlVk6wATa1iY8xKsIcVkInfgRWQ4TV5/etNbfem7DQaaW3MEXXHVku7e77V5dA4t5IKnLNGntthL3famjSAzoBm1UsLEGec0DN43CiSKBmbepkLmsmK7CkJsFMR2op5kxmg546M5oOBslvPh4M2gFg6xQ07XDx7LIRxaxZfDQIWWrjll45rAKQCSWGNvdu9Ex1y8JmFiuCzTH6XwkJWvSxFsoQlLoTC2VyNIohKtInlrNxQ4BL2xIJngmUMyfHZPTohHvPcn9RtuRJRwsAkfuP7tMCjnzkyG5g9TeTmtkrGfryuCiEMNoU7M5bpQlBQzIvkqN8ZO6/nM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(366004)(136003)(39860400002)(376002)(396003)(451199018)(41300700001)(66556008)(2906002)(478600001)(5660300002)(66476007)(6512007)(83380400001)(82960400001)(316002)(66946007)(38100700002)(6486002)(2616005)(186003)(53546011)(6506007)(8676002)(26005)(31696002)(86362001)(6666004)(36756003)(4326008)(6916009)(31686004)(107886003)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXA4TVdnTlBpL0ZTQXM2dW8rYWNvdWkvcDJndmVLWGdPRlY0V2FmMzVFZkJQ?= =?utf-8?B?Yk5HUjh5U0lKMzh3ZlhTekppYlUwY1dFanJsSjZmT09DaVRGVlN5Ykgxd1d1?= =?utf-8?B?RjJUYVRiRTlxRzlnc1JBYk01YnYxVDdiV3hOYmNOelZZWm12WTNnVFpTRU50?= =?utf-8?B?TGxmb1JpNndvVEdTOHVMOTRJb0d5eERKNFNKSW5FUERFMGhqbk1pL3JHTytv?= =?utf-8?B?ZERKa2krakZIeDUzelN5UUhoSmZWdGNNb0xkVmlVOExWOUVERkJnSk5oRkd4?= =?utf-8?B?bmRWdzFOVGVBc2VUZll6WUNEZS9XQzRMeUZlQ1hCL0MrOHk3cjkzdEEveWRI?= =?utf-8?B?T24zei96TFZYN0FETHRidTBtNVZIRnBFVTE4cjRMZVZ2dWxEZGJIUUxvZ1U4?= =?utf-8?B?eHFHSFdhMDY2NnpOdS9JcjNSNkFDT3ZXbTlqUndXVXJ6Qi95T0xUOWlOTDAw?= =?utf-8?B?VVdPaDQ0VEVpMkVlM0ZnbmUzc1Z3SkJFZktxTjhkYjlFaHVpTmViSVFDdFBF?= =?utf-8?B?S2FEcUtTR1YrbjRsOEdoemhBeDErSzhzYWlIdno3MUhwNnBON3FIbUxyR2lB?= =?utf-8?B?TTJKVUYyOGZubE0vYy9LK2FqZXN5eUw5blZNQnFzb3grMVpSZ01SS2lTc094?= =?utf-8?B?TzBKRG1vY0FzdmgveXFnUTdMc2RGMVNOZ3VFVkJNZXZITVBuT3llTVl6MEcz?= =?utf-8?B?R0NHSDZ3Z1JlMk45MFNDdmZwbTAzaHNHNnJmem1GNnorSmY2ckQ3UEpycktt?= =?utf-8?B?d3ZUUmN0WTk5Ykh4ZC9YSkJ1M0x2VE9FbkZleG1rMXBwQThrVUpDVWJ5MEE3?= =?utf-8?B?ZGZPc2ZRQUJsRGl0K2swUEJvOWNpNHVVeGFEMWFnSTBWUXJUWVVuWCtXdlQ4?= =?utf-8?B?TDMwYWlVMWJvK2FqYkhkVHdsWWlvYXN6ck0xMDRScDByS0JUN1VKR2VuNlZO?= =?utf-8?B?b0kvKzVxQk1DaHpzUHFNZi8wdW1lSHZZcmx5R3p0VTU5VFY0dzBBMDVMZTFx?= =?utf-8?B?ZmNaK3ZqdlhuZFAwZFhXMllsdnpTZmNJZjYxcGtlSEpRZk5zQjVkTndpaFRN?= =?utf-8?B?dWRPdzUyMkg4VWhSS2h0RjVHd0lrNjA5LzdCa2JkY3YyNlFPTHN5MHVUNUd2?= =?utf-8?B?VkNaeW5DbVgwNWwxTmw1T0xrNEZ3YjQwdHd5QzZzZEJLVjlRSTU4bUNyUks3?= =?utf-8?B?ZFVlbmNBcW1yblYvYUF4VWZhcXNFbEJKVmhBMHZMWDhDQWZPUHY4N0doTDZl?= =?utf-8?B?c2tRRldTa2l4djc4TG83Qm9GWGNwaTZuMi8yOVJMTVFVT1YrSlNxbHpDRk5Z?= =?utf-8?B?TjFjd3MrSHNITUVkNGIvTGRXanZvZm1MYXlPNzc1a0RTN1hXaGlPS2NuaE5K?= =?utf-8?B?TEZyQ0JqakJYaDNET1dxUlg1OHRYZloweWpZRkk5ZHVtNjIwdW4xMXVDTGsy?= =?utf-8?B?OFJsWk94NFZYOEhPaTFNQ21tNWhMbDgxamtIMDVQbUp4dVVVTkNSeUxzbjl5?= =?utf-8?B?bnZrUFEyRGhHMjNSOXRES3l2bDJuVjlhT2FJRzJTQU5HWFl1c1hoVzFUZ1VE?= =?utf-8?B?NTNydy90bGRHaHNLWmdKSFcyb3h3QU0yV3Rha3pvVmVPNUhSVk5acmp3QjBj?= =?utf-8?B?UTkvRGlmelV5cjZXNnlsekd6ZkZKNnlianVaTzdmSm9vOVo0aDZjNVNHWG5j?= =?utf-8?B?azFKbDAwMWFtaHFXMy9IeldYSmVkbFFsdzhaMVFPR0g0MkNnTWVpUGdHU1Rv?= =?utf-8?B?MW5ldzZCY1VNL0x0K3lsOHY0R2EvZW5HR0FDL3dMYjdqRDF0RGE0Tm1ZN2da?= =?utf-8?B?KzFvN0tWb3krOGE5ZFZ5dmVmaVBJVDNQc2V4MGFwbHpRWEFZTEsvV0JOTDNW?= =?utf-8?B?VXUvRU5ia2gzMm5zakhHVUJobGFxOVRaSXUzSUxJTStURVJWTGlzVlFLMElF?= =?utf-8?B?UGdXdkViNHkyVWw3NWV5K0xwazZYSXVUK3h5bUFmQ0ZyV2toVzh5MmR4c1NJ?= =?utf-8?B?S1pFZ0xrQjY5d1l1ZjJGcTlmL08zRkE0QkorS0QvUmdZVHowNFlqS2dpZWVL?= =?utf-8?B?TlhSZW1IQmJvMHhGZk5lYWVNSlJBYU56Q0JyaEo0RlJGL3AxTXBuRUwraXZM?= =?utf-8?Q?Cu6akJaySUSb6N2qo6S14xac5?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0f1b08c3-0df0-47a5-5c71-08db08536124 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 15:04:00.9856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wogwdHOH+A5o4qPC7C9NJ4+zaZWP62XdR3g3uRLglMhRqgEnCpMjWg/GMjalaJAnNM+abg7rjKQyDeHfjEm01Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6494 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7FD6C40017 X-Stat-Signature: 9it951s6qku9ewkm33bsfzk1bs8qd9qg X-HE-Tag: 1675695849-903645 X-HE-Meta: U2FsdGVkX18Cya2mQiVzBSdETTk1qJ0fOGJzpUxljlYhpc26RC2TNocI4r0d75BYDv8jDMTQfgO5NHHk128BiZ29dG0ujlV+uXVn2EiRBjGT6vweCWzjydAqsNLiQ1aUjS7t3HWZx1DueCUwTSD2WWV7sQATS25Cx+EWl8kgse4IwhuHpgBXn4p5Tsz76wluX5u/b1o6OC3nuGiyEhFhWkdxqpdU/jt+ErpSC/X9FPYwxt0mrjJfs+hp8u/VDbv6X3OGDX8SMnRYq5e46nljx94Kkzd+Oe9sGNnEqL1Cu2ebN7xvRJhlLO4H3i/B9UbNaZyRI3qffN3zVc+OxXeZLIznUbwLL4uQM7Ti7GQh0/UyFW12h1nsIfip7TsShks3dctBdonY/APpRLfoUAADhnBDta4PFoBGHANXjOoVTrbf393qjIL2InLed9C4fQGBAi92fctRJHg0JmVnpc+j0AuGpP5C5oyQ7k6X/ysUZ567reoHfL3ougwErjskp3d6wMjam+VKYfK1NW/1Xc6cy0JteEGpfPUYo/rKIFk/nGL8yOYCdsjD+TkXjA21oHZjRzyH+DbCSiQ8VkcaVyFbqqog8t5bWBPbN8GJAA+nAhksCtEABdrNDIUxqRymuoWNoUHJ3k+nB8X/6uFuy6cE1/jk//FobYuwcwEAv3KAaLMUVThClrlvj5WQtMKVAnBmOzEvS03MbqsS/Sa8zyroMgAYYJotBKFCoLNhVQwePW+v5YE8dIjY+t+DWxuoJmAcCRhCB2tJ9hvsZx34lcZc4BHs2dEVb10Su/gF+TlJ7fVqLR3jM0T3XijdBK/rcJwZ5ZR0eo833VBuY9LjAQdEetLbiKajcPArj7iujUfl7nUfqTicfExRI1bQwC/WWamrlx5SvZaR3UQws+0GuIPoo3uK+E0oWdYnGqUEB5GIzYRj0bkSGkzztP2Ew54Q/eQEXrjoJWZadWBBleBSJhg tyVybby+ i1YJPGEg+UwXs4JiXxAPKzQXEbL9GJN/AT4RAYRdtyyXB6PwVEuFY5PWxz5l3NlELEvGBWJ2ea/sWOdNNkhUD/K35dYGeg4/eAxYrlYN5UKTs2mDyUr97jqbARZwaqfKfRauvqQ3MWqAZkkodXQjhJmfqFKzR25MPQPnRnnY26DQvHyDWBEuljqYBX1lM/QbMIw2YUyuO6aMM+B/6GLAKULWxDu0qs0ySNrqqbdHhbfrPujQyc0xP7SdF/DszYGzdo6fdG3yHm4KmKcWfUzYSrdMog+pGF2U2oOtf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/6/2023 10:34 PM, Matthew Wilcox wrote: > On Mon, Feb 06, 2023 at 10:06:39PM +0800, Yin Fengwei wrote: >> @@ -3354,11 +3354,12 @@ static vm_fault_t filemap_map_folio_range(struct vm_fault *vmf, >> struct file *file = vma->vm_file; >> struct page *page = folio_page(folio, start); >> unsigned int mmap_miss = READ_ONCE(file->f_ra.mmap_miss); >> - unsigned int ref_count = 0, count = 0; >> + unsigned int mapped = 0; >> + pte_t *pte = vmf->pte; >> >> do { >> if (PageHWPoison(page)) >> - continue; >> + goto map; >> >> if (mmap_miss > 0) >> mmap_miss--; >> @@ -3368,20 +3369,34 @@ static vm_fault_t filemap_map_folio_range(struct vm_fault *vmf, >> * handled in the specific fault path, and it'll prohibit the >> * fault-around logic. >> */ >> - if (!pte_none(*vmf->pte)) >> - continue; >> + if (!pte_none(pte[mapped])) >> + goto map; > > I see what you're trying to do here, but do_set_pte_range() uses the > pte from vmf->pte. Perhaps best to save it at the beginning of the > function and restore it at the end. ie: > > pte_t *old_ptep = vmf->pte; > > } while (vmf->pte++); > > vmf->pte = old_ptep; Yes. This also works. > > The only other thing that bugs me about this patch is the use of > 'mapped' as the variable name. It's in the past tense, not the future > tense, so it gives me the wrong impression about what it's counting. > While we could use 'tomap', that's kind of clunky. 'count' or even just > 'i' would be better. OK. Will use count in next version. Regards Yin, Fengwei