From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F20EFC4345F for ; Fri, 12 Apr 2024 08:01:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74C8F6B008C; Fri, 12 Apr 2024 04:01:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FCB36B0093; Fri, 12 Apr 2024 04:01:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 576816B0095; Fri, 12 Apr 2024 04:01:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3AE746B008C for ; Fri, 12 Apr 2024 04:01:36 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CA0BB160DCF for ; Fri, 12 Apr 2024 08:01:33 +0000 (UTC) X-FDA: 82000135266.21.33AB015 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 62549C0015 for ; Fri, 12 Apr 2024 08:01:31 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=I3nsKH8T; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jgmnYoXA; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=I3nsKH8T; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jgmnYoXA; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712908891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JIUc1Cqz4RPVX2SIpYjGWH2HQMZ9B7ak3+uxMlPbKCI=; b=l2Db9kEyQinqVWBlqvStoqa1I366KcoTB4/TaYM1cuyX1eqDrDtPRJUUuCBhasGCPbwzUK tIBLeH1CZuINDQHrQ+6VKVecCW6ZATxtjOx8EzzP+efzUJM248sFAO/3Wjv68J5xNMKKvB eCRYGCoA1NJc6zjAJwjacfYtBUWfiwc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=I3nsKH8T; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jgmnYoXA; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=I3nsKH8T; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jgmnYoXA; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712908891; a=rsa-sha256; cv=none; b=jpFvwBIrkAoRY3rSRtrhSsHQ5U4fK3DeXY6RuTUNVnBBTc4FpVwL5CzlG9vJl+HvypsK9S xWwfve3x/mpiiuzH3y6dxLJdqMKW+2/5vLn/+edImRBIxH5BbS19hERcAMSAjTNsCAIjLw 9MmcxT7TNIm62Kb72xtA32HhHbOlPTI= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A0FF85F9E3; Fri, 12 Apr 2024 08:01:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712908889; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JIUc1Cqz4RPVX2SIpYjGWH2HQMZ9B7ak3+uxMlPbKCI=; b=I3nsKH8TD3BUGn8Rqu5l/op1xkSbJBqzJCJ4WbDEH6LR1t+f0134Pg/2RkTxAvJMtdhqtD IyUrUpYuNsUbgem1c+akoSdrpo9SifDOSP8NRFkUAHN70Ec+lo9TbOvmzKqDJKXvvzcQaA uAItrAWbVWTJpmkoqtjg3VY8m3ranzM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712908889; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JIUc1Cqz4RPVX2SIpYjGWH2HQMZ9B7ak3+uxMlPbKCI=; b=jgmnYoXAr28Wi81ZFRAjJ+1VPZ4VEYGQhXmF1vJ4LxReWEyQ08wkPeuA0OgExT1vzqckTT LREsdcM4HNcVBcAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712908889; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JIUc1Cqz4RPVX2SIpYjGWH2HQMZ9B7ak3+uxMlPbKCI=; b=I3nsKH8TD3BUGn8Rqu5l/op1xkSbJBqzJCJ4WbDEH6LR1t+f0134Pg/2RkTxAvJMtdhqtD IyUrUpYuNsUbgem1c+akoSdrpo9SifDOSP8NRFkUAHN70Ec+lo9TbOvmzKqDJKXvvzcQaA uAItrAWbVWTJpmkoqtjg3VY8m3ranzM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712908889; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JIUc1Cqz4RPVX2SIpYjGWH2HQMZ9B7ak3+uxMlPbKCI=; b=jgmnYoXAr28Wi81ZFRAjJ+1VPZ4VEYGQhXmF1vJ4LxReWEyQ08wkPeuA0OgExT1vzqckTT LREsdcM4HNcVBcAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8630C13942; Fri, 12 Apr 2024 08:01:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id EyVLIFnqGGY1dQAAD6G6ig (envelope-from ); Fri, 12 Apr 2024 08:01:29 +0000 Message-ID: <5d3c4a5e-0c27-4058-adf1-91e9602e5ccb@suse.cz> Date: Fri, 12 Apr 2024 10:01:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] slub: Clear __GFP_COMP flag when allocating 0 order page Content-Language: en-US To: "Christoph Lameter (Ampere)" , Haifeng Xu , Matthew Wilcox Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240411091832.608280-1-haifeng.xu@shopee.com> <5482360c-0a0b-e5f5-b88e-4a6ec4d43f7d@linux.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <5482360c-0a0b-e5f5-b88e-4a6ec4d43f7d@linux.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 62549C0015 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ktfmem8ibau8wneus6gkfk9i8y4pzswp X-HE-Tag: 1712908891-442774 X-HE-Meta: U2FsdGVkX1+ynMZQvWh5aLsYIsccQHy/QL6Mqs0Ruh932lMwJYfglaE+SGrItv+AA7vCvPQnkEKVPIbboU7jncJjCHM4jQj1RbhVXYGTISguWeCB22odOt6ue7Ek7kmr69M560k2iz+1ONi9xZD1Lnxq+y6J7nDYo6GaxBB+TvRNPLDnVJzY0b2rm97iobnWB6NOF1+K8tNSYw8jS4t+5/ZBdXeAivgsV7rXOYnEAnFH5vWY76wW3pK5svb80VMY0+NF+EuY/FeLfYe2pC5qnDVEJ1vd41b+VKal9aa09PC1KFO9ivMb/hBhZVkRRCqpqUkP06VJ3Jd1UZb1raGucruydkiNOUjOtVMWavszf085C73QUiehE/Hn+04J8xkOshGrosQlThdVsClsaz6lMEWhZapBpInweh1gR/LmerqMKMYS5ZzMXLGwCRs+yY+Q3IESvl4MEfTq6COpclJ58L9MvolfEIsrwPA+4GDAynQ0Io5RK9Vcz0InGP8anhCC9GiMourdOtRX4uZl5foy6kggM7W6IC4YeZEvwqJvDrWp/4njWKPIV/o6tgLTx0t3CG5/smp/68ZGrGWYezuKthtPmDiY4CzqWLV2G8mLqH9PZyHYYfeCTR+LKfWi+tBWKjrizlOQ7pU81l4G9uQDq9p8uJp4dvBrc/zqb2FeTGyN+MNLeFTrH4HyQLEYYakzwPOwUnD/2/WIDSqf0UONWXHMU99B1w+zhgq+g/WtCE6R7FMpRH88p8FtdjHIcPYq2upwojsugsqz7f/OYzMjunzKHvrE306KTNQ5RJLzg0uc6Lscph/8IOosNJbV+oWg2TDpm+t7n6OmTxfmQ0rcgSg+T/bhYTOpLPNuJkx1isYNmNNCEqkV83pZe6yVOkBviR5hHSiPuLN90zAyHYGx4nkIjeS49JKwqhWXJDw5KpTDu1ilITb6Yl4u+drzMl72TduithrDhX1XAt40TpU lbURgbEy c0RzmBCWMGfAzXmx3koVi9exBraKQ5G20h6yZc+ZsPG88k3qhQ+SPP7N5+wDFFjQjIuQAkPFHeu0QcRteSahxnUYQYLLUk+7lYLFROzEx+xFxURLL6BYZ4cBvEVV7zABWA6nqKYIa6sdzTtDeWiM9vkudpU5djLcI4cb/G+LK5Ul82smopViMLfMa+nOs1MYeaKvITS42yazG9auu87dhQfaSBg7fV7a77tfpki2/znqyUv9sKN3pMZ6pmxgyBD07yR+GdGXDrO3povonxyW+BfIl4pQGFWG1GWGjMTlyPdIixf9uW6SAgoyKDXTaRJCWwtTS+8tUT2eL9rgUWJprqix/LCxA6XZtpspC/C6vf7LFwJJWtYbs9nIk+xx4U6BenfvF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/11/24 6:51 PM, Christoph Lameter (Ampere) wrote: > On Thu, 11 Apr 2024, Haifeng Xu wrote: > >> @@ -1875,6 +1875,13 @@ static inline struct slab *alloc_slab_page(gfp_t flags, int node, >> struct slab *slab; >> unsigned int order = oo_order(oo); >> >> + /* >> + * If fallback to the minimum order allocation and the order is 0, >> + * clear the __GFP_COMP flag. >> + */ >> + if (order == 0) >> + flags = flags & ~__GFP_COMP; > > > This would be better placed in allocate_slab() when the need for a > fallback to a lower order is detected after the first call to alloc_slab_page(). Yeah. Although I don't really see the harm of __GFP_COMP with order-0 in the first place, if the only issue is that the error output might be confusing. I'd also hope we should eventually get rid of those odd non-__GFP_COMP high-order allocations and then can remove the flag.