From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D2FFE7718A for ; Fri, 20 Dec 2024 08:55:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0ACC06B0085; Fri, 20 Dec 2024 03:55:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 05D456B0088; Fri, 20 Dec 2024 03:55:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E66466B0089; Fri, 20 Dec 2024 03:55:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C43E76B0085 for ; Fri, 20 Dec 2024 03:55:19 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E5613A087B for ; Fri, 20 Dec 2024 08:55:18 +0000 (UTC) X-FDA: 82914727014.13.B32F6F1 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf08.hostedemail.com (Postfix) with ESMTP id 72CA2160006 for ; Fri, 20 Dec 2024 08:54:53 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=cgdtkIll; spf=pass (imf08.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734684893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UQfNyWmZKsPDEukQcf0PNeutIzKaofgYiuVwM4cz6bQ=; b=fVlFLRYFhNYVpp94TzuFcepv75nlVBFqHA82n/GjYhc+r37o34nat64l128VgmrCmUQnr3 +iquo7u7oyg7mY3ZO+jxX1JzuX08O8wpIgsZl2FnYhfB9f1ikBoefvOahwVBly0HctWx6H xSmE9H4fsMuqEp5sn0hb3fMq6NULTbk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=cgdtkIll; spf=pass (imf08.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734684893; a=rsa-sha256; cv=none; b=b98Y+Dw5ds/WCwQIXtsIob1USfZ2UzkVlL7nXTekkCzYjLBUIsedqMOzHeeOH2ccSw0ybx IURBM4K1jyEF4jWY8zW7Otdap7aGZe4DeiycXpr8o2R4gESfnPNB/VwfHoFST7unZz8PoD Xu+YmzldfyaeCpMUhgXu7SIuIZDzn+I= Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-725f4623df7so1612237b3a.2 for ; Fri, 20 Dec 2024 00:55:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1734684914; x=1735289714; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UQfNyWmZKsPDEukQcf0PNeutIzKaofgYiuVwM4cz6bQ=; b=cgdtkIllIhAnKyHwERQS58dd3szfQSbb5WJWa1cg+bcNHGIqQPFYre/2UDOHabBT9L 7guYPDnVtaPWkCbypx25AsRzb5jmIE9ayQszEdpPIXOubL/q4fctR7tKuWfiQRxWJo+V rLF8UJtXpqo+cOS6gv+XMVWCgICqI3OqrLeIL8NuU8eWpq5qDl1DpHMSqBpEVOX7hofq rKGh7reLL+9u+EazNBNuaxmTIOmdsPpM1bnnf08lOjxnn6SID2AIafsyGCz/QSSCSWgs g1HclP9iFtSf/F7tSoJgOSVI7TcDIc/SaA6SL8udv/JYeG2uyT4gHm58wDYdJXXqO79F J5JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734684914; x=1735289714; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UQfNyWmZKsPDEukQcf0PNeutIzKaofgYiuVwM4cz6bQ=; b=keBPgd0Y68K0HmgRge8aF3TPO313feswYZneOemzeuD0brasmjMPIuWccPeZkGPD6E toFfAiRy1YoZPKaKuY4trHWGb+n5mrWHt1ewIET0ho87UGFnFUgRAqtdVmkdk2JI+p4X /P4xGCa7OId/vGU/U45uRtgjTA+8bqA+D/ecg21A3GPMEYaxEv0l6C7qpRb0FdkRAAJt xWsqOSdQieQg2MRXy/AN7qwXuDvQrPvKB1oFJ1XLD1a7wG/8SiL5nIw3vHTfqFyPdR34 DnKQhRiRa9773o+B8c0gLf8clHnFjIE9ELUSETV3gd6ZZoxLT/3fjgrYdNAxnCtGCfmE gmRQ== X-Forwarded-Encrypted: i=1; AJvYcCWhrZlR3Ce8OTiQQodP7k8cos7x6Ba8dV0iV+8zPZWR37KNdcyAa0mlZ32xtbF2/s7jeXxajFEVvA==@kvack.org X-Gm-Message-State: AOJu0YyTo6SK5ec78Z1MjkJWm61FhRub2uYFaWxKTiwu6hkBrdYKRRrH jc41k2WRpIillt8mEnaVfyjP7Kc2smmsH1ZmhDKwhuZwa8OlEAoszMYlwvlDauo= X-Gm-Gg: ASbGncuZOl78VoLlza0G8foQJ6NKMsAmwaKbqVmagLwYthzU4qSYfCw93KZGVyB3vOs GccyIWZ7NWFknrRFXV3MP6qnasU58cWWk8t6fA5Zz6Ai5TQWhem7mPxoTetvJSVpMuvx10DH4Zr MSzv9VNQFXZux5coIa4STbyPBSqvP+34I59iWV6fx1Pk021PEvEJZafBMT8LD3f7sZDgHi/9aT6 ZSuyJykNhYQgfcX76Wn+exmi4nn2tj2O79Lv0Y0vZxTivZB5DsE4tADMltg68s7dmH4EI8o5ieS YusqYw== X-Google-Smtp-Source: AGHT+IFhsQwykE06H+WRP/74qyUyJawa/zavas7Qj2VdqxkKt93Yr6pU7Xanlr8qwKqxirNXDKAwCw== X-Received: by 2002:a05:6a20:7f99:b0:1e0:cfc0:df34 with SMTP id adf61e73a8af0-1e5e0470226mr3586592637.16.1734684914494; Fri, 20 Dec 2024 00:55:14 -0800 (PST) Received: from [10.4.194.102] ([139.177.225.238]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842b85f00f9sm2424275a12.43.2024.12.20.00.55.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 00:55:13 -0800 (PST) Message-ID: <5d339eec-bb93-49ab-890f-07c77ce040d8@bytedance.com> Date: Fri, 20 Dec 2024 16:55:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table() Content-Language: en-US To: Alexander Gordeev Cc: peterz@infradead.org, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org References: <0a6caf8305409173b5d41dccb6ecd46460cf9c1c.1734526570.git.zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Stat-Signature: t375inu7hrfozxiorkarspmo49sjeezx X-Rspamd-Queue-Id: 72CA2160006 X-Rspam-User: X-HE-Tag: 1734684893-240080 X-HE-Meta: U2FsdGVkX19OkbhUvCRP+B5PAs0W4qJU24HfMnGxx0mlAVDDIIs3/Q00cP3Q7kYjbSuYkdTw4zWiyqnh20yTgAf6OxzICwJPb0sEoVUHPS72EOHPkVxGmtNcl1F+k7E6+VfzvsqOyO3t/uHzcahd8ssioLFckJuHlNLHa+RlJsx/z5m5dg8TFAVPdqtq952Y+CfNs6pPSkSC8I3YwK0jJ5XT9nXTuzavcBuQVJf4CaO+fjCl35Grk1G1Jpt226kY9ULcm8hB2QITd1edn8rO1+mKqsq94aX1Mn1hHV7jQJB3lNb3siQse2QBYual3zLSSl7PaplfrmLAjMo72/2sS+5OoyB0JtqlofCE1xboMoxP+EaAZs2jHJXnOuFGw50oauMhchVUSxbgjJzG65pJVouL3oHoednY9iTtY9hjj0Adtf17woTaKNhYdfCLEPEyp/HWmbclXEYprzpT+DuZdjvhnT0CGYYzYG1+WS6Kaqg4s+LzuTW2E9DMf7Elxms8NvwwQD+lXTkGiL/UKTNo1JFzACjApxwKHdMoviOoCV0MfcNUAQvrsVmPzbs5kS8WdvC7UDCbH21IZ//eMokIfepkiIomewdmtd8r5Wj6mP6bgsH3/KpLV+vSh63e7cQd4+1sepbvSYlg9AMwswnql/MO6ItPGO5ROIAYjmC8aoxJjooIVII0oreIRUgjZxsaOsPztUVqCTx1nlhwOkKfVrkYDCvQFXz8c5pD6vIbwzHCw3BPEEsBbDIcFxjjmXAfplesqtwUWmisPFa1WATl0MIVciV6MbLWaPqqzbI6mUpyxNna8ndzACq4FTX0H4rs04ZRRcpvuM9Ugqq6gPQmHZ+EZb8Eo2wtn/zcS/bLdEOlPneteN/E19O17ZQjRiY5MtfUQ+J+y9bizeYm5h1EMFeTC+b3WPLLmR1ITjnTATKVC1kDMXovaPs3U5P7NJp6wPi+1gTv78lnQmgRF1b wMMIHWIN D1sdj24HfP7P50MJqq56uegHSLcFkRP6FJK2BLvFVAnOl3X8wo0Y8N4upCZ70i0K2PyKUW9rZph+35ArvEYozfIenOjlrZrJgo38s1XV1U4M9LFRuYHDRPKiWRUUEkA50ilKa0XzdgNeHfBZGeODpM1pC8BnJi29tqlZm/HoCtCIv94NXD1AtPrmRJHB19VvxUZ2QdHgn1BoXgt1JH8M0Ipe2+jkZZz3LXAlCqx1xMONqSxHO1bVSBr9FcO0J3sx2pv9KwA18wUdOYh4ZP3S9D++YicWxqwV9CdfEZAE6ataxvzYgRgxtq/JZrL1yNt6D6F+KO7tUqhmYLAS2y4Oa0NCM/KaIDiaV/d9YvowitZWx2e2DDjCDtXU8+J0O31XAHIiAdB909upBnV3gEpXmltNCNbUByxVOp03C0zjfU1W+DN1GZDf76f3Q7BTgwUGqljgWy/cKLBwEoxMmUJTFSsnEJ5Pb6F+wt38rJQ00xauX3vOG575EavtP7gLKu0xFy4QPIRxz6RcMfWCsTZgw5sUkX4C2oalqxaFDlwwn6qqJNfcUs/5O1+LAew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.088601, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/20 16:42, Alexander Gordeev wrote: > On Wed, Dec 18, 2024 at 09:04:46PM +0800, Qi Zheng wrote: >> In s390, the pagetable_dtor() of PTE has long been moved to >> __tlb_remove_table(). > > Well, not pagetable_dtor(), but rather pagetable_pte_dtor() and > not to __tlb_remove_table(), but to pagetable_pte_dtor_free() ;) > >> So similarly, also move the pagetable_dtor() of >> PMD|PUD|P4D to __tlb_remove_table(). This prevents the use-after-free >> problem where the ptlock is freed immediately but the page table pages >> is freed later via RCU. >> >> By the way, rename pagetable_pte_dtor_free() to pagetable_dtor_free(). > > This is not just a random rename, but rather a result of unifying > PxD and PTE TLB free paths. > > Could you please come up with a better wording concerning the above? Sorry about that. Will modify it as you said above. > >> Signed-off-by: Qi Zheng >> Suggested-by: Peter Zijlstra (Intel) >> Cc: linux-s390@vger.kernel.org >> --- >> arch/s390/include/asm/tlb.h | 3 --- >> arch/s390/mm/pgalloc.c | 14 ++++---------- >> 2 files changed, 4 insertions(+), 13 deletions(-) > > You also did not CC linux-s390@vger.kernel.org for other patches > that affect s390 sources. Just CC the whole series, please. Got it, will CC linux-s390@vger.kernel.org for the whole series in v3. Thanks! > > Thanks!