From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3415C7EE31 for ; Wed, 24 May 2023 23:13:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BD9A6B0074; Wed, 24 May 2023 19:13:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1469C6B0075; Wed, 24 May 2023 19:13:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDA95900002; Wed, 24 May 2023 19:13:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D7F876B0074 for ; Wed, 24 May 2023 19:13:34 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AEF5080377 for ; Wed, 24 May 2023 23:13:34 +0000 (UTC) X-FDA: 80826702348.20.93BC856 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id DB24F40017 for ; Wed, 24 May 2023 23:13:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Txari5z6; spf=pass (imf04.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684970013; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G+wve4XQd6yBhVbelwKVweAiFsVhy8mwFJqRZuDP9C4=; b=1X/dLn8o5giIl7YeARfxqZBrSPaSdXaP2s85IuPjuZcvZqj6FOzCUyB18pVQNpFoyeYMZI oSvgKPMwYvOce9KzAXBAlQlBBcIl5owLkvX2BqkrX7zGjhmwWKFRWs74kNb6Wihyj6qd4C a0KkENWZPvo5uTmmmRsar0jw1Sxju9s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684970013; a=rsa-sha256; cv=none; b=6axN/PDWrq1WlL7rUln9FDI2jiXgJPeVm4o013Ute5hom1Cf8bl3VfKsP1NMPvaZgKLBAg M71fLPpV8b9rJJjQ0Mpt10wpiuZfBEYT39gkFSw3MD5CEmn1DcnQrt26mdRgEdZKhV+6ls y21S/CrCRSeVeL1NS9FTFrUNs+jdu5U= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Txari5z6; spf=pass (imf04.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B963C60B89; Wed, 24 May 2023 23:13:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09EEDC433EF; Wed, 24 May 2023 23:13:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684970011; bh=TZkIpxpAgQpdYh2IdY1lcMnQau3zcUBWqWIr6I9VfCM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Txari5z6ZBrn3Eda4nkNy/2JwwlJLQjqX66l5Nj1swylueJgBUynUXM7+f+DTR2Yw HR9sMj4wecpB7wFrt/r3pOAjt92yyEhK5FE5UOB21N1jOZ8Gd9j4ahu36iaAGHwMDx r4vnQ4XUkQ04DwFI+3583OuKYAvZKda+Bp7JLd1gjhnAJyrFUiMo+ISPRz2OYdo2Hx CiDgSF5RxrSfGS52Sia19Q8VE4zWeibHvMQ8xB5t8JLo9xodX3XtHFESosM9lf789N LKIxqhtUcl6HOeXm4r31wWKBtsUbsNoaheWsT8dsnpwrNzF+ifumhMhgTCx0R/OYI+ P06GpR7c9n3RA== Message-ID: <5d327bed-b532-ad3b-a211-52ad0a3e276a@kernel.org> Date: Thu, 25 May 2023 08:13:28 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v22 25/31] zonefs: Provide a splice-read wrapper Content-Language: en-US To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , "Darrick J . Wong" , linux-xfs@vger.kernel.org References: <12153db1-20af-040b-ded0-31286b5bafca@kernel.org> <20230522135018.2742245-1-dhowells@redhat.com> <20230522135018.2742245-26-dhowells@redhat.com> <3071148.1684874594@warthog.procyon.org.uk> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <3071148.1684874594@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DB24F40017 X-Rspam-User: X-Stat-Signature: 1o7wuctg7x8xh3nkfz9rjnnnf6bnui3w X-Rspamd-Server: rspam03 X-HE-Tag: 1684970012-930139 X-HE-Meta: U2FsdGVkX1+qCH3ZHqTevEk9XeruQFD7DM64lB2qbfrYw4sStA8HfaX76hyHWP+Q6oNPAmJ/wPpqoiDl3NhioUu8Kb0nmyIl5hCrIBKwAa7YjHs6QW9LnXrqi4OtVoPN42n6DFYbooSG+WHyxSu/3c08q63Qx2Z6DR6PfrhnKB0uxTFJBaZaZV3/oyJmhRtzEm3vDJlq1mg1BA6WHyNEpFOAHnj6fr+zxeNs6PWGqCElbZXAD+WkOmRKax8pRrOkpxWNf3pKG0weFf4kJK/vTDCFeECrcrQd25XIfGR48FrMTH3hrpbEkk3kC5LOFS1vklW3qluucfXQqzKU0rY8rWtmIyYeho/2C79daQBO6noezugVfgpiBP2jmTvpW7uJRyQOx832+Zsb1ycSF6RK6ZuWkl15SnibFidk9xNI4+zeJr1QWfGdu1MKNgzuppMvzaldNnTWkPWqvR8zL/Jq3Iw1kLHWtjiyjqAQLn/P9qg6IxXmuTvAHBJFOwDSv+/pEHIW683/uDn8g1XX3QQetieP2qXG8gGmMSB00j3heJFtJMzQt/Bk7P66OhxReorQ68S+gLJadSys6ALa0tA47n8JP+iWMzlw1OJKC7UBXtzUDr1MiSlkJNzqhOh4AG2hIqVFm3TlHaKhJ9p2BZJpX21zdwHz8NDlPZi5T5jZ7AFpPHQBOOiAHUmHl2S4ni6KC++JQREmGb9Uhx5ubW2qK+efqiE32eHzK6RxmxLrucCYlq9YSMevrPiOgBkLRn1PJhAq2rcJaqKpzeVsYs9LGZBBsqoMgz0JYZ7aptx8vPwyvBRf6mz5V7lznvFQIomea2pFTdMKDVN7CTIvd5MyKW2BFEAP/6NHxQ+GsJALHrcqyQ+8C0G2oNGFp0z/sKWt32qMLEGtXXNj/zwMf1akSCGe1Z60TyWQ9Q/iWeABW0mAbz+PTaKKT0wLaSkegCTlYEGBE9SnppCx4iMdsAM Fau+M0a3 fuprcL7F9DFj1yhgOYjMWvWvjrzPyq1Ekj9nnPunjxSX3htRkUMQ0rckoo9pdcRLEdqqMnkK9DV1k73QrRUnKTfbFnj1EAwTF9Vyii7DXwMcpQbcwR5UEgln1jpV98Y37LZf+Fwv8CUf6pWCdIKec1K2rQTKjqVBKyDQOXrBcSG6Valb7m1msIS7vGLaRMDK+IcQfs9w2ekK44LtDPkaaVdmw1MRlULp6F9Tw8Oi+HyTjv7F3qcEkNddWomKhqaeBj9EheTbK8VIv+qnsMhyaUsHeXfss1rnDZWIso1XKwBdwfHNme0/GXcBf8/N1KAvSxextKKXXn8boVDh4jNFtSPTJPXPEgc4L5RPtUO9u3ZVfy3KMrPdUgnAoJufqD/7yTI6P X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/24/23 05:43, David Howells wrote: > Damien Le Moal wrote: > >>> + if (len > 0) { >>> + ret = filemap_splice_read(in, ppos, pipe, len, flags); >>> + if (ret == -EIO) >> >> Is -EIO the only error that filemap_splice_read() may return ? There are other >> IO error codes that we could get from the block layer, e.g. -ETIMEDOUT etc. So >> "if (ret < 0)" may be better here ? > > It can return -ENOMEM, -EINTR and -EAGAIN at least, none of which really count > as I/O errors. I based the splice function on what zonefs_file_read_iter() > does: > > } else { > ret = generic_file_read_iter(iocb, to); > if (ret == -EIO) > zonefs_io_error(inode, false); > } Fair point. But checking again zonefs_io_error(), it will do nothing is nothing bad is detected for the zone that was used for the failed IO. So calling zonefs_io_error() for all error codes is actually fine, and likely much safer. I will change that in zonefs_file_read_iter(). Please use "if (ret < 0)" in your patch. -- Damien Le Moal Western Digital Research