From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2660C6FA82 for ; Thu, 22 Sep 2022 13:07:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 220006B0071; Thu, 22 Sep 2022 09:07:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D03C6B0072; Thu, 22 Sep 2022 09:07:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0720F940007; Thu, 22 Sep 2022 09:07:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E86CB6B0071 for ; Thu, 22 Sep 2022 09:07:23 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AFB63121365 for ; Thu, 22 Sep 2022 13:07:23 +0000 (UTC) X-FDA: 79939747566.15.C10B1AD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id D4EF51C0003 for ; Thu, 22 Sep 2022 13:07:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663852042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CjhTURl6iV0xbs1mGgaQyYW7UKLG8JeOYP7PLGKX0XY=; b=OrgWaLisartBHP1PUHp/Izh8e2nDXfm0BP1tfRVJmLvS1HEZIWCWZkIb501YNx3ivLd9YF wPfvoV/w5mDvn5chSB8CkEOVqZNQ7eadJwm1tBFb53Kl06tTh7/SMgUCv15TLxfPFgd69L /2S9RevHcKKA+SiQklxHWxoStJ2vgYc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-589-psHG5zNQNKChXc6-UR0fMQ-1; Thu, 22 Sep 2022 09:07:13 -0400 X-MC-Unique: psHG5zNQNKChXc6-UR0fMQ-1 Received: by mail-wm1-f70.google.com with SMTP id b5-20020a05600c4e0500b003b499f99aceso1072366wmq.1 for ; Thu, 22 Sep 2022 06:07:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=CjhTURl6iV0xbs1mGgaQyYW7UKLG8JeOYP7PLGKX0XY=; b=7TgSdEDtQVWHrkUbeQkxmALYwc2FyEz2yEkKvDKWsTSjB8vdq8+9xB+jmzt+VMNh/Q tqJLE30QlEsMa9OyAD255J8NaLWTSjII2B3o7hc8B4K8NQMCxnH/YmrlkxT27KR5PR56 xpKF0YZXw5N9ZIzF6OS29wue15ebrXNPPKblFFuGCKmlnkTB/Bl+iddIzvnu0l7u/LB+ 27qRH9HHcIuy9RO4rew5SuElats+ApHPYjjtQaCwTmZCq4YvH8xph/ypfEIN8o7dS1rC 3pTz1YhmUAXHlycxmbsL3yly2ZrfU6w2np52C69yW43/YvtHjYmusQR1oyw5WiLNqaoW +DwA== X-Gm-Message-State: ACrzQf1El7Z2Bz1fE3A+Kl909d3Q5ZHXfsoiTBkLtWl+H4c/2nEQcX0e SHxbp4PcWW4CgFPo8pFrhrMWP3EFanGIQVvGgzxTzU+ZR86k+Y5RnGxAKgu4pe2o+qe9T7ElGtu GOHA4QvsvPVE= X-Received: by 2002:a05:6000:1146:b0:228:d61c:2c83 with SMTP id d6-20020a056000114600b00228d61c2c83mr2097311wrx.332.1663852032399; Thu, 22 Sep 2022 06:07:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7IJlo2iupZg2mw7YaQ5Yk0NNOYybzHl7p156+ZjUOAVavK9eqWOUvbqYy0l3NH8NiSk043Xg== X-Received: by 2002:a05:6000:1146:b0:228:d61c:2c83 with SMTP id d6-20020a056000114600b00228d61c2c83mr2097292wrx.332.1663852032114; Thu, 22 Sep 2022 06:07:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:2200:d595:cc20:2e3a:fc5f? (p200300cbc7082200d595cc202e3afc5f.dip0.t-ipconnect.de. [2003:cb:c708:2200:d595:cc20:2e3a:fc5f]) by smtp.gmail.com with ESMTPSA id c7-20020a05600c0a4700b003b4fdbb6319sm3486179wmq.21.2022.09.22.06.07.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 06:07:11 -0700 (PDT) Message-ID: <5d26264e-9c3d-4c7e-30d5-315ad01cf016@redhat.com> Date: Thu, 22 Sep 2022 15:07:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 7/9] memory: remove unused register_hotmemory_notifier() To: Liu Shixin , Andrew Morton , Zefan Li , Waiman Long , Christoph Lameter Cc: linux-mm@kvack.org, Kefeng Wang References: <20220920025123.2868953-1-liushixin2@huawei.com> <20220920025123.2868953-8-liushixin2@huawei.com> <2613e70a-4aad-fbcc-e014-eb5b84c2f8ff@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <2613e70a-4aad-fbcc-e014-eb5b84c2f8ff@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663852043; a=rsa-sha256; cv=none; b=upnDyJrw/88cRplNe/CZfCn9k71D4nk3a52/sSFaMYE5/HsVrONus3rcGPM8Sg/2b5E7R3 mPs6Gnj03PAPC9Fqlcw7q5cZUEDgK5sxtU19OEdBCRNkqsRrsEvPWHY1rTDtqOpahG+SA4 JJxbLqqHf4b7qM0FfMZ4ikdTzOzPJxg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OrgWaLis; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663852043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CjhTURl6iV0xbs1mGgaQyYW7UKLG8JeOYP7PLGKX0XY=; b=4B2/B9SIyT8rZQVGVjbI/7k5EkMpwLOgwqfGQUmemcI2WiF0GNhK/yJB+KIuDpKnaSV0KS JJiucnlPZLjojcWZaWQuqWYN369yyKk/9ZOBTIlvU4MrKdifdlMJYgOolIiVNPdXslN41o LsjEZAkh28FTaSIfJ+SJDcq4nEUdPy4= X-Stat-Signature: ci4e449tq9rpwnfhd7tstfxgxsxjzcqe X-Rspamd-Queue-Id: D4EF51C0003 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OrgWaLis; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1663852042-905061 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.09.22 14:54, Liu Shixin wrote: > On 2022/9/20 20:06, David Hildenbrand wrote: >> On 20.09.22 04:51, Liu Shixin wrote: >>> Remove unused register_hotmemory_notifier(). >>> >>> Signed-off-by: Liu Shixin >>> --- >>> include/linux/memory.h | 6 ------ >>> 1 file changed, 6 deletions(-) >>> >>> diff --git a/include/linux/memory.h b/include/linux/memory.h >>> index aa619464a1df..98d2a2ebcc10 100644 >>> --- a/include/linux/memory.h >>> +++ b/include/linux/memory.h >>> @@ -19,7 +19,6 @@ >>> #include >>> #include >>> #include >>> -#include >> >> ^ why remove that? >> >> register_memory_notifier/unregister_memory_notifier still uses that. > Yes, you're right. I don't notice this point since there is no compile warning. > I will add it back in v2. If there is no warning/error, maybe we can just leave it out. -- Thanks, David / dhildenb