From: David Hildenbrand <david@redhat.com>
To: Liu Shixin <liushixin2@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Zefan Li <lizefan.x@bytedance.com>,
Waiman Long <longman@redhat.com>,
Christoph Lameter <cl@linux.com>
Cc: linux-mm@kvack.org, Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH v2 7/9] memory: remove unused register_hotmemory_notifier()
Date: Thu, 22 Sep 2022 15:07:10 +0200 [thread overview]
Message-ID: <5d26264e-9c3d-4c7e-30d5-315ad01cf016@redhat.com> (raw)
In-Reply-To: <2613e70a-4aad-fbcc-e014-eb5b84c2f8ff@huawei.com>
On 22.09.22 14:54, Liu Shixin wrote:
> On 2022/9/20 20:06, David Hildenbrand wrote:
>> On 20.09.22 04:51, Liu Shixin wrote:
>>> Remove unused register_hotmemory_notifier().
>>>
>>> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
>>> ---
>>> include/linux/memory.h | 6 ------
>>> 1 file changed, 6 deletions(-)
>>>
>>> diff --git a/include/linux/memory.h b/include/linux/memory.h
>>> index aa619464a1df..98d2a2ebcc10 100644
>>> --- a/include/linux/memory.h
>>> +++ b/include/linux/memory.h
>>> @@ -19,7 +19,6 @@
>>> #include <linux/node.h>
>>> #include <linux/compiler.h>
>>> #include <linux/mutex.h>
>>> -#include <linux/notifier.h>
>>
>> ^ why remove that?
>>
>> register_memory_notifier/unregister_memory_notifier still uses that.
> Yes, you're right. I don't notice this point since there is no compile warning.
> I will add it back in v2.
If there is no warning/error, maybe we can just leave it out.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-09-22 13:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 2:51 [PATCH v2 0/9] mm: Use hotplug_memory_notifier() instead of register_hotmemory_notifier() Liu Shixin
2022-09-20 2:51 ` [PATCH v2 1/9] cgroup/cpuset: use hotplug_memory_notifier() directly Liu Shixin
2022-09-20 11:59 ` David Hildenbrand
2022-09-20 2:51 ` [PATCH v2 2/9] fs/proc/kcore.c: " Liu Shixin
2022-09-20 11:59 ` David Hildenbrand
2022-09-20 2:51 ` [PATCH v2 3/9] mm/slub.c: " Liu Shixin
2022-09-20 12:00 ` David Hildenbrand
2022-09-20 2:51 ` [PATCH v2 4/9] mm/mmap: " Liu Shixin
2022-09-20 12:02 ` David Hildenbrand
2022-09-20 2:51 ` [PATCH v2 5/9] mm/mm_init.c: " Liu Shixin
2022-09-20 12:03 ` David Hildenbrand
2022-09-20 2:51 ` [PATCH v2 6/9] ACPI: HMAT: " Liu Shixin
2022-09-20 12:04 ` David Hildenbrand
2022-09-20 2:51 ` [PATCH v2 7/9] memory: remove unused register_hotmemory_notifier() Liu Shixin
2022-09-20 12:06 ` David Hildenbrand
2022-09-22 12:54 ` Liu Shixin
2022-09-22 13:07 ` David Hildenbrand [this message]
2022-09-20 2:51 ` [PATCH v2 8/9] memory: replace IPC_CALLBACK_PRI with MM_BATCH_CALLBACK_PRI Liu Shixin
2022-09-20 12:07 ` David Hildenbrand
2022-09-22 13:12 ` Liu Shixin
2022-09-20 2:51 ` [PATCH v2 9/9] memory: clean up hotplug memory callback priority Liu Shixin
2022-09-20 12:08 ` David Hildenbrand
2022-09-20 14:22 ` [PATCH v2 0/9] mm: Use hotplug_memory_notifier() instead of register_hotmemory_notifier() Waiman Long
2022-09-22 13:33 ` Liu Shixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d26264e-9c3d-4c7e-30d5-315ad01cf016@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox