From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2E02C47DD9 for ; Wed, 27 Mar 2024 08:52:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 487F76B0098; Wed, 27 Mar 2024 04:52:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 410416B009B; Wed, 27 Mar 2024 04:52:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 289E26B009C; Wed, 27 Mar 2024 04:52:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 13E186B0098 for ; Wed, 27 Mar 2024 04:52:16 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D5111A102E for ; Wed, 27 Mar 2024 08:52:15 +0000 (UTC) X-FDA: 81942202230.23.1F7C00C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 96D82160009 for ; Wed, 27 Mar 2024 08:52:13 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iG7s2pVz; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711529533; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=obXCVoONf2iOwvyp8/k3nDQhXlHsxj/jfLxN6UfcAcM=; b=ox1h3RJoce2bskENBsC4flY+VigEqZAW9yeGiggKputGL6aQTXJK/vU2Fn/Da6qe1fpMTC NgePBXZXD5axcbysbGRQfRqnO6WoqBcHHa3vs+y8vcm+KiJzqyNyHIadrV5qpu6yd+oDg7 8E+CKTB/n8YnMst8Rafk7lcTsa6QJF4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711529533; a=rsa-sha256; cv=none; b=oX9JqvktqkCcWPTSQa1D95v/id4aee9T+9vsvhJaqF6cy5gBzN3oiZySynO0cr1ImyWA/2 MZQR1f7ojNhuMSneGfLtda39WiPP9uCY1XMOxUWfz38DOrLqzgPt6mYmkVXBrktzUpk37D 0nPSzR3pQy6UpEQoT5xj8GemIvBIDYs= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iG7s2pVz; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711529532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=obXCVoONf2iOwvyp8/k3nDQhXlHsxj/jfLxN6UfcAcM=; b=iG7s2pVzdk+2b2HUCfa5X24FLvYydmZzAziNOAtKbk6ZeDSs0LVV55uAC+OPL/A1Qe0iAE cYNbbZJTPlKiFK1prkEnJ+WuB7Ct5DJiqgp4obmhfq2P5RC4SkAVKNizCy9OpxNgnZdXet c9H2dfZfVMz7Gvdf7RzPvCbE4OwxpoY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-275-BhgCPfvnMsmkL8gT6TejZw-1; Wed, 27 Mar 2024 04:52:10 -0400 X-MC-Unique: BhgCPfvnMsmkL8gT6TejZw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4148b78d733so12692215e9.3 for ; Wed, 27 Mar 2024 01:52:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711529529; x=1712134329; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=obXCVoONf2iOwvyp8/k3nDQhXlHsxj/jfLxN6UfcAcM=; b=fe1M9oZzJGOwBOWBQsIbZwNHb05CRxlXMLs+eiWbTk3PJQbni/hCKxo9DpNImiG683 eCDKNMoX1mPaiKo6aqI+ps2fs8jWK6k+oYMXtM7J1TLNi26PbVzzOBAB3ml28dCPtJeZ 4S1gXpxpb8bxrPx25zQ74BmVq7I4ROClmaOR8Kt5ORE9yFVgw+q4PfwVGQO34C2rNw7o JzXcRu6t1Q2EIp4ZKZbmgZLNVw15AI9Ka1TNmCwbysHIkXUmRkYxmZMidwK1s9kUsK86 UHSPicBdcExIlPEc9Wz7innYXpNK6YsMEc53uGqp2Rs2NkHZDOQoxY/0tkC6dXJtyexb AlsQ== X-Forwarded-Encrypted: i=1; AJvYcCUhTtUJOi4OezmX9o3Q69bEBBV45ZZFE0D7icOK1uOJbF5XDY+BtiGLkYsB2wRLZFG2lhhY0b1xg6cjNkAMaE49hVw= X-Gm-Message-State: AOJu0Yz6Ke7ZAxlrAhX3RPqLs3vSUV+L8ow/S/PkDqnTHU/3v1C75xva pPgJtBLvY9CEgA41ZENj319BPftYFwKGrHWXEcziSoa+u4UMCSL3+T/VWkybsS3v46e1thu/fjd V+CL+lIZ5nBurkZsoejRJ3+ZLXc/PUAd59d8A0QBxn3rpUo68 X-Received: by 2002:a05:600c:35c8:b0:414:9463:d4c3 with SMTP id r8-20020a05600c35c800b004149463d4c3mr803659wmq.0.1711529529538; Wed, 27 Mar 2024 01:52:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPxbwmy8hFNjQk7jFjhX0Tup4NdmtYI9VPBNOD6LwwDuXoAD2+p073nPtr9VCci+k9Qiy6pQ== X-Received: by 2002:a05:600c:35c8:b0:414:9463:d4c3 with SMTP id r8-20020a05600c35c800b004149463d4c3mr803647wmq.0.1711529529165; Wed, 27 Mar 2024 01:52:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:8a00:362b:7e34:a3bc:9ddf? (p200300cbc7088a00362b7e34a3bc9ddf.dip0.t-ipconnect.de. [2003:cb:c708:8a00:362b:7e34:a3bc:9ddf]) by smtp.gmail.com with ESMTPSA id e18-20020a05600c4e5200b0041401eb021asm1483641wmq.24.2024.03.27.01.52.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 01:52:08 -0700 (PDT) Message-ID: <5d2533ef-40a1-4afd-b071-b68022188225@redhat.com> Date: Wed, 27 Mar 2024 09:52:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] minor fixes and supplement for ptdesc To: Vishal Moola , Qi Zheng Cc: akpm@linux-foundation.org, hughd@google.com, rppt@kernel.org, willy@infradead.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 96D82160009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: pidhod3b6y9781zibcdzu7943kfswz6m X-HE-Tag: 1711529533-903451 X-HE-Meta: U2FsdGVkX1/1qmrSIhjb5F776+/Kj+NvIUWn67MMkvN1o6+YT5LEGhzeujZHmYrovKkrZ/yeAvHU8EybkiLzlr/72JbdA51wCKcZyw5zwRZKhUu3M3xzOOQa49jkXj3llDXixUYI1YyAsUhqIirV9SU12eCJFQtp7VNzEYOqtmZnP7VCbq0FaEGiyiG89GswLNYpelU6f9suWAAmUy2sphd13XL6NG5Zqo07Yt10lO3mDWbZeXmrNnFMruZQbTs/b2oW1JODiCcf9Tw9Kdo6OlbEfsm1fg/L2BCawfm74La0ir/n++d76z2qirH4tjDR3Z8TAS2xJ81zfPC5dto/FkFrWwC8wBuoXqANRRAwdEN7id+e5CGvxZwFdq3L/cuuyoyRE6jid9yCI/GgH3MRxPKrV1zBmJQKo9N0OtQV8cANBk5spnfJQlZMAPmF+vHFqQgTu5WPXpZWU5IxAodoIOP7+hAkHeNB6H58atc+e+KIaLLDwMDm7EHXvG8RWDfg1HGz5SUJgkoJ8CuJZFd0bhs5HXD/AWFgPhvbnFwiOAExkkf3QBb1acEwKfemYqdyzKT/dAyezX6HLHNI0fLWNwsSX1PMqJuN30M76Tx8NBYka4PavOQF/vR6WXtWEWqwoWyYJl6OhkpFKfssjYtViMqOmGshTt3xBVNRG8enFQ9l0advbstQEm8tbojuiPwfoEXFRs/jMfojehT283KEium18OgDEkryRwUc9psOeRFjY9xsmnfRrpX9KsyF/vDn5c/xX5H8IXPmOjCFvv9TDN0yoIUJsWpGBwmm/sByZ78sOQOyrxM6c1xNxKbEIrITIzbI2GSp6AqxRzN6Uj9+qhWZvpzfdHguWGePd7/1umIPHajtXtcI5ZSPhx8VDQ22swV1T6HcPJ40t7O9uwTeFToFnnHWuRrvynSF0+DBj50hP0ck0Zux4J/9bLrbiKcYX7N3NfbTbIM3HleNnU9 SRbUVoRm AHT27Efk4JN3O/gJnDJRYqRoMYgYrDBfHbOGcaDOIjfnFf7ml5M5vUjQiQ5jW2qvWpBcEVB1AD6bRtADgMjcCyvFIQ9lXjbqsAwdrceukSJktUscyGbkr4nk/7iVIWbvkJqE28u1aL3OyQ1mltjMoRfYTQteEkvofgMPIM9cOvQtGYK/LA39E1Av9ptOe+yO3rEuePXX0soyk6VJgmnMcTPz6r0SJttpIP9V8voRm2mmZGJATISrXgGW1ALI6EjlM0+5Uw50EKvV/T+D6qv/s/fXfOtVsp/zcDWrV9Ej7Zo5fyRJby50caJ1kOn9XbsZbxmVb34lP60hQe7c3hvbsf4MOIklLhn8HIHXuOaZWc0VyWj5327jgDV4NMsyoEJfwHHWzFb68pcCph5fSXUrgfOg+tGhllju5tlCCPm0Xdx7MGf+4luJi4AfJPsTp9P47fw1ZzCqRZLZvuWtVK7zZF/ySISVigia6IKPbTc+CwYngCxPUKPRya92nTjscJheXZA5AJZNXEWmQ/E+giKWM4MvhzrrWNrfXn/Qx+umogsJqWs4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010473, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.03.24 20:07, Vishal Moola wrote: > On Mon, Mar 04, 2024 at 07:07:17PM +0800, Qi Zheng wrote: >> Hi all, > > Sorry for the late review. Thanks for looking at doing some ptdesc > conversions. This patchset has the right idea and looks *mostly* fine. > >> In this series, the [PATCH 1/3] and [PATCH 2/3] are fixes for some issues >> discovered during code inspection. >> >> The [PATCH 3/3] is a supplement to ptdesc conversion in s390, I don't know >> why this is not done in the commit 6326c26c1514 ("s390: convert various pgalloc >> functions to use ptdescs"), maybe I missed something. And since I don't have an > > It's important to keep in mind the end goal of ptdescs, cleaning up much > of the struct page field misuse by standardizing their usage. s390 page > tables and gmap are similar but not the same, so the conversions require > deeper thought. > > My initial "Split ptdesc from struct page" patchset tried to focus on the > most straightforward, simple conversions in order to introduce the > descriptor and lay a foundation for future conversions - you can see some > more complicated iterations v6 and prior. > > When converting to ptdescs (and any other newer descriptors), we should > be careful about generating superficial code churn instead of using > them to solve the problems they are trying to solve. The gmap shadow pages are page tables that are not linked into the user page tables. I recall I raised in the past that using ptdesc from them is confusing. -- Cheers, David / dhildenb