From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3546DCD484A for ; Wed, 4 Sep 2024 14:52:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE70E6B0298; Wed, 4 Sep 2024 10:52:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B96006B029A; Wed, 4 Sep 2024 10:52:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99B4E6B029B; Wed, 4 Sep 2024 10:52:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 746A46B0298 for ; Wed, 4 Sep 2024 10:52:31 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 29D4BC1289 for ; Wed, 4 Sep 2024 14:52:31 +0000 (UTC) X-FDA: 82527346902.22.7183CB0 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf13.hostedemail.com (Postfix) with ESMTP id B021A20007 for ; Wed, 4 Sep 2024 14:52:27 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=HaOeISB1; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=wVC+gZnC; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf13.hostedemail.com: domain of steven.sistare@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=steven.sistare@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725461477; a=rsa-sha256; cv=pass; b=GrcDYYXExTs8mcEsH053dKZ8XF4V8Mrn7AjVzuG7LdgNfRpFVUfOR5kWRlqoONkKEzTycA ynvBhXg+TxBGF6+UXKwFIuJyy87IA7omOyt1a0YkdAyUVJHtJLBYAtmjHx6Nxbuoou9RtF IKeZ59UL4INk6zkrvUBFt13Oppm0oKI= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=HaOeISB1; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=wVC+gZnC; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf13.hostedemail.com: domain of steven.sistare@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=steven.sistare@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725461477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VHLK2dAsAf6JlJQN6sTsV3yMijCNZzK0Zps31JS5zHU=; b=5YL1wugRdzTqejhBS+xf1J7sgKekTZ55FRdLvkfpcW/YGBdNc575iGWu5hhtn0jAegHnfa IZCga5GdgBe3XRumx/gWnRvVDUOLOJlqvxapoBb/FBn9gkTM2IzyxFV/8HenmbwwpD9eSx gaAkN/nQWfP3LHl3faMDXtLIIEwKpwI= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 484DXVHu002390; Wed, 4 Sep 2024 14:52:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= message-id:date:subject:to:cc:references:from:in-reply-to :content-type:content-transfer-encoding:mime-version; s= corp-2023-11-20; bh=VHLK2dAsAf6JlJQN6sTsV3yMijCNZzK0Zps31JS5zHU=; b= HaOeISB1Stb3u9vV/JBf0NozjRmE6aCearv/FP4yJJ7CCLRnsk+5DCUj8/x2dypV /EQSxgwHEwvPIAULbmbMP/KVa7GwhFbtUvsUlRwDfnooi2J9kAGEMaQS5WRrn/iB cRZy9FTqHS5kqB7IBeHml2VMgQtOMF7s8K9xW/7eWsjndI9p2mZK0NPFgntjoUzY t9FNHTCB6r/p0x9epl88lHQ5p72NHTngd2DmHWd2/ns6HPIV0ppqpzQ7MC0sJ60x 9dee5nA0vI2suzuB47o0rk0AG0iCD7LpnehtkMXlXC+f5GiwmfDC+PgK/KM5Q344 IAFKDw6z0e0zoQqDts/Pkw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41duw7us9p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Sep 2024 14:52:22 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 484E1f2j036720; Wed, 4 Sep 2024 14:52:22 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2100.outbound.protection.outlook.com [104.47.58.100]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 41bsma6hkb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Sep 2024 14:52:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kTuafgg92Du4zoFSGmruUAAQC7iAJZzErqP5PYiVqIioQBQhmrMND+Q9pWElN6aYVBSGN76X846AaLIOVSlXMI0t05xbVq58UWgf2chZ/smikdOAGOfWCbaRVUocSg0Nwls4rOK3M65wk3du4tM8R8ZnsergiYkAk+EMiKsbJgY2V5XY34RseIx97nYFJ30HKhzTl3yK/aZ2U6eD4kUWXXgL738YDwUyskc/ohKOhtnlLDYSqSIeDUJnIdmeJeBpbsBA5s0+RYztf+UMbXSzExRvV2CXkzKRQQsKcHDghML7lByM2R0O1KxagRQJUh5wq1AKFQQuWgpCsrrxFoELDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VHLK2dAsAf6JlJQN6sTsV3yMijCNZzK0Zps31JS5zHU=; b=Cqo44mRTV5GHUf7RFAVBI4Mqeh1raw/8w3CDVCytgPE7uzZkPTpXhNNqxqVJM9ZfINUtPWAcKFKTnHFHNJCgA251NqOPKXVAeyucOsbA5ei33t/jQBRMBEDIIDYdh4+qMXA2xYDTakVmw4cnolnMQjt5lOyDxO6GkceF2V7/oeyvFazuuVXXZASo3ZECSeXBP1Os5qoNAtk4XfhHFRk2G1yezpqJ/NBU8B2CFsVvM8R2BADxDvR2FvlKFIjuLud/nzJMOY1/HlimZ5imme7CEsov7r4SxarRQzNBABtoks3jZhHPNp42+weaA0kQ5J6thTsstK9BsYpJ7F6I2MRUow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VHLK2dAsAf6JlJQN6sTsV3yMijCNZzK0Zps31JS5zHU=; b=wVC+gZnCp8NDxSecwUsgb/er4owOaIoMWckqR0DuQmIkuhxDTc7K3eryYRCH280eHzhGfUHo/1bKUKImyDVNd5pZyv9/k5EwlZuORaYl2AHPka4DaIWeKx9VQe+3+4Q2g2IwfWdMkEhn+67kNMUBCjknvpif1qssLqO2GGK5WyE= Received: from IA1PR10MB7447.namprd10.prod.outlook.com (2603:10b6:208:44c::10) by DS0PR10MB8102.namprd10.prod.outlook.com (2603:10b6:8:202::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.14; Wed, 4 Sep 2024 14:52:20 +0000 Received: from IA1PR10MB7447.namprd10.prod.outlook.com ([fe80::f2fe:d6c6:70c4:4572]) by IA1PR10MB7447.namprd10.prod.outlook.com ([fe80::f2fe:d6c6:70c4:4572%7]) with mapi id 15.20.7939.010; Wed, 4 Sep 2024 14:52:20 +0000 Message-ID: <5d17d797-673d-4b2a-a524-b52918d39f95@oracle.com> Date: Wed, 4 Sep 2024 10:52:16 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 3/5] mm/hugetlb: fix memfd_pin_folios resv_huge_pages leak To: "Kasireddy, Vivek" , "linux-mm@kvack.org" Cc: Muchun Song , Andrew Morton , Matthew Wilcox , Peter Xu , David Hildenbrand , Jason Gunthorpe References: <1725373521-451395-1-git-send-email-steven.sistare@oracle.com> <1725373521-451395-4-git-send-email-steven.sistare@oracle.com> Content-Language: en-US From: Steven Sistare Organization: Oracle Corporation In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL1PR13CA0282.namprd13.prod.outlook.com (2603:10b6:208:2bc::17) To IA1PR10MB7447.namprd10.prod.outlook.com (2603:10b6:208:44c::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR10MB7447:EE_|DS0PR10MB8102:EE_ X-MS-Office365-Filtering-Correlation-Id: c8f8f0b6-39b0-4a99-099d-08dcccf12d58 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZVovVkp2bXdUYVZ6U1VSMVRneWc0bFZXVHdUUnJjNVlyQ0gycW5sQ3VnTE9J?= =?utf-8?B?NlZCRCtjMFRxd1dSb2NOdFFBZ3hWcDZ0N3dDai9XRkNsSmcvZG5hMDBYQ3I4?= =?utf-8?B?Umd4L25idHRaMnBtSzJQd0ZMeS9GZmE5Z1BUT0tSU0oxa3hqc2xqa2d1d2Vr?= =?utf-8?B?dXE2b1pXNVl6c0VsVklBTlFrVUdqRk9MRzBmSUd5bzZpbFVrcVRvdU1oL0Nl?= =?utf-8?B?YUlJKzVYcmxJMkN2djR6NnVJZit4OXF6R09SQm9TeU1SZUs4TVhKYWpwVURu?= =?utf-8?B?RjIxTUFOOU1uNWpLK3Bma05qUkU5Mzl1a1N0b1hYdk1TSDh5SWs5ZU9uVU00?= =?utf-8?B?VjZKVzZOcmhHVnVnVjV2KzEyRTQrQURXbmpXdHA4Z1o5clBTd2FGYytvMkJ1?= =?utf-8?B?eVgyUDFPSXpUV3A3TmVkZjBQR0VBRTN1OThKMGwySXBGcWpjakRxUCtBcFlZ?= =?utf-8?B?WndOT0hwSkNwSDRpS2xZU0NkNHB0MkdjcjlPSkhRYS92SmJTaUpac1BSRGZx?= =?utf-8?B?OFJQemhEQmE1dkZUMkNlOHM4SWNNWTJvNWxQOUc2OVRnNncvWWd1cWtOSU1M?= =?utf-8?B?S0d2dFRZa3NYQ2JOaDZkZkYrTlhjR1VvcWltTEVCbzlqY1JhSXJiRjlWc05j?= =?utf-8?B?bVhZU1F6MGRld3FraFcyTlRyM05mOEpScVNDdnE1K3FBNW1wODNpU0ZWaXlp?= =?utf-8?B?RTdha1lLZGlmNWkyVnhxY3VGMjFEaVFHYWFTYzlJWkhjZG9vM3R6Z1pOOS95?= =?utf-8?B?UW8zQkVvdEsvT1VaSWFWTkN6czNHTVpwbm0rM2dCZjRVeTFIM3N0SVdHZ011?= =?utf-8?B?WWdyUW04aFFBOXhGWk5CTmRvbmpKYnRKSUlFdlZFSmNCRnI2eHZRMUZMSndi?= =?utf-8?B?RnIrbWhTOGM2cWdXSGJxWGtrcVByMTNyRkIva0o5YnE1WlhMUlA5WTd5L3Bp?= =?utf-8?B?MVNrS3J0OEd6bm55N3JLbWczNmZuSnNqUTRwd2cxaUxlaktXYzkrMjRQd2J2?= =?utf-8?B?amFqaTRucHZvR09LUU1lVlVhN3Zlckh0TW51MUpKcmJGODlCWGpOdW9GMzEv?= =?utf-8?B?amZkVFRZTFZyanVFaWJuNWdrVU5oZ3VUVnRqZnNtRWJJUjRuZmN0cm1RaWQ3?= =?utf-8?B?L09Za3prU3BPbFM0ZWFSSHM2Uml3NDVSUXZjcXF1Q3BsemhjNGlkaEZHd0Fs?= =?utf-8?B?OERNMDkzLzc2dDFsQkpyc040QVQwZW52NEN2TG5YYytHcFBxRVA4SWVaOW1Z?= =?utf-8?B?ZVVuREJkdjNXeS9jMHBEcVZHczhDTFg0QkZ4UjQ0cE9XY0Y5c0UvNS91OGgw?= =?utf-8?B?VlpzM21NRFpNc0ZnRGhBQjNpQUV3TTd3eno1cUNFb1VYK2JabUxMYWRGS01M?= =?utf-8?B?MzczekxuaVU0T3NiSlR2SE1mT3JMSGU5TjlEcHlGVFM3SGFrbVU3NjJkaVli?= =?utf-8?B?STBUMmQ0YVFwMXdPUExWYklETzZWa0ZveS9DT2NXVHJHMThuYnUxTVZTTEtC?= =?utf-8?B?MFplTTlGak1QZldVQUdSRjBuNDI3R2x3b1YyOHZqeklKWm9TcTh1N0Z5a0Qv?= =?utf-8?B?SVBxa3ZUdUx0RlZPMHpuVnVuaEpCWmdDbGQyNVd4SDBoZi9waXliRnEzQ0FC?= =?utf-8?B?dVVNdkswMXRzSHNyRjFWU1VGaXBnTEZIbHM2Z0FESU9jbmt0RkQxUGFudmV0?= =?utf-8?B?RGVyMFE3RFBXZk0wK3U0amxINmV5eHptWUc4RE1rSW9lYllmWnNob1pFOFNI?= =?utf-8?B?ZktqT3Fta3B0YmlkN0UyOS85bUFoOEEwbjFhWEdxdXd2eHJIbWdId0RQZDVT?= =?utf-8?B?NVU4WVlDRkZFVFVXeitXQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR10MB7447.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkQyb0NvRkg5Q1RERXpaOWJhbmk2TjJ6bGx5VkhSajdSU0VRTnBQNmJIOHRS?= =?utf-8?B?akdBaFhRaWc5bDJ1WjltZlM1U2lzaENoSHRETThnV1FUVFlVcUpRL01lelJJ?= =?utf-8?B?N3RzUHl4Yk5sZThOMk9jbFRDMnVQQjBxdXJQckVDV0hVcnpLOERTZG8yYzZP?= =?utf-8?B?ek5rSGRCNGJWSXZQQXE5VE42UWpTeFYvS2xQTk5rL2NDd0p3aDJrVlRSZWtR?= =?utf-8?B?enMvY3NTUTlINXcrdzV5QUVmb0Z0TVY1Uk83ZFNLcU4veGdMSVlKZ3BrT1Y2?= =?utf-8?B?TUNxYUQxc0JwNDA5OFRhYVB3QkdmRDNnY2VlYlAzNzhZMnBOSFRTOFNQYjcv?= =?utf-8?B?NW1Bd2Q4djFZbGpkWFFNWXhLa0tDNjk0dklCZ2JXRFhoMkd2ZVpaYjZibXU3?= =?utf-8?B?bU1XK0doSHd0NUpnVDFVU1VNN2F1RjVmWi81NG0yenFxRmNxeWdkK3JqTzRM?= =?utf-8?B?Mnk0dEN1cmx1bzNFcVBtY0Z4VTRYYnVya1cyUjdEUEJscmdOQ1BrTFpZWEZz?= =?utf-8?B?S3R0cUIvTE1HUHYwRU9rZjYwZjdoU2RUeERmN1AzTjZsUXYyVlNxVnM1Q09x?= =?utf-8?B?ZTloWUpkNFNFNHBoZUNSb0ZzaGNROWJIYXZadnF3MkhJV0IyZEgwcVYxdTJI?= =?utf-8?B?SFhnYk1uT1hqNUFFemZNMG4wVDMrWXRJUUtkcmNiUi9abjVibWt2dDNFaTZB?= =?utf-8?B?SG9Oc0RZL2lNa0g1bW5aNVpVT3JPNEFqdXd0Zy9CcS83SnpJaERGZUU3ZHRw?= =?utf-8?B?WlZkNFJHbFk3K29iOHJ3Z1ROQmU2VldiWVZodXgvZjY0akFoYjZORFpSWWJP?= =?utf-8?B?d0hCRE01VWxhWHVTeFJzd0dTcUhrNlBHUHl1akduK2RWZzEvVE9WZjN4eTJO?= =?utf-8?B?anBhR2NCdU1QQTBHREFjMkEyMm5aeEdYTEVwbmc3aEJVUzdKNlpsdURYbUFm?= =?utf-8?B?S2sxSTN6M2VFZFRUWnIxNHZjcURFckVYdVZmNG53Vk9ucUhCSnRHNTUvNGtZ?= =?utf-8?B?OVg4a2VIS0Q2SGQwNEF0MUpabzJPSGpjZGVuOUJRRHo2dm9qUy9heDdWOU9Q?= =?utf-8?B?MGxuY1h1SEI1Q1psUkR3MFdlN0JmKzdXWmpudG9ZaDhuYXFmaVUwdVE1NUo2?= =?utf-8?B?YnA3OTAvNzJUV2NUVGdjdjBoMDA3Ull5QTdUbDN4VDdTQ1pta0M4ZHlYU1dP?= =?utf-8?B?UWFwUGsxSDZ4OHh4bGc5eHppQ0RBRi81d0dUU2lGSWlEdFZoYU4yUWdVVnRT?= =?utf-8?B?Q0k2N1V3bUtyck43TlNqamNFNC9OczdDWmdONFdaS3ZlWWIrU3hHcEtZT21x?= =?utf-8?B?SDVtbUlMblFrYnNXT2I1ZjJSV2Rwalc4RUhVaEQzd21VWkk0citSQlBsUG85?= =?utf-8?B?OE9yNmd0TWtucTF3dmUxeHpTaVdDUWJUbnN2NUJoODdVV1RkdHp3elBEdFhH?= =?utf-8?B?TGlZOXRCTDl5M2JFM0wvV21rZ05ESnJPbjVscVUwMFU0TktPVWR6eTlmN3Zh?= =?utf-8?B?SzdSbmV3azROMXBZUHhpeWVvWGZoUC9JZnhlSjNDODg4bWZ0eXVZT3B3UHpi?= =?utf-8?B?WndqdXNWZTFQMmVZSnNLdXRuYXhQZVJUTkFKOVAxZ0phSm4weTZwbnZWdEhL?= =?utf-8?B?c295ZDdDYzVmY0l6VnFidHpjcjZUU0FvT0pYbUl1aUhNRWxYSU41RGt5TjJV?= =?utf-8?B?MVA3Yk5sYWxtOTVFaU5NSm1tQ0RZUW5XOW1tQ1ZHbWlkWU91TDJJOEVNVTdv?= =?utf-8?B?djJWeWdNS1puemFzNnZXL1dNYVVGSDVrbDYwakdRT3E2eldjZzZOUEV2UWR0?= =?utf-8?B?U1ZVUTV6amMwYlh4VEZORFdtWVprbGlhQzB2cThOKzFwc0xkcW9CSVMvMnN0?= =?utf-8?B?SlRJSUNUYXVxMTVzNUVJOVd6a0JWOGZycDBkOTlQcVFra3JTSnBrcWRWc3NB?= =?utf-8?B?TFZBdGIvOFE3ODR0M3U3NTVkTndObExaVjIzODVsUmRtQ3g2YlVuL1hhckhP?= =?utf-8?B?NlVOQnp3SGxOQWl5M1dyQlQ5eWczMkpZQ1J5dFoydzlVQk0vU0pkalBGSGt6?= =?utf-8?B?emFRai9ycEtnVFBPbExYd0ZwNVZpcUd5OGRBNWJ4bjZBRzM1c1pYUWlZenp0?= =?utf-8?B?SStjK1ZBSDhRdVR2TU00dXUxU0dNQ0hnR3ZBcU1VRjdUL2h6VXNYRHY1QXpk?= =?utf-8?B?Q1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: YMs4+ZRzFPYivmLYkLD1QO7aD7sOF71D0+GCtXb61BGw///sAxVEA+ScqlLxiJ7YPaFTjNXCrXkXeHNcXm7RYupDJVg+yGGNkLdQLIfy/5NaNOZ0oZodrtk6x5HiOTNcpj6vHc0hZYE3ENknIGGPZvkmr9fmnd88huAhI+AXplY3NkaBmrQ5Dj0CT7RAzN3l8y8LX2xLWJfYqy0Vcw/B4xsbVFgPB0wV0uOvLv61nS0+SR/7vt2DPikJOCjJyo6IK5a549hOAxzUVpDrv5TqJfsHbQ8ONe+ghQ7m2rZIYI8GW/ljfSW9MsHt+68K+qPTiiAz6kpxmcBi0SHiAinFDqihIeD2mupVx1uAMp0MWv4pH/t6JxP+5GhlfnVwYq80VVtcMIIAF2OJBLQeDjUyT+i4lFj+Rq5jPcWaiNN55gS7LPKbIHNkJyuM/L38ts0wEXrTC9/wSFVWzaZTppfPRLAT7zvIpkCY3VO1vlZ2Wlj7YZnfR4inul8Z+CQg6V9eI11Dha6zxwBRjWD9tey4cqSGS0EWvhnkHNRdZi294hVVIIeTIBmHdG7d4b0CwzfihvYwW+mU7OhmUPhqHxbyq3hMqBsdWtDhPD4bdGNZXYI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8f8f0b6-39b0-4a99-099d-08dcccf12d58 X-MS-Exchange-CrossTenant-AuthSource: IA1PR10MB7447.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2024 14:52:20.0645 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I8rTflYKprIDkJ7lQ1NkjqClFLBnzryrTKLflBHSS+ZhRXvPo7pt407pk2tDdIpLDocGIcPprlayL8L54hoZqgMkTzFa+onqWOlizsJJP2E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB8102 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-04_12,2024-09-04_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2409040112 X-Proofpoint-GUID: 4nOohmeox4ghlN5z-2pErdAcRa4DPFbL X-Proofpoint-ORIG-GUID: 4nOohmeox4ghlN5z-2pErdAcRa4DPFbL X-Rspamd-Queue-Id: B021A20007 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 8y9n4n6i9rnyr9m1e576qqzkh5oj1i11 X-HE-Tag: 1725461547-695084 X-HE-Meta: U2FsdGVkX18AdECmpNhRzbrMHWae88SsFGIU35tqOaZVYqKLPKk+FFQrIM1NR5ABK6ItY84k4U4PPiuankDuvj8ath6n/PzEEg7i0aVKZbL5f2wplvMMgBIXP/gy9o1E2UzJSHE4Sl8nm85RBAHcX1VUXVsj7ydUM2x3xQsc61tt954mWSU3OzJ61dVj4DqYH+ylo+l/KOp6bFXqWp5m+YTFA1ediy3auvgPybqxPKGNFO+boe9xeGVe/xoclveJEja57D3AV8cr+TD5+6FY6QLNhJgg2Idl4BmXy/AYqIMzp1SglZ3YtQX80qipc2draUbLiZHczy9JMCQohMO8txCSjNbmirLB9IwU4RMwKD1r/uMy7MCpBjMK54+6ttbQZlxrmseUJg9aMWIM+diZX6BCvf38agl4KPa+xPoskZnZmvcUc97G4OChroJgbqbFUi0V4hAVlUUPdwE9VGQr0oHv4bafD0XWlIpOfSuARoQJUl/nx2L+qOqDIu2sT5bgGoDmfpIMVrsXssedOro7RTd+MP9kk2CPw/8wlNncVt7m5RGlTjx5G31TirZiH8kIuryWd+NDVxxJbztjd0Wpw71i5WV4xGHjajsMZMOfl9KG1T/hPaJm3kepUVA0+1C4zFsdvU5cq0fIOq5IhvwwFTXMB+IuBs5i/CuKHqb2qvpWaBQQIlgSrM0OppJm6SbFfEtyz0vFQhRaoblDccN/2sE6HGjl4JxGOkuHemEDRmCzHfdKG8Nr42w2c9nutWB1zsRsrnpDZg2lDVRoewgeUZnRK/jhLaLoYosHxsZb6jmhkJ5csRhh2EHVtGWNzw+9TYjXTBHFkGqmnWxl/Av5/PerwO+pAe39SPQKDD3EGqbuLN/blPBp8BS1Y3SuUNuY51pLuEmfALl/a363HDVDv0cqkbO3fGqUegE1W92RIQDGEcgFVZ7bvMUNN/lDfCKOGHRjP9MS/CzoWhZxocu fQcv5LJu 8Ex/yHFUrdzgGk+5m/lq3rdj1/h29gVHbSXELEUF+ZGm6bRprIRrtAmALG0AG738UHaDe/KnYqo2XfYBvl8QRkpb5rU1p3oGFRKFBHu04fl09QiqJY2xCiUsnny+xwqtJqKmfBm94A6osonsjP25C3BEOGF1wbXgayNNUZeffVXoR/KL6sk+TFXfyMraa779qh0T2jweMMfq0sAbNQp435vKiAb/bKgaC5K4hcSUJ12XKn1qJ9S3xMGE/0C9PAmgOGOEbWjUvKo0Arb14CbmL6GTKa8pxxkzT618VKDu+Np3rd7NQBnCNuQLuMoO/L1xq5T3RIVuWJhzDPFHocV8lHUn7H4LNCu4sr0lCn7bSmoviAZExntJcvZuXQIOTPf0zhrb8OmYTNoc08TuoFkFicpTglnnrcg6ukaHNtn5kPBZx4bFiU4B0UIW3lsHFIE3qgfAJH3c9gvuj7ijZ/4CY6hl22NQlDyQX0zng8Zs43ykGmgGsYfAXQSuNU3xpIvAjxjBj3M1ZwYdBJ7fUWrhv/YqAuPctQhwezpKQwGk8oG5G5uP64IRuE0DbLzQ0NNxlReRkuxa7A2Ixq1t6ImDsi6YoyyOAliN8HJTMsOmNA92wkU99mCNa+ysmYn3B+ttrscdn6/icwwL0jpjWAL7GCIZlw5fvJAaUAegbhBlzEP8WsHEuKBomY8eRNcM7in4pQlQv/+dQgF56Th0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/3/2024 9:04 PM, Kasireddy, Vivek wrote: > Hi Steve, > >> Subject: [PATCH V1 3/5] mm/hugetlb: fix memfd_pin_folios resv_huge_pages >> leak >> >> memfd_pin_folios followed by unpin_folios leaves resv_huge_pages >> elevated >> if the pages were not already faulted in. During a normal page fault, >> resv_huge_pages is consumed here: >> >> hugetlb_fault() >> alloc_hugetlb_folio() >> dequeue_hugetlb_folio_vma() >> dequeue_hugetlb_folio_nodemask() >> dequeue_hugetlb_folio_node_exact() >> free_huge_pages-- >> resv_huge_pages-- >> >> During memfd_pin_folios, the page is created by calling >> alloc_hugetlb_folio_nodemask instead of alloc_hugetlb_folio, and >> resv_huge_pages is not modified: >> >> memfd_alloc_folio() >> alloc_hugetlb_folio_nodemask() >> dequeue_hugetlb_folio_nodemask() >> dequeue_hugetlb_folio_node_exact() >> free_huge_pages-- >> >> alloc_hugetlb_folio_nodemask has other callers that must not modify >> resv_huge_pages. Therefore, to fix, define an alternate version of >> alloc_hugetlb_folio_nodemask for this call site that adjusts >> resv_huge_pages. >> >> Fixes: 89c1905d9c14 ("mm/gup: introduce memfd_pin_folios() for pinning >> memfd folios") >> >> Signed-off-by: Steve Sistare >> --- >> include/linux/hugetlb.h | 10 ++++++++++ >> mm/hugetlb.c | 17 +++++++++++++++++ >> mm/memfd.c | 9 ++++----- >> 3 files changed, 31 insertions(+), 5 deletions(-) >> >> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h >> index 45bf05a..3ddd69b 100644 >> --- a/include/linux/hugetlb.h >> +++ b/include/linux/hugetlb.h >> @@ -695,6 +695,9 @@ struct folio *alloc_hugetlb_folio(struct >> vm_area_struct *vma, >> struct folio *alloc_hugetlb_folio_nodemask(struct hstate *h, int >> preferred_nid, >> nodemask_t *nmask, gfp_t gfp_mask, >> bool allow_alloc_fallback); >> +struct folio *alloc_hugetlb_folio_reserve(struct hstate *h, int preferred_nid, >> + nodemask_t *nmask, gfp_t >> gfp_mask); >> + >> int hugetlb_add_to_page_cache(struct folio *folio, struct address_space >> *mapping, >> pgoff_t idx); >> void restore_reserve_on_error(struct hstate *h, struct vm_area_struct >> *vma, >> @@ -1062,6 +1065,13 @@ static inline struct folio >> *alloc_hugetlb_folio(struct vm_area_struct *vma, >> } >> >> static inline struct folio * >> +alloc_hugetlb_folio_reserve(struct hstate *h, int preferred_nid, >> + nodemask_t *nmask, gfp_t gfp_mask) >> +{ >> + return NULL; >> +} >> + >> +static inline struct folio * >> alloc_hugetlb_folio_nodemask(struct hstate *h, int preferred_nid, >> nodemask_t *nmask, gfp_t gfp_mask, >> bool allow_alloc_fallback) >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index aaf508b..c2d44a1 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -2564,6 +2564,23 @@ struct folio >> *alloc_buddy_hugetlb_folio_with_mpol(struct hstate *h, >> return folio; >> } >> >> +struct folio *alloc_hugetlb_folio_reserve(struct hstate *h, int preferred_nid, >> + nodemask_t *nmask, gfp_t gfp_mask) >> +{ >> + struct folio *folio; >> + >> + spin_lock_irq(&hugetlb_lock); >> + folio = dequeue_hugetlb_folio_nodemask(h, gfp_mask, >> preferred_nid, > I am assuming a check for available_huge_pages(h) before calling dequeue > would be redundant as it would simply return NULL if no huge pages are > available? It would be wrong to check available_huge_pages() first, because it would return false if free_huge_pages == resv_huge_pages, but at this point a page was already reserved for us in resv_huge_pages, so we should always succeed. The invariant here is free_huge_pages >= resv_huge_pages. We simply do resv_huge_pages-- here, and do free_huge_pages-- in the dequeue_hugetlb_folio_nodemask call stack. - Steve > Acked-by: Vivek Kasireddy > > Thanks, > Vivek > >> + nmask); >> + if (folio) { >> + VM_BUG_ON(!h->resv_huge_pages); >> + h->resv_huge_pages--; >> + } >> + >> + spin_unlock_irq(&hugetlb_lock); >> + return folio; >> +} >> + >> /* folio migration callback function */ >> struct folio *alloc_hugetlb_folio_nodemask(struct hstate *h, int >> preferred_nid, >> nodemask_t *nmask, gfp_t gfp_mask, bool >> allow_alloc_fallback) >> diff --git a/mm/memfd.c b/mm/memfd.c >> index e7b7c52..bfe0e71 100644 >> --- a/mm/memfd.c >> +++ b/mm/memfd.c >> @@ -82,11 +82,10 @@ struct folio *memfd_alloc_folio(struct file *memfd, >> pgoff_t idx) >> gfp_mask = htlb_alloc_mask(hstate_file(memfd)); >> gfp_mask &= ~(__GFP_HIGHMEM | __GFP_MOVABLE); >> >> - folio = alloc_hugetlb_folio_nodemask(hstate_file(memfd), >> - numa_node_id(), >> - NULL, >> - gfp_mask, >> - false); >> + folio = alloc_hugetlb_folio_reserve(hstate_file(memfd), >> + numa_node_id(), >> + NULL, >> + gfp_mask); >> if (folio && folio_try_get(folio)) { >> err = hugetlb_add_to_page_cache(folio, >> memfd->f_mapping, >> -- >> 1.8.3.1 >