From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90642E9412E for ; Fri, 6 Oct 2023 21:39:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B67F8001C; Fri, 6 Oct 2023 17:39:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1673680008; Fri, 6 Oct 2023 17:39:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 006E38001C; Fri, 6 Oct 2023 17:39:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E55BD80008 for ; Fri, 6 Oct 2023 17:39:37 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A67F380181 for ; Fri, 6 Oct 2023 21:39:37 +0000 (UTC) X-FDA: 81316353594.03.1C522CE Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf29.hostedemail.com (Postfix) with ESMTP id 8A24E12001E for ; Fri, 6 Oct 2023 21:39:35 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=JGlYFrqw; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf29.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.208.174 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696628375; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PT6SEGOGkAQe0ejKNRIEG3Mg0RqGqWFejjM93l9xq5k=; b=Tkst9BlcWePSB3/TVwpjInKSEqcjoN5zcXYCQyW29jcW4gSE/Qm2MpbqliKJUm6Vnb1rSg CxusJvTPt5QYK8uin02fmW+DrogM7pfpL8zXNJR9DwuiLg9wCwjtLMpOccp/1g6XT/k/V2 4SMy4v7gsXqSiC8jfmHBMKfyV/YXJ8U= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=JGlYFrqw; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf29.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.208.174 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696628375; a=rsa-sha256; cv=none; b=fm6IE1gL2wEzAaM22fCqLA1thBeVgkf3czxudw4jDUccKaOkV24R8LWJdHK8DSfYLTrVJl c11aTROVUiOvuDBoCZHSH/wRkbPzb3U04OWEX7E/2sv3V46MBVJ1GYTeiS59KsQ+V/AaZK KAY3pzj7AELTcYGyftsHXhMXMEZTobE= Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2c16bc71e4cso30542071fa.0 for ; Fri, 06 Oct 2023 14:39:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696628373; x=1697233173; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PT6SEGOGkAQe0ejKNRIEG3Mg0RqGqWFejjM93l9xq5k=; b=JGlYFrqw51AKCL9jCgVDjtcpMHmlML43m5Pr6Nn1aNaXsDmP9/X8E7Jz392U7M/p5K NvWWb4NpOmBik+qUASxWkKn6lVT2YO1yHR20X/TyKGsRKzVOxj8nmF7C/tdq/LEUuGfk bPO2TqxVVgGZe4RH2oTHRbdNzIgohejs/FBYe9Y6lHljhbT36rMuEUY6835DhP6jXW0P ZmfTAOk1sKpPIhUvsbGmeetEoJxxySC4MuAaetuBxtw/SxMNJ1VeEvOfyVQ/HRuwftu7 DlZBcVUYqbUcKyRlHhLE75I5HAvWUc3p2rAo2FrBRXHiACTl6OTsU09wLg0Q00qIe4WX PDrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696628374; x=1697233174; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PT6SEGOGkAQe0ejKNRIEG3Mg0RqGqWFejjM93l9xq5k=; b=g3ZmFkEZXo3QZk2Et6vWciWrFr1evPJmeX+xvVdHCX1vqFso1Ivgn1qr+SfG6HKHlV wC8bXYzGwJKn7SJYvQdh2ShVvoc8W6HY0CJQNjDe/FHQlEopMFyMS+mujZOdMIksvITH i2lyZ15nsNvrUMHgreMXmS/FMmmH3JcAAdyOrLKi4+vzDm4FZ8aOAQpJtyboqb5C0EdA E1eb4s8ZsfJYGiIHzxnfrRiRq9qk8bAuj1vJHAgdwtxzO2jeOFISk14Kf5wBgQnK93xe rA7F0C40qP5iVZkbJuE3hLz0RcP4LnJKo4n7gXt4pWaQGRQqNQ/1rY/BgL9H7gscVLd+ 6sdg== X-Gm-Message-State: AOJu0YzOQm9uSJTb1PPa93BkoXQkVWmXR6u3J+Av1VBFoHFWWG9V7e6l 0tFAQPkWexl+jfmzJihEdQxjsQ== X-Google-Smtp-Source: AGHT+IHLOGhl4bJHL/Xz4jCazed5eiZOPI0yll6JNm9DpVnTJLrYtOWQyVMcyFeBMQutFUWKp5H61A== X-Received: by 2002:a2e:b165:0:b0:2c0:23d3:daee with SMTP id a5-20020a2eb165000000b002c023d3daeemr8683153ljm.39.1696628373660; Fri, 06 Oct 2023 14:39:33 -0700 (PDT) Received: from [192.168.200.173] (178235177147.dynamic-4-waw-k-1-1-0.vectranet.pl. [178.235.177.147]) by smtp.gmail.com with ESMTPSA id p18-20020a2e9ad2000000b002b6cd89a3fcsm942283ljj.118.2023.10.06.14.39.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 14:39:33 -0700 (PDT) Message-ID: <5d14b681-a2c9-4210-a0c1-bf38708b7998@linaro.org> Date: Fri, 6 Oct 2023 23:39:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/8] hugetlb: restructure pool allocations Content-Language: en-US To: Mike Kravetz , Andrew Morton Cc: Anshuman Khandual , Xiongchun Duan , Barry Song <21cnbao@gmail.com>, David Rientjes , Miaohe Lin , Matthew Wilcox , linux-mm@kvack.org, Naoya Horiguchi , Joao Martins , David Hildenbrand , Michal Hocko , Oscar Salvador , linux-kernel@vger.kernel.org References: <20230925234837.86786-3-mike.kravetz@oracle.com> <20230929205731.GA10357@monkey> <20231006030836.GC86415@monkey> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20231006030836.GC86415@monkey> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8A24E12001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: u7fejrftyfxeopoq59kof6tdbqf54mur X-HE-Tag: 1696628375-699343 X-HE-Meta: U2FsdGVkX18lhwFFESYDLaJDtPE4BS0Xt59c+q+0YVRZaZfqrNb4TmPowewBv0ogWelqodDJlbqQBvT9QtONm36QrquX2tU6aOgfsClRgrFId1OmCI3155EtGZDdsY0rFLeOlQYiF0QEjuV/LwAcL1DrGD4CYqnPeN6/eeGfjkNbtdVIEswTtaLqh3FXeyyVQOfTLpWXnmbf8Bz5wT0K6T4gUCWifB/qgIrASWBimC+GOk34+c5klvj+UEAI3RP7FxRKaFmpRIPgEbg1zpBncD2HnC9nfP6bHAnXtoaMh8nw+rVJyMws4feXbBBC3H8PNBhokcmZqB/Q+Ns9mB2tmH+1gE7lkf96p2ArvjBEj2S4WXSvLLf82wYPeGJFUnLCQaAn8UlGmaGc+cv7JdQZM8Bc+pce6pfBM37nQLQkyRWb/QjqLmHxXRYddZz1qi/Q4x0qF4YVPz3v6g2RKNYT+kUZbbmZw3sqFysnlF2FvWqPUs9dYEaTXH0omDciNE3nTRjsa98nHTU/CCVOL1XSXngF1LxLBstbr42SIVBTJhjXw/NDGXD8ExfMvy3PTsGgZ5cDvOHZZURIN3j9uhuXlWz6sdfJSt2gOtZFhh2XDjAtWo2fq9dCw8YBdVQXHO+0OvKmnz3w/wRyV1l4RxXQeAEj3g9PW1WOHaYoWW+kTzhHgOgViCQGsuJs4Gnz6+5ZHwX7u57UM7+qnM8RZNUS/yn48mkKnDI9R7vMPUmJsVKTw0G0EgYovBpGypTon4Td5FQjyVWPY0prrKJGXDwET/V2HHdAga53ogiaeapcyuMECg/YCzAupsrgoc3xa7/el+IU+brJhKvqUFlffBXHW7eoaA9+hjOscIPGrPTDz4EZ+lM7X6MudGomw0AEv/2cLN1jnDwytJeHXQzFThD7uxbWGm3DKeYnPG1JKW6nahGX4sPMU/ECrKxqfkicsan/RzpL8b2OapC5fmOF9a5 yJotwI4E qz0AmGcFJ8ppVk5ee7FkBDmt79GmsDm1s5iDKfsv4e9PvJNTtS19pHMo//q7iXccV7HilJjVa9xIjfWWBX46100mmKz2NJKJQ/Cwdd6BeDOhVH6nUIF4b24Jt4F6P8Ls1Kjr23V1enogjj3NvXSHuqGTdJvtCAU0L31Ql0OZx9a6bW+tUxY6ABovkwqNYX2rwvmz+Hjg6x7B3hCTZ2vTo2MTkXl2CQ18v/HgPLJYOtmvIwwz6nFfiZ1LnEI9M2pKXpF/I3QTp6unRzhCg2cmukM/LQDeBs8Ac6AvJ2bJr2NqN7EYSdVi3T1+nOof51CQ0O/IuPqBNb+As1ExSJwE/LoJNUTZNBrowxbcu4VQ+yucmGV3xMWczxCYY0KPI8nZSnb44xzZDn84BHkymzFX9JgQGJqT6fXEvoxYYIQTikU2yzxgc5ta2l7B5m/9j3tOnH7p+yNDuDfBnqD46QS1p2Ut570WGQifVB8edyB5Uz4Mr8ncMTAU6BSc+hw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6.10.2023 05:08, Mike Kravetz wrote: > On 10/02/23 11:57, Konrad Dybcio wrote: >> >> >> On 9/29/23 22:57, Mike Kravetz wrote: >>> On 09/27/23 13:26, Konrad Dybcio wrote: >>>> >>>> >>>> On 26.09.2023 01:48, Mike Kravetz wrote: >>>>> Allocation of a hugetlb page for the hugetlb pool is done by the routine >>>>> alloc_pool_huge_page. This routine will allocate contiguous pages from >>>>> a low level allocator, prep the pages for usage as a hugetlb page and >>>>> then add the resulting hugetlb page to the pool. >>>>> >>>>> In the 'prep' stage, optional vmemmap optimization is done. For >>>>> performance reasons we want to perform vmemmap optimization on multiple >>>>> hugetlb pages at once. To do this, restructure the hugetlb pool >>>>> allocation code such that vmemmap optimization can be isolated and later >>>>> batched. >>>>> >>>>> The code to allocate hugetlb pages from bootmem was also modified to >>>>> allow batching. >>>>> >>>>> No functional changes, only code restructure. >>>>> >>>>> Signed-off-by: Mike Kravetz >>>>> Reviewed-by: Muchun Song >>>>> --- >>>> Hi, looks like this patch prevents today's next from booting >>>> on at least one Qualcomm ARM64 platform. Reverting it makes >>>> the device boot again. >>> >>> Can you share the config used and any other specific information such as >>> kernel command line. >> Later this week. > > As mentioned, I have been unable to reproduce on arm64 platforms I can > access. I have tried various config and boot options. While doing so, > I came across one issue impacting kernels compiled without > CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP defined. This is not something > that would prevent booting. > > I will send out an updated version series in the hope that any other > issues may be discovered. I'm pushing the "later this week" by answering near end of calendar day, Friday, but it seems like this patch in v7 still prevents the device from booting.. You can find my defconfig at the link below. https://gist.github.com/konradybcio/d865f8dc9b12a98ba3875ec5a9aac42e Konrad