From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 606B3C4345F for ; Mon, 22 Apr 2024 15:13:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E51336B0088; Mon, 22 Apr 2024 11:13:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB2EA6B0089; Mon, 22 Apr 2024 11:13:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C07226B0093; Mon, 22 Apr 2024 11:13:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A49286B0088 for ; Mon, 22 Apr 2024 11:13:28 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 51A3580BF5 for ; Mon, 22 Apr 2024 15:13:28 +0000 (UTC) X-FDA: 82037511696.28.4072C2C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 784F318001F for ; Mon, 22 Apr 2024 15:13:24 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NFt4l6eJ; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713798804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XggFGBgLkmBxMCKcF+mikPzmX9ukzyj9RvHvAHhy1Mc=; b=AC9+U5YsRUOYW8xqOnEyLB1pTaNFcqk2FZvQNnpWAVNTcturu8/oY7EbjMgORCyC3hb4RA ld0aRMNYzyRapZCy2sbn9cau/wKwcj4JbPdzASUh514eAlrUDrE3a/bWNzlEpLqjJmr5YX QcZvr+0BCxLhPr7o6mWJoOYqlBJgssQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713798804; a=rsa-sha256; cv=none; b=Jm9lk90I/qcFhOcf0taoOr5JxDerjmciKzLUczWx9wgE9BrSvWGCBn6kBhU6dPK+qC8Ezj xduxVsj9fqSyN8JAxeTAEKK1orgcxzyoiDfCouUEHLbNFkkzc8b6F9qqm3XNEKA988xbb3 B71AgtfTqt7Qe43gW9w6lSBvlC2bGlo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NFt4l6eJ; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713798803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XggFGBgLkmBxMCKcF+mikPzmX9ukzyj9RvHvAHhy1Mc=; b=NFt4l6eJ2idSAxZqcjGD+B/uvtFfslZziZftWhECc+epBYNUkfTdO6y5DUfyzkcKwV/ZRD 03yEUMCSOUtjlbUEeRMTnIDSqwXrfE/4gmMKDJcIcA45GkfiE+zxGboQW6WjRDOyLqG3QM 1XHsJM/EfY/naR5659qVZMjSfRoms20= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-S_GDtmP5PvWcTYHyCnXsyA-1; Mon, 22 Apr 2024 11:13:22 -0400 X-MC-Unique: S_GDtmP5PvWcTYHyCnXsyA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4190b0735d1so14292395e9.1 for ; Mon, 22 Apr 2024 08:13:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713798801; x=1714403601; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XggFGBgLkmBxMCKcF+mikPzmX9ukzyj9RvHvAHhy1Mc=; b=VUx6AS08thnLuFd5UYg+jJXvPxkaNsFenifDwtTksX5RM84QQNIzxZB54Euk+wMBxQ W7wQKtHxFJq18qQVB2o38eO8hK516x6tdcDeX+SqgZgWzjwBDPvL/HFDZfzFSFlk6AYb GhDUiPNiscCFDBSr9lvuNulam4VbMFOyGUZ7ct4EXAUJmFDRJInPg3kKJDDGADq6+3Va WHEZfOuem2BXBN7b7lN65JPbTNoWo/RSz93Qh2lCD11w6S5VRwiOvsyj+Z78IWL59opP gSOplznsSB95h73ltaXHNIRmXjtmDkbLuD5KRhZOE9kZ2Lfnh37Qa8oYDXK7PifNoNAk YOVw== X-Forwarded-Encrypted: i=1; AJvYcCVZcC+PiwkpddTFP5eWzN1JcLcbrzgWsFLdq2EfH4Kf71v0dp+FoOBHGa/EqXgWSLd8Ge7TumD4lSIwk7y1KrAg3IU= X-Gm-Message-State: AOJu0YyIarp8AvcGDhHMgXtlOiUv72Ho1gZuL4562a2vGjRwMgvklIl3 Jw5scDokZGlJIkx6G3X4X4dzdQAi0LWkl2UsZdGtiZdnmoMCBra+D29nQHjTcew06CVb3MtmKag lWXEB+2k0K/Q0qlLEc3EzkIVWZbj3c6QMLkJ9/iQlLp2RUkF1 X-Received: by 2002:a05:600c:4e4d:b0:41a:7553:81fb with SMTP id e13-20020a05600c4e4d00b0041a755381fbmr1139794wmq.40.1713798800911; Mon, 22 Apr 2024 08:13:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdxzGTLDC9x5rcgtjXwI/A0eNiI8nBUO7Ud4wOjoBerNcw5crG9mEY3bGSCDZW7F7QdfX4tA== X-Received: by 2002:a05:600c:4e4d:b0:41a:7553:81fb with SMTP id e13-20020a05600c4e4d00b0041a755381fbmr1139774wmq.40.1713798800426; Mon, 22 Apr 2024 08:13:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c739:600:d2fb:3a8a:9944:7910? (p200300cbc7390600d2fb3a8a99447910.dip0.t-ipconnect.de. [2003:cb:c739:600:d2fb:3a8a:9944:7910]) by smtp.gmail.com with ESMTPSA id n33-20020a05600c502100b0041a652a501fsm3150991wmr.13.2024.04.22.08.13.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 08:13:20 -0700 (PDT) Message-ID: <5d0dd592-3dd6-45ce-ab2a-9e154d36a111@redhat.com> Date: Mon, 22 Apr 2024 17:13:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Update shuffle documentation to match its current state To: =?UTF-8?Q?Ma=C3=ADra_Canal?= , Jonathan Corbet , Andrew Morton , Josh Poimboeuf , Tejun Heo , Wei Yang , Michal Hocko , Johannes Weiner , Minchan Kim , Huang Ying , Mel Gorman , Dan Williams Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-dev@igalia.com References: <20240422142007.1062231-1-mcanal@igalia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240422142007.1062231-1-mcanal@igalia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 784F318001F X-Stat-Signature: 8ragyri91ua8ye59sn77ettdgodj5gxx X-HE-Tag: 1713798804-648202 X-HE-Meta: U2FsdGVkX18UP3dWA/yNW5I3Cwz1I9H1pJor2slxH7crYXW0EzihK8WFh4ZrBO4dnoMF8BlMmMwYmcO6GU31SpvuAxOPjSV4/O3iFlWNmABqmuSRltDg1aDc+mBxNkOQkrwQNTG/y1+0Ew8KfTdfo7TJLC7LOuHmSshI+9N66qrKwtF7+BQS2vZkqBiafVJ1kGhNGBJfRCWs+oSJfCfY+6Y+P1hY4NVmsVwQ/dxpWymqIg543zBW2AkRtIfqChpdnZ7ataPZoF1kBERSUzGtdEeEt6CQXf9TgVyzRWk+oncZevq1dL6F0LB2lfUMRr6s/7cGXPMITv9nr8enzv/voiheGREQIi85/F5cr11CVEZ8OH/YlQcoB31n+tPRnzYue8T5Hd13Ia/LMwgtDFSasmVAkDPfutlvIT+JtkF7xKggVoUPeCfsdt6Whd7ggJfJ4uCrGUzifhcE/Gxl6aZM+p0BGY9SuNRVTe7iPob/O/a7gCrzoSC89KmzRSCy/bOXSZ1yyknNcO2pAAOgsi03p8ujtKl5v06x4DjNOVFVdlM960eZKE0vsxvOusmwKSncj6tlZKS88LxIFuohWaPIThFWDC+mHbO82dYAyJKRZ9e+Jdd5Ab4lfjuifYJs+E/FcZv85s7UGsMG4JZj8f9EoZZkWvVrdJLfZAQBmkTizR+Sya2r4wZDuJQcdqPeF8Ox9b85VGZgByUvDShIuLvms+lFoK4vvNbOZJrA4yWVwxngfIHShq4/dt8m9YN1gNGNhPyPw+Xx5nKOxSpGDoTMOJnnWCJoeiHjw8pJgopeioCsp/SSxIE+Kqo+EeMHXS/RwrguK/qynAfdIINoNG4WFSNiWaGQW4GPZppqIV9I0WYnnXQ0vQxABF5QC41xO4A5U0rqENVitaawpYf9GoWvPeMOTFLZGH5eZeZe8dqDQ44FK8inpQfLOhnffHenhMv8ziHxSlUQI2zHHCLaKlu Xjaskp8C sLTD9sddUwRY71bDEmSw2oMKX3kXWK8SzfarWwRL7otWVWyQDZsHgOXJ4CCFjjJccX/2WHyA1brpHmkUUp8tCjuHpU49en2t9eqWAn9GvTJgwtv0RNnfoufpeDbQDvkbzPbB1EZFqK1WFD+Vvhkry0hVc2EB9VuCsqynfjwUbbSDk6zEVj19KCrP8Zn7WcqRwbfi3Ig1lrLT3YetTLri8fthsMVwTVKOWJ4szNOKhCBXvCEavLfV/VFeQ42jekeSspMK//Y58PMkr14h0RqS0xT5iofn8Ptx/4eZZMekuQPNDQFqBLyPZXTi5ZAHUCHyjW8fEaTRLrCwiSI/LPe1o5Q1iuMk2q/g1QaV3Qu1JH9sprELHaOVWhuzUyN/tfZBp+1ChcUL4Pc0tx8hM88CsLfauv37ypLuIrA9D+7fIgPLo15+ZHlkWG2Ac2weyIRzt5d+5IjYv410MRuNY5Gf3L2jmvHtdIS0zd8hnC80MYkQb8wrImqQp8vfN7isk38CVNRARpLzLbxwmRRIfQ/aT/JMh6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.04.24 16:18, Maíra Canal wrote: > Commit 839195352d82 ("mm/shuffle: remove dynamic reconfiguration") > removed the dynamic reconfiguration capabilities from the shuffle page > allocator. This means that, now, we don't have any perspective of an > "autodetection of memory-side-cache" that triggers the enablement of the > shuffle page allocator. IIRC (it's been a while), we never had that autodetection upstream; we only had the code in place that would never get called. 839195352d82 removed that (dead) code. > > Therefore, let the documentation reflect that the only way to enable > the shuffle page allocator is by setting `page_alloc.shuffle=1`. > > Signed-off-by: Maíra Canal > --- > Documentation/admin-guide/kernel-parameters.txt | 10 ++++------ > mm/Kconfig | 7 +++---- > 2 files changed, 7 insertions(+), 10 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 902ecd92a29f..924bb8ddd8a8 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -4170,13 +4170,11 @@ > > page_alloc.shuffle= > [KNL] Boolean flag to control whether the page allocator > - should randomize its free lists. The randomization may > - be automatically enabled if the kernel detects it is > - running on a platform with a direct-mapped memory-side > - cache, and this parameter can be used to > - override/disable that behavior. The state of the flag > - can be read from sysfs at: > + should randomize its free lists. This parameter can be > + used to enable/disable page randomization. The state of > + the flag can be read from sysfs at: > /sys/module/page_alloc/parameters/shuffle. > + This parameter is only available if CONFIG_SHUFFLE_PAGE_ALLOCATOR=y. > > page_owner= [KNL,EARLY] Boot-time page_owner enabling option. > Storage of the information about who allocated > diff --git a/mm/Kconfig b/mm/Kconfig > index b1448aa81e15..f30a18a0e37d 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -333,10 +333,9 @@ config SHUFFLE_PAGE_ALLOCATOR > > While the randomization improves cache utilization it may > negatively impact workloads on platforms without a cache. For > - this reason, by default, the randomization is enabled only > - after runtime detection of a direct-mapped memory-side-cache. > - Otherwise, the randomization may be force enabled with the > - 'page_alloc.shuffle' kernel command line parameter. > + this reason, by default, the randomization is not enabled even > + if SHUFFLE_PAGE_ALLOCATOR=y. The randomization may be force enabled > + with the 'page_alloc.shuffle' kernel command line parameter. > > Say Y if unsure. > Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb