From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5267CC27C5E for ; Tue, 11 Jun 2024 09:53:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A22D66B009B; Tue, 11 Jun 2024 05:53:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D2586B009C; Tue, 11 Jun 2024 05:53:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C1266B009D; Tue, 11 Jun 2024 05:53:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6E8226B009B for ; Tue, 11 Jun 2024 05:53:29 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EDA1181270 for ; Tue, 11 Jun 2024 09:53:28 +0000 (UTC) X-FDA: 82218145296.22.B57E298 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 98472C0009 for ; Tue, 11 Jun 2024 09:53:25 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Dx9x+I2d; spf=pass (imf22.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718099607; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tZME8sShk2kQ0RQHoagPPnoqrAeCpuE0ELxkCzr8HcM=; b=35CN1oTYx9VKpGQHSiu06g+eZVgRN1g5gYwO1Y6Ezpi4TBEwnkcJ5Veu/HC/BaFY7ijlmK GAaiphig9yGGJtdEL94ML1tjKOmZ/8LDx/oBeaFDZ8xdOxjnkiRkatSTayIYaMqqdqbs32 Pz7Iw0c+mNY7xYBAr5DLHYk/tKrw/co= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Dx9x+I2d; spf=pass (imf22.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718099607; a=rsa-sha256; cv=none; b=olhdBetrfXMmY0FF99H7sQyGLyKyJwH/+4Wghkb5w7Lhp2ADbrflWWyynJ/F8xNzgp70Sw lTcfDw+knRr/WNRMpa9AzSAlJ2vwf2o6u0FCMlt9eLiVeKDwTQuuvb6xDDC2KR+Rssvz4l o2bfwOFqve3nvmjVvz2x757+oqnH3iQ= X-Envelope-To: usamaarif642@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718099601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tZME8sShk2kQ0RQHoagPPnoqrAeCpuE0ELxkCzr8HcM=; b=Dx9x+I2dMTfsmx7Y5v0uA4z1QMT9EX39/98SVtUgORIbsv9LcWYlMYxd9rAQQHU0VRtZk4 tGEFSZeStmTm9ozA0tUzxCnuP0tADDb709AHv8WduazDjKJELn3BvYhVNHwmt4sT00z3rc Ur2l1rnuvnrJ2PjfDJOlPb86Ciug4Lw= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: willy@infradead.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: yosryahmed@google.com X-Envelope-To: nphamcs@gmail.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: kernel-team@meta.com Message-ID: <5d051998-015c-4da4-83f0-1b4fb9009c68@linux.dev> Date: Tue, 11 Jun 2024 17:53:06 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] mm: Do not start/end writeback for pages stored in zswap To: Usama Arif , akpm@linux-foundation.org Cc: willy@infradead.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com References: <20240610143037.812955-1-usamaarif642@gmail.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240610143037.812955-1-usamaarif642@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 98472C0009 X-Stat-Signature: bydprcfiwdd3tgwxncume6kjn7riiyia X-HE-Tag: 1718099605-360353 X-HE-Meta: U2FsdGVkX18VyPhCDEnGdEUGSm6tp4JjIus16dGVeCER+Mjo8HbxNWNw23jt6mov6+uN4INaqQKuzxmxv7l3p9Eol1/fmEjHjBXjpxtYQaMunf1U13lBt02zux+1t9+TSmaWfzY43FnNPm+Lq8NThwExkYZjNNO58rdINwYPC9rLW64oQswDQyTke0wT1V9nMHk1SZwynetNm8DVNvQLIO0P9n92saO/s7VTeFIBsDMgp6a5FjomcrUlJot1rOm1hTAmYk83QNOtk77X8cYDp+OKLsBAVeyCDKnwT+kDmr8cm4rxheuXuWrvCfedsugAWWx78pzPFbDn3QyzN9WdqxmpXl+z29WtH5ohZsd+vqmirycAoIACeZnd/gzZkeQSmVu6ogrMCm1hQiwW+vj9QM5xClzRobwzY/BcxyDOhaU0aQ0xnUCbF1054uF7iG79XhzM+gB+MggZn1hoOomCuyPEo0AEYWBlN9PCleD5BKbAW+Yl9vqnw4nMe0d9QmC12spDMbF6pSMZQX8ALYFwBvAF9dGwjEmCoHMViLsSjGlc6jzFvaOLoHuChOSGzFQGGaU7iMQPUoqRkhqd9fJjlGaCBvDekNaU7IlPy0KIimPhD6+bi8VuFj4OLwn7QwGjH76Qg/3+hmw+ilONrkbnZ0GdnCCJdQ5ULWAMebW4Wvy8dpK2F5FsWsyxD3EUZh1hALrxW0p+zzVU02BEtmW+fP9Qt82ItDQKR2j0DkrN4fG8TxvclXB77UD0g+/XgJ3I0kh23BYxNWW868JU/N+TjX1TB1DzTXbXua84Iha7NbCwFEq+n1Ll1N7oB5YgMxPNbD1K1DN9+gCeVFggDx8v1rbYTv3qUu4hm6JZmhx9rx/qZH8FWB1jlacL6qqxgMQ96yWTKhpZA1A2OElN6UnpohR3gPr/K8yntSLvgN9raeqVH6JtM2j28uN9NloUDowjGi8Um9RknTB7OAJDC7Q qw+/uO3G zZb4zIkug5uSH4+oF9vnyEPNeTITJVBiSJFbSdOIWJhG0xQ9tD//N4X/YC6QW+2SVlsap5eZ4OjOdDGDAWY9hqU5QUQPTrsvF0yO3TrIlWD3KKgZrQ2a0cWxh7gfI4uiveAFgsHlpSQnC/yEm/RIKVWG0EDFqoYWx1BZcORH9AhDJsTCKGF7MyB9AdnmgEDuSvvyk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/10 22:30, Usama Arif wrote: > start/end writeback combination incorrectly increments NR_WRITTEN > counter, eventhough the pages aren't written to disk. Pages successfully > stored in zswap should just unlock folio and return from writepage. > > Signed-off-by: Usama Arif Looks good to me, thanks. Reviewed-by: Chengming Zhou > --- > mm/page_io.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/page_io.c b/mm/page_io.c > index a360857cf75d..501784d79977 100644 > --- a/mm/page_io.c > +++ b/mm/page_io.c > @@ -196,9 +196,7 @@ int swap_writepage(struct page *page, struct writeback_control *wbc) > return ret; > } > if (zswap_store(folio)) { > - folio_start_writeback(folio); > folio_unlock(folio); > - folio_end_writeback(folio); > return 0; > } > if (!mem_cgroup_zswap_writeback_enabled(folio_memcg(folio))) {