From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F38DD1BDF3 for ; Mon, 4 Nov 2024 20:54:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 952ED6B009E; Mon, 4 Nov 2024 15:54:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 901C76B00A0; Mon, 4 Nov 2024 15:54:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77B476B00A1; Mon, 4 Nov 2024 15:54:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 587EE6B009E for ; Mon, 4 Nov 2024 15:54:06 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B00AC1A09EE for ; Mon, 4 Nov 2024 20:54:05 +0000 (UTC) X-FDA: 82749613842.10.9703026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 69B3A100016 for ; Mon, 4 Nov 2024 20:53:27 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eblhDskw; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730753478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a8M+YhD7eIFK9bvrSlBRbCi99RlfI+RF+7sBmE4OFXU=; b=j/Ef7Av0bwh5ow0owb8/MlBXTgIhEF1qZnpZ46M5gH1cZP0yIGvTUWr/EENaASiHAV4vOP Qf3cURcOumE5Dl492Cc9M8EWA0Hz1PtWX+FBH7ZgVxS7SDRYzIh6MP8bUYOG9QJLF91fD1 UbCC9k0mcaCfJJpQ21bysFUsQxZtj0g= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eblhDskw; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730753478; a=rsa-sha256; cv=none; b=sM/FE4KtuHfGUTTbQB2AtvMqFLXXVgHb3X55pGZrJeSgB10x/pMdgxfkehU0spfO9SlkYl UhrZlX0sJaXHZIK9fsmx6ezcRg1suis9XCxn0cfQEjFP4biV+c0trGxlI4Rtw69d/7EhKi I3o+7wQvz4uTq1k1F/R0/eskECTe9m4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730753642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=a8M+YhD7eIFK9bvrSlBRbCi99RlfI+RF+7sBmE4OFXU=; b=eblhDskwc7ANaw+zZmqYCpkn+dCNKwdcA4bc4uOsKFBllH6VRmjHB7gaugM6IzWTyxrgTY JANXY+8eGMEzCbNUybfz3pENRnARzjUliBqmlooe6gSWfzQ6vuI218djn2Ejij3Esa7e4J /Q7qNNHMBF5MWUj9NMaup6OBAGvphv0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-568-PZ_HnTqCP_yzh2g7IkWmlw-1; Mon, 04 Nov 2024 15:54:01 -0500 X-MC-Unique: PZ_HnTqCP_yzh2g7IkWmlw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37d4922d8c7so2468015f8f.1 for ; Mon, 04 Nov 2024 12:54:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730753640; x=1731358440; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a8M+YhD7eIFK9bvrSlBRbCi99RlfI+RF+7sBmE4OFXU=; b=cQPLK3lfC4XfOnGgUqtS3xZsvl41VQG1NNkZf+Yee0mXF9NbAPAxRC1cvobgpLw0zB lbKA+oSSlG3hZ3lQnQEM8sFwjF6fST+wOuBPEvk4Nq9/BUlSqxcntLCH+hRikK2JxQq9 l01YhO/tImWqPpPsnEn7ObYca5NK4pXsx9DYkMDXFYTbvrEw5i0drToAuv2VZhg8tfBO Vt90Okurop6lYoxQpFp5nw11aHRtLJOIbM60tCQFDXZevo+uklUnE21Qg+X7+DirsFI3 iMitIRi3FAn78EjdjG3khTCYKv3yxvLfsprd6YlfEWets4sL6eELindml9nOOkqwE/BS M2qA== X-Forwarded-Encrypted: i=1; AJvYcCWWgHWg2apfGANQGQF40mTPknivXmzA1ph/lOSIEE+m8VQVCYAfq/Tmu1PhcAfTAEMHsYko3KfjWA==@kvack.org X-Gm-Message-State: AOJu0Yyq5gUZHUbJMOh1MIMXdMYI4CHMwNWZyN3Eb8+nadwaGmrwI6gX 7ZnjqDko5tXrjkmBtx5jfOt1y04qDu3/e1UFJlvMs0+SA3XaDAXDGX5o9rK1v7bLitrJQx4s75t dm8jBNMYzMTFdwaGSDS7S6PtnvMLL9ZNig7odQl2+wE1XjSsM X-Received: by 2002:a05:6000:1865:b0:37c:fde2:93b6 with SMTP id ffacd0b85a97d-381c7a3a51emr10425507f8f.11.1730753640059; Mon, 04 Nov 2024 12:54:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IEmkOr8cjoeGCSBHiM9Y5KdfAvMuptVeluhrS0JuPqqEDsC0L2bHxsa1SPiw60xM97FmCKNWA== X-Received: by 2002:a05:6000:1865:b0:37c:fde2:93b6 with SMTP id ffacd0b85a97d-381c7a3a51emr10425496f8f.11.1730753639722; Mon, 04 Nov 2024 12:53:59 -0800 (PST) Received: from ?IPV6:2003:cb:c72f:e500:e96a:8043:1211:8e6a? (p200300cbc72fe500e96a804312118e6a.dip0.t-ipconnect.de. [2003:cb:c72f:e500:e96a:8043:1211:8e6a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c113dd95sm14267515f8f.83.2024.11.04.12.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Nov 2024 12:53:59 -0800 (PST) Message-ID: <5d02563e-86cb-43f5-b10d-a0f5aed4d946@redhat.com> Date: Mon, 4 Nov 2024 21:53:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: shmem: remove __shmem_huge_global_enabled() To: Kefeng Wang , Andrew Morton , Hugh Dickins Cc: Barry Song , Ryan Roberts , Baolin Wang , Matthew Wilcox , linux-mm@kvack.org References: <20241017141457.1169092-1-wangkefeng.wang@huawei.com> <20241017141457.1169092-2-wangkefeng.wang@huawei.com> <713a2c5d-e6e8-471f-96a5-1f54fe2d35b8@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <713a2c5d-e6e8-471f-96a5-1f54fe2d35b8@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 69B3A100016 X-Stat-Signature: amdtn6oms3gzccpudo5w5gkhdw4meb7n X-Rspam-User: X-HE-Tag: 1730753607-19415 X-HE-Meta: U2FsdGVkX1+He+h1OK2XC3UyFgmjj88OkHG0Y/mqMP+ymNARDod+wCR6Iq1xiMY1GNIZZJFZyrI/onUSt4QLpjo3o9dHM71fvGcvM6cOZvCNiqhykv7ghPXTkwNTXJgalZ5r0pW0a2YO84HL5eqWGt/sG9U3O1J3CXm+/cvUlQz2xUZbkuMpVcVryXjXB7THHr1No0WAAAMrRIIf6Hot46g3cIyJPQUj9to+lmfk6ZgClKRGkH+Yaocml5HlkGjsqCRF/UOoVdHBT+8VvXwJPlfceQPBabfJzrju8VTALhcBM/2nnc+VXBU8XVefdQ4ZbnaMoj0r6FQ0GKf3+16Iwm6A7ciH3mFumFeokPlWjNgdYRimPANq+jk3aeKg3VEc5BQdAoHg18aAI9MS0j5MjZ2/gclJrZQU5DfTwG1h8nBHiqdbhvJ2mNQsI0+qsow1TG5jbmvUVpyk/NkbDuDzJHWj+9CDlPStSBBvYCiTFk92cijuGyackml6Z9SCenQc6CFX/VjhmukqGQW+pN18wcEUUw9cqMJYeYJ59AATp0umD0dZBIyh8SwhT6Mzfrufu6BXG904kj57rlPiSri/jgnvFW07E9hw1L3nh9neoTMuD48lLvIxEMzVL4iC1XRx9u34gMyHsfV+rJBHVJhB7v7d1Iui0X5F+pIZf/Vfj2TdEvrRthSHrqqqfx/5OOhdBeuhqXMovEf48LTYdyeZIvcL8OC8zPW6GqbD+ixbUODgiYF+7BR/qbqS05aUqgr+Z6bUsFdy34WuGT405SWxyCe7vfw7sL/oZ9vVPQF7PHHOXzPUyXpplvmJGxMMvNTx5SPDV6KOlxBuOsKgDWctkykFSDyqNBbVl2ZRhfo/wxwTUX/MZrtBvqiAmq+liao+/4825ouvACmT77se245+i3YuwiYu8zvhq17DhTDs673JfZ0K+iJ06P1zFS7Qeb32tHCgW0L6uLtyHx7IVBS be033+Lk Ap9QU7DXlO6/lP6dhD97MHv1iE37cXVk+55BpILQ1g2QXUWfE6qkzbFGwmFSG3YRWmD2G/dHjtX8yCbLUCW6A2/OYzAWCrqoPnKVBwMJHQ5xDX+PIL4i/n09Z0KokXGHY5pDU3sZ43Gnn9P+AJ0q+6Mi/QIPaLkFtSXY3tV+z+nDj0//HtY3egRKNM+INkJyEEDJ/oNwszFNoCi1YjC/qMYVmpwvk3u0UwUV6y0TcodIzpITn55pvWHEpC467O083skTPUZarelNk8XJc6kOPGHkOAop4lLt2iUyUbAnwefURH8OBwLqQG6sKqJTLF0PEiv8rBpl1jECotWE2nnF4qS5l+kBwiqyT2nusSeuM+vHQfgDdNbCI2y+3y/ZlDvlhAcl4Qeocv3FYgBymrfgP08uKyxMVWqarCOEEnjdNlAB1/F2+V5dMNQG1227SdhD9Hh1gq0GtSNUy4UnZmTpxDJ8S+vUc+1tNk2e92t/WZwnKnuJOnSvdQb6CRPYASy6Q9LzbMw4ePLkmtkZHVYGY8tez3nSuNZ5HWfaL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.11.24 02:07, Kefeng Wang wrote: > > > On 2024/10/30 21:09, David Hildenbrand wrote: >> On 17.10.24 16:14, Kefeng Wang wrote: >>> Remove __shmem_huge_global_enabled() since only one caller, >>> and remove repeated check of VM_NOHUGEPAGE/MMF_DISABLE_THP >>> as they are checked in shmem_allowable_huge_orders(), also >>> remove unnecessary vma parameter. >>> >>> Reviewed-by: Baolin Wang >>> Signed-off-by: Kefeng Wang >>> --- >>> v2: >>> - Add RB and send separately >>> >>>   mm/shmem.c | 33 ++++++++++----------------------- >>>   1 file changed, 10 insertions(+), 23 deletions(-) >>> >>> diff --git a/mm/shmem.c b/mm/shmem.c >>> index 247c0403af83..e933327d8dac 100644 >>> --- a/mm/shmem.c >>> +++ b/mm/shmem.c >>> @@ -548,17 +548,15 @@ static bool shmem_confirm_swap(struct >>> address_space *mapping, >>>   static int shmem_huge __read_mostly = SHMEM_HUGE_NEVER; >>> -static bool __shmem_huge_global_enabled(struct inode *inode, pgoff_t >>> index, >>> -                    loff_t write_end, bool shmem_huge_force, >>> -                    struct vm_area_struct *vma, >>> -                    unsigned long vm_flags) >>> +static bool shmem_huge_global_enabled(struct inode *inode, pgoff_t >>> index, >>> +                      loff_t write_end, bool shmem_huge_force, >>> +                      unsigned long vm_flags) >> >> Please use double tabs on the second+ parameter list. > > Ok, I will send a tab fix patch. > >> >>>   { >>> -    struct mm_struct *mm = vma ? vma->vm_mm : NULL; >>>       loff_t i_size; >>> -    if (!S_ISREG(inode->i_mode)) >>> +    if (HPAGE_PMD_ORDER > MAX_PAGECACHE_ORDER) >>>           return false; >>> -    if (mm && ((vm_flags & VM_NOHUGEPAGE) || >>> test_bit(MMF_DISABLE_THP, &mm->flags))) >> >> But where is this check for shmem_getattr()? > > > In shmem_getattr(), the vma=NULL/vm_flags=0, so only vm_flags check is > enough. > > - if (shmem_huge_global_enabled(inode, 0, 0, false, NULL, 0)) > + if (shmem_huge_global_enabled(inode, 0, 0, false, 0)) > Ah, missed that, makes perfect sense! Acked-by: David Hildenbrand -- Cheers, David / dhildenb