From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57174C02181 for ; Sun, 26 Jan 2025 17:15:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A39AD280104; Sun, 26 Jan 2025 12:15:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E9BA280101; Sun, 26 Jan 2025 12:15:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D8DD280104; Sun, 26 Jan 2025 12:15:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 71542280101 for ; Sun, 26 Jan 2025 12:15:55 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E8F911A1AB2 for ; Sun, 26 Jan 2025 17:15:54 +0000 (UTC) X-FDA: 83050255428.08.8928407 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by imf18.hostedemail.com (Postfix) with ESMTP id C6FA91C001B for ; Sun, 26 Jan 2025 17:15:52 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=fu-berlin.de header.s=fub01 header.b="i5/LfFq5"; spf=pass (imf18.hostedemail.com: domain of glaubitz@zedat.fu-berlin.de designates 130.133.4.66 as permitted sender) smtp.mailfrom=glaubitz@zedat.fu-berlin.de; dmarc=pass (policy=none) header.from=fu-berlin.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737911753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NDGj5KhhYs5RVS0ic+JKR8T7bxhK3ms7bWt/FFk0Cns=; b=mskL1IYtqXLsUtehVufMBJxgmUv7zafgDWvbYa4nVQJeKeXg1oWUcfP1gedx+svG2fnuyz gGXcfuSzyMnKgIhZ5RO/cLBNQVikhnl6qu5hMQTazJxekI+yxecxz1R69ic8WL+Tp/z1bA M9akHBwX0XWrXINNxAp53yog99OzFwE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=fu-berlin.de header.s=fub01 header.b="i5/LfFq5"; spf=pass (imf18.hostedemail.com: domain of glaubitz@zedat.fu-berlin.de designates 130.133.4.66 as permitted sender) smtp.mailfrom=glaubitz@zedat.fu-berlin.de; dmarc=pass (policy=none) header.from=fu-berlin.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737911753; a=rsa-sha256; cv=none; b=hHR24YDB5iFFmu/UmCP8wW2E0xu+DCaWOuC8+uLv3aFB2upQRHNIOL804z/boX9jhq3FRc aEFUzwnzhLOXQKlunb4juRvBdtf0ICIo4umVQtAe3TMI5QJT2TcPHUcSdvMj/nocT5QCgN eeWUAlnLajpJ+kHmA4YxT08NLmbJlq4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fu-berlin.de; s=fub01; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NDGj5KhhYs5RVS0ic+JKR8T7bxhK3ms7bWt/FFk0Cns=; t=1737911752; x=1738516552; b=i5/LfFq5gUnK6HOLO4eUm+xv09FDkSlu1rN6ZLlKWC8PZGZ8SVkJrIw45b5jHHAB1jwH0/fHE2W nyA5dhq0FIYy7Fz2t7aIAN6G62BfvT2W2zAOegXQKzdhsPlWiM5R2uBMYRO8007PtV54ZXHWLPpPj 0VZCQbY1+V7pOVkUxgvXn++tscv6dzWMo7TaFT/1J7KrvjmDoHS/19c0bL3Xal5zB5AC1P1Wpv/bh l3hzM2DG+qI3eoW+zGtJwz59W6bL+Oicdh258Wp9ioYSqaKQglU8cM1tq1fKMfsBkr0dGSeNKIWbn Y/tG21KwYcuzwkFVSPWCfitD1eW8UqqTgciQ==; Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.98) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1tc6Ea-00000000TuC-2XmK; Sun, 26 Jan 2025 18:15:44 +0100 Received: from p5dc55cec.dip0.t-ipconnect.de ([93.197.92.236] helo=[192.168.178.61]) by inpost2.zedat.fu-berlin.de (Exim 4.98) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1tc6Ea-00000002hZK-1Oqp; Sun, 26 Jan 2025 18:15:44 +0100 Message-ID: <5cff63bf0fc9e62772fb24bc919c591acbd10d53.camel@physik.fu-berlin.de> Subject: Re: [PATCH v2] alpha/elf: Fix misc/setarch test of util-linux by removing 32bit support From: John Paul Adrian Glaubitz To: Ivan Kokshaysky , "Eric W. Biederman" Cc: "Maciej W. Rozycki" , Arnd Bergmann , Richard Henderson , Matt Turner , Kees Cook , "Paul E. McKenney" , linux-alpha@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michael Cree , Sam James , Geert Uytterhoeven , Michael Karcher , Chris Hofstaedtler , util-linux@vger.kernel.org, linux-mips@vger.kernel.org, loongarch@lists.linux.dev Date: Sun, 26 Jan 2025 18:15:43 +0100 In-Reply-To: References: <24f03227-1b55-4e50-b6e9-7ac74fda2602@app.fastmail.com> <678ee681-12c3-4e79-a04b-495daf343846@app.fastmail.com> <82d33a2d-dffe-4268-a175-4536b3f9c07f@app.fastmail.com> <87jzb2tdb7.fsf_-_@email.froward.int.ebiederm.org> <2758fa70d237ff972b0c8d7114777dc4a20c8f3b.camel@physik.fu-berlin.de> <78f3ae1f68842a9d1af62caaac3929834ce6ecfa.camel@physik.fu-berlin.de> <87y0zfs26i.fsf_-_@email.froward.int.ebiederm.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 93.197.92.236 X-ZEDAT-Hint: PO X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C6FA91C001B X-Stat-Signature: 1ijdimabmp3ozce7mm8gknpyynis4364 X-Rspam-User: X-HE-Tag: 1737911752-872865 X-HE-Meta: U2FsdGVkX19iBBx9SSEt6Kui9M0avqC/bHUamNGVtoF5ciKYM0+qQkbldEipn2zgMQiqmfd8JIfVOI4U3X0+DVZO4KHqnvMXnlcQGbmGGGNW6sMaUeHsJ2jXZGIADMVFJST0xB/vj00wrHE7d7wWO1Bri9W2XWp1StCk/YgB164s4QjdskMSOjAo3BAKZsn1GTY59J7t3hbRNQyVD9OQ8kl39lpdlQyJI+DGHxD11uvuikBEfRSNNZdHo6H4fc30cvkn6XEs+Iq8+s/zKfvWQxRd/A1Oepb7rDdh5vxOzFA/PxLi734BikylaSSVHpAZgbj1PvC+8aE6oZxputj5LCql5kO+/2BC6zoMr0jBHUUmb7a/3Q7S/OlCHS9ewFFQbgfzwAovjluRNA/PtbsWQCNgXIZDTy/zqzqUyALf9duZTKLfdhqglD5FmMeiYtHWEsqupj/jh1i0tHbWWa/bz0HoEc8heSntfEr7dmWFX3BDdtwI9kx8s6LmxVbR5pRq4/TZNbGDxdIzw7vxHGtevHkKg9Iofp/ocCqiwbQnSxtuGLo+JxA2kHJZ2loGf2254OcX7ewIDfWET0A1ka0HxI7Qh6FS9w0lOL0KA639UkXx3nzmxx1A8x+a2b0+Ss5URp+L41Ginjjuc0WvyewZoahL1/kggeQNL6pkx37gp1IZE7H2Dd6d15uk6jTbKJA5Bu+ICE+BqXF8eJ8MaI3SLY17JTfxKiefP+dICy5ow03CCdCTl2/Tw1WVPwi4zFbezKYT2zW9CesE1PNvvQRLRvKWYSi0mgtxy5tevYDNh+hID8exwxadQUhqoCUISeNEQiJ0K/tO8DHA4MTE4aBac8UdQAV1GiTTnsduLaN75l8Yvwi4zwRkMNb9VAySM/rNUURkoZz7coCwxuS1qtBKEDhMH/vk3QRs86XJiPkkvDUlJjBlPibbRarAphfp27j/N9m6agDQRMfA3JcKyX9 zMuZJcSe 4NHsr+NW1Xbu1xhzpnnSQJ7fr84mpQM62jzPGvg2IkLyhlqoCqLg2AQpE0PvhanAl6NWP46jMcO782FTblilxbe8KuXdx3kyrD+N7CY7D2hhpyIkQFHv5+KAZUeOeZfE/jWSawHx1iOOeWtoQDjCsc2XlZWzfXPmASEtyWv2ECvT3bva60H9JR9KLugPtNsNtjVIX0mzheEFgq1ayvLToCXNL9tw5exDi0UIYpVcPW9i6FB8DgiKWNbMdvp+zdulmTBOw6dICWqSohVh/f2cLGWiHKvGiAwAKrihMrB8CJYE8+N1fdwVHvUtntYXU3a2lUzS8XOsoeNG5lZJD1YuzslRXoxQoz4ci6QysNL0/Ma2k8s4UU5L3q6iIGIUe4xI5/KqHtbId8nkFjHTrZo7ursvHcMT2GXkbL/df9QA3V2JFHjQQgYA45EYKdZm8j9dFyTv6slVZxD8xJK4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Eric, On Sat, 2025-01-18 at 11:35 +0100, Ivan Kokshaysky wrote: > On Sun, Jan 12, 2025 at 11:39:01PM -0600, Eric W. Biederman wrote: > ... > > --- a/arch/alpha/include/asm/pgtable.h > > +++ b/arch/alpha/include/asm/pgtable.h > > @@ -360,7 +360,7 @@ static inline pte_t pte_swp_clear_exclusive(pte_t p= te) > > =20 > > extern void paging_init(void); > > =20 > > -/* We have our own get_unmapped_area to cope with ADDR_LIMIT_32BIT. *= / > > +/* We have our own get_unmapped_area */ > > #define HAVE_ARCH_UNMAPPED_AREA >=20 > Just remove the definition. As the comment suggests, the only reason > it exists is ADDR_LIMIT_32BIT, which is gone. >=20 > > --- a/arch/alpha/kernel/osf_sys.c > > +++ b/arch/alpha/kernel/osf_sys.c > > @@ -1210,8 +1210,7 @@ SYSCALL_DEFINE1(old_adjtimex, struct timex32 __us= er *, txc_p) > > return ret; > > } > > =20 > > -/* Get an address range which is currently unmapped. Similar to the > > - generic version except that we know how to honor ADDR_LIMIT_32BIT. = */ > > +/* Get an address range which is currently unmapped. */ > > =20 > > static unsigned long > > arch_get_unmapped_area_1(unsigned long addr, unsigned long len, > > @@ -1230,13 +1229,7 @@ arch_get_unmapped_area(struct file *filp, unsign= ed long addr, > > unsigned long len, unsigned long pgoff, > > unsigned long flags, vm_flags_t vm_flags) > > { > > - unsigned long limit; > > - > > - /* "32 bit" actually means 31 bit, since pointers sign extend. */ > > - if (current->personality & ADDR_LIMIT_32BIT) > > - limit =3D 0x80000000; > > - else > > - limit =3D TASK_SIZE; > > + unsigned long limit =3D TASK_SIZE; > > =20 > > if (len > limit) > > return -ENOMEM; >=20 > Likewise, just remove these functions. The generic_get_unmapped_area() > works fine, tested on up1500. Can you send a follow-up integrating those changes? It would be good if SET_PERSONALITY() could be fixed on alpha for v6.14. Adrian --=20 .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913