From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 976F8C83F09 for ; Wed, 9 Jul 2025 14:13:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 225246B00BC; Wed, 9 Jul 2025 10:13:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D61A6B00C4; Wed, 9 Jul 2025 10:13:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 076916B00BF; Wed, 9 Jul 2025 10:13:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E55AC6B00A6 for ; Wed, 9 Jul 2025 10:13:28 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8C3B71D145A for ; Wed, 9 Jul 2025 14:13:28 +0000 (UTC) X-FDA: 83644918896.12.03E699C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf28.hostedemail.com (Postfix) with ESMTP id 07EE1C0002 for ; Wed, 9 Jul 2025 14:13:25 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=To0vAOte; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=OSZurXNH; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=n1cCiEzV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="usatz/tT"; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752070406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O9xPEVbKBl8nwHs3uX8qyvflxZIWls9igiOMBLBrdWc=; b=aUe80PBQaqqeMT77uPNTQ9c8dVThdL/ghYnzyC+VZsagpuq9FRM1T9p80xcqs0r/XOR07F 7tqpqc4Qdxv+65Bf6/DWECiqoXDpjmdsrl6AwC8at/2Qzvfd/cuvzsNP2I2bkR9+ZV6DEm +cdKCmf1msNBEPjI3X2c2aZ7tSUI9uQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=To0vAOte; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=OSZurXNH; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=n1cCiEzV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="usatz/tT"; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752070406; a=rsa-sha256; cv=none; b=GD0bMMwDs1BmgPV2miEmCoewVUs3HCmUSrl4x3QGPeV260jnk9LfqSnqmsOf/DuDhiUA2S R2xoBJZtX4j/AUfV4u28iFJqjNth4dAXEVj8cDvcJ8lQ4UK5b58kFff7ORc+d0I8chHRCA MqNHYA7DWZYv9t1TyWLgJ+eStGTFlYE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E9C822118A; Wed, 9 Jul 2025 14:13:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1752070404; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O9xPEVbKBl8nwHs3uX8qyvflxZIWls9igiOMBLBrdWc=; b=To0vAOtecu/VLF5EbCw15JfpUUWVFCYP4jpJD8BXOPuFVyMndhoCDZLA/3ptQMGTg1dHeT NBR2SCKUNegqpKO6hjRom+bXZ5Y7CJJxCT1FcFhXl8O7z0aJisa4yOppBeGN/4invK6C8F GnljmaIY47VYVUK3BZtyBbmCL4vgf3g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1752070404; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O9xPEVbKBl8nwHs3uX8qyvflxZIWls9igiOMBLBrdWc=; b=OSZurXNHbFMFVgIE8BOsWCwrxjNpvjN1AOQCZFlEPppnSKSWqDtwZhi0ylhGbF1BrJoiZY YE2Ci33JmlDBgJDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1752070402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O9xPEVbKBl8nwHs3uX8qyvflxZIWls9igiOMBLBrdWc=; b=n1cCiEzV6WreyE/tRmPvU1t+dwdDz1QzdVyWYeyhcw91DGbjfr6qACUEoFbfb0MSwOxsrV VN2oV58COtCFGxsg5bdT9cL1Uj9JrwfOTShoAHIJFyuo0HpJZBBwtSG9DhRAPOStbzpzBx NHUwGtqh+mjiPqebQ1Ly3sQAybogZAk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1752070402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O9xPEVbKBl8nwHs3uX8qyvflxZIWls9igiOMBLBrdWc=; b=usatz/tTUcMyefwQX3SXgUmwDQ20rNUBY1bMmTz81kTjyywurJltXww4nOpmffuQX+aI6r P/eo5I2+E4/bOICg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CBCB8136DC; Wed, 9 Jul 2025 14:13:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2a5CMQJ5bmiaaQAAD6G6ig (envelope-from ); Wed, 09 Jul 2025 14:13:22 +0000 Message-ID: <5ceee3d7-6e9b-4a28-a170-195f1451211c@suse.cz> Date: Wed, 9 Jul 2025 16:13:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 2/4] mm/slub: allow to set node and align in k[v]realloc Content-Language: en-US To: Vitaly Wool Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Danilo Krummrich , Alice Ryhl , rust-for-linux@vger.kernel.org, Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , Lorenzo Stoakes , "Liam R. Howlett" References: <20250707164755.631374-1-vitaly.wool@konsulko.se> <20250707164908.631462-1-vitaly.wool@konsulko.se> <4c5852cc-2ca5-432b-8426-01c108df66cb@suse.cz> <76FFFF68-15F3-4A36-BF1D-A33CF36FDC9E@konsulko.se> <7099B4C7-311F-466D-B12C-BDC52FE34A65@konsulko.se> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <7099B4C7-311F-466D-B12C-BDC52FE34A65@konsulko.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 07EE1C0002 X-Stat-Signature: jgauug8hr7ogypexiib1caix5ia3wz39 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752070405-533006 X-HE-Meta: U2FsdGVkX1/gCDJfQklZBhqJgeowFG28zT/HwdhBUjJSpb9PLKmPMw6cZQJ2kHik9MmuwC2UAuXRAIXSfo22fQ4ajrxkUvdZEQ6OeRjsrhorBKc86QuDHIx5ZEksMiCWc23Pu2xNhoHGEzu3IAhcY6zG05U7RwLKhFhc29lJ4IHK2r/5l9iluJBaWMTrPWVw6F1kR2/J4rjCPVsoZrxDSQ5CVxvK197hXhK3zUYNbhjnQ4ROTn7sUn5qVMC3vNg84JiEpLMl3gpvkyuRYc859NwMtqsHK6YHtSe93XZLPORijoPyLfzDLDc1XEuE2gj2RdeqbGrGD+XJ+NbhWHGTL71ARtGxKnvk+gUel1psbq5rEI/YavSTStp5PnfiM09PXYJFp9C+w8I1jfnPlStjzLMb7IDrbaO1oBkX/wJeUBaXJfLZz+wDRzHpwlGisFogoIxFPHrqA/l1TufqI5GdcQP1JPFa5M6dVPkiCZbr4yhK1vowpD0M3itjUGG7lPpAb+KvNYJnRsbVJ/FJvyuNr5Amwv3sbIKrFIc++V2nnE5GwABFD//9uhWOigVH2b+3PjEF3wncfytnxbk0vqiUvTSJExJ3D9mzuynDJulCYWcGVLOdSd7gZIX61cNUmZEJJbKWDeSex+OfMcYwyMVoqUEhdzZY9PeAQyGjepbEhK49y72nj3/wX8fdQLrjJuK0XP9STePiFb9Qp+n2AuU7rZJHWb8TXnB5+E/VXaXpkCPZEE/SjT2WSjtBaeo2qqhDnSaPkKiGd6CbbrBlU/VvUlV+DlXT4VE/P4XBdTX/F02vT9CHg4o8C73/Jn/6x1j8fRHkDNEDozIvlk9lqX/TyEeF61/lS3uYcfv3BVZNSBzKQL0ns2/8+EFL9HuIi1SV+G1bo3ZCbvIhRzIOJqJwYa1HxJ9iHn9UvTyM9ZwLLaU31Y4bJAQFEVxXzj9MK88ssgxGERFZ4rKIYJItGMs UgVs/36U 8kYlmD3Mp9vk3dlhbU3JQUT084/73ZLrqTWo5S3hT/S4hIfAZAXZzQcffsv98woAWjnWNFX1brZ4Nghtf6v5U4mPPbUlfqzf2aqCbczuOFOMs33xaJIBfTr7LCzr2PS48pgZxCPtp650bJ/jG2V6XDQ8DtXjAolY67o20akM1fA3f+zA98llpvpiwvGVd3IsJi9IBbdxDrGmT00J4OegJ79TG5doy97U1tIUZSlk5DQME1PktMUn6VNKyau+wa5LhVDXyCCg/BwfgJ2pw1WyXtqLqw0qsaPz77ofkRnxI7r93siDYrK/Dg4Y2ZSZyW7hRkA7xVC6COI2VtRBnPwHPXltWkz/UzASDFBA+NF19Nt5djMeOygFIFKi1F/buZaSdEBOH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/9/25 15:40, Vitaly Wool wrote: >> >> I don’t think that krealloc_node() is used at all at the moment. I thought I’d define these to be symmetrical to vmalloc() but if you believe these are redundant, I’m all for removing them. >> > Well, krealloc_noprof() appears to be used by nommu.c and it feels a bit weird to make nommu code deal with NUMA nodes. So unless you feel strongly about it, I would keep krealloc_noprof(). Oh well, let's keep it then.