From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F399C47E49 for ; Fri, 25 Oct 2019 06:35:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DC6E721D71 for ; Fri, 25 Oct 2019 06:35:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC6E721D71 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6A9226B0003; Fri, 25 Oct 2019 02:35:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6337D6B0006; Fri, 25 Oct 2019 02:35:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FAE16B0007; Fri, 25 Oct 2019 02:35:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id 280756B0003 for ; Fri, 25 Oct 2019 02:35:01 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id AEEED4DBC for ; Fri, 25 Oct 2019 06:35:00 +0000 (UTC) X-FDA: 76081344360.22.stop61_2ba3f28295521 X-HE-Tag: stop61_2ba3f28295521 X-Filterd-Recvd-Size: 4523 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Fri, 25 Oct 2019 06:34:59 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BB71328; Thu, 24 Oct 2019 23:34:58 -0700 (PDT) Received: from [10.162.41.137] (p8cg001049571a15.blr.arm.com [10.162.41.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2DD333F718; Thu, 24 Oct 2019 23:37:36 -0700 (PDT) Subject: Re: [PATCH V7] mm/debug: Add tests validating architecture page table helpers To: Qian Cai Cc: linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , "Kirill A . Shutemov" , Gerald Schaefer , Christophe Leroy , Mike Kravetz , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <69256008-2235-4AF1-A3BA-0146C82CCB93@lca.pw> From: Anshuman Khandual Message-ID: <5ce5a76c-ea89-c2a1-6665-7d75bce5fb87@arm.com> Date: Fri, 25 Oct 2019 12:05:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <69256008-2235-4AF1-A3BA-0146C82CCB93@lca.pw> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/25/2019 11:22 AM, Qian Cai wrote: >=20 >=20 >> On Oct 24, 2019, at 11:45 PM, Anshuman Khandual wrote: >> >> Nothing specific. But just tested this with x86 defconfig with relevan= t configs >> which are required for this test. Not sure if it involved W=3D1. >=20 > No, it will not. It needs to run like, >=20 > make W=3D1 -j 64 2>/tmp/warns Ahh, so we explicitly ask for it. Unfortunately compiler still flags it as an warning. Just wondering why t= his is still a problem if the second condition for an OR expression is always= false. Because evaluation still needs to be performed for the first condition an= yways, before arriving at the result. DESCEND objtool CALL scripts/atomic/check-atomics.sh CALL scripts/checksyscalls.sh CHK include/generated/compile.h CC mm/debug_vm_pgtable.o In file included from ./arch/x86/include/asm/bug.h:83:0, from ./include/linux/bug.h:5, from ./include/linux/mmdebug.h:5, from ./include/linux/gfp.h:5, from mm/debug_vm_pgtable.c:13: mm/debug_vm_pgtable.c: In function =E2=80=98get_random_vaddr=E2=80=99: mm/debug_vm_pgtable.c:314:17: warning: comparison of unsigned expression = < 0 is always false [-Wtype-limits] (random_vaddr < FIRST_USER_ADDRESS)); ^ ./include/asm-generic/bug.h:113:25: note: in definition of macro =E2=80=98= WARN_ON=E2=80=99 int __ret_warn_on =3D !!(condition); \ ^~~~~~~~~ As you mentioned GCC is quite stubborn here. Anyways, lets keep it unchan= ged.