From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 332D0C5AE59 for ; Tue, 3 Jun 2025 07:44:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C802C6B03A4; Tue, 3 Jun 2025 03:44:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C30226B03AE; Tue, 3 Jun 2025 03:44:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD0286B03B6; Tue, 3 Jun 2025 03:44:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8A6046B03A4 for ; Tue, 3 Jun 2025 03:44:27 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3FCBEEC955 for ; Tue, 3 Jun 2025 07:44:27 +0000 (UTC) X-FDA: 83513301774.12.93804F8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id D15E814000C for ; Tue, 3 Jun 2025 07:44:24 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XGJMRbwt; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748936664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SG6mTtKanLkSL9gF6goSw81A6MzIykOU0fNCSqg+tps=; b=rcTym/pJwOVjkl0dNDEVxix82rncnDr7A+4brlldMK+wlyI0assfFmX9KqGlDpIsgT998+ AkvL4ad0k2Uw7zxoW7D7ONxy0rWL3/KrbcnknFe49mx3sQQGtFlKXTYcE/LWgkEqV2GoXO cEakrs+OOZLRs09iBkE7HH7lNmzbTTE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XGJMRbwt; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748936664; a=rsa-sha256; cv=none; b=XAw/TBZXhfIgm9Qa746Z20fsalb/8+7J7sxcNxeeNNH4Xm67RcuncnM2DDL8PNg2byZCNk yVBfOI2HmQ/zUWR/8jX+gchzjb/iS4baG+Y4TA0q8pmLy2qqpBXOE42zGUgRe3/tmfPmiY E/rdtTZUzSKV1UFDJcicqxh5+t2Jmd8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748936664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SG6mTtKanLkSL9gF6goSw81A6MzIykOU0fNCSqg+tps=; b=XGJMRbwtsNHqBrSSQV05ByUqrulxrgsSPaYnJgx9T1Q6nWhb3wCFdUKtIxwXeeHg5RhI1T iXy80HgQtm3ZiuCwOcqwo/T3IrKR8f4jlbRCxBZ5jVwI98b87F58nKHQBRyAaTWnmCJ8UY YB5ZkvCq3piBvR4mAxOYIpClRKalZh4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-g6xDsgfrOjOF3Z1It72_Bw-1; Tue, 03 Jun 2025 03:44:19 -0400 X-MC-Unique: g6xDsgfrOjOF3Z1It72_Bw-1 X-Mimecast-MFC-AGG-ID: g6xDsgfrOjOF3Z1It72_Bw_1748936658 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4eee2398bso2013060f8f.1 for ; Tue, 03 Jun 2025 00:44:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748936658; x=1749541458; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=SG6mTtKanLkSL9gF6goSw81A6MzIykOU0fNCSqg+tps=; b=EaPz7ILJCNDt2SC8uawPyknnKsKWQ0wJyOdaGMd4giVDi514ajEVCpSsiPjU4tmu/S HLrk+k8xk/4nvrywqUv8e1Yemf3KzBYZbNaQp+NZZ/7VcLT3oDd5qBYtHfqynwo0I9x1 2gNOnkMEkz2TvH97PTeyKVCtwwq2Sw40FRpogBfdfz4ZI4XULV2WkQUG8ZfTNz+iWRqB w/Fpi1oAxjhzUbMlfWGsREJOBW3M7nrICJ4UfXOj5wn0aCSCVCNWpLbqVc0v6UaD1rKd X78HNq9Wun+LkWMDAjVLwJhpNRsFDrwUMXExoOLoHCejki7/iRzh7IaZWI+AtOicnsA5 QK+Q== X-Forwarded-Encrypted: i=1; AJvYcCUPE0vekdqz795MUXegzO7dTUkPA+ha8AETyJq2z5uWmcSHsEtU8lpoRCSxXvtVWKH5dTTxuybDzQ==@kvack.org X-Gm-Message-State: AOJu0Ywb4aHeaAa5mgp2OkRLQ2IdoU/ciTUSQFASIRAHOItk7puWjzXY A80L6bFA2/uQwdxtv1JkmAieUWm/zNa/hVRsXleBC0a0AZU+9FCdVb/saTC3P5VQWGcw9TAHdmh oghVtjJF2ghMXEOK3AdmZYsaUBTQxN48n3gW5HhuuuhQZnj5EYclS X-Gm-Gg: ASbGncvUWtlwTJK34zUrYruK1z1Vh2sgxz5CFzyGpmkJK3s/9cg7nSp/Id73sI8dQgK 9TYCL6MUn6EGyzDvv0D84rtIg4wRdg4kmh5vGJ0174qlXAmEHOqjdwlfQRx7hN1OVjb5Mc6yKLs vhjCz9cW0HNVTdlb8SZIj4LK73JvsZjuC5gy80nhgWCmI6ZEouibSKHjsxNF0zQHQmWwir4nUyN CzaVU0YbRx8t0gPmHO0rHzYwXpIXWYN1nkL2cKhEOf26tJ+GjTkH8SnYEeztl2OvSDKj7s13aRO g14SQS3vBVNOOOVzWbWJa2wzATD4jOmd5NDMsgc1qZbz3I36N/szcyQTWMKeAbmIWApE7CelbvV qbizcKLW+fhCGO8yb5APhpsh8F/TnNSgnBoqf71E= X-Received: by 2002:a05:6000:1a8f:b0:3a4:f786:acc8 with SMTP id ffacd0b85a97d-3a4f7a023admr12719493f8f.7.1748936658388; Tue, 03 Jun 2025 00:44:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjJJ9way87jDnzJBj4N9lNHw7SNKH1oMFyEekMgNpE2iFEScqcgGmu5upP2vBF8O/aiqEkyQ== X-Received: by 2002:a05:6000:1a8f:b0:3a4:f786:acc8 with SMTP id ffacd0b85a97d-3a4f7a023admr12719476f8f.7.1748936658013; Tue, 03 Jun 2025 00:44:18 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe7440asm17674702f8f.58.2025.06.03.00.44.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 00:44:17 -0700 (PDT) Message-ID: <5cdeb7c8-1f5b-486a-9406-1865f533b246@redhat.com> Date: Tue, 3 Jun 2025 09:44:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC] mm: madvise: use walk_page_range_vma() for madvise_free_single_vma() To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Barry Song , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Suren Baghdasaryan , Lokesh Gidra , Tangquan Zheng References: <20250603013154.5905-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250603013154.5905-1-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: liVQti33g-4tSb2GHOee4m2Y4cY_dRNKNVdtlvx3wCc_1748936658 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 7ogxs7jrazthittdo3wr8k1rcugfc9bk X-Rspamd-Queue-Id: D15E814000C X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1748936664-935223 X-HE-Meta: U2FsdGVkX19kXsHuPdkRkJeaXnGtMpu88HGsN/4CqD28w6b+UudARM9BXLHmgaWdhm9fe3emyr3FOvX2aWZdjIH+J4UMQgYvRmbxekrNlfNrIjfn7Sj7E1Ru/606oUWpt42U0DqiUKZOjGQKtTCSnBGvOUQv4iUaInf6f7VBg8H90CDpT3Ke6S/6WqyF9bD8gszMXtZbfDS4VdCm5AWmqweGFuhWyygPle+xcPS4Kis1j09ikuds6RYw8hatSpUE0GR5vTDFDzmI+YuYNhipehLS5f77huIgYKrw9HHJKN4e35OBSva1itE1xmbEwcXl+7oSLZdftsJtjJ+Vx/ojBUyNhf0RKbCTRCeuuUFwbd5Jsh6CYyaDBwYs5YI9S/PE/0Qhoco6I62UHW8JFM/YyS4/L1A+8MGJNhQHTXxmaSZ0DmQMpYiyw/R0881J9JELWoPqgX7mYcS/WKuEHU3/n/161utHbDA2+kUNUVVJc3xNbvdjpjUwqf+ZWvCB1JrhhikUJOHIy6JAt/NZcq5tKaO9jmBPXk8d/mEuuuP7vZ7t4VeSz6UiJof5condAFhWQPI2fg242S1afzcYXZZpSXT5/L5vaRgMIB08mcwoVSvZg11UZfGSP4aliF0qofKw4FAHmEWP4rfJIcBSWTZxRbwrkZJw0Qs6pvGt8G0wEquR9cyQctyVykF4EYsXDYKEQ+OlpLEg6JMxE8ZU3kSRJzLncwAGG4/prqnZ2iMw+OygSRZ1v0ekKhpUN7MYZonFJJlSwt3a7ephvNlhNZQObTkeZVeFH2WOW1VA6WSLh/Wyu5/QGmcU9OkSL1Y/GDzpiIU3nnezwRrq2C9HkpnymK94PoGtL1FKIzGsc5gMztBFL/LhT9Tr2NsWe8hk05/o3f3Eh6EEOnRr6pUOTwqBqi+BYD1x0JzMdZKZMi7BMbv3pa83WJnQtBTb6L6mNaTnT3GltG/AbUIwoMufWf8 Qmn2TSiy mvu/uxpplm1xRNWGOiIvwY78OPUoFSfVAdDGCJ1oqZgX63B97yZ+wnTAUxnQWpCdcPyTX87nA+sRM4tsquKtRm0WN1YHSNy6aJj+YtMFeMrIG0Wj/yhxqoQuzwGr3/1dw/uiH46FFGWO3KyCUiOcU2tg3UQh6rIkFvj85EO4XlVI6VzAS49cd+506aAZm5twi39lrC9qk8/CUkC20eMB5fx+BqNYicfeYX1lOCTIQMN+9lsfurIzCv/EfCJfaA77ewGmL62RJdyRB7GMCDVja6F6C4Dr4Z8BBnZyTog2YPghQdjlV7NLXR0vy9s+Dv9iCVH6SFJ5dYNOA9rvF9AdEeg+KjErBw2E2M0WdnRgms5QlEfSjGmgQgKUGSIbJebhz/wrSyQWG5jjX7mEc0z6E6F2NrVERzUD1syEJr9cHmjSX2xk6UiWHsW5dYLMvst8pEpO/J1FTgY7ZyH5ObjWqPNgkmEZg5qgRakS/5rFZeb2TAmsdw4TZfwKVPMjnFa3eXSSyHLEofJ+cdfj5zP32n4oik4x+Uq3iZAsC6uGuovk4OnM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.25 03:31, Barry Song wrote: > From: Barry Song > > We've already found the VMA before calling madvise_free_single_vma(), > so calling walk_page_range() and doing find_vma() again seems > unnecessary. It also prevents potential optimizations for MADV_FREE > to use a per-VMA lock. > > Cc: "Liam R. Howlett" > Cc: Lorenzo Stoakes > Cc: David Hildenbrand > Cc: Vlastimil Babka > Cc: Jann Horn > Cc: Suren Baghdasaryan > Cc: Lokesh Gidra > Cc: Tangquan Zheng > Signed-off-by: Barry Song > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb