From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AD3BC4707B for ; Tue, 9 Jan 2024 22:19:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31D9D6B009C; Tue, 9 Jan 2024 17:19:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A6FD6B009D; Tue, 9 Jan 2024 17:19:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F92D6B009F; Tue, 9 Jan 2024 17:19:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EDFA16B009C for ; Tue, 9 Jan 2024 17:19:11 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C7838A0F9B for ; Tue, 9 Jan 2024 22:19:11 +0000 (UTC) X-FDA: 81661189302.25.319FF2B Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062.outbound.protection.outlook.com [40.107.223.62]) by imf30.hostedemail.com (Postfix) with ESMTP id DB63D8001A for ; Tue, 9 Jan 2024 22:19:08 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=ipMeTyAW; spf=pass (imf30.hostedemail.com: domain of Ashish.Kalra@amd.com designates 40.107.223.62 as permitted sender) smtp.mailfrom=Ashish.Kalra@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704838749; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0n6S1IhJFL+vYOedd5EP4plpcRrdfl1wNTTgjL8YbRg=; b=36aHR9Si3OwWAG2G4/4R+B7z6h5wITLYUxY+0Mc+KX4rNGYigKadZhhPpLynTrVxsszhV9 zPoqXs52ZWRuzdOoBJdkTmXfMs8oCryyutHwWQdSqJ3rx4+KmgRDhx8iZPFevsFRFYPCTZ vgXv0ob/swIBeFNk+7b1tVFp2X3ojhQ= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1704838749; a=rsa-sha256; cv=pass; b=OU5GgMziqu/rSi3g1sz1KoWsTrMlFbAaDI5OKMa76ngPYU2EYTrL9npR8u+XurqNjKy5Sr wjTTt6WH8XtuxL/ChosrDELOG3M0B5YtUG3x4xQSjIHJRYVMFxLMzocEaDYLPAWLXfNVoz xvCxCUSEcWB7UkJ0gFyJWl4uRKNAP+c= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=ipMeTyAW; spf=pass (imf30.hostedemail.com: domain of Ashish.Kalra@amd.com designates 40.107.223.62 as permitted sender) smtp.mailfrom=Ashish.Kalra@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=glZyEfEpxdgF4C+TsUTtFiiiR9Tzp1jBkEn3yr3GlXe6nPDGaH1nv5wAsOk/TJnEMl2etEWj6K/pLnxu6iYLywp/TmhTdWOeWnwgvOa4Qb4qWu53Mi1FzNAjIoz7WSuIWVzR6Kl0MZ9dmWiDNjQxNUscjqyx5fhlk/WoX4cERloejfYob7fskEvgfM2PrtcpbIILyCyrU+87JiOlBI9pv59Obam7KSFpyM3BvKwv1FgBZPyCJM3Xa8hJgbU3aGHg8GAQAiaDL3aN/bVvM9uqaPbOZ/AC70xymt0xXFuqa9doIV4eRG9Lixk9ySPQG3rVe66u1kynO6uZ0vNPrOmsFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0n6S1IhJFL+vYOedd5EP4plpcRrdfl1wNTTgjL8YbRg=; b=Rx6iUNCBXcmOXDq8aACWmWgGHWMU03okpiTwY33HYs/huCLM7AC99n3Sy0j72pjjhCgzew2R9ybnAkTUc3T+H9NkYKwb+o6O+N/QtWr0op1UCTJAo6LFali0nNJDz1hnrT2DH5qPwFUIv7Y1MfvN1q6A9mRWQLTLONMmlNBtg9BqKgXZFxRJ1DYBo9KvzCSfgXI8GG6yth7QKJS0QgtZysiBHZi9sUk3VpfqJJ3ZUYoXJygzc8j19KNBr3wKhdvT3pPBSDrFfuPQjzLaMGzvWwEZgGt31HbpAs2neQvJYnNpMsZdvOwPTPmnOboNdSNzH1xhpRHIDbmVGE9S1LYBNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0n6S1IhJFL+vYOedd5EP4plpcRrdfl1wNTTgjL8YbRg=; b=ipMeTyAW+a38uAoKfbajM8/64/Zqpno8KBTunc8/7wwmEelALBoVDYvnZHEJdeou18VcSb1nJworRQJwrTMFVYZxW5OGEfTuDP7BqjTTorYDMhr35ulEh9iuLMGUjyx0H8vSRCAv7hX46pVwSA4/gNuHTFvUdZzt65TkhWYM0Bs= Received: from SN6PR12MB2767.namprd12.prod.outlook.com (2603:10b6:805:75::23) by IA1PR12MB8333.namprd12.prod.outlook.com (2603:10b6:208:3fe::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Tue, 9 Jan 2024 22:19:05 +0000 Received: from SN6PR12MB2767.namprd12.prod.outlook.com ([fe80::dc71:c26c:a009:49]) by SN6PR12MB2767.namprd12.prod.outlook.com ([fe80::dc71:c26c:a009:49%5]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024 22:19:05 +0000 Message-ID: <5cdd2093-b007-404d-96a8-89b3aa6e6e4b@amd.com> Date: Tue, 9 Jan 2024 16:19:02 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 15/26] x86/sev: Introduce snp leaked pages list Content-Language: en-US To: Vlastimil Babka , Michael Roth , x86@kernel.org Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, bp@alien8.de, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-16-michael.roth@amd.com> From: "Kalra, Ashish" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SN4PR0501CA0057.namprd05.prod.outlook.com (2603:10b6:803:41::34) To SN6PR12MB2767.namprd12.prod.outlook.com (2603:10b6:805:75::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2767:EE_|IA1PR12MB8333:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e0c4860-42cb-4455-bedc-08dc1160fe0c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jFElfiQML6gAx3uii+bok8dqoPCGUIM6kpw51H1ISdLZXwrvJcl/kl7kcZAaFxDHdIzIMSUSa9144WRy65C8kAS4jPuO7cODA4aEAGH3SUEPl1oYp459ahcAU+KsxxFq/6PKq0Ar6QFfCiWf9Vv8WrIO8jjsgCtrtH4u1dyeRtfd3aQiR03WIgjgKrY8GwryFxwBSogXe+W8+HMe0efusizDBs098GcGnKxlcYTDR/ilxu9ic+DPxZwiwoyEHPs/b/z+PxGtfp3gkAtORUNt0aE27Hlum/M7i00Kum+bfAPzYSda539MyRGDDXLHlaIG47favqj4wcgzvG3atXDbWJ8KPXEOoayBlfQ4IoV6g4dp9DjpeG8ZDiRrd/XXF2VU5yNaOnIHhGHhepc0tLVnF1avQlwAccIsWBNFmi2HlS/K1mlF4h+ktAuvAfl4dD3YyjzHz7LrepYXfjgooqDqYaciQwBLA/hl0V8e0e1tQJtccIn9YHQ82BuOc71kuQzuLyitpow+htLkdanM3DPkAR9uTPBfOy+P0ME5zADD2MfQySbrYMr+RNHxe3KhqeQgjENuE4JJ3rE0YEdRfZ9WbLoyeQ7uMAn6C1d0TvbrKP75SuiaTLpJdB/O195FG42JGzor7HdD+AEq9WDRBdihIEd/JrYbtJvqtdkatZPJpgzfWe6GcIHnLAvqs9HDd8Jp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2767.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(346002)(376002)(39860400002)(366004)(396003)(230922051799003)(230273577357003)(230173577357003)(451199024)(186009)(1800799012)(64100799003)(478600001)(6486002)(66556008)(966005)(66946007)(6666004)(316002)(110136005)(4326008)(66476007)(83380400001)(2616005)(26005)(6512007)(53546011)(6506007)(8676002)(8936002)(31686004)(5660300002)(7416002)(7406005)(2906002)(41300700001)(31696002)(86362001)(38100700002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U00vZUFXY05xMUs5aDdhZFZramZTajFmM2FDUGRLNlRLL2ZmYytlVlJ2NlpC?= =?utf-8?B?dVhzTHhMS3ZKQ1pZZTQ1YnM1cTc4TkNNZkZjR0ZEWjBGcVBhbTR3NSswVy9l?= =?utf-8?B?NnowNW9iS3hKYlRWY2hqZW9Sd2tBZHBnT3Y2aU40TlREUEpxS0dHK0c2MEg0?= =?utf-8?B?ZkZ6Vksxb1h4U2tEdW9vVDF0RnJyZjBlZFBXd0dWblF5aG1LRk9HTk5BSU4y?= =?utf-8?B?MnpkTXpaWDBKbG4yLytLNGEyc2RCa0ZHaEhLdFRkcTBhOTIvZXhVelhBQ0Zu?= =?utf-8?B?ZzBBWjVUS2QyZm8rYVJYQUdib3dsVjhYaVVSL2V5bThaSVl1NnVIeEVqQkJP?= =?utf-8?B?azBSbTRGd0lCVVB1QWcwK3lmUUlkcWhKU0RMc1pZTmlHMDdNMy9GWk1jU2JM?= =?utf-8?B?ckYySmNEWS9nV0NmcjVCQTVLVnRYUWJLZnZWQTF4L3dyNFUrRzRlVmsxSGoz?= =?utf-8?B?VlNDLzgxSDB1TThSMDAvRkJPbXZySWljWG44VGpsOVFwK0Z0eE9OSzlzSVlD?= =?utf-8?B?Mk44NXFvK0JaQW9yV3QrVHYrK1BabmsrUzV6SXRydGJic0RtWTNZcnR2TDU3?= =?utf-8?B?RlZmWWswTzJqV1VIS3d0S0Y3dDJhb0JSK04yS25JckxVdU01UHkwbUx4clVu?= =?utf-8?B?bE81QVpydDIzdkgyT252NHpGN0xuK2xQRFZOU0RBaGZvaFkvY25iN2VEcXc3?= =?utf-8?B?MzZ0QzRsYkpsdnFOS3ZVTlMySUZ4MENzdVQzQ05HRVU2KzBCYm1TaC85TWJI?= =?utf-8?B?V0orZFcxUnBzRjhGYXBLNmMyN1laRjhWWkJFZEdEeXVTTEo3cUJPcFRUUUhL?= =?utf-8?B?M3VsWEVrY05DOUFXOGcyWHdTRmJ6L3dFSkJUNDM2akE3QTkxVDNkZzhHNGdm?= =?utf-8?B?RnNnc2JqK3VYTEw2TVA5NUcwaDNtWjU4YU8yTlVldzJ0Zk1mb2lSUERQOUVD?= =?utf-8?B?Q0Z0N2JBeHRIRlBWbSt1M0hUejVTYlY3WjRnRVl1SG9ucjNyMzFpTHpWWlJN?= =?utf-8?B?UWlpamoyTytWVWxkZHFEMWVwbkpWQlBubHFXTVVtWk42WUZPeitmWmhlRmVl?= =?utf-8?B?cSsvNkhNb2lha2MyWDBSZ2RHT3ZidkpLd0x0bTc1T2ViSit4eWhoaksxMmRa?= =?utf-8?B?TXpWeldMTy9RaEhUYUR6SlIxZmlyTlVYYlBBblJIaW9tVTJ0SDJUOW4wQU1a?= =?utf-8?B?Y2FMUWNDOW9EeEJ1cmp6UlhBdDlXWSszMlRYSDEvY09Id21jM0F0MkpITkJk?= =?utf-8?B?OGhBVEk3aXpGY0ZyRllQYkgrY0g1ajgrUW1ueFNDNDMweU9ZMGs0MmllMEU1?= =?utf-8?B?TThZdnBKalp1VHZMSjlzSit1a2ZaN2VRNXRVRzlud0xETVJoK2RPcTVpTm1G?= =?utf-8?B?VTJNSlg5ejlEN2t2enM4d1NOQ3lIbU9JTmVjQW9WaFcwM2tYbDZqQXJKTWY2?= =?utf-8?B?REJ0TkxxLzMzOWpZWUM0QWEzUllQK1ZFVktCSndKVlRjaE45RlNUTnUwRWxK?= =?utf-8?B?RHpKRlM2SER3T25NUVR6K000VkczY1g1WTVFY3VYNmtwWVRvMDRxWVFqc0dk?= =?utf-8?B?dnFuU3RRQ3lWZHoyTXJlRy9IcGFLL0VzbG5YaWttMHZpUUZwaW0weTQvRVdW?= =?utf-8?B?OVhva1RnSXZCK3FMRGdESmVHbllGUVJieHFUNGJvaklKUEJTcHpUZmNtdjRl?= =?utf-8?B?OG1lSXBvcXR4blVHVlg5RnNQZTgvMXhFNHhtdXdQVWxlQlVERGVUS2NQNVpI?= =?utf-8?B?L3NmZCtVaDVwL2xKdzZJTEh1emxZOUllcS80SE1zSE9XQjROY0ZvWGMzQXNE?= =?utf-8?B?N3pRcFVBcTcySWdMdWliYzFYT1QwWUJ3bG1uZWFNaUpzamgzSy9Kak1rWE0y?= =?utf-8?B?VWZ0bXBGeHVpdDNJcVJhL05FWGVWMGdveXhsanU0ZXAvWit4ekkzRTk1bVI0?= =?utf-8?B?cFJnVTJ2dEEzV0loZWsyaWN1QjlUdzhwcExCMXRZQS95WkNVaUZaL0kwTGpq?= =?utf-8?B?S3dLRE12V1R3M1BGV1c1RUFhdW1QMW92NGxvTjdWeDJnbnhiUGEvZjVqK1ZZ?= =?utf-8?B?M0F6OXJQdTJpSTNIbWpmMDVwaGl5bEJUZnZyNm9FaWkxZTZvcnljQ2RzMzJj?= =?utf-8?Q?bvM2OaOt3OioNN0rx2JcyYcmQ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e0c4860-42cb-4455-bedc-08dc1160fe0c X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 22:19:05.7949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rlJmXGWhY5tCxB+ITpClkD1nGrM6lU+uWbxcxs+3cFzJ7sifpwYn74nqzPXJl6Iv82FIb3dQa4l/kzxur22x/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8333 X-Rspamd-Queue-Id: DB63D8001A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: b1amzi458wnqk4uxf675kek7q9u94rsm X-HE-Tag: 1704838748-875824 X-HE-Meta: U2FsdGVkX18OIIq6rXnvkOUdMc3nXkGuId4j8O468AkEtLez78SJ0XsSIHOBhSpFysKjQY+VV7GZ6CnrBQQIbBi0VmuzNxTDNACGvRzNwxd5xoKBb7baZifIeF4YCi48wE5fLoOh6mCO94lJY+d78UHiY8bZMx0u0LukuDFC9xrh7XJOUigpsSGD+xzZSn0ZTkeYlRXr8pIRVPHqL5Ix0hk5vgrXg3lxB8Q7pkcj7OcIoHTOZqx7mvT85BjC5XSltBWldVgKohdrMkvj5IOwxbRe6nIpRokRQhhNg6A7DGYkPwN5CwTSuu4wrUyV3iCdZ76BaKSOP6lm/877XTqmT5td0wVJHo4FuxK1/TMW64wggWxBUR/X3jNyOZd6mJxGYP4qqj90rcVZXozqmrH8w6o40AbHsCT8ix4ZrC5odzLdMhXXO+gGKeWhbP6yt9/WUGRUvuuu+2CqNVbynoCBPl1ItbVYtsaP/WCFWkQ5YDqVpC/7emOCXd2R5LWJyUQD94K45FTtQAOB+dJvQY15iNpNFj93bzw46pgmwQmEvkrpweD2vk/l1/1jgU8KOTDIB4MWlIEv+W1LQIMxmRedsP64pMmJCJJdZKId3YDRFolCYU8eiSHVdF1670QaI9Si9AO9FaOZo1tfTuMV7zYEc0UAyt7j8I9O0m/L/vV8K7qI7ZvPSANYpUh6wf520zVdYvYnlx5V9Mha/2h1NwYtbqTAsUZUeS87EOQ5r3fEQdzSrAafj5bA/SdzuHXSWNPkXx9nWyOOIQtamqE2Vwuh7uEQnecImSG/XDSE5O8r6rnqYvEjph66xBP7NtgWcegEnF4Ne4FImAsA+UKYTf2GGMOKq6XeGKB79DS0uXJDtQdbLKseZoOudqhyIfXT5i7S3ZfWoZGgi8AOq3+cbSNBH2OZet0ZI3IVRKL5vkXUPajG0xKpoZKHqygp+/jOZmD0cCrfNXodolAUS5GjZWg wpzXY6oB L6x6bQRgGKMX7RQaGBk28j/z11I4wxom6ni+vBqrP8BRDksOVEEWlrYQsDI5hUB98L9w0PqobbiO1OqJkigNGPaIQJxTWjwraxPbb8Mpn5nWGr6aWMAmf0jrbi7j0U8bT9uNYPCsBAoz9Cn9/PZfLqfga/5xKom2ElFiQkO8qgQNkCZn3BYstUMrWJO3+3ESqWoQm7OechxC/d9uGbqe4G2HWgb1SQn8AL7lRcRJ5Z9ItPdS4e+gVHcx3FPYxckkM+WOsgdJtyk+Az6oluXqR/XZiO5bP1KNDIaev/G7vppDM8kco6T5VoPvUctc7qry49I2ik8o1f8Rtp9g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Vlastimil, On 1/8/2024 4:45 AM, Vlastimil Babka wrote: > On 12/30/23 17:19, Michael Roth wrote: >> From: Ashish Kalra >> >> Pages are unsafe to be released back to the page-allocator, if they >> have been transitioned to firmware/guest state and can't be reclaimed >> or transitioned back to hypervisor/shared state. In this case add >> them to an internal leaked pages list to ensure that they are not freed >> or touched/accessed to cause fatal page faults. >> >> Signed-off-by: Ashish Kalra >> [mdr: relocate to arch/x86/virt/svm/sev.c] >> Signed-off-by: Michael Roth > Hi, sorry I didn't respond in time to the last mail discussing previous > version in > https://lore.kernel.org/all/8c1fd8da-912a-a9ce-9547-107ba8a450fc@amd.com/ > due to upcoming holidays. > > I would rather avoid the approach of allocating container objects: > - it's allocating memory when effectively losing memory, a dangerous thing > - are all the callers and their context ok with GFP_KERNEL? > - GFP_KERNEL_ACCOUNT seems wrong, why would we be charging this to the > current process, it's probably not its fault the pages are leaked? Also the > charging can fail? > - given the benefit of having leaked pages on a list is basically just > debugging (i.e. crash dump or drgn inspection) this seems too heavy > > I think it would be better and sufficient to use page->lru for order-0 and > head pages, and simply skip tail pages (possibly with adjusted warning > message for that case). > > Vlastimil > > buddy_list of tail pages is not usable.                          */                         list_add_tail(&page->buddy_list, &snp_leaked_pages_list);                 sev_dump_rmpentry(pfn);                 snp_nr_leaked_pages++;                 pfn++;                 page++;         }         spin_unlock(&snp_leaked_pages_list_lock); } Thanks, Ashish