From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C613C54E49 for ; Mon, 26 Feb 2024 13:33:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE882440165; Mon, 26 Feb 2024 08:33:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C9825440147; Mon, 26 Feb 2024 08:33:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B877F440165; Mon, 26 Feb 2024 08:33:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AAD3B440147 for ; Mon, 26 Feb 2024 08:33:24 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8643FA0C72 for ; Mon, 26 Feb 2024 13:33:24 +0000 (UTC) X-FDA: 81834046728.11.488A7FF Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf13.hostedemail.com (Postfix) with ESMTP id 561E620025 for ; Mon, 26 Feb 2024 13:33:21 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DyoY7LO6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of dlemoal@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708954402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7V3WjLm31blZt4VPP5/SjHPc6GmQ6abYCb+wOO6XWgk=; b=BrHCLBAManu/3NmOWU5ZYzcASNXEkcGh+aIPcZR1SS3rdZwvdF3bVMyWOyh5tJlpo83WVF n4puUmS1cGAYUeM20HLo2ADB8+9Zjv48qAQHJ2pv9ayth8r/prM5pQPemgcbgGtoAf55yR MUgMZdcVnae7TWToQ5YatLqTfByC8+E= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DyoY7LO6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of dlemoal@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708954402; a=rsa-sha256; cv=none; b=0cFlpmtnSn+Reco0l6HKmhjZREtRz0ax1ywCuyUBWx5tQRWGaHgC6HOlckbsLHiPk1Bg33 NeU3OsDuk7wruqk/v6837OYhF4MgTTdRMGWEM86g937fP/LR3AWIb6PNSgO0YOv5Sqaoom OQS7bb0iGvLTz8QATQqg0kgQ4VCTuvI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 82B25CE1808; Mon, 26 Feb 2024 13:33:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3920C433C7; Mon, 26 Feb 2024 13:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708954396; bh=M0oOylNxz4l9CNHQvuMDa7jjrq0NbJbo0mR8tnz3vHw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DyoY7LO6znuJBW24YVgBlltkCcHIjjL26Ju+7A+qxERFc3NFn4jn4y8KN2QaKTROh C59msM7Xynq44wIhCfdGRbtF9bLJ6aXYzIj7A8VvaECPj8mYdt1oOpNHAtQv+sjO8j lcDH3+XiD2GobpMlbvC6rZRPPmoBvLRa7kzQufBAODrbzYmytsuX+z+17cEd4bU7K2 0FHVrBMC+gu6k9Mnz2novFuRxY49XVHQmpVJwAoe5JCyFo+1xZWHbY/+AdlptjxdNH G4nKQM7c2EDhJkUZbOXpkpZW4GIowb6CExCAQ6QjZ2HhufFZMIFt62vMgfR8HYTk5F +n9bBRPXYO+cA== Message-ID: <5cdbfed3-62cd-41fd-b71a-5c6b1940ceb6@kernel.org> Date: Mon, 26 Feb 2024 05:33:14 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] zonefs: remove SLAB_MEM_SPREAD flag usage Content-Language: en-US To: chengming.zhou@linux.dev, naohiro.aota@wdc.com, jth@kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com, Chengming Zhou References: <20240224135329.830543-1-chengming.zhou@linux.dev> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20240224135329.830543-1-chengming.zhou@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 561E620025 X-Stat-Signature: mhijzj6m9uxf31yz73qo3bppwt7xezs3 X-Rspam-User: X-HE-Tag: 1708954401-139837 X-HE-Meta: U2FsdGVkX19CJSNE1VCGPTzjNCc+iJqQAsKQY++t0VaoR+vVfo96YAfRDsyRYGxa+JBBSdPcNhleni29rjAv1P6QfFsDTU9XSSqBaMTUVxdOvCkocJtHPW1LJ1fxxo2HO7gbV09dMT+rzJx3gOSvAIMpXKLfpRYo3eGuIrBBQCDmq6AElupWq9fIe/Js+qVbSl9KCTEYp2pk3owZK50wTBS8X70s37XoYvIupZp5YdnYf4WIJ3Oct1gPeZ1SN+DvuOkmdE2mBplEdTP08JiHITEbuF0/4S0VSMX2V8nh3I/tKEv5D0hQjzUgitOQFXO4XVCM9YTODMcEnyFZwHlshgC9Ci0KQ5uFBT6XSLvGP+Q/cbEwXBLMizFW8kypyx34CgEVXOQXvJU680qENNvFnH+wHOqywKDMa3kW5/Bji4aP3BICyry2x7Vm+k3tAH3SZXOIE2jgAq9YF3c2MUN6sXRjzsnTY4RAuAYxy/Q9QRQ81BPXdnGowh2hYJIYsWFOpRVMOFYkT/CWGkjd8+fCkcUqnsiXpzgEJN8WKkEmwpLm2GatYB4SxQTTzYGNwWyS84+5BO365sg5CbMINtbJp1toEcroNnx2YzFTQeKVxKoNZrVYu5hV6sGAzbcz1hfX3/ixJGmqbWQ42YwHg6ZAp31AD14HFvTJlY69T1kbR66+Hs168uxl1nJFEfv96fXacuE6/5/3/CzRSstpMtTQlZRnicPz+dtPc+8kkphNH5cNwlOZE6aoKo9IUrTrJIMsekZntbebJHoxJJAKX4XBu1M+gKXjks2ugYJlo797GSF2eijHAY/vRzTm+bLt63UNljHf6IL0l/N5Vt/scI4XX5DiMZLeXk1/GWIeVSaiklVevYmCnUdH5BOf4osLqCTbf8vj5d5inBw/4aXPxw8KTXGwZl5UBeSN/1mmarkC3EZuSCbZtlE32x9dSWOdl7NO0+C5/75oysLxWTI2dfO 7Gy+/1jZ MXJW3+LuM7uci9E3Gv6JRziAdKu3GkfGz4qRbAtptJegqENtAf+/IL56pG3nmuujLgtMt0iTGbbCZ0s4/CzRBaAM9Ajr2PonUp7fnIQ5vL/U6XaW1NEzxoStR3Md5BdXJGq/tzDH0+8i5N2wutr4W+DJAyCur265QZI4Cj9H7myWmbRP19ZLtVF0Kn0mDmEOeoCQQPd5Ecy6Uo6TMp5UsqXJhNwyGDAx9EbQ+oGUIAXJHSkKcTrgDKtiM3y4wafsU/CGtUXjYAQk2rLS+b6fI0Zo76uuDt/rQ2GVqd/QxX/USP9MjJAPVEl03mZp9Qcn7qtAJBAZpH96OfTq/SfGzHWoHBTZCbvhd1wmC4UTSNNnUWww2jzZvx5WRgQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/02/24 5:53, chengming.zhou@linux.dev wrote: > From: Chengming Zhou > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove > its usage so we can delete it from slab. No functional change. > > Signed-off-by: Chengming Zhou > --- > fs/zonefs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c > index 236a6d88306f..c6a124e8d565 100644 > --- a/fs/zonefs/super.c > +++ b/fs/zonefs/super.c > @@ -1422,7 +1422,7 @@ static int __init zonefs_init_inodecache(void) > { > zonefs_inode_cachep = kmem_cache_create("zonefs_inode_cache", > sizeof(struct zonefs_inode_info), 0, > - (SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD | SLAB_ACCOUNT), > + SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT, > NULL); > if (zonefs_inode_cachep == NULL) > return -ENOMEM; Looks good, but please rework the commit message as you suggested on the btrfs list to have more details about this change. Thanks. -- Damien Le Moal Western Digital Research