From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27535FA375E for ; Fri, 13 Sep 2024 15:51:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F7376B00CA; Fri, 13 Sep 2024 11:51:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A6CD6B00CB; Fri, 13 Sep 2024 11:51:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41FB36B00CC; Fri, 13 Sep 2024 11:51:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 23B986B00CA for ; Fri, 13 Sep 2024 11:51:14 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7C12DC05BA for ; Fri, 13 Sep 2024 15:51:13 +0000 (UTC) X-FDA: 82560154026.21.A2183EB Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by imf25.hostedemail.com (Postfix) with ESMTP id 735B3A001A for ; Fri, 13 Sep 2024 15:51:11 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XedfPqeI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of carlos.bilbao.osdev@gmail.com designates 209.85.210.48 as permitted sender) smtp.mailfrom=carlos.bilbao.osdev@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726242585; a=rsa-sha256; cv=none; b=c54UQLRUxaDX2ef8rUrYFER0bC6f35T6FYgcTHDFuD8vSx2noH5952zqLyaLYTUSK60DpT 1yptTCHyumuxof+NYgRkPcCOBFAcm/lhzfG9lQnvrxJEzY9OJi5wsWJ5fzLR0X5DN7emHR +YcVrFYwPFh64e7JvK6rWhoiCr4y9DI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XedfPqeI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of carlos.bilbao.osdev@gmail.com designates 209.85.210.48 as permitted sender) smtp.mailfrom=carlos.bilbao.osdev@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726242585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ehs9yLbkVlOBEgkAu8IxC2ecxN3bEC7UNanNZJEoFLs=; b=qT2ZymOJ4Qo1j9cdGvUpuWo/JfXacgd+PtNHtYW390DQItuk67HMZlvBc69SS+fDYkec1q hm7H5GdO2O00+V11r45Qqcbp9fPHd1MfhFMvMYwz1PuBYyi6fudurm6qSziGTG3TsIKOsF Ru/g40RQ8F3Nm0o+eos1XX4KL+Dh9iU= Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-710d9b33303so1376331a34.3 for ; Fri, 13 Sep 2024 08:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726242670; x=1726847470; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ehs9yLbkVlOBEgkAu8IxC2ecxN3bEC7UNanNZJEoFLs=; b=XedfPqeIrwBMbcuGiKaRibZpXyXQaFwTmjMOYfHavpvdyX2Ze5ec9Z/aFe1CHpj02g nmKTK//j8FruFAl1YDcJ4c3fuebp8RsnxQZ1tO/PRr8Ez39VC+8IBkhIFmiLTwslkahd IF+Ndj1N3Z9FoXVsdDx8VLFqW8qTtI8Fhqr7lDmxb8NpSqau8L0vw7z+NUf/Ke1+ErT+ SPX2HiGlCshRdqYqbt/fPF6rP4BSOp3yXz/Oz4iWBtvxvR15mCN10taOuuh9HRi1ftKM Oo7AjA0pXWUHjOajRPqqZ4KqONIVhIUHchEhpgQR65bBYvWi842vZKbIzCKobPIg1KNC FT0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726242670; x=1726847470; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ehs9yLbkVlOBEgkAu8IxC2ecxN3bEC7UNanNZJEoFLs=; b=YN7iur273hmYYUkbLH+jx2PK+KKhzIjk6bUFznCAXBO/VhezAyT5wFIF3qQDMRg88M wEx8/WXh3/Fl1Yg+/GeWBO+3HOCAZvURDoNXIn9LIHtKdLzlQWdq7tqH4a512vVZbiPY c77NZBZiq21WrnjolCEMYgpfDQRXXxf5CZrsVwAeYnQrL+u4SpaMGbDyW2C3cX5yszw7 ZH6+gIP8exu17QHkttrXKh0PFZRUcTOM79zzlkTS2rfUC3s2wLu4PjZ13xgZvvt0G0XT 5PJCIbCXzCcWymrZRMLQ4CK5mZsQxxlmuB0n+Mx7oWMWKbbBQbNtednRqB+/vqKfWp/g MiMA== X-Forwarded-Encrypted: i=1; AJvYcCWUVA6QEKp8B91xzlU1AE5MtVv36R4j23Jv9eK8TI9TnG9HGU12bMiz2tAomxsTkvpAwiiVJHZeWQ==@kvack.org X-Gm-Message-State: AOJu0YxqB7/NWSskKRef87I18FQI3jWiB94P0SFmriasUmP0aFHourUU CFOjE6a3hjxp32K//MhK2p7m4wb7n1QSirrRwRWVQVpjmRR0RI3m X-Google-Smtp-Source: AGHT+IGwspwIdcxizms74BUEV11s0x25xQw3otEtykkXT6P5qLAwtjFU5Aef8TBprXa84EXBrlG8AA== X-Received: by 2002:a05:6870:df92:b0:27c:475c:ab2c with SMTP id 586e51a60fabf-27c475cad93mr3175704fac.43.1726242670341; Fri, 13 Sep 2024 08:51:10 -0700 (PDT) Received: from ?IPV6:2603:8080:7400:36da:dff5:4180:2562:4c1e? ([2603:8080:7400:36da:dff5:4180:2562:4c1e]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-27ba40b0bb0sm3632948fac.41.2024.09.13.08.51.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Sep 2024 08:51:09 -0700 (PDT) Message-ID: <5cc36aa7-e064-42b3-b52e-fb471d99d338@gmail.com> Date: Fri, 13 Sep 2024 10:51:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/30] mm: Introduce ARCH_HAS_USER_SHADOW_STACK To: Deepak Gupta , paul.walmsley@sifive.com, palmer@sifive.com, conor@kernel.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: corbet@lwn.net, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh@kernel.org, krzk+dt@kernel.org, oleg@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, peterz@infradead.org, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, kees@kernel.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, shuah@kernel.org, brauner@kernel.org, samuel.holland@sifive.com, andy.chiu@sifive.com, jerry.shih@sifive.com, greentime.hu@sifive.com, charlie@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, xiao.w.wang@intel.com, ajones@ventanamicro.com, anup@brainfault.org, mchitale@ventanamicro.com, atishp@rivosinc.com, sameo@rivosinc.com, bjorn@rivosinc.com, alexghiti@rivosinc.com, david@redhat.com, libang.li@antgroup.com, jszhang@kernel.org, leobras@redhat.com, guoren@kernel.org, samitolvanen@google.com, songshuaishuai@tinylab.org, costa.shul@redhat.com, bhe@redhat.com, zong.li@sifive.com, puranjay@kernel.org, namcaov@gmail.com, antonb@tenstorrent.com, sorear@fastmail.com, quic_bjorande@quicinc.com, ancientmodern4@gmail.com, ben.dooks@codethink.co.uk, quic_zhonhan@quicinc.com, cuiyunhui@bytedance.com, yang.lee@linux.alibaba.com, ke.zhao@shingroup.cn, sunilvl@ventanamicro.com, tanzhasanwork@gmail.com, schwab@suse.de, dawei.li@shingroup.cn, rppt@kernel.org, willy@infradead.org, usama.anjum@collabora.com, osalvador@suse.de, ryan.roberts@arm.com, andrii@kernel.org, alx@kernel.org, catalin.marinas@arm.com, broonie@kernel.org, revest@chromium.org, bgray@linux.ibm.com, deller@gmx.de, zev@bewilderbeest.net, Rick Edgecombe References: <20240912231650.3740732-1-debug@rivosinc.com> <20240912231650.3740732-2-debug@rivosinc.com> Content-Language: en-US From: Carlos Bilbao In-Reply-To: <20240912231650.3740732-2-debug@rivosinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 735B3A001A X-Stat-Signature: z3ioedtny57aor6w6xijwjgy63hut3d6 X-Rspam-User: X-HE-Tag: 1726242671-790327 X-HE-Meta: U2FsdGVkX18Pko7+mIRwh8tRMrfm0lOA29Ko6lZTicUuvg2qNWPU0KKGqI1jxzCMJru0MI2vxCyUO6pne1BiQLLRW38cMMHuub6E30kITgQ1scjnovTiJSOBGxSlzJXCL2dJlHV7qNmCuiI8fx2MihaMnD9RMTDUc1oRpuvel/k5TT1VPuMDcVJFKMq5PCQjbPXuo7G2SbcU/w4lnl+DuNKOfdLjyFelDDikUNHTt3GGVIgmeBdu7qPdfHchaMtgh7aVirfYmxu/u1zkVn9kUF1NI0+TLuryzTx3p3LspUYpyFxgflsqYgoL5NBR60flLQmOXah5iwQ3U+7U3efijd2VoOjRyJPd0v9jxkJieIQ5KroXBemR9lpUoYmseHHu5zqHvaorCGf8osn4Hye0D8tfvz48avd0i3FtCcSF7tzStuWG70T2XGFMunliGA1lmNNjLwr20Hep1uZgBKF7o54GhNpHLXhFhPpHRfTiCQfNgmYDG68PkyTgR6snaS0tPqii/EzSOTakvYcbNAp8KPB8zFFwe3lwBtQINIcf8vJuU9XFizQsPfipV0jChTU6rXupeQmRU2loB8oh4rcvmDmTqAgn37xH3QKjO2QVgERq2CQr4fiXKmoKMgr70JJN5GritV7E0LdpA/xxc1JYATIGalZmiVkme4UrTQ0MxubhFVVEGMARRELuZ8gPxWal3fqTtDUqsMhXPobGut9RwOFGZPksE30l1NOUkxNsnzuxgEdowRBGeGWWqkO+4Hw7ORdx0uLinicHG4LHTwxacXnZjWl6ed4Zn7uRzWvJ+BrF2rDKM3gSm0s4i9MWjwX9WM2D5u90Giwt25mwo+2XlvniRQQflKOjjL48GTIorDGxORU06Gdho96jQ0+AdD6vU/za10J1Tc+Fh0HWyvFeOKMPsB3O5+eE9gaQRSR4DnQBMwpd2Lxtwv23kB3FBwIjrCWBMGKvn3krNNKp0be xt81a3tv O3h3EOfu7Tgsbwx2mMWKwaxCD50aAgNnHofVU0dGNZiLHRNC6ujeKw2uuUuDbUhLFTJUBbIAB+j5Ck+eSYdUtctcpT7AoY0jEHiR/tEjbhsCUqoKL9OFmMpladfmJOqeynvZVSP+mwrl/DogkGdDFlo51a/H134CqJ61WBTLhr/4Kc8zA6b8YTXy3uXSpluibypS6uTQ8+Z0SJSADkpPq55uItLvhXosN0a8a5bqU9+lJ/5BXX4ub5Qh992xIHpJoz+JgfjAnSzXFGXTsaSzy8k2NzEU3J2MA7Lm7CQAYIEspXAF3wUiHHG/2N+Mre4BvgeJCHx+5S8FYgyKUDbB423uIlXSbj4lt2jz/t6jwnlu5x+3B5LDCyO7BGigpaQhhX2Yxm0lVnbklpvy06Xv+ZJLaVstXqQcwxyYFU6aiih83BT4Fx2Zeere0aGVNbAKaFSpuCsoj4Dv3i3hST/IjjBPvfKAUr54zaES9GpApZJv0wF1VeQxjjVqSqhhVxqRNS5knoOTbfGAP84T7rY96obtiTdkAm94tIdB++xbSdnZMJV5PnhuaCk2fUOrK4+tDsQBfCko/drA6vyMb2A/qr2E5dBm2tgX82aYVpdLM4H+XXaUUheYIe8zysUPeDqN0JFKHYnRPE0jlIkFsKLn5Ukqs9m3FcrlVnjSy0kj5eLsx89xutMp3ORkqo7Xlk2Opfvq3qAb5yRju8fUCmxLUabbEYg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/12/24 18:16, Deepak Gupta wrote: > From: Mark Brown > > Since multiple architectures have support for shadow stacks and we need to > select support for this feature in several places in the generic code > provide a generic config option that the architectures can select. > > Suggested-by: David Hildenbrand > Acked-by: David Hildenbrand > Signed-off-by: Mark Brown > Reviewed-by: Rick Edgecombe > Reviewed-by: Deepak Gupta > Signed-off-by: Deepak Gupta > --- > arch/x86/Kconfig | 1 + > fs/proc/task_mmu.c | 2 +- > include/linux/mm.h | 2 +- > mm/Kconfig | 6 ++++++ > 4 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 007bab9f2a0e..320e1f411163 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -1957,6 +1957,7 @@ config X86_USER_SHADOW_STACK > depends on AS_WRUSS > depends on X86_64 > select ARCH_USES_HIGH_VMA_FLAGS > + select ARCH_HAS_USER_SHADOW_STACK > select X86_CET > help > Shadow stack protection is a hardware feature that detects function > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 5f171ad7b436..0ea49725f524 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -984,7 +984,7 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma) > #ifdef CONFIG_HAVE_ARCH_USERFAULTFD_MINOR > [ilog2(VM_UFFD_MINOR)] = "ui", > #endif /* CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */ > -#ifdef CONFIG_X86_USER_SHADOW_STACK > +#ifdef CONFIG_ARCH_HAS_USER_SHADOW_STACK > [ilog2(VM_SHADOW_STACK)] = "ss", > #endif > #ifdef CONFIG_64BIT > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 147073601716..e39796ea17db 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -346,7 +346,7 @@ extern unsigned int kobjsize(const void *objp); > #endif > #endif /* CONFIG_ARCH_HAS_PKEYS */ > > -#ifdef CONFIG_X86_USER_SHADOW_STACK > +#ifdef CONFIG_ARCH_HAS_USER_SHADOW_STACK > /* > * VM_SHADOW_STACK should not be set with VM_SHARED because of lack of > * support core mm. > diff --git a/mm/Kconfig b/mm/Kconfig > index b72e7d040f78..3167be663bca 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1263,6 +1263,12 @@ config IOMMU_MM_DATA > config EXECMEM > bool > > +config ARCH_HAS_USER_SHADOW_STACK > + bool > + help > + The architecture has hardware support for userspace shadow call > + stacks (eg, x86 CET, arm64 GCS or RISC-V Zicfiss). > + > source "mm/damon/Kconfig" Reviewed-by: Carlos Bilbao > > endmenu Thanks, Carlos