From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D7AC46467 for ; Wed, 28 Dec 2022 08:17:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB6538E0002; Wed, 28 Dec 2022 03:17:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C657B8E0001; Wed, 28 Dec 2022 03:17:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2D0E8E0002; Wed, 28 Dec 2022 03:17:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9F6F18E0001 for ; Wed, 28 Dec 2022 03:17:44 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 66D82A0011 for ; Wed, 28 Dec 2022 08:17:44 +0000 (UTC) X-FDA: 80291011248.24.852B272 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf22.hostedemail.com (Postfix) with ESMTP id 836EEC0009 for ; Wed, 28 Dec 2022 08:17:40 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of haowenchao@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=haowenchao@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672215462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CJPimVnxorRg2kzRc2DAU24mx1aUehs3rtYnka4deQA=; b=6K73j8GWLZTajZJvPxCT6xIbuNeYkbtduI+VPnALFa2HQB2lKDxmcyVKfuLipB2j5+Suea qpJw+jIBe4xtP9U+2o7QM11acneDhyWPMmEO6b0bs+rQOyM+C3M3QzuUbO7hyNUj9cpraG Ex7+IdODNHjB8YZPClyxusO+h1RDLuM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of haowenchao@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=haowenchao@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672215462; a=rsa-sha256; cv=none; b=EKEE0jzvvI4WLF0t0w78EG7817mgTTg052HzExim+eIQ36+m97cGJ8O+d4TcYt22HQpNKE OBKrXuEnqhmFV0DriUdw0ndWHutLEvdUe6xo+iPupnfJ4Dgat3mJyfbkbqv9z5CNQSkffD d0iSd2zFNU//fgPWg/1tkqBsj+f7Xyw= Received: from dggpemm500017.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Nhkqz6sm9zmWMm; Wed, 28 Dec 2022 16:16:15 +0800 (CST) Received: from [10.174.178.220] (10.174.178.220) by dggpemm500017.china.huawei.com (7.185.36.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 28 Dec 2022 16:17:32 +0800 Message-ID: <5cb83ada-a1a4-b52f-3254-0e6536ab4315@huawei.com> Date: Wed, 28 Dec 2022 16:17:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] cma:tracing: Print alloc result in trace_cma_alloc_finish Content-Language: en-US To: "Masami Hiramatsu (Google)" CC: Steven Rostedt , Andrew Morton , , , , References: <20221208142130.1501195-1-haowenchao@huawei.com> <20221218102030.94b44e62608f20fd9decf9a0@kernel.org> From: Wenchao Hao In-Reply-To: <20221218102030.94b44e62608f20fd9decf9a0@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.220] X-ClientProxiedBy: dggpeml100018.china.huawei.com (7.185.36.133) To dggpemm500017.china.huawei.com (7.185.36.178) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 836EEC0009 X-Rspam-User: X-Stat-Signature: 9d1zettk9ojsp7ahaoyk37n7ub6xowxn X-HE-Tag: 1672215460-378632 X-HE-Meta: U2FsdGVkX1/ZTUnHiWDmHvsHjwssAFtiJkeyvfEQwBvnhGfUHb7Kbue+jN4NTHaGZY4hg5rPYbLM6fLUgweCM9VTlJOvgDCMbHM7eG9Xf9rVjd8UPS3gJowl49kC6PyM2w2x2Vu3guHtEUKIFScnJJlppHYD8Wt888wPrVSIKFYOJqqZPcH/wE1ez8/0keLhmqYkk2QLtqMpGE+8dNVegAgNhP94/5vNb2P3Ywglpgkc96GbNyaYNSoqjRN5ZTmBHgM9NTcHSBrL0unrKjCwV2kycx5PvGEX2NTNpjm4PuTwbFvLozqHI5Q+GDtdc9KfJkmpdCgHYlMmQDqEp3IcOtK8kaadwpPbC59+9BifoPdKzuX/Lhj19kF4l/54S+wM6N1PTpZwFPdqH5gm+lCwZTX97aYWPy1GPnix7y9UKgJKXiOM71SpN+g9xLq3qsxe6bAbmDVvHw1UyIHoDKD6ncU1U0WiDKfzMeR1vbAMN1qQavZbZ0l0R92IfuUhmkhrzki0n1vJTy7lqUCheQRJpo1jfHgMaDxvfwzzU3EOmKAy7Qzpm0fuawvIzUNEDlp25De65ewk6B51b1PmLtWiPO/5ArBwIcpT+mwSqF4bTbCe8r5V/J4DVH5gDe04pnVwkiXwQX0PDoK5bhDqat1Ve4wgkZqqcTAFT3W4ep3bsvxx18J8b+ih4NzsmTfcav7Gwy2dMtB+oby7SEZXu8801DY4dKlSE9JocsUrRjRNrq09CKLfDtV1/zMjTsI8nVUl6ZUpyaHgJ9YjS/agYfLFvAmMADGCs+GEqW8RfUpkAGMzneCmXeGltcw51LiTBQD/7qpc4dM7gW6uEPwtOlwfytgA/rkzUQ1hVno25A8WOuZw51fn2fq9YQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/12/18 9:20, Masami Hiramatsu (Google) wrote: > On Thu, 8 Dec 2022 22:21:30 +0800 > Wenchao Hao wrote: > >> The result of allocation is not printed in trace_cma_alloc_finish >> now, while it's important to do it so we can set filters to catch >> specific error on allocation or trigger some operations on specific >> error. >> >> Although we have printed the result in log, but the log is >> conditional and could not be filtered by tracing event. >> >> What's more, it introduce little overhead to print this result. >> The result of allocation is named as errorno in trace. > > This looks good to me. BTW, with this change, cma_alloc_class has only > one event - cma_alloc_busy_retry. If so, can we remove the cma_alloc_class? > > Thank you, > Sorry, I got COVID-19 and just recovered, so did not response your email in time. The cma_alloc_class should be removed. Since Andrew has applied this patch, I would send another one to remove it. >> >> Signed-off-by: Wenchao Hao >> --- >> include/trace/events/cma.h | 32 +++++++++++++++++++++++++++++--- >> mm/cma.c | 2 +- >> 2 files changed, 30 insertions(+), 4 deletions(-) >> >> diff --git a/include/trace/events/cma.h b/include/trace/events/cma.h >> index 3d708dae1542..ef75ea606ab2 100644 >> --- a/include/trace/events/cma.h >> +++ b/include/trace/events/cma.h >> @@ -91,12 +91,38 @@ TRACE_EVENT(cma_alloc_start, >> __entry->align) >> ); >> >> -DEFINE_EVENT(cma_alloc_class, cma_alloc_finish, >> +TRACE_EVENT(cma_alloc_finish, >> >> TP_PROTO(const char *name, unsigned long pfn, const struct page *page, >> - unsigned long count, unsigned int align), >> + unsigned long count, unsigned int align, int errorno), >> >> - TP_ARGS(name, pfn, page, count, align) >> + TP_ARGS(name, pfn, page, count, align, errorno), >> + >> + TP_STRUCT__entry( >> + __string(name, name) >> + __field(unsigned long, pfn) >> + __field(const struct page *, page) >> + __field(unsigned long, count) >> + __field(unsigned int, align) >> + __field(int, errorno) >> + ), >> + >> + TP_fast_assign( >> + __assign_str(name, name); >> + __entry->pfn = pfn; >> + __entry->page = page; >> + __entry->count = count; >> + __entry->align = align; >> + __entry->errorno = errorno; >> + ), >> + >> + TP_printk("name=%s pfn=0x%lx page=%p count=%lu align=%u errorno=%d", >> + __get_str(name), >> + __entry->pfn, >> + __entry->page, >> + __entry->count, >> + __entry->align, >> + __entry->errorno) >> ); >> >> DEFINE_EVENT(cma_alloc_class, cma_alloc_busy_retry, >> diff --git a/mm/cma.c b/mm/cma.c >> index 4a978e09547a..a75b17b03b66 100644 >> --- a/mm/cma.c >> +++ b/mm/cma.c >> @@ -491,7 +491,7 @@ struct page *cma_alloc(struct cma *cma, unsigned long count, >> start = bitmap_no + mask + 1; >> } >> >> - trace_cma_alloc_finish(cma->name, pfn, page, count, align); >> + trace_cma_alloc_finish(cma->name, pfn, page, count, align, ret); >> >> /* >> * CMA can allocate multiple page blocks, which results in different >> -- >> 2.32.0 >> > >