From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80888C36010 for ; Fri, 4 Apr 2025 21:21:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D6C2280004; Fri, 4 Apr 2025 17:21:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19135280003; Fri, 4 Apr 2025 17:21:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF27E280004; Fri, 4 Apr 2025 17:21:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D16AD280003 for ; Fri, 4 Apr 2025 17:21:28 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F194FAC2A0 for ; Fri, 4 Apr 2025 21:21:29 +0000 (UTC) X-FDA: 83297632698.28.031C1E4 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 3328B40004 for ; Fri, 4 Apr 2025 21:21:28 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=i9mRbORf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743801688; a=rsa-sha256; cv=none; b=X+LVoU4bhU318Q5d2X6LXgIgORXFKKDrhgUsFAhP19JgA3PkR+ELBrbpl6kzvR35tgOrnC xwM2nGScKoI9f9OSRy7ym0UJDLY6A3nt99eluoGC7eJ2z4lsk/+YAFZqaI7lwn9Ads7kin PFvGqo8W12gvkuttYvkDPp1m/8iZlAs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=i9mRbORf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743801688; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PCDFsmCLXNsZf0RsjmKJX1X6mpiwwMUVa78UqlfKrP0=; b=cNSYnRNiUjL+kbwmypl6K6HU9vbFhEQkGCPBzjWLe5FmBn2N4ciWLGR9+YBHFs2I5ePlM/ XUb1bdI4FDUUCNcczHUbZ9peoeoQ+qp2MNAMPyS7aAVLPF7zKt44aQNJx7MQhgvE/xhtxx ui9I5hD67vbfVCYujxGHtPyKrSCm8aM= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2240b4de12bso34416735ad.2 for ; Fri, 04 Apr 2025 14:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743801684; x=1744406484; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PCDFsmCLXNsZf0RsjmKJX1X6mpiwwMUVa78UqlfKrP0=; b=i9mRbORfDcdg9qH+wGWIfNCtyGCAAVHWvxzR3dUcchj9889UG1l9Dv16zChdC6PNx2 a00AisMxVfNOixT9mbi5YKcwzWwLfR8QijDpbOoe1SGGZcA7ravjoTknB+TuWJv2N+Qo 71u9gbiMv2YCrS2jWdUVhbid56RrfKr4ngaj29lhL7n9v1TB7pQQdKGRe0fMGleYHZu1 NZo95QJLoK5/cfpiT+Gf1GcAif0X0My/k2yz7yKSQGQEPXpRI3LaTn6PYxFojFa72lrB Ljk1qZBJIGWCep9lWdrn6go4tZMpmkyGOFATlRmPeVCfioplZL2/5WmIjpC9K3l+7wY8 kvQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743801684; x=1744406484; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PCDFsmCLXNsZf0RsjmKJX1X6mpiwwMUVa78UqlfKrP0=; b=FnOJ9KienNyUCgtDid1P/DJg473AxQqG7ncnsD9bdVYAmr7ZE60ixry8eUMIQkPcKy lfVn82pX0iI0dXC/qzlA25eqo9tzFclr9sFCxIJFW69Hf/yvuDPzEMadAU/pWpAidy0/ A653l3L7UEOpKtKW8xg641uwrZs9pwj67XzCcxWjUgIgbadhwOfT0kH37E3Up+SDkv5j A8z7JEVsz+qq0wUG/y4RAms3V8iy/aJUzKiLI3M5p2Bcw+wpPWJ/Q2dHmJQYGBV3ceee 8hWeFTBYlCtU1WsmHlNJlSAS9Gb7NtRbDaNHqwMin9guDTTpZdgI8q/s7hi/n664Nd00 r2Ww== X-Forwarded-Encrypted: i=1; AJvYcCWZ+6QxFJHEJlOSUDFBbY1viH2n57eDc7NZv1f9wZ+8Hq0JT7GrLi70XHdvQ7s2s5eizZx455Mo0Q==@kvack.org X-Gm-Message-State: AOJu0YzIEFRR31zJQ6Yr5C35s4adqPJVjhR8ZIgtugW56Uw0+XJUsbNX D7kHo0wpguKBqK7r6nBVVfdEMzcsFr7LanfokXXPzzdR7r0BEj3Ds/Pezg== X-Gm-Gg: ASbGncva1GNMddpvyTuEEZPxCZlN9ZomZaObOdGAver6lxcH6zCeALnLAhf9D3Ja3yt HUBSji4q7wPq8UFIo3WgzhJ2l2yGktNnapZtyFrISiqMRHHdHhRjteSa13URPsAOHI4h90gWNDe nPsZonjBcf0V27XVzVCoEGwx+rutbGAJGYjUdd7mLV5g9J6ibDA5d0HX8nZsDfFefjk2JkAeiP8 PXJTzLbldDYSMR//tnWKOF/HK2YDMv7DoKO+xiPAVSHqe4cCRPicIfUe7NCPvHq28gyWpOSVyYl 5ELRPZQVKjnTfiYX9WPG5GJNA8h6eWJl6rtFLyvbPz4VrB6Jg5h79+YxmvfDbl3HJ8VANv1vTPo CQypAG1htHWyb7wg= X-Google-Smtp-Source: AGHT+IGLlcM3WioENcq4p23jy3bfRO+1RDbfA+DKFQTDFRa4ZtZ8MehPirkPRZR6rK1AZvGlE4xHNw== X-Received: by 2002:a17:903:8c7:b0:21f:71b4:d2aa with SMTP id d9443c01a7336-22a8a042b20mr69352375ad.5.1743801683861; Fri, 04 Apr 2025 14:21:23 -0700 (PDT) Received: from [192.168.2.117] (c-67-188-127-15.hsd1.ca.comcast.net. [67.188.127.15]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2297866e1ccsm37329615ad.174.2025.04.04.14.21.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Apr 2025 14:21:23 -0700 (PDT) Message-ID: <5cafaf69-133c-42ad-a481-d4ea843298e5@gmail.com> Date: Fri, 4 Apr 2025 14:21:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/5] cgroup: change rstat function signatures from cgroup-based to css-based To: Tejun Heo Cc: shakeel.butt@linux.dev, yosryahmed@google.com, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com References: <20250404011050.121777-1-inwardvessel@gmail.com> <20250404011050.121777-4-inwardvessel@gmail.com> Content-Language: en-US From: JP Kobryn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3328B40004 X-Stat-Signature: 5s8en55uzeo87g9ffnc677qsr9mxw4sq X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1743801688-705692 X-HE-Meta: U2FsdGVkX1/rpDIhve3v2ElR5T4zepycU9Xdi7I+dXbWLYUhcoEq7VpcFHNPopofLzpzsUE6mFJZd9WM4ewJs7YC0Jbc3I2YOCd57pHhsMkn1e35WlAaAKetJfz0cTNGaBmjzpyBT+6SRaJNx20fMtDlNvyCJHLJwoYY5z83gUoWwb6lhIs8Pv6BLaWURbxoPsW2G6Gf9afIw8sXI9t6pNOagh5hKit2lPK8A5N/aOI/z+bgUVewWqr8orVe1sgRkwHskr0FYbIMP5nqDh76BjLj0GKHdJZ5dl6sdL/KRUC9UegHUeyZTDA5CDt6Nor7L0UhpGFR6fC6o+BD6zGZdWuiEk/2Mtn3Exxsr4M7B1cTbrzJUx223kDKcHaoAGetcn17j2czMg5MPEenAf/8N0KMG2alHjv5FDt2AOZ5auLXbh1x1QrU62AtA+Zb/JGWAxtxHt+46CqUb2XxjcuejG+ddim1cCW/46w/F4cYXvKsSP96wHEnZpcjhB9VD1TXwrZ9FfXTqa2FvdXMxI7Og6gZ6qoEybV8kS9GG06zjc1DVT5OcnPjKE3YPT2Hn8pI/804cvlh0TXDwGyEmvkkYODe8hx7AUxgmokoLZlG7a/2W/zG2qKXWn7DFJZ3onXFtA7yis3jc1LtVoyZk4WzlWZ12rk9NJqJ8UhFgkJE1bfc5Di8hB1Rh0aXd+lj7ZG/0yVl2bhD0AKZFw50qRfkwCWBa6JHkDis7QBll4ayiWpPSknUlnWevFbh0+skPirSi+S07dy3MTkIkYE9QlKPFVyFV4PCoiz6yHO6L3dGkR42NRNGxoIbjq+4AjzzYWKoyhHO7IFtHo3ClrhMXuMoBoHueYlVVUlz5zM6EexLv5vhCgaMVkFMPkmrGIfoj0248RKwjujkgI8hryAxERjdjEpyV1eicFlGi2BwwXZdTtA6DLFwj/RwO30avYMX/5Fk+xJ0VyLHL+wcteHRr7O 5NJ/2Q6C at26MiKJSr3ULqb8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/4/25 1:09 PM, Tejun Heo wrote: > On Fri, Apr 04, 2025 at 10:00:25AM -1000, Tejun Heo wrote: >> On Thu, Apr 03, 2025 at 06:10:48PM -0700, JP Kobryn wrote: >>> This non-functional change serves as preparation for moving to >>> subsystem-based rstat trees. To simplify future commits, change the >>> signatures of existing cgroup-based rstat functions to become css-based and >>> rename them to reflect that. >>> >>> Though the signatures have changed, the implementations have not. Within >>> these functions use the css->cgroup pointer to obtain the associated cgroup >>> and allow code to function the same just as it did before this patch. At >>> applicable call sites, pass the subsystem-specific css pointer as an >>> argument or pass a pointer to cgroup::self if not in subsystem context. >>> >>> Note that cgroup_rstat_updated_list() and cgroup_rstat_push_children() >>> are not altered yet since there would be a larger amount of css to >>> cgroup conversions which may overcomplicate the code at this >>> intermediate phase. >>> >>> Signed-off-by: JP Kobryn >> >> Applied 1-3 to cgroup/for-5.16. > > There were some conflicts with the commits already in cgroup/for-5.15-fixes. > I resolved them but it'd be great if you can verify that I didn't do > anything silly. I'm thinking you meant 6.* instead of 5.* in the two branches above. The changes to resolve conflicts look good to me. Thanks for the quick review. > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-6.16 > > Thanks. >