From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AED6C48BC1 for ; Mon, 12 Feb 2024 18:58:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F11C96B006E; Mon, 12 Feb 2024 13:58:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC0846B007B; Mon, 12 Feb 2024 13:58:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D61706B0087; Mon, 12 Feb 2024 13:58:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C21186B006E for ; Mon, 12 Feb 2024 13:58:27 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 38B1E1A087D for ; Mon, 12 Feb 2024 18:58:27 +0000 (UTC) X-FDA: 81784062654.21.9EFBC4D Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf28.hostedemail.com (Postfix) with ESMTP id 32642C0012 for ; Mon, 12 Feb 2024 18:58:23 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="G4/EU+Ls"; spf=pass (imf28.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707764304; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=koC4KPt/zdBeBgblMLz30Cr5x0S0YoG2RyqdQG6cS84=; b=oi0mNuOgKKxJ3QPHmZPbMWcJ5rQnLqB/N+/IIGfnGJz1Fwu0GPlu+d/1rx/yWHoXwkPrDm NgeQslLZOjwI5x90MiGJx1va2puwMvbKOMhr0KaAv0M+b7U9EGcDCURToD9hFBGTvBIEy/ IpBE+u7sZCnmzXQ30/4lyMzhWjfdEUU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707764304; a=rsa-sha256; cv=none; b=S5mN6RTtSwgK7+f+l2dV3PTUrXA1eyhxnLnxd8eyMbfodOypDxPxemDUcuCtNTVSJ3cBCH LKVZD4TFaD8teRaOOtTbJ5YJioMz0CbvfdUlSRP8zUxH4gz1ALVmh9g3UT1/bJnSVtkNE2 PjEmyWj72ald/CsnrOaRr6y0Rq19h+Q= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="G4/EU+Ls"; spf=pass (imf28.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a2f22bfb4e6so478265866b.0 for ; Mon, 12 Feb 2024 10:58:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707764303; x=1708369103; darn=kvack.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=koC4KPt/zdBeBgblMLz30Cr5x0S0YoG2RyqdQG6cS84=; b=G4/EU+LsvApSyXXXZs/Qsok9MBeOMo1XR1LVEDaSLTXhndtr77BfN3G+HQUd8yORMO kJa+mV0W52v0gGRCK2wpvjcrSsUNts8X5TWvmy1lbxYayW6BpLZdlryNvD7uc3dpr6Lw VxXgVU1JRu7NRtXHdHYMYdOFM2cfARPR+fAzJv6Hu9JN5jbEYjqJv6WWRByvc7dwfIp1 c/YIKiuujo3LMptxQp1fWlnEz8Dpx4agEaT16OsIb7CIv4KRZECxr052cNkkUSVSLIoP oqHepjyutZEjQQlOHm2dcpyZY7stfUsYt1lTH0xLeBFDP6zEhwdxzJDAC996D/GGFiit DOAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707764303; x=1708369103; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=koC4KPt/zdBeBgblMLz30Cr5x0S0YoG2RyqdQG6cS84=; b=hdbzh5pKwbs1DzSRuJ7qm8HGzSwN90pPiidu0KpTif2Utt8Dzh67lG14CsZDe7XY51 5JF208ticmAWwRyrXlgwvVj1TknJ+N7mf2GO9vO6Up4tlzmX5AFC8wOlpWF0h0G9PrkI XBW48LyKF89sN4aAi3s2aJZHk3NiGmLg8ykvGvIA0/9Q9QIw46XsjXEsVLNugPWWAsaY 4x7zDrOeLUbTL/Rnux3CPx9jm+ASP8q3QcLyqMsTrN6SvVodh7IGJKQ3PUmRZfT9TX3S 8WwEybZy+rDcH8RBapTw0YIVovL6xz2+GcSV0vypiDqun+u3cdPA9JR8quOwYAHlbpWu pDcg== X-Forwarded-Encrypted: i=1; AJvYcCVoPG9QCstYtEovb8ogL65gUUgGcnz3SgANzb1gwPskyAquvxzj9tjw0maDcLKD8KpIKxKwDWWFF8YoTECQoSSkD0k= X-Gm-Message-State: AOJu0YzDA3ND8ZTnaBHvy7LQqK1FMjqrlo/YEheTK615TwbwDuevYeO6 +C9oBsyJwp0EvIPnFzQEC4Too6bykTXXBJUK8v8zV6h8YJZhA8Mo X-Google-Smtp-Source: AGHT+IEatP1z98ZHMU7xhDzz9DTR4TebEOqNs6F8PGIi6JrY6NZQCJ0TccpTRrRolhYMVgQ1NzJN+g== X-Received: by 2002:a17:906:5f83:b0:a3c:11a0:b4e8 with SMTP id a3-20020a1709065f8300b00a3c11a0b4e8mr4708486eju.24.1707764302510; Mon, 12 Feb 2024 10:58:22 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWSeLYhXaVg/ZVIcX0rI25sa0+9pREzclYi5mqfMlNrRNppbNRyGzgLD0eMXs5P+uhpZIWMk2IiK5xRXGalBWIdqWzmZeuu2xoWV4yUe/FUCvtL8SQ+19jLnxczXgKUC7TETyb19H0weHHoTq2Y04lmn8pcbf5XQynVehPnhIkGCKu7b1UExdyWMmEHqNwGC43Jyj7HWVzWLc9y9RttwL/7wppWnPBtREt8hF99ACA9KFlcGg1pidBKSjfU/8++99+Apyg6DALBGAe7fzyyc3qjYTIksZrwyJuAMGrGYX/79gvFjP5Y7AJr+h5tgCruurlvN0e0GtvoxyvZ70oocpenh72XZqFzqaWhFl3b1N28KAV+V2JYipHF Received: from [192.168.1.94] (host-176-36-0-241.b024.la.net.ua. [176.36.0.241]) by smtp.gmail.com with ESMTPSA id b10-20020a170906194a00b00a3c8ad35920sm468774eje.158.2024.02.12.10.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 10:58:22 -0800 (PST) Message-ID: <5ca7ab230317267f78df2dab399716979f1d4856.camel@gmail.com> Subject: Re: [PATCH v2 bpf-next 13/20] libbpf: Allow specifying 64-bit integers in map BTF. From: Eduard Zingerman To: Alexei Starovoitov , bpf@vger.kernel.org Cc: daniel@iogearbox.net, andrii@kernel.org, memxor@gmail.com, tj@kernel.org, brho@google.com, hannes@cmpxchg.org, lstoakes@gmail.com, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, kernel-team@fb.com Date: Mon, 12 Feb 2024 20:58:20 +0200 In-Reply-To: <20240209040608.98927-14-alexei.starovoitov@gmail.com> References: <20240209040608.98927-1-alexei.starovoitov@gmail.com> <20240209040608.98927-14-alexei.starovoitov@gmail.com> Autocrypt: addr=eddyz87@gmail.com; prefer-encrypt=mutual; keydata=mQGNBGKNNQEBDACwcUNXZOGTzn4rr7Sd18SA5Wv0Wna/ONE0ZwZEx+sIjyGrPOIhR14/DsOr3ZJer9UJ/WAJwbxOBj6E5Y2iF7grehljNbLr/jMjzPJ+hJpfOEAb5xjCB8xIqDoric1WRcCaRB+tDSk7jcsIIiMish0diTK3qTdu4MB6i/sh4aeFs2nifkNi3LdBuk8Xnk+RJHRoKFJ+C+EoSmQPuDQIRaF9N2m4yO0eG36N8jLwvUXnZzGvHkphoQ9ztbRJp58oh6xT7uH62m98OHbsVgzYKvHyBu/IU2ku5kVG9pLrFp25xfD4YdlMMkJH6l+jk+cpY0cvMTS1b6/g+1fyPM+uzD8Wy+9LtZ4PHwLZX+t4ONb/48i5AKq/jSsb5HWdciLuKEwlMyFAihZamZpEj+9n91NLPX4n7XeThXHaEvaeVVl4hfW/1Qsao7l1YjU/NCHuLaDeH4U1P59bagjwo9d1n5/PESeuD4QJFNqW+zkmE4tmyTZ6bPV6T5xdDRHeiITGc00AEQEAAbQkRWR1YXJkIFppbmdlcm1hbiA8ZWRkeXo4N0BnbWFpbC5jb20+iQHUBBMBCgA+FiEEx+6LrjApQyqnXCYELgxleklgRAkFAmKNNQECGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLgxleklgRAlWZAv/cJ5v3zlEyP0/jMKQBqbVCCHTirPEw+nqxbkeSO6r2FUds0NnGA9a6NPOpBH+qW7a6+n6q3sIbvH7jlss4pzLI7LYlDC6z+egTv7KR5X1xFrY1uR5UGs1beAjnzYeV2hK4yqRUfygsT0Wk5e4FiNBv4+DUZ8r0cNDkO6swJxU55DO21mcteC147+4aDoHZ40R0tsAu+brDGSSoOPpb0RWVsEf9XOBJqWW A+T7mluw nYzhLWGcczc6J71q1Dje0l5vIPaSFOgwmWD4DA+WvuxM/shH4rtWeodbv iCTce6yYIygHgUAtJcHozAlgRrL0jz44cggBTcoeXp/atckXK546OugZPnl00J3qmm5uWAznU6T5YDv2vCvAMEbz69ib+kHtnOSBvR0Jb86UZZqSb4ATfwMOWe9htGTjKMb0QQOLK0mTcrk/TtymaG+T4Fsos0kgrxqjgfrxxEhYcVNW8v8HISmFGFbqsJmFbVtgk68BcU0wgF8oFxo7u+XYQDdKbI1uQGNBGKNNQEBDADbQIdo8L3sdSWGQtu+LnFqCZoAbYurZCmUjLV3df1b+sg+GJZvVTmMZnzDP/ADufcbjopBBjGTRAY4L76T2niu2EpjclMMM3mtrOc738Kr3+RvPjUupdkZ1ZEZaWpf4cZm+4wH5GUfyu5pmD5WXX2i1r9XaUjeVtebvbuXWmWI1ZDTfOkiz/6Z0GDSeQeEqx2PXYBcepU7S9UNWttDtiZ0+IH4DZcvyKPUcK3tOj4u8GvO3RnOrglERzNCM/WhVdG1+vgU9fXO83TB/PcfAsvxYSie7u792s/I+yA4XKKh82PSTvTzg2/4vEDGpI9yubkfXRkQN28w+HKF5qoRB8/L1ZW/brlXkNzA6SveJhCnH7aOF0Yezl6TfX27w1CW5Xmvfi7X33V/SPvo0tY1THrO1c+bOjt5F+2/K3tvejmXMS/I6URwa8n1e767y5ErFKyXAYRweE9zarEgpNZTuSIGNNAqK+SiLLXt51G7P30TVavIeB6s2lCt1QKt62ccLqUAEQEAAYkBvAQYAQoAJhYhBMfui64wKUMqp1wmBC4MZXpJYEQJBQJijTUBAhsMBQkDwmcAAAoJEC4MZXpJYEQJkRAMAKNvWVwtXm/WxWoiLnXyF2WGXKoDe5+itTLvBmKcV/b1OKZF1s90V7WfSBz712eFAynEzyeezPbwU8QBiTpZcHXwQni3 IYKvsh7s t1iq+gsfnXbPz5AnS598ScZI1oP7OrPSFJkt/z4acEbOQDQs8aUqrd46PV jsdqGvKnXZxzylux29UTNby4jTlz9pNJM+wPrDRmGfchLDUmf6CffaUYCbu4FiId+9+dcTCDvxbABRy1C3OJ8QY7cxfJ+pEZW18fRJ0XCl/fiV/ecAOfB3HsqgTzAn555h0rkFgay0hAvMU/mAW/CFNSIxV397zm749ZNLA0L2dMy1AKuOqH+/B+/ImBfJMDjmdyJQ8WU/OFRuGLdqOd2oZrA1iuPIa+yUYyZkaZfz/emQwpIL1+Q4p1R/OplA4yc301AqruXXUcVDbEB+joHW3hy5FwK5t5OwTKatrSJBkydSF9zdXy98fYzGniRyRA65P0Ix/8J3BYB4edY2/w0Ip/mdYsYQljBY0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 X-Rspamd-Queue-Id: 32642C0012 X-Rspam-User: X-Stat-Signature: d33qxh8jz1au6rud64xaojderjefwnk5 X-Rspamd-Server: rspam03 X-HE-Tag: 1707764303-241959 X-HE-Meta: U2FsdGVkX18beR/wPAQtdwGIfdGxb4L1ZUTdpIVs/T6YNZbM/sNt1je/R5lh6vptHr9lomEelWnUAK9FHnxsVSL8fafpiBJ1dhSBMxvzUndhKRmC5CR7b8RXCtC3uIYDeNMx8g4yqKei7iciQX4wmlrMjhLu9E2acFeQgjqGL/5VEflmK22VBF0iG4MKLvwNBDstnFzQD1PWTCGcP0SPvK41CEKXSs1GWacgs/C+iuLQx4ecPcb2A/uuShVBPvhSGJl5WF4CRir5LZV7MiBJC1Q/rxReMhmP2kopwU7Kr+myyLI7mlIdXA8JZdZdfnmKK0xrsB+WT1Q6c/a4btA575pVheJi91vj14ietHaRwsqxWiXmkWvjpuJkZKC1ZRcmsyO9eQFNBuyxNfpayJXKTjbfxlTGHFfl5n5/kWwGOj8d3TB1JTr8/2CnFs66EeIzEpqK6uQJmQ4c+WawovpkDx7oACZR/xBN/MBg8dYPvoeEND3GQVGzlFiWVaq/YQFUK8f5dMYfcdiRvC+KDRIbGelKwwC5y738qsBG9cPCJxOjyscXi5uMSFLaJDVZppuni60TDB4V5htWA1vfhwsJ/+pu3Zbg53HEusmr7joENcHhBw6UUNejZ65dQUf3NqUpvLlWn6eZKaHaYYA4tjpxHQizjjPXUj/F0Luy6pJrcW5XCG4xySA5ccLQsmrfwprGfgMsHAACWZH6LEC+tD2KRhGA/2dFaLJmCXfu78DnWnV13VIbSlrnIIX9Y5TcnwGNPZY/bTtJbvFLKKmSR5a1Z+/SIqVFwKLGA4zcolFLfUR9OQwLcH18X2ZWvb8trySzf+fFV0EPJmWEfpF7slit9BsNG/jMl4icfCoMKSA3+zDXyV/1kJ8IVLN4VXErbZMZUKULoOaH+Qud0JDfuOA7udLStRb2udv4JSBy2c4NAAguVXPS6dr7C0hAM3RjAMEGinAN5UhPVfaUp7DdKVR hxVB/uZW K2TPWMoo7/QJ6y/8kDpMFqO2cQLWt6/uYLqaYzb9Xx0HeutbZ0nuFg6u8CkCATrw9LcmY+zsg9kIRjLX6Dx1GpbTFz7eANjRaTr/X1S+CKvVjNUdQe5LSODSAz5EyhhVa0o6GdJfF7CDpALMhwx4aWXnUXacnwGf70QB7TOdyYJp0k1XVq0sIBGRPyTMtDKyLxwtXVYwIkHF2D2bg5RXFfvBS2RcKgWlt5y7tUSDL+8nyjthdFUf1p/p/r2rCEaQa36Jll/jmcxNRdaQ1/h4BjEnTaHeGRW7ejPEvm2MLeSKBPJ1+EqqU/REi6BF0mM1EvNDuTLxK7Y3d6JWIyyd9GETj4C3u9UyJ7nkk5xHIJyEXe7M/ovGpu0GHfd/GBERYQ1L5+bPitnR1Xo7Y9wjWfPOdkeejMRLv0O777R0r/cFs58VI6pHTyGoCO32ly2TRC9h5NYW7+dVzVbimMrY17Wo5cArbLHIAz5EezMGM2oyp5j0WN1tXpgipVmRjJVMVwsdMpCB4rIywe97LKV0fzIAjQoOfYHgaVqo358aE1auJLFBA3/5hVAMc9k9oND0s6sEel0p323xYYds= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 2024-02-08 at 20:06 -0800, Alexei Starovoitov wrote: > From: Alexei Starovoitov >=20 > __uint() macro that is used to specify map attributes like: > __uint(type, BPF_MAP_TYPE_ARRAY); > __uint(map_flags, BPF_F_MMAPABLE); > is limited to 32-bit, since BTF_KIND_ARRAY has u32 "number of elements" f= ield. >=20 > Introduce __ulong() macro that allows specifying values bigger than 32-bi= t. > In map definition "map_extra" is the only u64 field. >=20 > Signed-off-by: Alexei Starovoitov > --- Acked-by: Eduard Zingerman Another option would be something like: #define __ulong(name, val) int (*name)[val >> 32][(val << 32) >> 32] thus avoiding generation of __unique_value_123 literals, but these literals probably should not be an issue.