From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0D9EC6FA82 for ; Tue, 13 Sep 2022 11:17:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A35E6B0074; Tue, 13 Sep 2022 07:17:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62A826B0073; Tue, 13 Sep 2022 07:17:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CBC68D0001; Tue, 13 Sep 2022 07:17:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 382806B0072 for ; Tue, 13 Sep 2022 07:17:29 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0E21512071F for ; Tue, 13 Sep 2022 11:17:28 +0000 (UTC) X-FDA: 79906811418.11.874179F Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 90BEA400F5 for ; Tue, 13 Sep 2022 11:17:28 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 56CDD1063; Tue, 13 Sep 2022 04:17:34 -0700 (PDT) Received: from [10.163.58.193] (unknown [10.163.58.193]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B63B03F71A; Tue, 13 Sep 2022 04:17:25 -0700 (PDT) Message-ID: <5ca3fb8f-2dbd-f6e1-8482-7e2fa4729b19@arm.com> Date: Tue, 13 Sep 2022 16:47:22 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 16/16] mm/page_alloc: fix obsolete comment in deferred_pfn_valid() Content-Language: en-US To: Miaohe Lin , akpm@linux-foundation.org Cc: david@redhat.com, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-17-linmiaohe@huawei.com> From: Anshuman Khandual In-Reply-To: <20220909092451.24883-17-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663067848; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HWyhct4s/lrY7yRgGfC9ObK0B51+r4g97p03SHcd75U=; b=W8hPGRNBSISUXQJDjnI1saA00Cpz7Pk+nRUCjrtidnmMr1YC+Y8Wc2ePLdgYBfKZoBHLEc A7bKUxo76cblbKgpLzADfomudND4P17aRdoW72OAKAnouSmYifp8PcfVWa/161xNPXBwG9 Y1NsBQyJ4pOPWmia30VfQj9sa7W/7fc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663067848; a=rsa-sha256; cv=none; b=YzEGjxPKL1Ux3+UElacUhIUUwcbrpCcL7hbe714WqkyeGx1QLaH29rkf6SVCnx4cYF2dQU flP55hgx/a01UQyGwn6RPWeujRyyMx88A8z9V04247rhnhowp0s8U0EqZB3yTOF2m3NhS5 iuFKGP8nQafLQNB5GST3k2QYdohzqCY= X-Rspamd-Queue-Id: 90BEA400F5 X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com X-Rspamd-Server: rspam02 X-Stat-Signature: 5umu6efdmt4m1uowbn7r8c98i7t38zmy X-HE-Tag: 1663067848-800150 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/9/22 14:54, Miaohe Lin wrote: > There are no architectures that can have holes in the memory map within > a pageblock since commit 859a85ddf90e ("mm: remove pfn_valid_within() > and CONFIG_HOLES_IN_ZONE"). Update the corresponding comment. > > Signed-off-by: Miaohe Lin Reviewed-by: Anshuman Khandual > --- > mm/page_alloc.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 262e8972e019..4cc0232020d2 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1929,11 +1929,7 @@ static inline void __init pgdat_init_report_one_done(void) > /* > * Returns true if page needs to be initialized or freed to buddy allocator. > * > - * First we check if pfn is valid on architectures where it is possible to have > - * holes within pageblock_nr_pages. On systems where it is not possible, this > - * function is optimized out. > - * > - * Then, we check if a current large page is valid by only checking the validity > + * We check if a current large page is valid by only checking the validity > * of the head pfn. > */ > static inline bool __init deferred_pfn_valid(unsigned long pfn)