From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD87ECAAD8 for ; Wed, 21 Sep 2022 14:33:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2ED16B0071; Wed, 21 Sep 2022 10:33:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDF316B0073; Wed, 21 Sep 2022 10:33:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7FB7940007; Wed, 21 Sep 2022 10:33:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B996A6B0071 for ; Wed, 21 Sep 2022 10:33:54 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3C0B1141191 for ; Wed, 21 Sep 2022 14:33:54 +0000 (UTC) X-FDA: 79936336788.07.5BF927D Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf26.hostedemail.com (Postfix) with ESMTP id C9171140023 for ; Wed, 21 Sep 2022 14:33:52 +0000 (UTC) Received: by mail-io1-f46.google.com with SMTP id z191so5140871iof.10 for ; Wed, 21 Sep 2022 07:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Se7+Ff9WqHH52xKsfLImB0VpB3sBEPrrxWsAQKpiM7Q=; b=zMYIeUYAmpy9CQkl6DYYYJYMJOwDHE9+wqGm3WvDWZ6swFZk736je/N9cbvAunXyDx J768hnLHjZichCzKv2+FvJq+C4jrHpf32tpVxqO6A3Ldm9cp5OYPjD5mqJlEqqnqU8dn xv55mdmIz+l9M8Sxj8hsqO8y9uUudOZmF4t35BGgIdq67gkJBQYmsoZfKzc/FctMe2JV iG47vzl25ynwmqDYv5WHPdjDP5l7H5HR1/UsBprBQJK3y/GUAW4OBCieYjEEPB4QSJpZ dOfd47Y+Pui4J/rJ70Hzg+3N0X3i4VpKVd+dOjjzWA38cDs/T97/jEKUG0mxKicSn1Ww CJ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Se7+Ff9WqHH52xKsfLImB0VpB3sBEPrrxWsAQKpiM7Q=; b=yrPYdqz6mVXU3E7BXgIOIBZwPrC+qjylJqxLOcD7BdWtOU8Ae985uFNE7fyPWNdVBm VBv+VZX/mvBObF9NbVJssS3d6oEYrXQBixJ6fG3FDyZWJ+Jadn+ZF/pHGtZY5Vp/Xh83 CxqNRjw6MsaQt4FTIGQsmXzUyk0eLe9KdK9RLM20AqI8QjniQwTXoxHZOZsqAm8noeCj 6I9herpUCWiQ0/WronzBjn+HZpQGhcqDqBu1E3CjP+26R0RY6iyHKXvSgq5YANYqIdLD l+1Fn7Ac+jD5QWM9qpFxteNQtdRy5SMrI9SsY6qnk0cZZhgF9WnwrK9UuHXqcHQJUkZh qfmw== X-Gm-Message-State: ACrzQf0Ssr2am3qwF5DN62KdH49ImSk9Tt74gEkxJPLTRLpJZCQrwKW6 z8dqwyZ7ePJcM3A9rvfk4I3cQw== X-Google-Smtp-Source: AMsMyM5e5I6RLwQQqcEkJmrEaPHZSQm/6+4OA2wGKKHZgF+jyLo0T3aKmA8VuPbC3E2F2Ttm2YLx+A== X-Received: by 2002:a6b:c6:0:b0:6a2:5f1f:aee5 with SMTP id 189-20020a6b00c6000000b006a25f1faee5mr11569710ioa.150.1663770831808; Wed, 21 Sep 2022 07:33:51 -0700 (PDT) Received: from [192.168.1.94] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id k13-20020a02334d000000b0035672327fe5sm1098824jak.149.2022.09.21.07.33.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Sep 2022 07:33:51 -0700 (PDT) Message-ID: <5ca12932-1452-1bcf-2a41-0f23c05a9930@kernel.dk> Date: Wed, 21 Sep 2022 08:33:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3 00/12] io-uring/btrfs: support async buffered writes To: dsterba@suse.cz Cc: Stefan Roesch , kernel-team@fb.com, io-uring@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, josef@toxicpanda.com, fdmanana@gmail.com References: <20220912192752.3785061-1-shr@fb.com> <20220920122540.GY32411@twin.jikos.cz> <20220921101958.GE32411@twin.jikos.cz> Content-Language: en-US From: Jens Axboe In-Reply-To: <20220921101958.GE32411@twin.jikos.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663770833; a=rsa-sha256; cv=none; b=gx0MynN4vqAwE6qW/tdMOYWiuQO31S528APznUw2CVXKszn/eLKbUBHe1lVYw+IaIVAm1R wPwxuSqml6JQoOmg4HKiQEL8lW4NtdFmGrK7DMvGqSlr0ArGUKZkabJ7XjJKmhe5R7bTDg ItFYEfm8ShOG+O9ZzaZ9uQY0vnNa3es= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=zMYIeUYA; dmarc=none; spf=pass (imf26.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.46 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663770833; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Se7+Ff9WqHH52xKsfLImB0VpB3sBEPrrxWsAQKpiM7Q=; b=inglbc+vCdGlQtkLCum7KhNbJuRSexgAXiakpMpfB7LPNbqlEu8URABWrnm70r91kDq67B iZhzzVclk+S28e8faPr/c4IkD2bfYzOziCwxO4lv3mp+lcYlQhe6FDzQauUpZvsvktSz1I TIPKDgkrOsMokX7B0zfD2E1dAJVgX98= X-Rspam-User: X-Stat-Signature: iyxk4hdcpcrhcbhib7fu6h3785buw7mz X-Rspamd-Queue-Id: C9171140023 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=zMYIeUYA; dmarc=none; spf=pass (imf26.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.46 as permitted sender) smtp.mailfrom=axboe@kernel.dk X-Rspamd-Server: rspam07 X-HE-Tag: 1663770832-902050 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/21/22 4:19 AM, David Sterba wrote: > On Tue, Sep 20, 2022 at 02:25:40PM +0200, David Sterba wrote: >> On Mon, Sep 12, 2022 at 12:27:40PM -0700, Stefan Roesch wrote: >>> This patch series adds support for async buffered writes when using both >>> btrfs and io-uring. Currently io-uring only supports buffered writes (for btrfs) >>> in the slow path, by processing them in the io workers. With this patch series >>> it is now possible to support buffered writes in the fast path. To be able to use >>> the fast path, the required pages must be in the page cache, the required locks >>> in btrfs can be granted immediately and no additional blocks need to be read >>> form disk. >>> >>> This patch series makes use of the changes that have been introduced by a >>> previous patch series: "io-uring/xfs: support async buffered writes" >>> >>> Performance results: >>> >>> The new patch improves throughput by over two times (compared to the exiting >>> behavior, where buffered writes are processed by an io-worker process) and also >>> the latency is considerably reduced. Detailled results are part of the changelog >>> of the first commit. >> >> Thanks. It's late for including this patches to 6.1 queue but it's now >> in for-next and will be added to misc-next after rc1, targeting merge to >> 6.2. I did some minor fixups, so please don't resend full series unless >> there's a significant change. Incremental changes are fine if needed. > > I'm revisiting the merge target, the potential risk seems to be low > here, straightforward changes for a separate feature, so it's now in the > 6.1 queue. We still don't have ack for the function export so that would > be good to have. I don't think the ack there is a big deal, iomap already uses it but can't be modular. So it's just adding a modular user of the same thing, really. 6.1 sounds good to me! -- Jens Axboe