From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 849BFEB64D9 for ; Tue, 4 Jul 2023 08:18:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEAEA90000E; Tue, 4 Jul 2023 04:18:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D71D090000D; Tue, 4 Jul 2023 04:18:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C122B90000E; Tue, 4 Jul 2023 04:18:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ADEAF90000D for ; Tue, 4 Jul 2023 04:18:50 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6215FC0988 for ; Tue, 4 Jul 2023 08:18:50 +0000 (UTC) X-FDA: 80973228420.15.7BD77BE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 00DF2180014 for ; Tue, 4 Jul 2023 08:18:47 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Bj1bLJBO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of hdegoede@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=hdegoede@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688458728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g6aXgU8jM3z8929Jnl6AdOiHPEfIO1BLnIZsiV/lNIk=; b=G6HuhUeXyHLEA3KL9xJ6U6ccNJeBj+/xlCKWOAa3JpYjRST7mkdNSkxZqvpO+sbvCjsJ64 aw2pU3tBEVoM6PORRU/gfjzbxhEtPTvxU5iBXAIE4dEjpFVDEwAb8ssxb5v0AVumbmRJaA YdaWPDIaOeE3tnVDstYol4sHjmwkeOU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Bj1bLJBO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of hdegoede@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=hdegoede@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688458728; a=rsa-sha256; cv=none; b=l0cXRFmwmJdPY/BvpRV5eaQ6m6DcqLRpLb6ZETl35RVmp0vpg+G7hkS+LRVOJIUlEl7cW0 klpPQTQBM8MkfTYi2hNNtXJc+KP2zXufyaCxfbDjGIzzlWnuo6EL5veFS7rDPcfJ3gjQu4 oxbYzOng9E04xilsuSvYu6k4XEioNy4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688458727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g6aXgU8jM3z8929Jnl6AdOiHPEfIO1BLnIZsiV/lNIk=; b=Bj1bLJBO165v1+XSFtQ8H3GJD9KtoD2AvZms3hLklpsQY7KCEh4NbeYa0+SyU/cJ+ZFsv+ +xwotvjfzOeF/QXVzgDDeTHRsQbqJbvyWPWi1e/kHYUoKL6CKbiYn3Nix3Q/cXGy4yk4lr EJbKWTmoZhOhQssgAdvjVCxLy6DeeoE= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-531-6iofpElXP-KVsMcmi2e7Gw-1; Tue, 04 Jul 2023 04:18:45 -0400 X-MC-Unique: 6iofpElXP-KVsMcmi2e7Gw-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2b699c5f238so44429611fa.3 for ; Tue, 04 Jul 2023 01:18:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688458724; x=1691050724; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g6aXgU8jM3z8929Jnl6AdOiHPEfIO1BLnIZsiV/lNIk=; b=Ra+IutVWdNZCS5CJKoVGRRmiLxWayelfSmk2U6zcE/DQ4yUZNLw1icWmQJkeNNoZ++ KoMi+wj/9H2/KMhlQwUJR53THSnlrL9bbLf3yNEDS7QjhTyO3YJEE3MyD7qVGpPc3zoh IT49Q4x99hWZHmcFCfJ6+uh0dsgE1bs4yo/0JW43jPG+nCcYoNvTz0o52AmfL08ZeOW8 KeKeBLc9PDVozPlnTMBenSDqX0XiugRev45FwS+hw2K04nfMTXrdLt8tEUu3rY3iaf+h QqZcXl6b6yGLPEvQ3nuA34SmlqH/dB0ldmVRPMb9jxbqfrJYu87RrZdoe1qWEFuuQ0tT Tykg== X-Gm-Message-State: ABy/qLYLF+3l2ZFScQ7dS3kF5ITsQaIlgyQOP2omUqeXFk0GbyzwgklP vIIqkSC7Pwwu4mMuYDbdexJ3EIYbUO0Ag2TANbekxsNwPvlNlJ4LQF7TNAFSWDQh7H/NllqpwpM zOR7lrq3P56Y= X-Received: by 2002:a2e:8541:0:b0:2b6:a76b:c39e with SMTP id u1-20020a2e8541000000b002b6a76bc39emr8027631ljj.35.1688458724502; Tue, 04 Jul 2023 01:18:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlFTs+iiz8gypQfHHvK1JfZADMpW1pPq979+WEjzCGCJp9NsjmauFA9srSuB3WXFUffV+ZtcYA== X-Received: by 2002:a2e:8541:0:b0:2b6:a76b:c39e with SMTP id u1-20020a2e8541000000b002b6a76bc39emr8027594ljj.35.1688458724195; Tue, 04 Jul 2023 01:18:44 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id z2-20020a50eb42000000b0051bf17d7710sm11500722edp.57.2023.07.04.01.18.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 01:18:43 -0700 (PDT) Message-ID: <5c99b5f1-b001-7ce9-050d-bb21edfe36bb@redhat.com> Date: Tue, 4 Jul 2023 10:18:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/1] mm: disable CONFIG_PER_VMA_LOCK by default until its fixed To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org References: <20230703182150.2193578-1-surenb@google.com> From: Hans de Goede In-Reply-To: <20230703182150.2193578-1-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 4xp7a9guif41d5ixisqx8zfnxxk8gx15 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 00DF2180014 X-HE-Tag: 1688458727-350204 X-HE-Meta: U2FsdGVkX19C8QPxIfAGXnRCiElufXdU0Qwv3b7RoGTmI4kXh0FNLxEEgJq/LWYXpmi3fZhsIFDaLVtRoC668YUZZdBMphbRMM9CocwapB99YbHwemsGATeKO+65ZOrNMshsJ3kir6u/FcbzMjSyBEj/uc+nxyRH6W2BZz+O0OycXYAbn6MBgZ8//AKjjNF5MW10VLzGF0xzzXyEYJ6rVr6KWav7XmysW5bK520xVKC5Eu++vuWcERBkgbK9cx3asZLb9m4qu5nf0EfPeemUItVLl7mP3CVazoruETDn0RgV/kkD+XJ5RvWk7vEoA1+zITQIjaVXDU1vx5Q99sepQjN10d049cLoZ5gazLzyQo4kTjtv1hKk003MZ26ekLESbgKlUiRKU/CUdrMIHmyG8Exiu8U7KDZA8XBvwkZvehV03C0QYl6rVj/zVk+7lL3V/xpyVNVBWkXXiEi9dMmfbFnD4vCSgcaIPDGbSktiCOo/zOyl7ZRkgXZqrNCPgYukfVXIH1G9Cr0UERen+vAtqcJyLWNYK8c6XRUk/X25PgxrlSb9h0/Vc7a1fRt9mPi8qiy6U9ZuDqouswfRIvy2O3UICq3zUEt5rIsBeTWBjAlG1El7hjuGoEpRKk/DQELfIl3jgpnD9Q9T4f8HrHayG1yQQW40NMiAu6ZSBQ+hqT3OFo68/SDndI9yaCCcxL3kJVkB+u1s6zG5MlJeAi+x0fSUL4jKIS/tte1HOwEndrwM6ALPOat9J6+uSYNVvglO+1xGcdHhgbnCLjETOznO+K+inmUqRiiNMVjIKq9npOqTurEWNvO8hWhqc1oD0B8QY+t67Z8cnR/q+AE2/+RX5PuCLUenurUdnhBjpZXi9eW9A8wwLKsCKIIXTax9xFM6DEuFGRc1gN85nv8Dx6rd0wzEpHHhnx6FtqPuU6oq7CaBfuQDDzMllBg5S62M7sdcpDF/5auDRWbBbLu3Zx1 bRLVVK56 pFFE5+hzz9bt8Lv0exX99MMHxfcArpet9piNJTiIooeuExrtjJ0OshqBA66JqCkznaYgyU2H+oW3pWI+DsNgyvI4XGse21q+1cSK3sPfRoV5E5CxYhhRWMFyKdGmVIFS5uQB9A3dawH/qJ0WWK2g2ufWpwLaiT8i+XLAee3oA4Lzhzlqira4tz8BnM5TcBK+T0qIcy6lI5pfgftdSgW30frcawWn8mQVKS6glL49eLUv9ztxZnJbKUoxwdXhDAUJ2imBxPKZixaI8ebZ50w68rFMWO3KkRuEA2Vv/d0GHm9Q38ZphjPzeK0ZT9zcW8e5+mnyDjYXYjtkfgRiG6m6TYmEiBLNJZWJ1yA71tLwJhchcCZOzXAP/pxp5mrPvl0y9PvzEuUmr+Kyb+yXuFleR2ejD5SS04zc9+6BA6OOxBEN9uDUdS5VkF3ZFNdQ6lPjjeGob5jQOxFZfTcUl3i+3PAz3DU/KdYWlIkuPA2vdqI/ztmLgwQLbGAEsVkFsnWwaWJdQBE4NWtY1C5AQY39nKBzyEWNR/vnlDZZSfskq3nRnSayj0ALUGhLZzQgD3sZbMPzQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Suren, Thank you for your patch. On 7/3/23 20:21, Suren Baghdasaryan wrote: > A memory corruption was reported in [1] with bisection pointing to the > patch [2] enabling per-VMA locks for x86. > Disable per-VMA locks config to prevent this issue while the problem is > being investigated. This is expected to be a temporary measure. > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=217624 > [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@google.com > > Reported-by: Jiri Slaby > Reported-by: Jacob Young > Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling first") > Signed-off-by: Suren Baghdasaryan > --- > mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 09130434e30d..de94b2497600 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1224,7 +1224,7 @@ config ARCH_SUPPORTS_PER_VMA_LOCK > def_bool n > > config PER_VMA_LOCK > - def_bool y > + bool "Enable per-vma locking during page fault handling." > depends on ARCH_SUPPORTS_PER_VMA_LOCK && MMU && SMP > help > Allow per-vma locking during page fault handling. This does not disable the option it only makes it user selectable and for users with an existing .config which already has this it changes nothing. IMHO you should add a "depends on BROKEN" here until this is fixed, so that this really gets disabled. Or maybe just revert 0bff0aaea03e2a3ed6bfa302155cca8a432a1829 for now? Regards, Hans