From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C0D5C4332F for ; Fri, 10 Nov 2023 16:36:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D4E38D00F1; Fri, 10 Nov 2023 11:36:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 484598D0005; Fri, 10 Nov 2023 11:36:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34BAD8D00F1; Fri, 10 Nov 2023 11:36:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 200BA8D0005 for ; Fri, 10 Nov 2023 11:36:35 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E7B06140465 for ; Fri, 10 Nov 2023 16:36:34 +0000 (UTC) X-FDA: 81442597908.26.14EF9F8 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf13.hostedemail.com (Postfix) with ESMTP id 5385420023 for ; Fri, 10 Nov 2023 16:36:32 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=mO2uYd9E; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf13.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699634192; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ru3MXs85V0TkBtzH6XUT5hSoA+maK9Vla4p+oxu1MjQ=; b=A1zI/WFG5hRU5BG23N7hDCwA7BViy6soyY1+gZXMqns7HXMjdKAUNOpb6TVcyegDCk5gmd Qk/cw7IlCSrwH61gp3hMLl3THpb88vCPvzH0c2wZij6PopBcfi15C4HSyK8v/ztIfBQz9Y Bgd0h7jYckRvdkxG4/oExtEZjc5z0ZQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=mO2uYd9E; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf13.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699634192; a=rsa-sha256; cv=none; b=LnG7a4vcVgftMTDCd0DqWdUyWYxXS4tA9auH/710dXkk4OwNRgaSsxiJ2eXFhPVCsdLf2E oUhrRYZpkOE4F/8o3MxD/btx0p4Chk/jTPZZ3YMQqcaRvba9iJLmEJ9pKhg7wqF+s7A3td IQfNbLUJ9dxECI6Htx3zunJAyOeo43w= Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AAEkk0W009514; Fri, 10 Nov 2023 16:36:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=Ru3MXs85V0TkBtzH6XUT5hSoA+maK9Vla4p+oxu1MjQ=; b=mO2uYd9E4x9fwSDDz7pNXhLU/yOaAdAi10V6MUk1nfrw387RwdsUsu89meYxgqxzfL1Q 4uiUUnOtrpU4vwYiYHF9tF2gQ7ZDPzjcQU4AC+GPrjHV0QOLRA4wIdF2msdIM9UFh5+C sCXB07Sac79CezCxBKsNAUL7nVkBq3jGzYqbfYC96avDxS+oXk5B6lXTx5ilKrUik1pM ZNKptu0cuPABXbGCbWof2gkPrAIYagLBM5brZePprqCf95DtnDQd8vsQq817W9VTRTIF rr/mHv7pqdRndLoaO8RG05BdEWJf5eMfh6+z8yQ3YD8HmOeB8IG6rPHY2igpmIkT7mev Fg== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u9h9v8xwm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Nov 2023 16:36:29 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AAGaSS4023378 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Nov 2023 16:36:28 GMT Received: from [10.216.59.75] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Fri, 10 Nov 2023 08:36:25 -0800 Message-ID: <5c7f25f9-f86b-8e15-8603-e212b9911cac@quicinc.com> Date: Fri, 10 Nov 2023 22:06:22 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V3 3/3] mm: page_alloc: drain pcp lists before oom kill To: Michal Hocko CC: , , , , , , , References: Content-Language: en-US From: Charan Teja Kalla In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: kTKagX7y4wucFs2tiqPbsNo4sbIeU6ji X-Proofpoint-ORIG-GUID: kTKagX7y4wucFs2tiqPbsNo4sbIeU6ji X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-10_13,2023-11-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=1 malwarescore=0 mlxlogscore=214 adultscore=0 lowpriorityscore=0 spamscore=1 phishscore=0 suspectscore=0 bulkscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 mlxscore=1 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311100138 X-Rspamd-Queue-Id: 5385420023 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: aspjgmuh9c4yji4zoedyzoj3rmi9fb1r X-HE-Tag: 1699634192-144258 X-HE-Meta: U2FsdGVkX1+RVVtDbvZlnJ7u795dMFvkp7YlNwRLcqCl9GxDY/l/qtkZaI71sINHzAV1IRNv4QpsP9uIV7fjbuxuN9jAKfljT2/xZTFVG1HKJL2gtxcqSxgxLekdXa1kctFs9p/1BdCBAkSKMucquPnhRX3Dqo2ZG30xBTcczkpLFXBb2sYWVkgv4aQ94BcEYpCJo1AeXuKZ2XjkZML3SkDHoEJO52g3fTLI+5/oKYcnoW56IeLfNCCS/M+eOdkUC/ZjEydvJssiCfTIfJD+sRQMQDPY0H0fP5/EgdvGejC28IdXziBzTVY13cBCL9HbyGNTz7pRlTy+saSwKDC9XJHoTx/YvhobI10nyA7QnavUtJethwq+OXhFQYrRtt5JBCOEgoreRJpVnThT9kELzM21lio7KfF50Z24wxfn6ykcQQNAaA/QK7bnUzHCa0mXi+oY1BGN1p5SyBsUTYjgAosuiQPxKnwiDX5Jvn2FY7K5nCFD5bSm/dw7WjCehSS376ymVn66syGJEWwGrook1Y0vxQ+NrZhRvHndmu81CE2iXaox7cI5LO/htqj02Q8mG31VKxTTMWJvZQvpbfhCTvL4VSfxSr/ybrLdPUD9y07UFkro1N70+fnQVRbsrnjsrNoVF7R1DiNCOPj3/gdXt6R/giKOIgrY56+Wsx5uExMgh8EXHXLt4tXhJEI50Agj+v3ofzkI27D2OlqpJmDumbibL45H/L16DnjDRbSye09lthagDrpaw2BHnPDAnQSIkyO3/hEkLkVyfkmvmJfq8mKE/ZHK6nW36itlkpNrqsyolQ4+eppsoz/4FVXHPegyawKlngKj1g6AHlEY7DJJz1hgA7UhlYG/VzI0Oj2Ka6EiA5AE86dA7WtwQlU/0+IdtVliLhG+jrOO9EoZimkxfi5y33RC/YMBsG+mzBUCgXxvsG0TgvqBoaMlX5ZyxK7F3j3pRKKm7F7OjGFQGIE Gn20eZ3a eRPpxNZr5vGoFRrK7hosuuOXj3ZWvKbDt8hgCMxkwcWLbR9C8xObsAvtwN8Fm2Xfos0FsWdKM3KzUrOhu9AkL3JyBJnSu8mjHNsGB/Od7oTtoMjTsoaUb2tbX7ABInKDGA6ueA4sypKLNg2gOPDOSiVcsCi7nt8nduSJRMvOo3G+CPXlBZ+stfbk+F9SNRNf2VQOAMY6sEbCSnRU/ZljEQHVgSgzC1Kcxu/P+NpddaUtxbjguvKHzpi6VKhUHSxLOHJKIRppsIpN08lKR2OkGOfZGEv+vmmKIBUlT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks Michal!! On 11/9/2023 4:03 PM, Michal Hocko wrote: >> VM system running with ~50MB of memory shown the below stats during OOM >> kill: >> Normal free:760kB boost:0kB min:768kB low:960kB high:1152kB >> reserved_highatomic:0KB managed:49152kB free_pcp:460kB >> >> Though in such system state OOM kill is imminent, but the current kill >> could have been delayed if the pcp is drained as pcp + free is even >> above the high watermark. > TBH I am not sure this is really worth it. Does it really reduce the > risk of the OOM in any practical situation? At least in my particular stress test case it just delayed the OOM as i can see that at the time of OOM kill, there are no free pcp pages. My understanding of the OOM is that it should be the last resort and only after doing the enough reclaim retries. CMIW here. This patch just aims to not miss the corner case where we hit the OOM without draining the pcp lists. And after draining, some systems may not need the oom and some may still need the oom. My case is the later here so I am really not sure If we ever encountered/noticed the former case here. >