From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77854E7849A for ; Mon, 2 Oct 2023 13:13:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B92EA8D0024; Mon, 2 Oct 2023 09:13:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B44C08D0001; Mon, 2 Oct 2023 09:13:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A31A28D0024; Mon, 2 Oct 2023 09:13:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 939BB8D0001 for ; Mon, 2 Oct 2023 09:13:52 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 53F2B1202AD for ; Mon, 2 Oct 2023 13:13:52 +0000 (UTC) X-FDA: 81300563904.22.E247C32 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf18.hostedemail.com (Postfix) with ESMTP id 87B181C0014 for ; Mon, 2 Oct 2023 13:13:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=none; spf=none (imf18.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696252430; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sYHqtRb87dqJys/6PyDOkEFPsNGkUWGDakPw0mnRJsk=; b=1Vb2tC68VXvuawfySKSW6YLsc1U0z0lyQZ50lk2B1FY4rcvnTvcNHCd2mXpCMVx4PAxGKC hJ/ApFzgk943/VqtAaegYk52b8bAk8F4v++CQyvW9wXG9QciABS9OY6rxMBdvynvO5fEYP rcc1DMiah8NIl+ABr5FO7rDW0pQ12QI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=none; spf=none (imf18.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696252430; a=rsa-sha256; cv=none; b=WCmz5Y+39lWRrC1ghympOSHIaJ4ScihGlOU2is7Wclj/p3eoPGdrNIyHfSbmT/G+jzVrgX y6oZtuV0626GhsBDzkrsV97DlzOCBab8HqSaO1VtYSqe5TtAdpBXhWkutbbwWXoT+PFHde 95qp1AmqdB936lUUx5IRquZwvqkFLCw= Received: from imladris.home.surriel.com ([10.0.13.28] helo=imladris.surriel.com) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qnIjv-00088s-2O; Mon, 02 Oct 2023 09:13:35 -0400 Message-ID: <5c6c554ad749531826e71083f56cde90f336942a.camel@surriel.com> Subject: Re: [PATCH 2/3] hugetlbfs: close race between MADV_DONTNEED and page fault From: Rik van Riel To: Mike Kravetz Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, muchun.song@linux.dev, leit@meta.com, willy@infradead.org Date: Mon, 02 Oct 2023 09:13:35 -0400 In-Reply-To: <20231002043958.GB11194@monkey> References: <20231001005659.2185316-1-riel@surriel.com> <20231001005659.2185316-3-riel@surriel.com> <20231002043958.GB11194@monkey> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Rspamd-Queue-Id: 87B181C0014 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: jt7zandfoqhekdhb7rpmh7o6gwsowhfp X-HE-Tag: 1696252429-190497 X-HE-Meta: U2FsdGVkX18ysi+FiSkXQTkwuaDuQeH+ueeDuoEKpr37Sn/m1lvyrMczuzUzCuGL3gmNGKboZ/GqQBEAiBUhHHXiC8nnbF0b6RPwEjS3AV9n4tTjztx1ivhxgNxxowRmtD7t4vIFED6H0JqdB0vtYu+flhnY/nzwnr+gYYifBIIRvzcwmH5oRUuTBEFZ+kuQr/t9mg9as1HtMOeyv5dSx4R29VaRAeutPbKUL46KeoB+C/caBsImdzlystUHIv6Mt0Hddt0rJHVgy4llsD8bEbMFqOBmMKTd3162D49lX2yZHZXPd0yiUNBfMZ2XzDMpbaA7bFerRqPKqf0LlScPJyxbA3xiOg26njgJ7u1KUr/m1jmb6bv0t13Cl1zk8f/ngRyU6DaAqvNNEZfXH8JVzEbqnNWnompXo6usB6YQoGHyZClO4UnHYZFMXPt8JD5TsslqgO+k7BdzRf0+2/oEz5JCNg3d3rbBb9869uLo54jS5AUke21fbFTHQKFnu/uLZ2bwSiOabAjNWkpm5ujCrpUj7jKdfmKY2v+D6VQTN87udyW1xFqskp8Fd4bOwqlP8LhhfRrqFaNFBCK2CDc3o0G7dwBGNNppSbzUwdWRTIAJvJ/d9dn2FX1ycD4cp7Syt3G/BymBZ7aQoJZtWV/T74DVFry1AUXTzoBlkGeW0hMInixFd+fL+/SGFwkM3z/LjFk7ZIbToBu/Yo4wHqbBSpYNwXnu2LEswQ5PLRZDGL4EY2gIn15ze/p0RdJ8M7NdoA5uBs95PiXXayZnHQltFHRtYGKm2M7a2IpwGwp03gUo/0GClxe0z4beKgVnr9GNM9xUxHIzeRkTxPy+nqmtgz1wkOTap0n/YI9l+oNuZSXyrFhivzgYTfDp4/WG9HWcSIB8xzRkWsfPVhPFOpBSd9D8ok6CpGq9Ui3pe6ns2IdeDZrKUc3URgrUSlgKRqeyDNea2E9B9384vpL1y/u Hq5vgfTe m828Re8IvlZcP5NJDg+iCAcqHDF5eR/JnfJ9ctWs4bQCo2KmIEkjjqJsHY9FrgeRz532WTBpKtR5c9lzULobNw4B9KPgwzSsrohEh8K8SNfWJ3/7dJxUS4lKsIcb3oRQqteaj5IOH8v/zUryLl4ERqbfutKnSJnfWwZ3u5id2As7J7yM0WrauIUCLq3E3Jns0U4fbGe2pbkkxfjIAhmH63Nzyrj0aR7BG3EFJh3N6B1zY4jFZi0mLkPnTogfD+ZPKe1mYDVWx8oR6iEMKoYBBsRn+J3xRuBUlYZVx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 2023-10-01 at 21:39 -0700, Mike Kravetz wrote: >=20 > Looks like vma->vm_file is NULL and __hugetlb_zap_begin is trying to > do > i_mmap_lock_write(vma->vm_file->f_mapping). >=20 > Guess I did look closely. :) Ugh. It looks like the fix for this bug ended up getting pulled into patch 3, instead of patch 2. I've had it in my code for a while now :/ Let me move the fix for this thing into patch 2. void __hugetlb_zap_begin(struct vm_area_struct *vma, unsigned long *start, unsigned long *end) { adjust_range_if_pmd_sharing_possible(vma, start, end); hugetlb_vma_lock_write(vma); if (vma->vm_file) i_mmap_lock_write(vma->vm_file->f_mapping); } --=20 All Rights Reversed.