From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B52C2D68BCB for ; Fri, 15 Nov 2024 15:01:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F9A06B008C; Fri, 15 Nov 2024 10:01:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A9E36B0092; Fri, 15 Nov 2024 10:01:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 371166B0093; Fri, 15 Nov 2024 10:01:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 168426B008C for ; Fri, 15 Nov 2024 10:01:41 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 797DE1C516E for ; Fri, 15 Nov 2024 15:01:40 +0000 (UTC) X-FDA: 82788642090.21.68E6639 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by imf28.hostedemail.com (Postfix) with ESMTP id 8296EC0031 for ; Fri, 15 Nov 2024 15:00:51 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=xkMBkjBX; dmarc=none; spf=pass (imf28.hostedemail.com: domain of axboe@kernel.dk designates 209.85.167.179 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731682719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=daa6RCRSBOXDojMt+CYYvatICfCaMKTsm2GIsGdsz1o=; b=wOngrr4UYR+1lEsWJOq/twEHJGEqW0cZ3lpMTLc8t3XK1WVY/ipvPT61MQEpwMe+SWJBJ4 VIzKMZAxjIYxtcXp2L2FUyXyajQw0fiUmkmbAak1Xwy+xrcjEMhurrLJAhWH5HLWZCt0wU xAOi3Q3S3+0UDWjIkMlG8K4wmNMxXss= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=xkMBkjBX; dmarc=none; spf=pass (imf28.hostedemail.com: domain of axboe@kernel.dk designates 209.85.167.179 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731682719; a=rsa-sha256; cv=none; b=7TQSrW8oo/E8Qk7uzmehVhXAWsSlJeE7tP+fiSqqteo0abprMsAPUC+aG8tWs69tGxhOR2 81sJiH6EDzmj3rfK7GK4rO3OJkrWUGXbCN+pBxMtlVpBnggE2FXMZtYr7SNuYYk7wjCwYY 3ZfzYdbf+Sc4g7cbtb4fpG05HAKqKwE= Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3e6089a1d39so956499b6e.0 for ; Fri, 15 Nov 2024 07:01:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1731682896; x=1732287696; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=daa6RCRSBOXDojMt+CYYvatICfCaMKTsm2GIsGdsz1o=; b=xkMBkjBXVdX1h8MFmBOxTyp78TF8kH1wCOBK5mKfREGAZRaSfoXR76CR7U2FrFSGRO JO0goVrIr1cMBhZ+5W+Kg4Heh3x4oErp+0OPwR0gnEo1b/Z6DWmyAVkXleK4s3S3XqwY IXX63JQIC7Aa/VQ6x45eK8Lw0kCeAd6f3WmCxwJo7nFTyqwA5DbuTPxSiNrJCxpbFNGO V670uj1E1HtDASeYeQlug2bWwJEmmP0+mWHwsrTbp2OFGX/9tleQE546/kuqmlVeivmG GNvnEh+GqCGyqXuN4faSPDMKQSn+9ai2BxIgicHUz56sFpT9e1xkAWYRMtFYCLZguMdQ wOiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731682896; x=1732287696; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=daa6RCRSBOXDojMt+CYYvatICfCaMKTsm2GIsGdsz1o=; b=HDzlZP4btcy19+GNVNxIyerY7eH2BNTxuK8cKq8WA3AtoU50HyvX93YMz8xF7vl6Yk +Jj+hYb8c0BXnMRFVRvWaiBBuHxl0jQBfLLaeg0R4o21i2cYmqKh+I+WwIMNrtoXCaqH 8BPEAay5biBaELdjhIMM53mlv9scvbijC/Gp6h+dTjgpc9zy4E/jP82xWpXUws7wFJu0 mTibKOkXoy7VU4lb9qC3bRtUxU7rV/Ne+vZsPynqCftmFJ/zI5LiQxPqdCEi8DrHxhlZ iuWzv88u0GnmUtIdG3MPAAhGlo/uxn9ILrbk5ffQ9iSsEGImWR91nYdnJh4c0y1Z9Wxv nTrQ== X-Gm-Message-State: AOJu0Yw7tTu8bchbxBelrwchEoGpaB4r4IhpacVecKW4Cdq6I34fiGTP RccYKczjAXe0ENKAsnXSwOXP8SGJqrWA/rpEqaFIDQ0eXiahShqLLOSRfyUbKSI= X-Google-Smtp-Source: AGHT+IHUMI9fHXDh2gLJRoCs0tTa351RP+bVjNh9KTwP1t19tdcKal4tMfqXouiaHQoPBiHfxg/DmA== X-Received: by 2002:a05:6808:2123:b0:3e6:3777:76a7 with SMTP id 5614622812f47-3e7bc7d4a70mr3117960b6e.23.1731682896434; Fri, 15 Nov 2024 07:01:36 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3e7bcd10914sm529838b6e.12.2024.11.15.07.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Nov 2024 07:01:35 -0800 (PST) Message-ID: <5c6b9c45-25fd-4a6a-bfcd-781431f5c6e0@kernel.dk> Date: Fri, 15 Nov 2024 08:01:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/17] mm/filemap: add read support for RWF_UNCACHED To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, bfoster@redhat.com References: <20241114152743.2381672-2-axboe@kernel.dk> <20241114152743.2381672-10-axboe@kernel.dk> <66q2ojkbzy2l7ozzc4ilputbgvdtwav4r4qdvnl7x32tuutums@zachqbvl7y3w> Content-Language: en-US From: Jens Axboe In-Reply-To: <66q2ojkbzy2l7ozzc4ilputbgvdtwav4r4qdvnl7x32tuutums@zachqbvl7y3w> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8296EC0031 X-Stat-Signature: fjc6x791hanmw49f5fwo4ypbzx5p3qdp X-Rspam-User: X-HE-Tag: 1731682851-319323 X-HE-Meta: U2FsdGVkX1+veFa2RkJD7RTsFI2m4xaoN6BH+JZK75YYYKvOxxDmtnM6+sFdspcFq7MpAMALOz3AW2vMj+BzFi//DIM8PT6LmEbxE/RV6SJIyqb6kCSGI/0tRuBCML4LI3kPmSaTlRc8Cbz1TLwyhisvQSS+GcAMrvQZKZESvInptwyAexat5OvpzjnvG028G2+7IdYHnbmGKyeln3T0mzjtrWYF46EpHfJRY0oHB3QD4i0ryKVnZNVvfHyMyZPR+rvKzNpNXY3O+zZrFhPJgKYmnd5gCX8rVcrQ0AwSz1lB/igo+0DD29k1drWzJYi1w2gpPISLTWP9gpJbmVSVcIe7c0G7ZfPvXHZ/yeGzws7iZ33CyrBrqWIBx+XzA0fnn+8SUqcl/X5cFB+T03VytmsbXX3w2UU2amFKfoo4T2wdFV27vu9QEuYI3KJY3nIVoJYaGCxtnekhsYZcn28FFA+Vz79uujjwYEbM0y/0ZMg1vvCjTQUh0L1j9KYaTzy3Z6+kr2V5tK5DUQmfw9NxGobOST5sB5G2hQQMxDmfv2EwCm1Y3YSo8PUibSurwi5uaz8w5pXmLLoqK2lbMtAGfKdJgEETWTIz4aXrUUY1GDkXul+aeT0vZxdb/24l/zXXmZwNz0PaVNEa+sfjzlD0G+nVj1Zm5Qhjp9pxnXQOPu33V9yGZRXTMFYIVjU420Zm2Wq/rKwoW99QOG2imVXmzSpUlYpo5WdDKt2AyMXqpSdlhlcszlHKHg5XFglTAnYjUOcIMlZg5aTrkZV9JsCCscuqaC7wtGQadQVetG+MYv+uWYlpaYdKpnqzay44xWJjmfyxMlNd7dJmmirx7Qlk/aHSrbkh4F+uIp+7o8Er+LUUcJV7EJir1HmL7jrHA3U+yQRHD5ha90MBjoQqs+DHiGXDvfApNqeO2MRNzBylsMhWEnhwUJs3Kezpx80R/1ODFJRVQ8JrbT8fMhzST3J v1VrXESY OSuP1CNn0IuGOXIwTxXt53o53ANr6hxvLLIsVb4yHNoVeswXSfp0Wlei551tjp4LgLkOhwSlguXStZvZU/FxKevFQM+8pQZ4Q6VecNgOUScmzlNQnng3GSHJBAqfzdPtYeyPU55Xnd65reWvWCTncYIQZ0lyIcAYoyqp5He2LoV33x7eKfbej3f3RX0iunjAKpMzus3kKC/4HblJwKsIF+QyECs1iBSUKY12fYP8Vm+LTrsbQT8CDEmLYY6xS1h8biWvHc/zPFspRLB0AqmIMAPoujHPRp6qmzsYyibj8Vvn+izw7NHQ10OqTs+Y4RHVxpmHq0d/X72EUPPJGfP3YkWOOURnDiB8uJ22ATwp75UqBRyg3EYdjaX4n+YZUXZTr8iCcpguSBCcWuIIW5BeJb9bGei6ObGZRLj9cQ71fIpVg6EY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/15/24 1:49 AM, Kirill A. Shutemov wrote: > On Thu, Nov 14, 2024 at 08:25:12AM -0700, Jens Axboe wrote: >> @@ -2595,6 +2601,20 @@ static inline bool pos_same_folio(loff_t pos1, loff_t pos2, struct folio *folio) >> return (pos1 >> shift == pos2 >> shift); >> } >> >> +static void filemap_uncached_read(struct address_space *mapping, >> + struct folio *folio) >> +{ >> + if (!folio_test_uncached(folio)) >> + return; >> + if (folio_test_writeback(folio)) >> + return; > > Do we want to drop out here if the folio is dirty, but not yet under > writeback? > > It is checked inside folio_unmap_invalidate(), but we will lose > PG_uncached if we get there. True, seems prudent to skip if it's dirty as well, if only to avoid losing uncached for that particular case. I'll add the tweak, thanks. -- Jens Axboe